From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13F34C4167B for ; Wed, 29 Nov 2023 00:25:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 74B286B025B; Tue, 28 Nov 2023 19:25:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D42C6B025C; Tue, 28 Nov 2023 19:25:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54D7D6B025E; Tue, 28 Nov 2023 19:25:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 431B26B025B for ; Tue, 28 Nov 2023 19:25:47 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1DB8EC036F for ; Wed, 29 Nov 2023 00:25:47 +0000 (UTC) X-FDA: 81509098734.02.A5AFD34 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf29.hostedemail.com (Postfix) with ESMTP id 449F612000A for ; Wed, 29 Nov 2023 00:25:44 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=aoyhKhCY; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701217544; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s79KKQuQOw+McryaEibHTjOFNeepmOvGc+6XuFBzp3c=; b=PpzFaBQ+BjXD5LSjdaL2Mq2nDJm4XWMEAFos5SazWvW5NyX2rT+YvUo4tzUqpvoIiffNM5 Aq4zZCQb5bQbDZcV3HqRA/rRJvjbk8mw6KRbHDBF12atpzXdEIqWgW50m/rQJ1HmmBgPfE YzAhAmxu/AOXxVj2Wc00UpsikOxSAtM= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=aoyhKhCY; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701217544; a=rsa-sha256; cv=none; b=jAMh+qrYp47hZxhTFMMgpzS93U+s6sRQIp5XrBsf9+35qnMUTam+861x3mSviTo//C/Fvu VhR7DlMK7OsB9pbkJ3KdS7mhSHuNvqOrmDblGfpMjfmVercLrRW2zJLCSYX8RiFIFKmm1Y TRHVGhErP9ZYGcnRmSTEkMJYyfS9VWM= Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-54b8a4d64b5so3086062a12.0 for ; Tue, 28 Nov 2023 16:25:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701217543; x=1701822343; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=s79KKQuQOw+McryaEibHTjOFNeepmOvGc+6XuFBzp3c=; b=aoyhKhCYMQ0OChw3CpMi3wxI8MVN+pa4ez6hEVPNsdDrjPjr9M5mqF4NHphYPdXuXn mypNEdcLyT832JnuHLZhK2bnAvAnAtJrSL2leUtkWX1g6bd5uQ/un/lTSXPCJAu9cKZj 6L8Yv0SyaBsyFTA1zKyTJrmzfGU9266E0oLNiZ+YnN2MsA7gxNLfqg+SZBG+jZpbNTCo HJE6pFJ2Eq2VychWjgbEFhUiN+hXQM0NpVMRjP/H/2xa1fUT9EzXEdiZsjaMXQANtJye 3xV4sXJ5cFQXpZyIxmxUQ0PczTVA/MYNs9NBzABsP37RVxMw/ChpbSo6MB86ilvpZUA7 QBDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701217543; x=1701822343; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s79KKQuQOw+McryaEibHTjOFNeepmOvGc+6XuFBzp3c=; b=YBw2NGov5EaXiVUrM/RFG4+efoKwTkgGu1ZB7IYQrn/H9TD/oV/yQbwf/1JKNtCvZh VAa85g1GJwVRn9bPwHX0L0dY+41HXqAzmyx3HD4hmVH8hLLD16hgcuehYWMDULnCkHMQ Yomp2p4B8Pv5x41/T9TzCXZrTOzDXrzwRSxzVYa/kkxiusDlH1z8yIXKq6Vrhf8tqPQt bWhHECWXi2OLkIDUSoX2vVz0V3dw8pP1SUg1P18vz4sX2G4ye3KcMIDrNEnsHtGI9Kr9 n/eKyqpdstC1hocFhVmmsHP8lcWNuFuz9V6pCdpizH15qlR4kvrPiBicWyM1+WqfaVRk kaBw== X-Gm-Message-State: AOJu0YyQBPfdlHyYjPim4er5rJgKwTYlqTm29R1KXLZ6BMLQ5FAKyRkk Sqj0fjTSOiZSHUXX+AUdj6qVVZMNaNG7bKZ2B3Gq8w== X-Google-Smtp-Source: AGHT+IFhvJD8pcFDSUkXj7rCXo1krioxrjZU+Fh9ydxhF7LIckb5ecLVgf1lGuB42STpvzRSm1nEjeoSzXAsfJKhmOQ= X-Received: by 2002:a17:906:1091:b0:a0c:c09f:65fe with SMTP id u17-20020a170906109100b00a0cc09f65femr7312731eju.38.1701217542589; Tue, 28 Nov 2023 16:25:42 -0800 (PST) MIME-Version: 1.0 References: <20231128204938.1453583-1-pasha.tatashin@soleen.com> <20231128235214.GD1312390@ziepe.ca> In-Reply-To: <20231128235214.GD1312390@ziepe.ca> From: Yosry Ahmed Date: Tue, 28 Nov 2023 16:25:03 -0800 Message-ID: Subject: Re: [PATCH 00/16] IOMMU memory observability To: Jason Gunthorpe Cc: Pasha Tatashin , akpm@linux-foundation.org, alex.williamson@redhat.com, alim.akhtar@samsung.com, alyssa@rosenzweig.io, asahi@lists.linux.dev, baolu.lu@linux.intel.com, bhelgaas@google.com, cgroups@vger.kernel.org, corbet@lwn.net, david@redhat.com, dwmw2@infradead.org, hannes@cmpxchg.org, heiko@sntech.de, iommu@lists.linux.dev, jasowang@redhat.com, jernej.skrabec@gmail.com, jonathanh@nvidia.com, joro@8bytes.org, kevin.tian@intel.com, krzysztof.kozlowski@linaro.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, lizefan.x@bytedance.com, marcan@marcan.st, mhiramat@kernel.org, mst@redhat.com, m.szyprowski@samsung.com, netdev@vger.kernel.org, paulmck@kernel.org, rdunlap@infradead.org, robin.murphy@arm.com, samuel@sholland.org, suravee.suthikulpanit@amd.com, sven@svenpeter.dev, thierry.reding@gmail.com, tj@kernel.org, tomas.mudrunka@gmail.com, vdumpa@nvidia.com, virtualization@lists.linux.dev, wens@csie.org, will@kernel.org, yu-cheng.yu@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 449F612000A X-Stat-Signature: s3y4nu7ew8tb7yciss9uz4udfcdofnru X-HE-Tag: 1701217544-909775 X-HE-Meta: U2FsdGVkX19znbDFHtNKMpg5CHmv8QtOPyv9Hny8lXNB2GvTB5u6KGCkaVXkiQ17sTyT79ytRHOBQy/CrDxgviM02Qj0SIPFDjQPX91rxYqCM74D7X7eLfWjfW4Zw2XCF+X/icYABz8B69g1h1rrSvCfxd0iC7r6w0IfUzNrGYSJMYC3w5tlwzrc1wnNxIHs9CtIM8cCSTWlTtMee71XklX8qkXJPAJ1i57Vdw+u4tWSQlb9bVAvCxj9nGaTY/s3IT+XeHCBb202n5Sn/Lv7SfOM104hzDJFglsQExSl9A/yMANX08vYsTf5CsC60Ti2n5OWMQpthZcry4vLfA9IzWJZ1lCBSFtBcvyDyHAHMklo5rUJv4J6MBeQTvhtcYRh4NJFGgAfSPQ8QQzOz6jGreySJ66AmdhW8Wkb5JzX/Y8D5VhgS9qFJn2mRGaiH9+7O482jC9ARVJVof+xW3SIL/Dnk16KgEidfA3fd+h8Hb9e6YhwkdiPdSeMrVeuSkJn2+7+IhT4FxPjJZSuf5D1GYy+y3qKJaUWwKZgLoUNwV/3kKT5nOzVBPhH2ewp6XsM6uPjv1+b0XP5yoVJs+MIE/IXE5ytmvp+2F+cV80kd6ffGt7tlUsTWxhSzw+Ck+4nHB+iwmDX+uA58MAmF+hHW23onzrti6p2Zzd9BdreQWjdzBKLtd6NxBTHM/hRgmJe3t32/NOFXUdeV68JvE3Wla0mQ6dkjgsMtzaOvm5gJsnaax0QsCZAcRm+ftul6/kyQV2GVj669DKuVPQx8zNTvJ7+vM3/nAg7oCsunvYIfYw06GUR15hdBOmQiddvRWR6EJlbkhJfiYpbyepuct/X97oVeRieNDhqWdkSv1A5KJBUkIq1eHJVk5e50bJ4fX6GTvF5x49//BOmbcXGHPNd1duhfq1WV2Bv7MUJOc2e4J8E0/0LieRvg/G0XLXPXVinWM9fuUD3tMC3Mdixj9J kmUboeJA 70jPQIqBTikkYTMzcHgx84IXa8GBlqeaHufpreTLmLnTX9ydCqdptMuESlw3SZ56ktuABggQ0vvIy6uS5eTLRdl1w3V7VmHWOszKHfWnQfynShJ1EAMaTA9fMVtyuqIZR5ztLCpCQxYB7mTcCsNmlh+TOcXTU9WhYifJkhQepzu2HSLnZAPdwXcYQUtrlUYSoytUhazSRZOliejzynvtSBh1pOpoYE4Ny0jX0zBnbE2kiyDpXk+xZnhXerav5qJ89dw8pOqR4aJH/M2p/2tpSMJVd9NVdKyjv1xCOttQiOkGlGqUDbwKd/ijpjzGGk7XUN9EqO7N+hfyMwQEyWtStzPh3kwi4dD7jV6S4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 28, 2023 at 3:52=E2=80=AFPM Jason Gunthorpe wrot= e: > > On Tue, Nov 28, 2023 at 03:03:30PM -0800, Yosry Ahmed wrote: > > > Yes, another counter for KVM could be added. On the other hand KVM > > > only can be computed by subtracting one from another as there are onl= y > > > two types of secondary page tables, KVM and IOMMU: > > > > > > /sys/devices/system/node/node0/meminfo > > > Node 0 SecPageTables: 422204 kB > > > > > > /sys/devices/system/node/nodeN/vmstat > > > nr_iommu_pages 105555 > > > > > > KVM only =3D SecPageTables - nr_iommu_pages * PAGE_SIZE / 1024 > > > > > > > Right, but as I mention above, if userspace starts depending on this > > equation, we won't be able to add any more classes of "secondary" page > > tables to SecPageTables. I'd like to avoid that if possible. We can do > > the subtraction in the kernel. > > What Sean had suggested was that SecPageTables was always intended to > account all the non-primary mmu memory used by page tables. If this is > the case we shouldn't be trying to break it apart into finer > counters. These are big picture counters, not detailed allocation by > owner counters. Right, I agree with that, but if SecPageTables includes page tables from multiple sources, and it is observed to be suspiciously high, the logical next step is to try to find the culprit, right? > > Jason