From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2AC7E77197 for ; Wed, 8 Jan 2025 01:44:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6CBB56B008A; Tue, 7 Jan 2025 20:44:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 67C046B008C; Tue, 7 Jan 2025 20:44:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5432C6B0093; Tue, 7 Jan 2025 20:44:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 379596B008A for ; Tue, 7 Jan 2025 20:44:14 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D71A61608DD for ; Wed, 8 Jan 2025 01:44:13 +0000 (UTC) X-FDA: 82982589186.21.3AD591A Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) by imf07.hostedemail.com (Postfix) with ESMTP id 091F040008 for ; Wed, 8 Jan 2025 01:44:11 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=CdccLLLK; spf=pass (imf07.hostedemail.com: domain of yosryahmed@google.com designates 209.85.219.52 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736300652; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gHo9hEuef3ERGHHO2rwMA2Af58CDjKtCvUYF4uesulc=; b=xwcvsBS1xUVi3qOHyqtGthjxwx4S1l8jd+1nMZ6HeRtj3amsrsNpMNG2Sd/K1pFTexI6Fp CM2nQ1/d4SApjyZeTT9zoSAsLWHm1NAaNX8vU4u1zFVkl4nQ7ADFO6OEqT1EJHeYsjMi4v G1hiOeKsMpzaYc/fbi7rpS7mm5Pw6lw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736300652; a=rsa-sha256; cv=none; b=em28bPfBYoDuYAMBndUKEM3DGP/Xxl02zUu8UnIHEmD/ssS7Ow5HFVMzf0vJ+nPyO1Ltnv r8seG1BkfgD7489yKWZABimNZUtQYUVPq3v1MmJYoBRfoYvDezkB7dNjxi2ODH3dpTxu3F BBY9ou+EVTrm0QZhnn5UWUu06dMqXE4= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=CdccLLLK; spf=pass (imf07.hostedemail.com: domain of yosryahmed@google.com designates 209.85.219.52 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-6d8f916b40bso211191376d6.3 for ; Tue, 07 Jan 2025 17:44:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736300651; x=1736905451; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gHo9hEuef3ERGHHO2rwMA2Af58CDjKtCvUYF4uesulc=; b=CdccLLLKxM0usiPAtHrbR5PnGj8aFqnPNmXF2rTrYqJCe3LNp0Diva7fRHqlNZxx72 nMqlmy9QVoAQ0FEXYaLKtPO0h00Nsj/HgONa6FqigHIpPpJkSaDSF8dzRwVEVK4M6Bz9 CyDxMIXHSblku1aFw416jgs35rXdKXlqdVE0FLqOXNoJxC6//TqBXm4tVIi+k9TGDGBf pLNs2UeAjVCpIxDRceCaOs2zZpS6ih80eH++g582wujpBAADpY/vXy80kg87Pu6AGieo 7ZQTzPNAxKW4zmaDklFMlF5TXYXNTW6YW7sRR8R1Y/nIbRmcc9kg9EXfxSjk/GMtakkF XzgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736300651; x=1736905451; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gHo9hEuef3ERGHHO2rwMA2Af58CDjKtCvUYF4uesulc=; b=v/8/t446EVjr92qhLCwYA46hgoJYi7giPeG8y0S9ZXx3eKliRkr+J4Y8kx9zWmXXcY O6fSN/cP/WSaZixjdNk/+KnzNaGAngylRLrCSo9A0eiUi+HqioSDqDoclVsh4cdOO7a3 T05J5bu50Cp1Nds26kHhzFmw6F/mjo+r/BUdxrspHIEp/yj24ZdhN74Yrj1mP3UUyBQp ftxR4oQlCQ2YppRPbH4GfvBkKZwJ7pP+DoPGXmi7K4u0umZHkrOmUVmi8ZykiOdlN3DS FCpeb8MedDnnDJevJf2+LMvbNI3LZOye95rqkTsnPWmjLpddlPO/k263RQFdy1BzRMSk 5fXw== X-Forwarded-Encrypted: i=1; AJvYcCVZ2Tq/mbVDsTxakbiKWW8NCZyJJwvEZCgS3U3/CxfhvC0mpJt0hoJjVWieAXHwpc3G/aZ0EV+SeQ==@kvack.org X-Gm-Message-State: AOJu0YzKSvieqZibAFUG+udo2086dQMLZfbKtSyjAajmmnlyRB2E8vEn /tx55l8yAqlz13AJdqYv4KJPd0u411WpHQqUxUzOVGAaziVy1Qp3UeBhHvsTJbqAulrX/z+mTKC qC+Skv6wSYm22uMkfVk4I8CqIqeOS22TWjQVK X-Gm-Gg: ASbGncu9VfbzZpAARfFzFHozK+q5+D7Qc9PFxr/psyzVOLw6qrH2VLPr0HtAqxoROop 9FBlK8bkluMsEKqQKjHs7Rwzwukj3CgqP9KAG32sDsVJrFAHLAK4xmYovmd8alqtfKYmc X-Google-Smtp-Source: AGHT+IEX5O9W2dy6wtPD3nEP1ySmPfoJdxTB0Bjv81VL5rGDRrVFLLDjZ4XMD9DXqk259cr80NiLawuESt8uEnzFk1c= X-Received: by 2002:ad4:5d61:0:b0:6d4:dae:6250 with SMTP id 6a1803df08f44-6df9b28c6aemr22247996d6.34.1736300651023; Tue, 07 Jan 2025 17:44:11 -0800 (PST) MIME-Version: 1.0 References: <20241221063119.29140-1-kanchana.p.sridhar@intel.com> <20241221063119.29140-3-kanchana.p.sridhar@intel.com> In-Reply-To: From: Yosry Ahmed Date: Tue, 7 Jan 2025 17:43:34 -0800 X-Gm-Features: AbW1kvbgBXpKidxdPUyw9ZPKdRgCny0iuoA8E6tbrDl9_ptZM6BG2eAm8w4f3c4 Message-ID: Subject: Re: [PATCH v5 02/12] crypto: acomp - Define new interfaces for compress/decompress batching. To: Herbert Xu Cc: Eric Biggers , "Sridhar, Kanchana P" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "hannes@cmpxchg.org" , "nphamcs@gmail.com" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "ryan.roberts@arm.com" , "21cnbao@gmail.com" <21cnbao@gmail.com>, "akpm@linux-foundation.org" , "linux-crypto@vger.kernel.org" , "davem@davemloft.net" , "clabbe@baylibre.com" , "ardb@kernel.org" , "ebiggers@google.com" , "surenb@google.com" , "Accardi, Kristen C" , "Feghali, Wajdi K" , "Gopal, Vinodh" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 091F040008 X-Stat-Signature: cy1sufeo9gb8ez5g98ohzas8afjf5dq4 X-Rspam-User: X-HE-Tag: 1736300651-382111 X-HE-Meta: U2FsdGVkX1/77+pZBngz9V2gzfxAVoqMJ23XXV8XbC8JoVOF67Kv4YUM8HtviNtBwf+QqCf4ICVneaBXsOQStUcuzhnepSauL/YC1k7djLYn+/N0jXRO/2tLTc9f5QDrtfzTnMKEl5dJ+be0FpV2eztU4YsRt2fbQexin+NRH+S0zdYO9G3HoGDUBjhdrjKvj5JsDq8nhGt+ozbScUZn/Mvb25HgAoAnp8bskNMlaaopDOuLCHRd+XvA+6beMboVf54+5AiGgX2xbd6bWdHOlpcqya6bL2BT3c0vkVHhsOg3ChuLBVhp5uXvcgGeEVuZKTdw2dZOEkSIMQHJxwrhmyinlrapON496ZmbGIdyn9bpNTH72Xdu7ue88N8uF3a8CotS18QBu0fDW2OIIOqW4XuifGWYJPPV+s3SBmc1kHZ3S/7sgb5HfWY9P+6PZxZO05rQulX1H08n5vZdpwHf9gDGlCWe/6UX6mUpjr8iw86P2SWf9GesIdHWBlZ2UfUtvNRcwZRrKkSutNSVsoNlLIyHUTOLDNlwzsYBwbr3EvbwSZnzudjkuAN8aGFL9Mzb/iLf81eMZNlnIfCZ1UGw44ba4XFaCqsMPNp5gDu1NuxBkW4d/c4snwLRs6wmbVs1V+q/WYYozRUiGqSayHBGJhYbFPo5Q5HRz1in2+ploDTOevGtYftagVa6umxa4HdrHDtT0SiZx1sJiFFgHOlpxK3PWHTzaF2quARW+9/2CxkYtQ93Ice3ZLGwCJnY5S4mDycYX3ReEjyWr9PTEjoCDUjm+Rbq7HL8MptOr55iMFg++QOaxfnWctrqiWUlAefv8ZSandT+dva/UuwdtwqoHEO8WTJ1MhoFj44x0xe67DMvTN8Fb2NU5FjeTCxezzLyDj+rAUwVV0NKvZ6M4xWsJXrHSPGtu92H4nhKAsqIAAzmwe40AXc5hOyIXeyHiE6e1YxU9t23xU7b62hnwZA nsfKeEk7 ko0qYgGvuwEkf1gRogJYTSZfWzynQzmwv8BHV+Ggrao10yXCuSnW3nIit9DU5BgzOelpEnjeoxyoY98UGhb+P3EgpCjkifSRl7InSZFYoaME3CxdjZT3qFeN0bVcSjj5dBr0LxDOo/ppJYg8fiarPFO2DFqDXvaa4AJXnoPm7Uo/w8om/Pw0uKj9g1ASBEH4Y0ccabaLgc68Njx9/N1pTMaEVEJN1ujX+n/VmzePIZxPaoWr+G5s/OQz07p2+GDl6NwHv7n7H/yPj5/WGhdGWsoNDUdye93N8WfAqAvnivYjRkGs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000686, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 7, 2025 at 5:39=E2=80=AFPM Herbert Xu wrote: > > On Mon, Jan 06, 2025 at 07:10:53PM -0800, Yosry Ahmed wrote: > > > > The main problem is memory usage. Zswap needs a PAGE_SIZE*2-sized > > buffer for each request on each CPU. We preallocate these buffers to > > avoid trying to allocate this much memory in the reclaim path (i.e. > > potentially allocating two pages to reclaim one). > > What if we allowed each acomp request to take a whole folio? > That would mean you'd only need to allocate one request per > folio, regardless of how big it is. Hmm this means we need to allocate a single request instead of N requests, but the source of overhead is the output buffers not the requests. We need PAGE_SIZE*2 for each page in the folio in the output buffer on each CPU. Preallocating this unnecessarily adds up to a lot of memory. Did I miss something? > > Eric, we could do something similar with ahash. Allow the > user to supply a folio (or scatterlist entry) instead of a > single page, and then cut it up based on a unit-size supplied > by the user (e.g., 512 bytes for sector-based users). That > would mean just a single request object as long as your input > is a folio or something similar. > > Is this something that you could use in fs/verity? You'd still > need to allocate enough memory to store the output hashes. > > Cheers, > -- > Email: Herbert Xu > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt >