From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8029ECF9C69 for ; Wed, 25 Sep 2024 00:44:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0CF1D6B0095; Tue, 24 Sep 2024 20:44:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 07F6F6B0098; Tue, 24 Sep 2024 20:44:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E88BF6B0099; Tue, 24 Sep 2024 20:44:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CB3B96B0095 for ; Tue, 24 Sep 2024 20:44:04 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 77EAF80656 for ; Wed, 25 Sep 2024 00:44:04 +0000 (UTC) X-FDA: 82601413608.09.75D4E46 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by imf25.hostedemail.com (Postfix) with ESMTP id A1E82A000D for ; Wed, 25 Sep 2024 00:44:02 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=GMxEoXTK; spf=pass (imf25.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727224982; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pJi2L8GyGwoT7qv+pMxak7hzPYu05kdSza9kqGDuKdE=; b=gbKKlz7uvzsaR8IlDymbnZd/bIOEHipIwu8GVUeoLbj77rzJxqo4UFd3GBj9hi1dpi5L4Y Ew9CylmU4FM6/XQywafSQ3bwlRNNsul3w8QdP2T5DRLH/qdjuca0fEPjDtXv54Xqluq3hx 7MP+Cf1mWBz0Kb/RJsEOjg+FUo5h/+w= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=GMxEoXTK; spf=pass (imf25.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727224982; a=rsa-sha256; cv=none; b=jXD97SZ3L14vxd/qSox7mFB0nzqiCu94RWBv+W+S1az6SBGoWg17ZCK6JgUNWtSK4X9azF ylQ8j6ULD6v92dv/V+ll2zu3NY5+Uv5IXzg+06XBcSCJOWkoWqHfNw5E6TZOZl4YvQjgZf PeUSMNedRe3Lafc67CxkGmhCa3boHkk= Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a8a789c4fc5so69972166b.0 for ; Tue, 24 Sep 2024 17:44:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1727225041; x=1727829841; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pJi2L8GyGwoT7qv+pMxak7hzPYu05kdSza9kqGDuKdE=; b=GMxEoXTKEjkvwcqd2Bu32HhfoM5Az0M7UMhMrPjope5017JvWLw0cDLs0C30zCrVcy OvuXTVolp8qAIQXJz5r33CTDQ5u8A8q3ujMnnQs5EEZNTvmx80FX803TOh4+38rVkhkS wuo6HhMY7yvKFE8sD8wwgrQveLfexlLZZybxXLuTj2cJpEqPIVxVsm66718iaRmq/yEa AAA0aLgT7FMqfffCzdcUJREdgFBGcDeDzBfUteujM7g/XxNc/YU5OsziRyv47SxhSm2l lKf0xPP7LAJohPMR4yZqL1xDDtlNLMjwUUoj2pbiyFWG7iD5Ke9WPY9izpSoZE9pdTGe /kiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727225041; x=1727829841; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pJi2L8GyGwoT7qv+pMxak7hzPYu05kdSza9kqGDuKdE=; b=W7xm4VUC6GLfdX73sIweSj8JHBAErtGgV3eC0LqWg0AxyUGpkOWQE+2tz3G685TGsR ZzXDeQN72JNVZDKSvc/OdgUl6jPPLVvho8KLVmCHKBv88ytOMFKx2DoZD3MRrHldyUb0 ghjaaEaE63XLqD+UkUD0ETj4YI0bVeshIDfGleSneF0J8MhgZJ2+TD5ZkQhLuWUhZpJj 3Ampj9QWaBRN1Ucnf/hvIbFHsfyfD01OOZmJrufkJid45gdq5ruiFsE1CUB+2ON4b7nT bqJnU3+LwrG0FaNGoGJTk0Yvwutzj+H078YNWgPhWLWCQ0aJwFAUcnenm9Wyo/lfVNVN 9bLg== X-Forwarded-Encrypted: i=1; AJvYcCVYsWEqQ6dFJrNAw0Qu4TO5kcv33OmCU9nKkXfoeuPoBzMjwAMaInvW/q8C9/vH8TQhGo0aau8W7Q==@kvack.org X-Gm-Message-State: AOJu0YxFJqlLMY3+AsWTiTX0ZF3jrGB5j/a1zsgaf9VooGztZYm2fZLG wxFWsXBfxNyx8SvAJD1y2gvW3kfqtiSizg0DGbMr82jvRrD4ffXYpRT09eIK7plJM0sdaWvdeY0 x+hgU4lZswSKfXEjnfDWPGDMVXO6Z3EZnslBf X-Google-Smtp-Source: AGHT+IHX2NYpXdGM7kuVX9QLVKYJ1CekqVQmRM5AlnWr0eq6Uj/GUufVxg8WQ0twEEIpboTdLbxA+ghZsOlkkLVY8oE= X-Received: by 2002:a17:906:c147:b0:a8d:2afc:c06a with SMTP id a640c23a62f3a-a93a17042a8mr67026166b.19.1727225040808; Tue, 24 Sep 2024 17:44:00 -0700 (PDT) MIME-Version: 1.0 References: <20240924011709.7037-1-kanchana.p.sridhar@intel.com> <20240924011709.7037-5-kanchana.p.sridhar@intel.com> In-Reply-To: From: Yosry Ahmed Date: Tue, 24 Sep 2024 17:43:22 -0700 Message-ID: Subject: Re: [PATCH v7 4/8] mm: zswap: Refactor code to delete stored offsets in case of errors. To: "Sridhar, Kanchana P" Cc: "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "hannes@cmpxchg.org" , "nphamcs@gmail.com" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "shakeel.butt@linux.dev" , "ryan.roberts@arm.com" , "Huang, Ying" , "21cnbao@gmail.com" <21cnbao@gmail.com>, "akpm@linux-foundation.org" , "Zou, Nanhai" , "Feghali, Wajdi K" , "Gopal, Vinodh" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: A1E82A000D X-Stat-Signature: x9e6n394yb4e4fnzpn8q9w9mc4y3mxsg X-HE-Tag: 1727225042-453836 X-HE-Meta: U2FsdGVkX1/zivml9/uPd6H91EudqtHPnr71rHVF/qRyXNL7t1unFfOwDqqBm2dA8yrsA2OmlQhvj2QF7ik1T8bf4Pccrmf0LaYPOEDO/vKhX/5b8TpY0K7cqVIwVCyMv/j1S5zW8VVphj6CYlsXLBLKAllxgQjo9sgqMKUFaK4vAGFfcxjkolebqhSK/hXuX4fBtU+M3dX9kRxOC+SdgO8jr6c+oJfmowd1gFK0s+XMuW1FAfKJPTH7cMflpZYg9smhzKNzilI2E6K2XRS6yuXKizS3nm9m6QIeVuTPMPl0fXMh89enK9ay/6Jgg+YKfqSbQlPRDDyqNiBUDwWUvDheUEhfci2oCVyRSKpjR+R1TpegzIbRYrFJnw7uPsm23yQj67Pm7/6E1vwxTe4OVc+Pp8q+YPNbC3IdneeKtbZ38l/W9ARzzc8Z4BUIGHdztoSXrlYISnnJifHL0suDkPkIHZiZyFHNQocNPoQl/Lr2+/kgBxOW4MpxuGWtFTuBmcOfWNopr4yV1SMSaU8JxH4n7I13Gk4XQbrMyNfSJVXDrzCbSfZZMZYdvtNinP5Gc4UMUpk7SCEm7/wZVkbLAPoyFolCIp4wWgLlU0srjXuuP1uaW0xs50/a+38UWafK5aRod+kGj0bzG9PWBwJcQalWCDwGcv+kYub7kDwe1I4nWOf9ll8aJ81ebzjocG8QBX9/HmuYJ/jznlaaqRajjz/2rHYw75NvebY+EbVFmvn97IFIx1xEQfatcSS/uYTJJTzMQSMiCiYHvWIBM/HZJbOl5Ye6lg/YrjUfD+9J3ZrgoWaA6YMGcTiD42IeRyTCoghc9ZmcPHwmDaySnPI3g9LnWGqh7odF2JauzGhKMmFSEwRE9ZsV2yDphEO8TcXb0hrG/gTy+ydPYVaNa6P4rci5aP2tI/GerMAR6obFgCeNNCpGC99XBpK2ymo8JOvpzMvBMyzaV+0Y6GsK0DL XnUCTaTl 5TSyERg2Qr+mDnjs0ty+BmgocgpAtwad1LyzlfLYkh7ohHtdXmU1YhmzMUZne2fg68Os74/BhM4a2DoKjILrOpA3qlrU9zhVn0mH70L8D1R6QoI4gINJj6FqQGK7TxAvZI2i0OZSnRLBV9JBX2XBBf2Sak1pUZKw1qRB5Zh525eODMflwuhW6cj/N7xK4l6rZhsUtMAIWGTSUJW7bok2WrV0DnLZQeIXC8oVrD1EKLxTLoAzOko/KPa1BCoAotM0jvkvOUA6OcSk9NuA6vUZvijo/p6h1KbiKOqUM+xcdpW5in/LeNJxnXbiOQ9KjyYp2Fwydem7sn82FXhVBVvZBMF8+kYIkWtkHJyCSDv4ZSROOLz0Z3rXYpzBxxOe+iuh/7Ivgl9WUZokwZdj9Xc3H7nTlIomQO3CbsqhapxHFt/BUxs7KJSfLLbRkXbjeTvn++g7Eo8kd5gndLxKsgUV7EHVq6KKWVTEc5d5m9A0EvMoAbBbpASVAZytgq4rjlj/r+mygprteu6N7g9SyRnlbSavKjXCFsr16+iR9LsWCWOWKmPtQPRs7Wc/Q8p5Sv2UXO6dE X-Bogosity: Ham, tests=bogofilter, spamicity=0.003849, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 24, 2024 at 3:33=E2=80=AFPM Sridhar, Kanchana P wrote: > > > -----Original Message----- > > From: Yosry Ahmed > > Sent: Tuesday, September 24, 2024 12:20 PM > > To: Sridhar, Kanchana P > > Cc: linux-kernel@vger.kernel.org; linux-mm@kvack.org; > > hannes@cmpxchg.org; nphamcs@gmail.com; chengming.zhou@linux.dev; > > usamaarif642@gmail.com; shakeel.butt@linux.dev; ryan.roberts@arm.com; > > Huang, Ying ; 21cnbao@gmail.com; akpm@linux- > > foundation.org; Zou, Nanhai ; Feghali, Wajdi K > > ; Gopal, Vinodh > > Subject: Re: [PATCH v7 4/8] mm: zswap: Refactor code to delete stored > > offsets in case of errors. > > > > On Mon, Sep 23, 2024 at 6:17=E2=80=AFPM Kanchana P Sridhar > > wrote: > > > > > > Added a new procedure zswap_delete_stored_offsets() that can be > > > called to delete stored offsets in a folio in case zswap_store() > > > fails or zswap is disabled. > > > > I don't see the value in this helper. It will get called in one place > > AFAICT, and it is a bit inconsistent that we have to explicitly loop > > in zswap_store() to store pages, but the loop to delete pages upon > > failure is hidden in the helper. > > > > I am not against adding a trivial zswap_tree_delete() helper (or > > similar) that calls xa_erase() and zswap_entry_free() to match > > zswap_tree_store() if you prefer that. > > This is a good point. I had refactored this routine in the context > of my code that does batching and the same loop over the mTHP's > subpages would get called in multiple error condition cases. > > I am thinking it might probably make sense for say zswap_tree_delete() > to take a "folio" and "tree" and encapsulate deleting all stored offsets > for that folio. Since we have already done the computes for finding the > "tree", having that as an input parameter is mainly for latency, but if > it is cleaner to have "zswap_tree_delete(struct folio *folio)", that shou= ld > be Ok too. Please let me know your suggestion on this. > What I meant is "zswap_tree_delete(struct xarray *tree, pgoff_t offset)", and loop and call this in zswap_store(). This would be consistent on looping and calling zswap_store_page(). But we can keep the helper as-is actually and just rename it to zswap_tree_delete() and move the loop inside. No strong preference.