From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DAB5C48260 for ; Tue, 13 Feb 2024 08:25:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ABB036B0085; Tue, 13 Feb 2024 03:25:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A6AEC6B0087; Tue, 13 Feb 2024 03:25:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 959F06B0088; Tue, 13 Feb 2024 03:25:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 847486B0085 for ; Tue, 13 Feb 2024 03:25:18 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 456EE120AE2 for ; Tue, 13 Feb 2024 08:25:18 +0000 (UTC) X-FDA: 81786095916.14.A3E63ED Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf21.hostedemail.com (Postfix) with ESMTP id 64A3B1C0011 for ; Tue, 13 Feb 2024 08:25:16 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="IX6/UhbC"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707812716; a=rsa-sha256; cv=none; b=mSixQyqFh7q7G0OkckP99QEQ5HdE81qm+IikRUHwwX0HHXcPoqeWWIaY6x6yUgHMcs09Ul GkdvHCMLw3H4fKpzCRsi4jOat99vWgl5GSF/AbFvrOt+3mMn/4qcskPAcIq+ZPZTgMx2Bv l00bPwbDjVEPQZ8b4ny6+sON7RBGCqU= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="IX6/UhbC"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707812716; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B05LEYyR3ICjwHDeiWKyMo5pzjYfYHSKORFyqZMjQsw=; b=vu2kSRH7twn8d43VQODHMmf0SZLZtGxIiNyBqfq21m2Uah8D7P4cZYf7jjfmPi7CnyahR0 sPZrRLrr3DRHg0HAUfH7WOjzfi5I3Qmgely2dhiPBU5+STGn9Wq3Sg44b/phgjP/mxLlrT yZaU7NRegUllfpoQuu7JZis56vjNg7U= Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a3ce44c5ac0so121576366b.1 for ; Tue, 13 Feb 2024 00:25:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707812715; x=1708417515; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=B05LEYyR3ICjwHDeiWKyMo5pzjYfYHSKORFyqZMjQsw=; b=IX6/UhbC7JJ2oRfxX1KuDht5cuw+rVwlooldAZ9CleXm8fq81uugVl7w7sXNTi40wz dmPZ9x4kDipQz9Y4PRWZi3Uhl3G7SLcznwpVRa6h9oov8y/Lken5YWj41BEQgIMyvOF5 fmRx/9GqL4RRpzCkQwVsA224qQPYCKmETi+OFO012sb4Tow0Ypgjx88GAVM2ov6wwN2N 4UIsUz5nzVGKVk2KqbJqApWFe6DqoT+iDagEyvR4sRkJbSUhN828fwU24hua/befKYyV sAmXZHjoRkVHfYKsSUAyDx52gXanq/GvVM2h4wR7BJTo1rOkel4prod4MFlZj1RP5rjl c99Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707812715; x=1708417515; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B05LEYyR3ICjwHDeiWKyMo5pzjYfYHSKORFyqZMjQsw=; b=Y9XSs5G9MK/f7DnJp0xECyjZS56liM6FO9EUFlCPaHzIMdXi5geT0gj9O+L+2nkL/f WX891hGU7ywwIGAIWF+CvpQ5YXFBtA39oTxW7lQufseOWDOqamnvmfiog+ljRX7l7FYV zy9p4ooxLRbgU10KA+CzF9ZujioE+RC5HvG2Nr4N2/nL8kj3nbPm6xciOBIkBrOh+XP2 JsRFDqUTtr/HQ6cWI7NjWhbKKp8l3MwJxhU5Y6D38N6D78fCmT7jmbjAaAH8+gL0BbCR 7/e7n0IHGL1/43jeKnCR2AWlrVu/jglblKFeJQaPSC7BKI9L2DJV+wZeLwsSO6CNZe3H KTwg== X-Gm-Message-State: AOJu0YyecjCb8laRwGIZuRCLm4W8BkWrJmpVVbhjocSoT8VeTNYEFZkR 7h9GRX8rJJlnOP4gj0wwaEL8T7BUjhCt3kjvHbqM/qEJVzjiQq5mCCcBMxnF2AEgRm6vBRIEm7m uIY3XqtlBjUcu/TPHf0U1V9/gciccCQBM9S7m X-Google-Smtp-Source: AGHT+IFGO1SpbJUhvgx/bE9EiAh12keH5uH/8QOlUwjYPTDiGVD/Dov7JnNtDm3nRybHnAZ0gi+JxDOMMoe4IiWjklk= X-Received: by 2002:a17:906:46d2:b0:a3c:bf99:123c with SMTP id k18-20020a17090646d200b00a3cbf99123cmr2982211ejs.23.1707812714876; Tue, 13 Feb 2024 00:25:14 -0800 (PST) MIME-Version: 1.0 References: <20240213081634.3652326-1-hannes@cmpxchg.org> In-Reply-To: <20240213081634.3652326-1-hannes@cmpxchg.org> From: Yosry Ahmed Date: Tue, 13 Feb 2024 00:24:38 -0800 Message-ID: Subject: Re: [PATCH] mm: memcontrol: clarify swapaccount=0 deprecation warning To: Johannes Weiner Cc: Andrew Morton , Michal Hocko , Shakeel Butt , Roman Gushchin , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Jonas_Sch=C3=A4fer?= , Narcis Garcia Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 64A3B1C0011 X-Stat-Signature: 7yed4co4a5jtad7zdbg5swjqw7ihbqx6 X-HE-Tag: 1707812716-10254 X-HE-Meta: U2FsdGVkX1+V+0wLn6cP9PLrih3qf7/WNsX0IQqNc9uSXgYeEtMvbz4ACM11bwkvYVjHAQL258MlernTPiycu3oAW+VIi6l2xWWNQtAZCI0HKHnp5IPUx/2qMOvIbAvU/Zf5iTlEkhkvU9iU0ksbJAJxj1wjnwr1Rvx1AyoziE29DoGlspahX6olTzO+ebMhLY9o9qjRmSWzOPlEE/uxe9YKMB92QB8Bl9Mt3YKa3Aq/y6WVFbHUs3I8/HK8g3R4wtytSHQWqdvsZUnX3tXnmQ5tNG95Bu5ZhjM2Ml/CH2nxrbKp3maH+9/wrkdyotqaa3l+qHwOg0rcf4viuIwcbd+Nz2KQy3BR0+qflNqjbdgapz7rwfWwRqtuWplroljFaVIL6+R6wN01U23Hh2PcpOTtCmB3/QGQA4OmAPvVxskSwL60ihXyjktjrdytD0gf+TcVAIjCQyiy1k+eHfcY25qr4KTXNl6Io/IDSUgu/2QijKfwX0T8dkQAaIv3PRxMBPjU03g5G6EaSBsaooAbqxSHMjUC8w/OUXIZWV63r4aqLxGtOhNdj86Yi/usbKJ0R4G82GJsaFlNaU98wvEXjEqrzP7P+5UmR4XS68MNjnIsp76jU+EdSXAgTCj4jtGo6cP8Be7Pcdz13R7LgGrcq7LOtFiDK7hsA2SOBjpxfn5NkYHEhkoojz76lWC9YytilE8mMBCnSgh32sGzyA255n2cqwSdH7+Qnn9EOmNA6wuX9AqIlVQ/vBR0F3E48ekb2lhOG7sxXzWBLYVsqgapuDCoR3/SwE8KFTdXdUkjhGhGQqDlSjmiJ8D5F5wYzMNTW976CzIp0JohAu4CyIIy4JdaXRmeE2wcwz9fc+AAmDUZVrTKzV1MmRJZTr8QW9iPX5nvpChTYTPVQPdzydVXDAYW3AgXSF7vV68MYTi92eynHn14KNODjvF4yl2c7Mhwzy31oH0zFwigoJH9/PV C+HeD/kH EfYqIvMevoIK5kTss8nKP5qfoq1uQuMLFwwciohFNkTMrL3NmsZ6vSgyoTAhfHDmLEhV6/qqpyWQMVsEbcvaiw9lBFpR2A1QO8G88fa1E828w+6zr1+UYeclJB9v4/vRPH53K/xqka4htDY+0TMmoPJL7IY27OiKefTPrjmYUaGcwqekRr5Kpb+0QvVFFVuj+RaLSdKjne7/bNtr8an4g3OB8HIqFjx9OzhEIgLHPSd7kVu6/U8j0/nIlX6uxqUCnFHqJK5W68E+F6c4X1edu3KeNo8H8aVro4/kO3MsmBlr01g7GWDsRTWstSNdKvwGrbDgezLqKtLXOCbbSGDnjLwINOJcZWyhyjByaGYT547936SFucu7MFqtzKzO/gw5BbCXG5X3Yr4gswX0yPxOqequx6R4BhqWkxxRS6E64QXcLy67/Rmg4eZGjWPpHsE41KPgxZrFEgy5WdwmzNZ5YBSX9zSAqi/L3dkM9NkYElZnW9ms= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 13, 2024 at 12:16=E2=80=AFAM Johannes Weiner wrote: > > The swapaccount deprecation warning is throwing false positives. Since > we deprecated the knob and defaulted to enabling, the only reports > we've been getting are from folks that set swapaccount=3D1. While this > is a nice affirmation that always-enabling was the right choice, we > certainly don't want to warn when users request the supported mode. > > Only warn when disabling is requested, and clarify the warning. > > Fixes: b25806dcd3d5 ("mm: memcontrol: deprecate swapaccounting=3D0 mode") > Cc: stable@vger.kernel.org > Reported-by: "Jonas Sch=C3=A4fer" > Reported-by: Narcis Garcia > Suggested-by: Yosry Ahmed > Signed-off-by: Johannes Weiner Reviewed-by: Yosry Ahmed > --- > mm/memcontrol.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 1ed40f9d3a27..107ec5d36819 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -7971,9 +7971,13 @@ bool mem_cgroup_swap_full(struct folio *folio) > > static int __init setup_swap_account(char *s) > { > - pr_warn_once("The swapaccount=3D commandline option is deprecated= . " > - "Please report your usecase to linux-mm@kvack.org if= you " > - "depend on this functionality.\n"); > + bool res; > + > + if (!kstrtobool(s, &res) && !res) > + pr_warn_once("The swapaccount=3D0 commdandline option is = deprecated " > + "in favor of configuring swap control via cg= roupfs. " > + "Please report your usecase to linux-mm@kvac= k.org if you " > + "depend on this functionality.\n"); This line is surely getting long, but I see other similar instances so I guess that's okay. > return 1; > } > __setup("swapaccount=3D", setup_swap_account); > -- > 2.43.0 >