From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0892C46CD2 for ; Wed, 24 Jan 2024 21:41:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C5E78D0002; Wed, 24 Jan 2024 16:41:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 676726B008A; Wed, 24 Jan 2024 16:41:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53D9C8D0002; Wed, 24 Jan 2024 16:41:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4274B6B008A for ; Wed, 24 Jan 2024 16:41:06 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D189E1403EE for ; Wed, 24 Jan 2024 21:41:05 +0000 (UTC) X-FDA: 81715525290.20.74BDCD1 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf08.hostedemail.com (Postfix) with ESMTP id 0C23E16000E for ; Wed, 24 Jan 2024 21:41:02 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="C0/B9fuP"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706132463; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Gdx+IUjeaUFcylNxhLz8scMMaJ9E79xhrBh38+G7OAE=; b=NLETF4HTM/VrXk9y8pejYPadsVMncDNk6B02BGOpGYHp/Jn20KDMjSQtLUzTVWmy6EgRKZ vaDU+0JlJF1qPt5enBOhiaKEy9xv0GFHaQdL+lGjG9xo2qiR84oihWrSCGNQuW9APmuRI3 uFZ2vfy1Btr2tBKo4HiqxgMrjDy7Beg= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="C0/B9fuP"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706132463; a=rsa-sha256; cv=none; b=aLXMShyXeAbrE4egGXYyIoiCwAJfzL5n+f3F1c+EPX3FqCK91r8ICcUWqIt4TRSGRZuUvg F5V+mbpacNU7XYfWwztNvido8tWjVWutDRn1JMlWO7gJD2mDyZJ3kRMJw2ou/iDo7U4O6U lLSZeKlPtxocXawVjYrRoQA/OoXgHo8= Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a26f73732c5so674406766b.3 for ; Wed, 24 Jan 2024 13:41:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706132461; x=1706737261; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Gdx+IUjeaUFcylNxhLz8scMMaJ9E79xhrBh38+G7OAE=; b=C0/B9fuPSZZcIVsYleIg9BupVRxhshrP2kH96X52Dnnz2oRe9vrWByzfwebHFktZfV FuF/e/2j+Zh+wLkiZzXbZqby9XSHeT0cWUzPCgEN5tIn4k6HxlU+Z7ES4oylpTILDhwt BHoMZneX3cI8K2nbBI4R32RRv+3cMlOT2Y84IKkwvhT7Uub94xNzwD93Zoa37qPj40UN Cv3I1QVJ66zJuUHtkbNi2jMydToqNam68zJ+vTapJtTeH3tlI+zhMSXFMnRPmoxdrHqy kQvh7Vzhk63S8h0uYSxExUsSscW+U8W1IhLU9PrggULOvH3ryEs2gQN3mPak/KjaYYWl 2smA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706132461; x=1706737261; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Gdx+IUjeaUFcylNxhLz8scMMaJ9E79xhrBh38+G7OAE=; b=qxsDqsdpVk9W+H8D+FMds+tlJBTqJebvvmmqcoS+SBAsELiHIhJPdBTEwMPMi2aiJf biEcdS50HW8kA6uIW0t7xKR3ojHz+sT/HxY6cfWr5lZ9avs14xAS4afiASIGs29qgoOm yyEE9k818y2STUgi595lSZDJ+AbwlYTQPR+03Nvx5hQpobbOM0yRmCf5Awrn06q8pJE8 fBy8XzUGySID8pieSrTTJePoF+IFFK6yUuXoogMZSIrRUw5cLEkVMB2k0zY30MqPn+8o jdeRKERaiyz16XZCntHsvEtEnbGD7OJJHneX/JAtQSe3qCWhNrDgfy1lDN1fVfx2r3kv 2j/A== X-Gm-Message-State: AOJu0Yw5kn4PhYtpZn/az6ujLJVHigf71SeAHDxI+Bdwo8EmJiZGM0K0 9y5wt3lsGlCmFWBaMD4Nl7aD2JGvSLl3ixWVGHe9JLKcAvB0R32Nj7TE6tmoOo2ejSnFGm5qKwZ lJWRu5JW03rCoQuhu8JoFT2x8cC0/GN/L8d/e7B+IlWiV4dNB7g== X-Google-Smtp-Source: AGHT+IFjEoF4u+IMowFOiDBleDGBDyR1EL8Is/Z+o4fzErE2dFPJZE576v7LzN33Rzm2e5yXyrn0pa07Li0HkM6mKxw= X-Received: by 2002:a17:906:cd04:b0:a30:f55a:b54c with SMTP id oz4-20020a170906cd0400b00a30f55ab54cmr1114691ejb.132.1706132461253; Wed, 24 Jan 2024 13:41:01 -0800 (PST) MIME-Version: 1.0 References: <20240112193103.3798287-1-yosryahmed@google.com> In-Reply-To: From: Yosry Ahmed Date: Wed, 24 Jan 2024 13:40:22 -0800 Message-ID: Subject: Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED To: Andrew Morton Cc: Christoph Hellwig , Nhat Pham , Miaohe Lin , Sergey Senozhatsky , Huacai Chen , Nicholas Piggin , "Aneesh Kumar K.V" , linux-mm@kvack.org, loongarch@lists.linux.dev, Johannes Weiner , "Naveen N. Rao" , Minchan Kim , linuxppc-dev@lists.ozlabs.org, WANG Xuerui , Vitaly Wool , Chris Li Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 0C23E16000E X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 4d97apqapx6fyjecmrz7d7jtnogxts1d X-HE-Tag: 1706132462-814976 X-HE-Meta: U2FsdGVkX1/PyrRx4f+GSvOJGfq532KuSoAMWsYEsK9b6RjqTPPee4eIcOgqEnbqoWRMEimkkeQpdI1Jmq/ytUwSgHJ36n+9nBxA28u9bXIztIRVrjm/Vl0xyocEcv5E0Y/KBGSFCNBujCJkEngqkxxM2Jn8adjQaOlFWwe1mFAxN5ckoSMUe2+gX6PGDE+Ec3GVGvyhtHfdh5h5LjdxxTxJxmlBciEVB6ImtwXnt3qO1A3pXCsv4HA0gRh2nhnR7E1+PFj8jnlLqzFGG9fK5bGAs/PdNDbCTXfWxozV/O6uEK0jVg8J+GOde5leRO/9XAdDtXO08Xmbv3k0yOK7gU2UvzeYjv9RMCRXeEr4IA02wJ5VhZDrChh8ph1ahaXfwkCys88xIfVtWaxpixf2qTC0BEPSLGGRYERyACD0aPn4PlALDd+f+Lb2NQ24ZbVLejSJLJgVEIrEswH5vO9hhSk5t8eblLzdMDSUkyklt8zHQ6eqtx65N5Z8Z2gl6VbUYWmsWekjWilV2CIh4K9S9jZ89HJIrLZtvS1zhaQkmvhTYq6csXV99EyvqKFws3TMcQVFvEbShhoZ2uJ9QB5Z1aBpvmnCVTTLrESEVtBgUEQ95ChsaPrUgoyl4EmpNrkU7Y77QlM2DBqbHKAPzoz/0LWc6r4Ozid1Sf7HaBTO4QopB3FRKPwtUch5+KHDMrn1g48hbha2x7YEbReGmxgKJShVVJbjI0VGIebtsOq5FwnS6wT28KZykXJ2nyrvQ6KyV3Kcg4HJ27GDjnvoonv7gG+esbsbP0C96WQCzkmAksPYZAPPFMkcsixOox1JbF02SjAQSRiqOLTpVbK1dFFuW+2+W12T8m3/PnfcdWvNZf09UuhYK21rdhJ9YX780zqretCCnZKGFNOW0XwqZGq0MHWBQEo60gR8mO0x3ynn4j1XSTyVWsH2FWCCp7aJUrbL+fyHJGsnjOlQ21swZbk sRltxQ1d yFj3O8X4i61chHd3aeRSAQPiL1yugtTZ3G78hGP2u3Ooh4Ajun/lvdIXzME8Nw9ZcHE9GHVYCbCUZeenTAobrIhvJSqq/ManPZQMVlgpJ9rgRvlhzaV6sSDpyhWJWlvf3R0nEsl83xzU4Q0Q8YWLNKJ8dab0elknkUHTbyOCSkFSfus59lzFwNl/cBYyK4HeEjdgQfJSbnmOKkWLe3rok7WGOOvqhq041dqn6NCiy/hbxksOhpl8uDGwyyP0ipqAk6XHIvWAF1ACEshAUOHHSM9KwIX/GEvk6B1s+jUojI0FUjGYcCYmqnVMu/UG2nWs3Q5vzJtCfgMEQETfW/vreZp3/aa64azkP6vLDP811n/2inFE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 22, 2024 at 12:49=E2=80=AFPM Yosry Ahmed wrote: > > On Sun, Jan 21, 2024 at 11:42=E2=80=AFPM Christoph Hellwig wrote: > > > > On Tue, Jan 16, 2024 at 12:19:39PM -0800, Yosry Ahmed wrote: > > > Well, better compression ratios for one :) > > > > > > I think a long time ago there were complaints that zsmalloc had highe= r > > > latency than zbud/z3fold, but since then a lot of things have changed > > > (including nice compaction optimization from Sergey, and compaction > > > was one of the main factors AFAICT). Also, recent experiments that > > > Chris Li conducted showed that (at least in our setup), the > > > decompression is only a small part of the fault latency with zswap > > > (i.e. not the main factor) -- so I am not sure if it actually matters > > > in practice. > > > > > > That said, I have not conducted any experiments personally with z3fol= d > > > or zbud, which is why I proposed the conservative approach of marking > > > as deprecated first. However, if others believe this is unnecessary I > > > am fine with removal as well. Whatever we agree on is fine by me. > > > > In general deprecated is for code that has active (intentional) users > > and/or would break setups. I does sound to me like that is not the > > case here, but others might understand this better. > > I generally agree. So far we have no knowledge of active users, and if > there are some, I expect most of them to be able to switch to zsmalloc > with no problems. That being said, I was trying to take the > conservative approach. If others agree I can send a removal patch > instead. Andrew, do you have an opinion here? We are not sure that there are active users for z3fold. It seems like we have all sorts of opinions here from "don't deprecate" to "remove directly, no need to deprecate first".