From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69C4FCD11C2 for ; Fri, 5 Apr 2024 04:48:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A35336B00E0; Fri, 5 Apr 2024 00:48:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 994A76B00E1; Fri, 5 Apr 2024 00:48:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80F376B00E2; Fri, 5 Apr 2024 00:48:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5FB0C6B00E0 for ; Fri, 5 Apr 2024 00:48:16 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9DDFC14108E for ; Fri, 5 Apr 2024 04:48:15 +0000 (UTC) X-FDA: 81974246550.25.39843FF Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf27.hostedemail.com (Postfix) with ESMTP id EBD3B40010 for ; Fri, 5 Apr 2024 04:48:13 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=xlC+Kzmq; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712292494; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OFngNohcsIWWF9VBx68/C+XJdy9eZcqacGTQk/W+jbI=; b=v/DfUhM9cMzrwq5ChBapo8a0UjZm7yNKAV2pqCLkCw3UhUlKl5A7M3GmuXZtjnloPyxjVN s7oKXsOtcQi0N/kkz4G6awQnd0upwoAuCS6MFBwIa5AvFcGIFdRHW3eV1eOHhXQwlOXD7N /8OvFMXauDANJlF/Eh2B6IH0cPT1d74= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=xlC+Kzmq; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712292494; a=rsa-sha256; cv=none; b=KYaHYrNX1o3KHV/9GQRnC8xIYZm8dutyXfmhyBeMjhWDXWEgqbE7V53mRsrM/scHiBBi+1 BegU8/m3Vb/gw0Ab2uLPeCuCEMlSy91WyGSfnIosGGo9O/Q1qELP3FNLfTo+stFdjvlDkC O7BsfVV4MEAC49ZHDR384FzL4hOBbfI= Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a44f2d894b7so224902866b.1 for ; Thu, 04 Apr 2024 21:48:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712292492; x=1712897292; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OFngNohcsIWWF9VBx68/C+XJdy9eZcqacGTQk/W+jbI=; b=xlC+Kzmqbnm2yNhAzy3lu7NOztEpkiMF3L8RNAoy9DXC4SVbH2WSOhJBKo5RJk/lCY 4S64xLMz6IycgGmyj67Gm1iiCpdHrKEaBwyR80nBH7O5QIzTEYoUvxYzqhaWFOHyeaIQ vbiqIRZnE/WVIw6/ELNJpfYEDYtEBvxyljJ02RMc/B9qUJerYSRN9BT5xTqM093/67Kq STH6acT1Hu4MC5EitxsbBrJQq/QT9Y58wORAVfY671HWdTrEQi2M0rq/TlMYD+1Hvww4 MRy7lrBibWpJWQQ9O5sAOzmgkr/WTtP8BeRiCFm8YT2L1kd9g17NUUqdI292YJEeBYic CvVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712292492; x=1712897292; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OFngNohcsIWWF9VBx68/C+XJdy9eZcqacGTQk/W+jbI=; b=rrYDFHXeFoqmJrGMMkUKuK8UvN0XSib2Revp90vn2ynd95X15djooM8mAec3TnxCwq IfDYj3fb0NQXgJ0wdKa7uhY0Tg80GerblpttokuZP6bJm60tfEj7/9z1CzRIJYipzZKi oxfF1lhGrkQKJGapqnBL3bUEJapMw9LknOclrpdw2H7sbK+SVdvVX65T87k9ST86FvbB x2tPz85GuuL1u7sqNFihTxM5DjTVAN0KN14/LrGbX5ENuqwjiocSi3eBHY/2OifHgpap bOVhmt906YI9zT1ZuW1N7DICA06MzaFyaENjsviKD4tP4CK9bHMP7LrfGuWKQ8msv95U f0Ww== X-Forwarded-Encrypted: i=1; AJvYcCUwdJzX9+B473EnP9u19lAF6mzBKG+eFf+OVaUTwwOG6hSix4DAK+EQno+hhIEMDHwLJK1ZRMD64tK8Oo8xqmY/XFk= X-Gm-Message-State: AOJu0Yzp/oQ6wIAhM2ItKOBHGBn6SiJvYzYVDF3aeqHmG0I7DO1vM0mI b3S3V/dImT9GZNXHUfz7IuKMcGyC7OsDuzeWG5k3t24Qmfl+W+n2gMrn0yOGzyjN/lyGHt3dQX0 SGwXdzPqwCERqJ35OdWAhr/X3xEvgvv8jDvPz X-Google-Smtp-Source: AGHT+IG0FTUjSAmspO/nmTPWRrODUK6jOybARjqK66uz0z8iWEoCJvp6YB5mNy5YKEO10BQdeJehh0/wHKz/44T7/BE= X-Received: by 2002:a17:907:985b:b0:a4e:109f:7b4b with SMTP id jj27-20020a170907985b00b00a4e109f7b4bmr215688ejc.41.1712292492092; Thu, 04 Apr 2024 21:48:12 -0700 (PDT) MIME-Version: 1.0 References: <0000000000007545d00615188a03@google.com> <20240403180752.f95e1b77e033b5e03164c160@linux-foundation.org> In-Reply-To: From: Yosry Ahmed Date: Thu, 4 Apr 2024 21:47:34 -0700 Message-ID: Subject: Re: [syzbot] [cgroups?] [mm?] WARNING in __mod_memcg_lruvec_state To: Yu Zhao Cc: Andrew Morton , syzbot , cgroups@vger.kernel.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org, muchun.song@linux.dev, roman.gushchin@linux.dev, shakeel.butt@linux.dev, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: gq3dw7yfke8gnnktisd5ockehzn88xwo X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EBD3B40010 X-HE-Tag: 1712292493-769629 X-HE-Meta: U2FsdGVkX1/DIX8ERfh7T44OpFDATwYUR9OKYlNOsPiqkWiIZvzRbwWJlRWeOrXcSccUSScOeKaGoFyUicyoEgjJKBPuQE9CwwfexAoCAHjo09uU082q/5ifRSCvALt+anq/oSR/M7pw5qeo1DmkAhHQIBWZVIW/+BTegG9lq5c1f6ztrbHZNzxdVFFV2W1KerRfTLzlE1ZKUkzoWbVxxQY9ddMe73uTH5AdzShykuyrQrLt4Vg20IJX4jQ60uociSxPwQB41FzRFWu7CYnaPuEEGTb7fS6EODI7epWMvezUa6ecyvXPLc3A87rj6btjuYuOlWTTOzhSkf6dbow8RHZsDh4c6tY4B58jkbZpa0sq5b4l2Ca2nhptrtWezPzMw6ZGKIub3dDKsEe3UOOhKS44hcN7I2/fwHvHGc8GIIBkzjfbU4Xcs49d2Q9iw0Q0SABzWFf2O7fAjH40zllZ/D+MJg7FjvFbj7l4bm8AOAl33kUYU7B0PAhJU4QgTlEHueYzJGS7XKR28yQ34rhIovHQQrIO2VUccq4vndSh1SWyNhgwdWflKBfrV9p+3mOK0t1U0fbcnJJKX+xzfLZ29oq2S6f6a+VvfN36t0GT0ZiB34CbpA6B1eJQnFPOYOJwa/MUNcYepPU+SddI41O6YxeAsCxbl+8o7OnPg0bRiq+MX/9H93xWIJ0Z4oHz18CpQI0u5tW8ttQWARRhysdap1aAAPNQNWIG0b6Qxs02y39GxVeGH1/eoQA9uQFgE3EYnwmnw2+W8J9nanpUMS5LUL1KhaWoivGqOBI5eLK0lSfETBuE6fVVvLM9sQpWIFPp69e705sp6jII7wkyaOtjHUV6c1jglEAHw28aybQuyZOCjSN4DfOgv7nNwdYc+HxX2M7z+FDPrpBfa8aAVAKesde4OE6ZuMgS8+hXOCdtX9/eLVD5DZYy95LGs2WEPHlur4GPkxY/41nCl75l57e cPFNGSzC in8TUp0Yw7a8cnhy3iqN0QmQBbAgiptPWEpzu6YZFkAnddsM9UCXilCdgHQhoI20Mc91QnZpTZr+LnMATF34r4S+HRRSA1NjP8FXLX7wxd/nWkBqu1Q//Zixnj48Vut/GDq+vwSepSxlaePA2p+2XbfDp9hp+ESj8i7HAwHN1S3JOqtxnpp9Ps2H73hnGq/M03yjwpBFOPbkkNPnkkhP10B/YuFCx25taQr1dgYYdHgdV3knnAdMLI+AUzh0Ecr3yHuJEYv8g/0OvPUnZrLUj6Qpu/8sUh1wU1vMp6sWMmBEJ2aM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 4, 2024 at 6:44=E2=80=AFPM Yu Zhao wrote: > > On Thu, Apr 4, 2024 at 7:36=E2=80=AFPM Yosry Ahmed wrote: > > > > On Wed, Apr 3, 2024 at 6:08=E2=80=AFPM Andrew Morton wrote: > > > > > > On Tue, 02 Apr 2024 01:03:26 -0700 syzbot wrote: > > > > > > > Hello, > > > > > > > > syzbot found the following issue on: > > > > > > > > HEAD commit: 317c7bc0ef03 Merge tag 'mmc-v6.9-rc1' of git://git.= kernel... > > > > git tree: upstream > > > > console output: https://syzkaller.appspot.com/x/log.txt?x=3D15fd40c= 5180000 > > > > kernel config: https://syzkaller.appspot.com/x/.config?x=3Df64ec42= 7e98bccd7 > > > > dashboard link: https://syzkaller.appspot.com/bug?extid=3D9319a4268= a640e26b72b > > > > compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils= for Debian) 2.40 > > > > > > > > Unfortunately, I don't have any reproducer for this issue yet. > > > > > > > > Downloadable assets: > > > > disk image (non-bootable): https://storage.googleapis.com/syzbot-as= sets/7bc7510fe41f/non_bootable_disk-317c7bc0.raw.xz > > > > vmlinux: https://storage.googleapis.com/syzbot-assets/efab473d72c0/= vmlinux-317c7bc0.xz > > > > kernel image: https://storage.googleapis.com/syzbot-assets/5ba3f56d= 362d/bzImage-317c7bc0.xz > > > > > > > > IMPORTANT: if you fix the issue, please add the following tag to th= e commit: > > > > Reported-by: syzbot+9319a4268a640e26b72b@syzkaller.appspotmail.com > > > > > > > > ------------[ cut here ]------------ > > > > WARNING: CPU: 0 PID: 30105 at mm/memcontrol.c:865 __mod_memcg_lruve= c_state+0x3fa/0x550 mm/memcontrol.c:865 > > > > Modules linked in: > > > > CPU: 0 PID: 30105 Comm: syz-executor.2 Not tainted 6.9.0-rc1-syzkal= ler-00178-g317c7bc0ef03 #0 > > > > Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-deb= ian-1.16.2-1 04/01/2014 > > > > RIP: 0010:__mod_memcg_lruvec_state+0x3fa/0x550 mm/memcontrol.c:865 > > > > Code: 45 85 e4 75 1d 48 83 c4 18 5b 5d 41 5c 41 5d 41 5e 41 5f c3 c= c cc cc cc b8 00 04 00 00 e9 80 fd ff ff 89 c6 e9 a0 fd ff ff 90 <0f> 0b 90= e9 a7 fc ff ff 48 c7 c7 18 43 e1 8f e8 32 51 f8 ff e9 5e > > > > RSP: 0018:ffffc900034beef8 EFLAGS: 00010202 > > > > RAX: 0000000000000292 RBX: 0000000000000001 RCX: 1ffffffff1fc2863 > > > > RDX: 0000000000000000 RSI: 0000000000000001 RDI: ffff888024b92bc8 > > > > RBP: ffff888024b92000 R08: 0000000000000005 R09: 0000000000000000 > > > > R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000001 > > > > R13: ffff88801c326000 R14: 0000000000000001 R15: ffff888024b92000 > > > > FS: 00007f0811bf96c0(0000) GS:ffff88806b000000(0000) knlGS:0000000= 000000000 > > > > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > > > CR2: 000000000cfff1dd CR3: 000000003e4e2000 CR4: 0000000000350ef0 > > > > DR0: 0000000000000031 DR1: 0000000000000000 DR2: 0000000000000000 > > > > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > > > Call Trace: > > > > > > > > __update_lru_size include/linux/mm_inline.h:47 [inline] > > > > lru_gen_update_size include/linux/mm_inline.h:199 [inline] > > > > lru_gen_add_folio+0x62d/0xe80 include/linux/mm_inline.h:262 > > > > lruvec_add_folio include/linux/mm_inline.h:323 [inline] > > > > lru_add_fn+0x3fc/0xd80 mm/swap.c:215 > > > > folio_batch_move_lru+0x243/0x400 mm/swap.c:233 > > > > > > Well it beats me. I assume we failed to update for a new case. I'll > > > toss this into -next to perhaps shed a bit of light. > > > > > > --- a/mm/memcontrol.c~__mod_memcg_lruvec_state-enhance-diagnostics > > > +++ a/mm/memcontrol.c > > > @@ -860,10 +860,12 @@ void __mod_memcg_lruvec_state(struct lru > > > case NR_ANON_THPS: > > > case NR_SHMEM_PMDMAPPED: > > > case NR_FILE_PMDMAPPED: > > > - WARN_ON_ONCE(!in_task()); > > > + if (WARN_ON_ONCE(!in_task())) > > > + pr_warn("stat item index: %d\n", idx)= ; > > > break; > > > default: > > > - VM_WARN_ON_IRQS_ENABLED(); > > > + if (VM_WARN_ON_IRQS_ENABLED()) > > > + pr_warn("stat item index: %d\n", idx)= ; > > > > Line 865 from this commit should be this warning (i.e. warning because > > IRQs are enabled). This also makes sense because __update_lru_size() > > should not be updating any of the above stats. > > > > folio_batch_move_lru() in the above call stack should be acquiring the > > lock with IRQs disabled though, so I am not sure what's going on from > > a quick look. > > > > Adding Yu Zhao here. > > Probably an RT build where _irqsave doesn't disable IRQ? Yeah, that's possible. I don't have enough familiarity with RT to know for sure. Perhaps lruvec->lru_lock needs to be changed to a raw_spinlock_t? I am not sure if that's the correct course of action.