From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C76EAECE587 for ; Mon, 9 Sep 2024 20:45:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24F206B00D4; Mon, 9 Sep 2024 16:45:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FECB6B0207; Mon, 9 Sep 2024 16:45:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C6A66B0208; Mon, 9 Sep 2024 16:45:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E311F6B00D4 for ; Mon, 9 Sep 2024 16:45:03 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 861411C2E0A for ; Mon, 9 Sep 2024 20:45:03 +0000 (UTC) X-FDA: 82546379286.15.C89B4D8 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf09.hostedemail.com (Postfix) with ESMTP id AEA3914000C for ; Mon, 9 Sep 2024 20:45:01 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=K6++lFgO; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725914588; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y28KVwZM5713wIABpPiFiUqwyB36UAsbyqOCul1ZAls=; b=SkmsHQ+G3u3QxMabEwP7+SSDibBlaWTiAlkP0eUsq1nIohP/tLDKmk+BwcIGkY8Xb0nFLR ABeo8tk835cm5UudIfYvH/4Nx53CyT6cJbDr5loKPnPP2McSX/s55IFfGaTjl+3LKr9RUT hZJ9DAnOYC1ybVLiLqat8kPQQkUCQZ4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725914588; a=rsa-sha256; cv=none; b=XmOw7j9TwsN4jVMHfm6n6GabZoDzo71Vr6u/11jcsxd2EGQvFheBIgrcv9yoIIqn5AEbH+ NGRQ7sfqpPfgsnaGwKs1YzXVWUtFZkd2fIkE6fxTCJ3L9iXuf4MtRiV3xaFCX4bDhT75a+ 7Mg+V49VDzZc3IC5QOYPVLlk5HtDeX8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=K6++lFgO; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=yosryahmed@google.com Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a8d6d0fe021so100397466b.1 for ; Mon, 09 Sep 2024 13:45:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1725914700; x=1726519500; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=y28KVwZM5713wIABpPiFiUqwyB36UAsbyqOCul1ZAls=; b=K6++lFgOdB372LRyd859rJhAkveWph2MWKNDHpJrCEqMCEJnq0QOPQbAjumSWSATZ/ YNPC6y3HQRUeZSyijDV1MhJ/bL/KbaxgTOlt7ZnWtDihExtrTCp72FjOevD9ZV4G53Po RqRZzapVJ79x76pq9n/P9Lwh67TGT9CUkzFbwDdGlFoBuq+KucwVo5CVWvL+1DadnK1Z b3ghlTp1vx/F5ecrjlaDaFfrwoxtEo3I20fUpJJG5dM0XVV/sjAEHiW0ZismSLmR92Sh roxu6ehNfDJPI6iGmhJjgvYW32eUbE3WvayW2b2k1FQRQUKBhjcdNKIP5UZPb8rca+1S 14DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725914700; x=1726519500; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y28KVwZM5713wIABpPiFiUqwyB36UAsbyqOCul1ZAls=; b=QZeSTcH655ZP93iT3GN+99y4PS+jLZjOd75kWC+OXTjbkeHSYFUCJk3AAP75FXyLOY ePPbHafuVeHDi2ZvoO/9hGUVLBsm9XFb7ivTCY4kW7SS0DNng7hRDrLuPlfZU7a9o9Hy 1NNVRprfnd4NS5QzlJKvZcDF0WjshTxzYeFIQ2GjfIwHwkzv+bkUjb/x0+wLTi7SpKfm WoQxNvnH6GM1z0ANBsDYTJBh8vR2fCkF4KL31pdwkSYpJjiB0uAsGwYmrchFuOr86iQa yLigDgQWmFaFM1WLcCQz6bGIyut6HgYyhgp9Nxajlqy4WWBBJmbZW5E9QeEdWhMoSmAO q8YQ== X-Forwarded-Encrypted: i=1; AJvYcCWMZsKNLdkWh+u5N5ZIGU92jPG2uIwO7Zo79RlePjBghZwy7cSKbiQKj4oGLDl7e1Ptunn9OWLNyA==@kvack.org X-Gm-Message-State: AOJu0YzxiTD3SqW4bklCMxE6u93E/pkFuu7PwucxTbjYfHMnxDkztXS9 FACFPFKw9KpKo5f0aCfCXOVj9Xh9ZpzvOnfGFlqZCOdimIAHT7bs4GceYlZaVwUHKGDyK7DjOT9 Xau2qjtdtg5BOktxY+teJ2Ivu6SZXILNhWQWZ X-Google-Smtp-Source: AGHT+IHUOhpj2xyrKzGrMnUTxW2VUXqTfgRqFsZ7Q6h5I6U2jYCG15EHSZWlAdAwUqiQ4R3s2tR81G50b+7cttWuTZY= X-Received: by 2002:a17:907:3f1d:b0:a86:82e2:8c6d with SMTP id a640c23a62f3a-a8a88870e91mr932920066b.62.1725914699445; Mon, 09 Sep 2024 13:44:59 -0700 (PDT) MIME-Version: 1.0 References: <20240909202625.1054880-1-arnd@kernel.org> <85524814-6256-4f83-bb59-879debf26646@app.fastmail.com> In-Reply-To: <85524814-6256-4f83-bb59-879debf26646@app.fastmail.com> From: Yosry Ahmed Date: Mon, 9 Sep 2024 13:44:23 -0700 Message-ID: Subject: Re: [PATCH] mm: z3fold: deprecated ZSWAP_ZPOOL_DEFAULT_Z3FOLD as well To: Arnd Bergmann Cc: Arnd Bergmann , Andrew Morton , Johannes Weiner , Nhat Pham , Chris Down , David Hildenbrand , Mike Rapoport , peterx , Matthew Wilcox , Kees Cook , Vlastimil Babka , Chengming Zhou , Anshuman Khandual , Vitaly Wool , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: AEA3914000C X-Stat-Signature: nwys6e71ztyr1yici9twsxk3s9abstir X-Rspam-User: X-HE-Tag: 1725914701-35590 X-HE-Meta: U2FsdGVkX1/ej5Dr/87fdaSF1cNq+SLtcU4GlE4F5cooiAJHFHTFhA9BKlJSL8cvAdoURG/oiTvOXz3hnDPrvzY6wgJYZW8nhY0xkaF9PNjMm2jWe8yFrGzyv7QOg49AHJPugK3U7VLhR0Bq/hhrZjpFO7iJuhKUPhS4+HSDN1vhBHzjxkldH/FGIRyznQL+AQ24d4xYjKnn9Au5o0aKphP+FEyBXqsbWSfyr/OMjwJ02+qei62j6SApTXsXBYkWbNreDjlCXCS3hxR7SJemMSAQ92kTp/ImAkTYj79HDmPcaTb9aj/Hp/Joq2p4RBfgUxEG5CVPy68UAW1DpMZHiGa9j8lbbo3xwU2XlFD+7p6p13yB+FCYJsdo31IBknedLlISzA9PUft8nwLGN2GWyENbUMeKXKzUdeqo9P8kzqYry5UMYa5mUpkUTyawiPi2A0TyRZfhMf6RGfFZLOSO97h5ghbTMj6P2pf20VPAlnps58Rtd1GJWvVzqz8C5qdlbsZM54xAX3q9RYkQzUNsL0YrxU2ptMK7h9FPuRVUqhTH3t0U2telKuUIhirnRrV9zJ3VHQkogukb04q6rkJibkVKmzLbD4UsxBasoTrtIj5ZFO2PovI7HgEY1WNU6x9OErJe6jLkcFYwjq3EAUiJWMDLI1beT3AwkDn1EzeVDOT4njnrx8MealrW6v0jCKjgxmK+8nKhsetlmoFcBx0yTCmfOVnsCdYU8FDcdAbxRB3FP6k39r+76d+RvOaWbS1M7GYEk/uo7/qW/y6DUAtIXtnAPRMoViQonm211OMb2OqAvKqNoyKJmO8IYuDYU2YJ1TbEFJTzwjK547sP95hbEVyQpPq6PSoczZjjR2zgwZgL8pPjYdXwNqA5fjhglocGxqeOK9TrfyQKVM72C8OfYuZkAiZ+gChcueoE+JvIg4wQdz72UiKftldnetwfrHRqkY6mYMdBz+AcFkA4IH3 ZGoYbzCC e7F8lYTI7C9b2ZuQNjmQ2gZwJjyth6gv0naBM3ckge2L5savL24sbu9LFFJuVegaMRZaE1leOvrQ/vDsmFx26wISZzDaCRjgHVLqprE9QC44kP08dHpmC9/lO/5B7T4+WrkXYrBdg7uv9gQwdRcbCrudwEBk8MviI8XUYqqcmDxEIznpWrNBeoyChd1OIBW30NwFkGR3lAOk0EMCaEviFS94iRfoYBX+qeo5onFkfaTDig1PsSrCVMZa/LAVMUg3HrshfL0Gm8wfa6JQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.002605, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 9, 2024 at 1:43=E2=80=AFPM Arnd Bergmann wrote: > > On Mon, Sep 9, 2024, at 20:29, Yosry Ahmed wrote: > > On Mon, Sep 9, 2024 at 1:26=E2=80=AFPM Arnd Bergmann = wrote: > >> > >> -config ZSWAP_ZPOOL_DEFAULT_Z3FOLD > >> - bool "z3fold" > >> - select Z3FOLD > >> +config ZSWAP_ZPOOL_DEFAULT_Z3FOLD_DEPRECATED > >> + bool "z3foldi (DEPRECATED)" > >> + select Z3FOLD_DEPRECATED > > > > Thanks for looking into this! > > > > I was going to fix this by changing "select Z3FOLD" to "depends on > > Z3FOLD" instead. It makes the warning go away in my builds. Does this > > work for you? > > I had also thought about this but decided that this would > make less sense from a user perspective. I doubt there are any actual users who care :) > > If it builds in all configs, I won't complain though. I will use "depends on Z3FOLD" in v3 just because it's simpler. If bots complain, I will fallback to your approach. Thanks!