From: Yosry Ahmed <yosryahmed@google.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Arnd Bergmann <arnd@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Nhat Pham <nphamcs@gmail.com>, Chris Down <chris@chrisdown.name>,
David Hildenbrand <david@redhat.com>,
Mike Rapoport <rppt@kernel.org>, peterx <peterx@redhat.com>,
Matthew Wilcox <willy@infradead.org>, Kees Cook <kees@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>,
Chengming Zhou <zhouchengming@bytedance.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Vitaly Wool <vitaly.wool@konsulko.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: z3fold: deprecated ZSWAP_ZPOOL_DEFAULT_Z3FOLD as well
Date: Mon, 9 Sep 2024 13:44:23 -0700 [thread overview]
Message-ID: <CAJD7tkbLfKPLJb0_eiXjjfxaDZSKHCKfTJrWrnw0stNhzDh=gw@mail.gmail.com> (raw)
In-Reply-To: <85524814-6256-4f83-bb59-879debf26646@app.fastmail.com>
On Mon, Sep 9, 2024 at 1:43 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Mon, Sep 9, 2024, at 20:29, Yosry Ahmed wrote:
> > On Mon, Sep 9, 2024 at 1:26 PM Arnd Bergmann <arnd@kernel.org> wrote:
> >>
> >> -config ZSWAP_ZPOOL_DEFAULT_Z3FOLD
> >> - bool "z3fold"
> >> - select Z3FOLD
> >> +config ZSWAP_ZPOOL_DEFAULT_Z3FOLD_DEPRECATED
> >> + bool "z3foldi (DEPRECATED)"
> >> + select Z3FOLD_DEPRECATED
> >
> > Thanks for looking into this!
> >
> > I was going to fix this by changing "select Z3FOLD" to "depends on
> > Z3FOLD" instead. It makes the warning go away in my builds. Does this
> > work for you?
>
> I had also thought about this but decided that this would
> make less sense from a user perspective.
I doubt there are any actual users who care :)
>
> If it builds in all configs, I won't complain though.
I will use "depends on Z3FOLD" in v3 just because it's simpler. If
bots complain, I will fallback to your approach.
Thanks!
prev parent reply other threads:[~2024-09-09 20:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 20:26 Arnd Bergmann
2024-09-09 20:29 ` Yosry Ahmed
2024-09-09 20:42 ` Arnd Bergmann
2024-09-09 20:44 ` Yosry Ahmed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJD7tkbLfKPLJb0_eiXjjfxaDZSKHCKfTJrWrnw0stNhzDh=gw@mail.gmail.com' \
--to=yosryahmed@google.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=chris@chrisdown.name \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=vbabka@suse.cz \
--cc=vitaly.wool@konsulko.com \
--cc=willy@infradead.org \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox