linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Yosry Ahmed <yosryahmed@google.com>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	 Johannes Weiner <hannes@cmpxchg.org>,
	Nhat Pham <nphamcs@gmail.com>, Minchan Kim <minchan@kernel.org>,
	 linux-mm <linux-mm@kvack.org>
Subject: Re: [mm/page_alloc or mm/vmscan or mm/zswap] use-after-free in obj_malloc()
Date: Thu, 22 Feb 2024 21:05:58 -0800	[thread overview]
Message-ID: <CAJD7tkbKGpJi_495BeThg+U0un09p7Cnwz6-2fRjghL8wotETg@mail.gmail.com> (raw)
In-Reply-To: <20240223045845.GN11472@google.com>

On Thu, Feb 22, 2024 at 8:58 PM Sergey Senozhatsky
<senozhatsky@chromium.org> wrote:
>
> On (24/02/23 13:56), Sergey Senozhatsky wrote:
> > On (24/02/22 20:50), Yosry Ahmed wrote:
> > > On Thu, Feb 22, 2024 at 8:48 PM Sergey Senozhatsky
> > > <senozhatsky@chromium.org> wrote:
> > > >
> > > > On (24/02/22 18:27), Yosry Ahmed wrote:
> > > > > I also don't see any recent changes in mm/zsmalloc.c that modify this
> > > > > code, so maybe it wasn't introduce in 6.7. I will defer to Minchan and
> > > > > Sergey, I don't think zswap is an active actor in this bug report.
> > > >
> > > > Yeah. [1] are the only recent zsmalloc patches I can recall, and those
> > > > patches touch zsmalloc locking (zspages migration/compaction).
> > > >
> > > > https://lore.kernel.org/lkml/20240219-b4-szmalloc-migrate-v1-0-34cd49c6545b@bytedance.com/
> > >
> > > These are not in 6.8.0-rc5 anyway, right?
> >
> > I see them in next-20240223, which seems to be 6.8-rc6 (according to
>                                                    ^ -rc5
>
> But they look more or less correct to me, so I'm not blaming those
> patches.  We should be protected by pool->look.  Bisection would help
> us a lot, I think.

Andrew picked up those patches in mm-unstable, which is included in
linux-next at some point IIUC, but the patches there don't all end up
in the next rc unless I am misunderstanding something here. These
patches should be headed to v6.9 AFAICT.

Actually, if I am not mistaken the patches were sent *after* v.6.8-rc5
was out, and it's not common for non-fixes to make it into rc releases
anyway, right?


  reply	other threads:[~2024-02-23  5:06 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-23  2:10 Tetsuo Handa
2024-02-23  2:27 ` Yosry Ahmed
2024-02-23  4:48   ` Sergey Senozhatsky
2024-02-23  4:50     ` Yosry Ahmed
2024-02-23  4:56       ` Sergey Senozhatsky
2024-02-23  4:58         ` Sergey Senozhatsky
2024-02-23  5:05           ` Yosry Ahmed [this message]
2024-02-23  5:19             ` Sergey Senozhatsky
2024-02-23  5:23     ` Chengming Zhou
2024-02-23  5:29       ` Sergey Senozhatsky
2024-02-23  9:26       ` Tetsuo Handa
2024-02-23 10:10         ` Chengming Zhou
2024-02-23  4:43 ` Sergey Senozhatsky
2024-02-23 15:22   ` Tetsuo Handa
2024-02-23 23:54     ` [PATCH] x86: disable non-instrumented version of copy_page when KMSAN is enabled Tetsuo Handa
2024-02-24  6:27       ` [PATCH v2] " Tetsuo Handa
2024-02-24 14:23     ` [mm/page_alloc or mm/vmscan or mm/zswap] use-after-free in obj_malloc() Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJD7tkbKGpJi_495BeThg+U0un09p7Cnwz6-2fRjghL8wotETg@mail.gmail.com \
    --to=yosryahmed@google.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=nphamcs@gmail.com \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=senozhatsky@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox