From: Yosry Ahmed <yosryahmed@google.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
Hugh Dickins <hughd@google.com>,
Viacheslav Dubeyko <slava@dubeyko.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH] mm: Support order-1 folios in the page cache
Date: Wed, 6 Dec 2023 13:07:01 -0800 [thread overview]
Message-ID: <CAJD7tkbJ7zL4pyvFuWB48Yj-p_aqAJji81+hk8nsmUdF2RYj3A@mail.gmail.com> (raw)
In-Reply-To: <20231206204442.771430-1-willy@infradead.org>
[..]
> @@ -2836,7 +2844,12 @@ void deferred_split_folio(struct folio *folio)
> #endif
> unsigned long flags;
>
> - VM_BUG_ON_FOLIO(folio_order(folio) < 2, folio);
> + /*
> + * Order 1 folios have no space for a deferred list, but we also
> + * won't waste much memory by not adding them to the deferred list.
> + */
> + if (folio_order(folio) <= 1)
> + return;
Would it be clearer if we have a folio_has_deferred_list() helper that
has the check and the comment, instead of having this comment here and
commentless checks elsewhere (or repeating the comment)?
next prev parent reply other threads:[~2023-12-06 21:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 20:44 Matthew Wilcox (Oracle)
2023-12-06 20:53 ` Dave Chinner
2023-12-06 21:07 ` Yosry Ahmed [this message]
2024-02-05 12:00 ` Pankaj Raghav (Samsung)
[not found] <CGME20240122143620eucas1p1017072128a3b497fd95b796ebaad71a2@eucas1p1.samsung.com>
2024-01-22 14:36 ` Pankaj Raghav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJD7tkbJ7zL4pyvFuWB48Yj-p_aqAJji81+hk8nsmUdF2RYj3A@mail.gmail.com \
--to=yosryahmed@google.com \
--cc=akpm@linux-foundation.org \
--cc=hare@suse.com \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=slava@dubeyko.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox