From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24B08C48BC4 for ; Sat, 17 Feb 2024 23:15:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 354FB6B009E; Sat, 17 Feb 2024 18:15:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 304A96B009F; Sat, 17 Feb 2024 18:15:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CB5A6B00A0; Sat, 17 Feb 2024 18:15:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 045D16B009E for ; Sat, 17 Feb 2024 18:15:17 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8D9E616033D for ; Sat, 17 Feb 2024 23:15:16 +0000 (UTC) X-FDA: 81802853832.12.B41041C Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf04.hostedemail.com (Postfix) with ESMTP id A084140004 for ; Sat, 17 Feb 2024 23:15:14 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=IOHOkach; spf=pass (imf04.hostedemail.com: domain of yosryahmed@google.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708211714; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lJvonYTzCl7xp2PkiG/jmRrw2+4vNhq8HjWyw9v0bD0=; b=qXXgFuEyLnBwJ5CX/ihMG7zgkuMfwZgp9daGYnfS6uH8kG04BAfPLegDeCt7a6J/18O2+r lnqAGLJpwiBiy//0uIElzh8AUWjhF064cP3YDcnjwtFLtFweqCp5MMiz9I4Ff3ih12xsL+ g/WejyiajM7fg604nqr8aliRZ6LnmCs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708211714; a=rsa-sha256; cv=none; b=VvInTf9EFzEuP4mIaiR8UNRaflM/shiMAVWcTXyK5I6aPM4HKRjKqbPzFzzTD+3Nq9yYuW 7GlN+kwGVmQNhiwsf0XkkUHcC5tPCuDFt4j6fI4SZ93KD9LFILiE2CCY4LrSKn/V+zzLKE p8IGVy+xzM5lQNqAqwT3xroGHQSuCEo= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=IOHOkach; spf=pass (imf04.hostedemail.com: domain of yosryahmed@google.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-5129ece824aso1363937e87.3 for ; Sat, 17 Feb 2024 15:15:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708211713; x=1708816513; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lJvonYTzCl7xp2PkiG/jmRrw2+4vNhq8HjWyw9v0bD0=; b=IOHOkachdhGzID6GMooeyvlLJBySUSyeRhNA6jMWVVlYoZCTM0ZObWNs337f/tTJO1 zyYbDN8Y8IJjYQojFXmmJEgCraU6fKRnc4wVoU93a4/u8tQyvytGCI/NS5ySyS/ikRyM /KuU48xKPe0EWtgX7gKW/pD1T1EXi1XXbGO0PpOnjTr37C/AC+0gnq4YH3bJCgJcQKOO WiCIoGA2RXtwNx0IlaU+nryYwSPYhU17bAqyvTgW8dqYJ8TgnRX7kETryNWKjA5tBCKX koueqYzuV8cbGhAPFfU+et7TMGg3LsNXq8m5qDp1HnieoU48o7Ch42gTE6y2wqje0aZS ATtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708211713; x=1708816513; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lJvonYTzCl7xp2PkiG/jmRrw2+4vNhq8HjWyw9v0bD0=; b=wmy9l1jBpECDo5PMnxoFsuEgpkLJmitIM+FdsRHtlR61dzGyxTHBhuY3zgdJNMpONr tyBm8Lo5e3WOjAPETjYzoIW9TigvilQCL/FCLcVd9NhqNUwKAmHCPfIbDXEuUkQ4ymj3 PVtSG3vSs/9RmXIeEcKUL43H56rGuNj8FrsPIOJW148xQ2Ha+pEhz4/JuvFsKo2gVfYP +DbCGbXpoHGtDS5PzZM6nsfyzIBNgoIvd2EvUEKPnVoQ7wjmD1fJCc6syvb3l7zzHuJo tXE3gIPhOusRKv4QxKbApT5PaIDRiL0a9q10+b42LSBFaeDdwl8DuzbtFqE0TnI4VMVF 6HGQ== X-Forwarded-Encrypted: i=1; AJvYcCXI8Ofs6ldLGRCN2UYkfjPp45EJkO1VyqbsN3+uNdeSpc19KVNsc2HpnCC7QuRvI+Ce4ap7XrLep8gavoA8nS2qiG8= X-Gm-Message-State: AOJu0YwwwX7mHRxbpFWKE0zee6Y1WvX27NOq9kH8SUdDJeHBKvkf0OCm MQpOr+Z4lD6i2vZTpR8vlSqR3i3Ch/wQFngGMVrTAi47do+cHWNsXmWHbB6UASV6qKJMxue48y2 LsC6+T5TLDc0Fkn4R2Pqkkxc6JsjbqPBJrNOj X-Google-Smtp-Source: AGHT+IHpwwwxmZeH8i63HKX9Y9eDBXBqmFtWnPfRe4unf/ap00AxwwGeRckJWtJzJckk4sKjPna8wKb0Sjv41t0PLBQ= X-Received: by 2002:a05:6512:104f:b0:512:b03c:426 with SMTP id c15-20020a056512104f00b00512b03c0426mr698lfb.30.1708211712560; Sat, 17 Feb 2024 15:15:12 -0800 (PST) MIME-Version: 1.0 References: <20240217053642.79558-1-21cnbao@gmail.com> In-Reply-To: From: Yosry Ahmed Date: Sat, 17 Feb 2024 15:14:34 -0800 Message-ID: Subject: Re: [PATCH v2] mm: zswap: increase reject_compress_poor but not reject_compress_fail if compression returns ENOSPC To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, linux-mm@kvack.org, nphamcs@gmail.com, zhouchengming@bytedance.com, senozhatsky@chromium.org, linux-kernel@vger.kernel.org, Barry Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: A084140004 X-Rspam-User: X-Stat-Signature: ts3zkop6e7y1igry3rerktggaap4e9ho X-Rspamd-Server: rspam03 X-HE-Tag: 1708211714-787613 X-HE-Meta: U2FsdGVkX1+YaoOw+HsmEAffl8ITvIyx2JG1Xi7yXxMj72LtKdo4yjho8pBttAPkt5zgssXIrFIs7HyjyQuFyFERy6Wv/w0RFznhFAJlI/GpFvzaLmOfqLyXe1s6vEnFSeffk3A3xMVdIfI4urlsWU0800dyzuPU7kJolGc7nn4NaJmPVxc0SE4cGNCS8i5jG+sp5q4P9obt2mnye8LeaIHn5CfZfROmTKbLbnlRXkS+XIeJdj2Z25CKN9VpYaqWbDvTDBn6ih3Pw5Q+m7dw/lP0OT7uNHZRERbJgyglhIU8jFd1G6la23RGfZ/R+oKGKYaZFf2IB3os9hCkPlrDK0Lv5mLIPQKUi6TEQ5gQhgf3jEXqXmwyJckma2eO5EFrUKqPSLOqAhFpEtLZAd5HRsZyYF6Bd3Ma3Seodh/QoF/p+UmA/viWbwlT/Cci8KeT2xHTKBIjkX326CknD/Jtz3QAkZMpVn2HMpPCmDON2wE6gKx+iUbbhUKtCwAUez+OVM9t14a4DzkQcIZ2m0ijBaUI5QaEzI7KJcM+BJ74+S7KvE88i847b6jeMzk2lEkcthodqX4n/8/hCj8HJfts3JCgaFyRDURscLA2gSbhyaiA8HQauZ6XqoFs8aaz2RTGCkeXmg8nWHE6joloNnbfXyYqpovMYYe8eYL5VelBqsKVbeyrLPCjlVKOFEppvqTurZ2SehC/GjwcYdSlWHmuQ9WKD6be07kfKr0/uVC/QABe08HVh1MSFB6sfeqq9J/WadjWe842Sa5AOHDPCPiEj2UoKQwuPy5dBAYdz5v1kDh6YpqJZr1I8fYuVSJcMYVzJGLsTrm5A4plemGTAc9E7iUSfmDysKQ5MZ7NNSpbc1lwkt4L6d4iK6PzLv+5pAc5JUbN11k08gAnmjIcA9xR1QoBjtMq8607dAgFVLv6oslPRLBDmUymZq/rEODG8oVdtFxldTpQNiSsjfwbwVD OOHyznfh aW1jvyePmTXzKBkXITIGCDr+URX+RZZxSlm/ZecbZQyKV5yiNPHXpqk03PvNZInj7WIijrOSOjhc3CDYXJCgpjoF2tFhnEuFPFpDKntGkebiQsKDNr+ZJ3hMx5E1iVZrtuII1vBMIX9JgMmsl8BUH3k7kEcmvzzO9BZFdtLUay3T38XONDt+jJF8U5NRSPGU6M+QCfmtlHiQZYFI+llBmKW1pNBV/0xpBVf2iHC+a7p7/slJZcvu4g6Xr7bjYzdCKpCJDxMUPLDkBEkKJmly13Po5MQR+GqHww9i5aadxRgi0kQfY1wFOwITXFLr+Pc2yqZhj/Y5mmxCTq1ebRQ6bqJHsztJXOKKweK1INGS9WjkSB+RAhZM0IfTXwuCspP6NpTk+WZC8oXbJ2y21WtMfu6E/P0jgLdO5ds9Mw+xdxrAldht2T9hP7fFjLt7iK8fMTJMsQbm7rW8+G42YmXkwHoROz+k7Kzwm91d7K/UnHNajFRE3oFLHJBY+YQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.002208, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Feb 17, 2024 at 2:19=E2=80=AFAM Barry Song <21cnbao@gmail.com> wrot= e: > > On Sat, Feb 17, 2024 at 4:57=E2=80=AFPM Yosry Ahmed wrote: > > > > On Sat, Feb 17, 2024 at 06:36:42PM +1300, Barry Song wrote: > > > From: Barry Song > > > > > > We used to rely on the returned -ENOSPC of zpool_malloc() to increase > > > reject_compress_poor. But the code wouldn't get to there after commit > > > 744e1885922a ("crypto: scomp - fix req->dst buffer overflow") as the > > > new code will goto out immediately after the special compression case > > > happens. So there might be no longer a chance to execute zpool_malloc > > > now. We are incorrectly increasing zswap_reject_compress_fail instead= . > > > Thus, we need to fix the counters handling right after compressions > > > return ENOSPC. This patch also centralizes the counters handling for > > > all of compress_poor, compress_fail and alloc_fail. > > > > > > Fixes: 744e1885922a ("crypto: scomp - fix req->dst buffer overflow") > > > Cc: Chengming Zhou > > > Cc: Nhat Pham > > > Cc: Sergey Senozhatsky > > > Signed-off-by: Barry Song > > > --- > > > -v2: > > > * correct the fixes target according to Yosry, Chengming, Nhat's > > > comments; > > > * centralize the counters handling according to Yosry's comment > > > > Yet Yosry is not CC'd :P > > terribly sorry. I thought you were in my git send-email list ... but you > were not... No problem, I caught it on linux-mm anyway :) > > > > > The patch LGTM, but it won't apply on top of mm-unstable given the > > amount of zswap refactoring there. I would rebase on top of mm-unstable > > if I were you (and if you did, add mm-unstable in the subject prefix). > > This patch has a "fixes" tag, so I assume it should be also in 6.8? Hmm that's up to Andrew. This fixes debug counters so it's not critical. On the other hand, it will conflict with the cleanup series in his tree and he'll have to rebase and fix the conflicts (which aren't a lot, but could still be annoying). Personally I think this can wait till v6.9, but if Andrew doesn't have a problem taking it for v6.8 that's fine too.