From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50A88CD484A for ; Fri, 22 Sep 2023 17:59:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7EDB6B0304; Fri, 22 Sep 2023 13:59:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A07FA6B0305; Fri, 22 Sep 2023 13:59:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 881846B0306; Fri, 22 Sep 2023 13:59:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 74F316B0304 for ; Fri, 22 Sep 2023 13:59:57 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 35EADC01DA for ; Fri, 22 Sep 2023 17:59:57 +0000 (UTC) X-FDA: 81264996834.22.7AB3E63 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by imf02.hostedemail.com (Postfix) with ESMTP id 59EDE8001D for ; Fri, 22 Sep 2023 17:59:55 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=eETnlvy0; spf=pass (imf02.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.172 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695405595; a=rsa-sha256; cv=none; b=JS1ArFgwjZHKKqWFuVIN2wmlaJRb4Zu3P2FdSlIAk/lMxG0xt/zIkS9zzlqqRwTRHYXkx2 Px4bQ/XWiO+cezsOJYXMSq4pVtODbvriZKW5TxQvLeVAXU8bRfedbllDr7FsZiBolXnY87 dpEQFWCgItCC0XsO1fj2TnUEQvN5ULQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=eETnlvy0; spf=pass (imf02.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.172 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695405595; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=neFKDss4Eoz4zqBDkZFgiJEWmdfT57VEWXtM0Jgtcu8=; b=q0P8NUqfyoVNjGyhSTZYlvnvCtEirY0RzoE23q/D9hHEL/pt9jThWYjAmThf6v1Rse4e+J 9uQU2sYGysrwJ4WuoCK+0rExx0Vy6L9jRywIhDLHG8jYunAct8nYsFiIAMTLDASDMQBcDn sRXiXcY4rTVqzoKo+6a/jB/Eczf1iKU= Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2c124adf469so43409051fa.0 for ; Fri, 22 Sep 2023 10:59:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1695405593; x=1696010393; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=neFKDss4Eoz4zqBDkZFgiJEWmdfT57VEWXtM0Jgtcu8=; b=eETnlvy0VuMtVQTh7N2UkJSlNjCZd8QrPB+Uf10A17Aq2TzFISdUV5s6aL1R0JyHV/ U/Y5i01inIv4psnhOkAIXMV03nbKaYnOJ4h9pSJtiEu4F5qwGvUEkIw0wcX+D1yTy+e2 k8xk//P5IwnuWibyvIXaFe1gL6ExHFqf4AOUaI/j8Ech8+knBThKsrPJX4SCNQCaYywt YXU5+XANBmuxpg7t6SUH1eglUurUNNtVpx+GZ+SCX32hUOeDdA23RKWBCQDPaoFwLnwz 0qhichuMZsnXm2UB7H9s9WEujvEhmBdWxWRMNlEEpP2TxbGrSmvn+PASIH/H7rF1ZNS4 M4mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695405593; x=1696010393; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=neFKDss4Eoz4zqBDkZFgiJEWmdfT57VEWXtM0Jgtcu8=; b=SmEfRIFBB7N+unvUHB9ydG+fkkuSxyj05hJ2Nd3+R+oqnUSP9a3D04MsST58FyDfzA uNTZKKREglXPe/Erqh0PUWQKdofPKDtLaCuLtHaR5lGJ6l8TD/85o6XdeCdZTdMxjMyM dOueUaAgavSyR+wZCtnBwJe6zBxCoVcTug8Slz0MKUutFK2aHaQ0j12q2JeWDLUA1P9Q JBoTKfs9xB7+lqadqTK2WFb4SNseugIlqtBDuoBOVjZILgrPXlHhOMtq7hhBqrdzvlUR mHMWTZhfn+vY+7cFXhDbQAHnQE3mLG4DnMKPhdtaPOcs7IAsnWbpnecTu5qr/fdb6YGP SbHg== X-Gm-Message-State: AOJu0YyiwXxMqsOXpQ/v3xJikeCjL/OiI0tzEBM4f1R8wElumPRx+MwQ 8GD0wnAku1PqCXO/yKtyXtBLiZ1xdAZKQwvuMTDG9TMWa+sZoyE7RkIUgg== X-Google-Smtp-Source: AGHT+IELut1xHfbiwqDVm6Sq/3W8KL4RFEb3KaEJoxNiOhq0MLqeWIIK2Jkfl56eDAdwP2sEzoc2VncrFBFuV7o/z/g= X-Received: by 2002:a05:6512:2512:b0:503:8fb:f738 with SMTP id be18-20020a056512251200b0050308fbf738mr259391lfb.17.1695405593333; Fri, 22 Sep 2023 10:59:53 -0700 (PDT) MIME-Version: 1.0 References: <20230922082542.466579-1-yosryahmed@google.com> <20230922100310.102aa12ac2bdf0568e6e7432@linux-foundation.org> In-Reply-To: <20230922100310.102aa12ac2bdf0568e6e7432@linux-foundation.org> From: Yosry Ahmed Date: Fri, 22 Sep 2023 10:59:13 -0700 Message-ID: Subject: Re: [PATCH 0/2] mm: memcg: fix tracking of pending stats updates values To: Andrew Morton Cc: Shakeel Butt , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , =?UTF-8?Q?Michal_Koutn=C3=BD?= , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 59EDE8001D X-Stat-Signature: kkq43z7hag3u4d49qmkomah6osk1c5d8 X-Rspam-User: X-HE-Tag: 1695405595-690754 X-HE-Meta: U2FsdGVkX1/+Kt+DF6k/+xzj1nv1uy9h55eU8Afu+71GuY0PNkKBgZtuURUDzFBJyLM82hkvobtJZQmc3FND1TxHizjwKa+5cXP+ykd7RHWWMtP9sN+bKDH4JaLwJMwoghu/baqpYuhOi2rRY14aCc+gCrq1HYIKErimRXPNtldw10zV6nAsdI/hnTmEDewBGM1g7XnbRHdhm/CwfUw6G2zClX5utNNRozzf6gb7ebEeGmthLpqgpGMB5yhXLcOeyr2ixxi4iy7tE9LAomGaVrstmOQ+kS8ZVUXbFeRgjWK3H0jPwy8eu7rXpYlkOr6BR6+SIlxWLUAdmtT2Qf0xixQkHZTxqNPp2O7eFIBzL8aCIrOCRsRndrKY2c3N3rWdLuqqZQYQnhUPvHbsF4l8Tk030bGzPurVLyc680awt8pfRJO3RGqQCpiPZtFrpTyRRQfJhho+w4/RWY55S3RVkhpaXARwkhIJLVLDQrJrWT7YFQhsFgwj7XZWgHsJfBQRp1SJeO0lS2T8QqZrfhrzuyl2PoDys9pdTj/Zv7N38w1Y4fdeFle8gPInW1DoQgdGXxqLIKEitbFnUh8jxaXxCiuYWe28BzQMZZo1ZodIgGXuZhFSPecOip3vggoLJwTWvERZyMu6RIA47zg9qYLyogxSEEE1d5qtXm5aJw4Bx4JPMITEu3FJPq1ybHNpYwcm1tebskDqFkelylOaCXYdHQUq+UvzDh6tf4MXViSJKO815iSuenYuX+GO7NvAR++UYFX7QfjkAMaKXORGk/TJM7rBvkQE4PEOu95CUgneLRXpZh6MG7R2G1iqJb+XpDhJxf8ctLfyic3cVN6luEPp8vGywwfCdr/bG4HVfpmGn/JxcnixgA0iQGZK/GoY5BPfiOIiKrscxwMlfK+erDt7e9VfW5LuhdjzTVqgrVUI+sVW7pPEOnln9y3o4V35JlngswOv/shi5tnKBqwBmCW tt+oGSrd ZD7rRi6+LitD5MDt/DAkeJO7ZeWmdc+elT8A5hVNdWoWRQG7g0XCxb+umGI3eJk6Qz78qlKEpu7fEeo1tEDvPioPmtfHgPnO+V6xlJ+KFkyO1EQ0fihWlXtRXBE1vFLM2PG59dRYL62po1OnczZfhsf1IYwqN0ruWBZtcPkpvPwNWWPc+Krn8KkUzASAPkO/Hm5lcRj1BNavNvFXUGSkCSSxqpdvkZXwdKIt2xiauPPjMw/KXHDHjQ00jacB5yyTNSWZk5ojrhT9xVmRBCP+Oa9hbi7KPQ+0/Jci8owU6BJlB5jgXDQU2QR7RVBp5dZ+sravEwVljkxP2+YIC675jRPqM2xTmo7pWq2YODgPFd8DjPe7PpDr/mVSVGhn0gGfcg7CuNX4HTKfJRZA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 22, 2023 at 10:03=E2=80=AFAM Andrew Morton wrote: > > On Fri, 22 Sep 2023 08:25:40 +0000 Yosry Ahmed wr= ote: > > > While working on adjacent code [1], I realized that the values passed > > into memcg_rstat_updated() to keep track of the magnitude of pending > > updates is consistent. It is mostly in pages, but sometimes it can be i= n > > bytes or KBs. Fix that. > > Clashes with "memcg: remove unused do_memsw_account in > memcg1_stat_format", and maybe other things. Can you please redo > against mm-unsstable or linux-next? Done, sent v2: https://lore.kernel.org/linux-mm/20230922175741.635002-1-yosryahmed@google.= com/ Thanks!