From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E843C54E5D for ; Mon, 18 Mar 2024 20:18:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 001346B009D; Mon, 18 Mar 2024 16:18:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF3EC6B009E; Mon, 18 Mar 2024 16:18:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBBFB6B009F; Mon, 18 Mar 2024 16:18:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C91A66B009D for ; Mon, 18 Mar 2024 16:18:01 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 954081207A5 for ; Mon, 18 Mar 2024 20:18:01 +0000 (UTC) X-FDA: 81911271162.02.76B3467 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) by imf28.hostedemail.com (Postfix) with ESMTP id D8690C000A for ; Mon, 18 Mar 2024 20:17:59 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=DUyAJ+p9; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.182 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710793080; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1yot0vG/EvXqiKrPizPMgdy7ntkGix/8bUop8nR7PDI=; b=AHHCCqFY9HckDO7v/cRiOnyj/OhTl+RLAyy3tJAkVfigCr/rQ+JOzhmOcJnYOUCCa/MjOa T1m7M1KjOWu2BcoENSgPtz2GQ86O6p6+Ofhi4dAAmTQURXjVhKR4b4PFSUR2fH4ZImMAKt LA48z6E/B2WykcJ1te4Tt+Xs3St0jv4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=DUyAJ+p9; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.182 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710793080; a=rsa-sha256; cv=none; b=Nk53fOsepWej2v4nX3ztlMjEQbCB7qFjYE1vgg2wFBB9Lg6zEqwnkJwX4/cfQtj1XeClyw UIQRJlEmV89mDrNBo//VkY/6oAoKXL86rVqBZK6ff50Sb2GEJXqWbeFiznYTtrSDxA3msG USdLiJWm5g0PdpTJCk+twL/RtBk67AA= Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2d28051376eso78209271fa.0 for ; Mon, 18 Mar 2024 13:17:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1710793078; x=1711397878; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1yot0vG/EvXqiKrPizPMgdy7ntkGix/8bUop8nR7PDI=; b=DUyAJ+p9YQCFteDeKsoh2eKL+f8B7baLtpWbZgziEMgGI/L6q8J++1mWdSL1iGenvy sDLTZOGNaCCV+rFvJqIH46ED15EnQ7eYUx3am0fmS/SFIJ6gyl6kD1PgWqeWFu3GvvSe SV0JBrABor1w202/UsiF2UA07rduNlkHuKMV0z7uvF1wdq3yUkLO1nP91PNDjYMJEU9k pm79cCHE9Vy8vZ2NpcfNY2vQIwzPXY6r3znuQZ7uZ4kjx/lo4BvCUTfiDA06gqWM0zsx safH9vfihPyaC/7bckQC0zcKCPdaN7FQlwfXDYKNPdH41YBUJFLee3+Gw6n353zel8Zc 4cQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710793078; x=1711397878; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1yot0vG/EvXqiKrPizPMgdy7ntkGix/8bUop8nR7PDI=; b=P0zMsqSSy0tV9Vls5BgnN68ea0DvGs3/4Fqgat1EHwn0OSKLk7ZfLRufXMQO/u+NVF fFyptDg50gVgCW4sySiNnc7KgVTdlt8gq71m8HanQ3OX2JnJU4IRWvNqYOl/Uny2GeuU qbuftSGpm16rwUH/qyCAksmRVtkLyU5V2i9O99TUxf9R7fhywIozk35csmxYcpT6zsRD 4hro+DqPZYKoObCATywii8rPra2jEUXvZijxvM2zJo8MjXhQZDhH1unlcPXBvULEgX3U xsICJ4sONgAVBZsPcM+miSQi7BaxyzUzzU+HIN4QmLCVtV05YjOt6LppIf3qpEOLDvfu +khQ== X-Forwarded-Encrypted: i=1; AJvYcCVD+iS7NQSHAlqXDSv/57zwKr5eRCYzqjMoVVSG6+F7aapZXdOwDIxUhkwPBlT35gqt96SCyXiPOnjVdfkF0ySTwZg= X-Gm-Message-State: AOJu0YwF39who8UYJP1GaoxetPHQe2C2hQR08f05gbHSBs6JYOoZYJ8e n7faC70U6sBgia603D+2aeXXm4xvxFMYPn8a2wyvZ5MgTtnMvR7YtXv+kZYDrhDYUb2Clu/Pin0 GG351pNgC2XiyrmEDDRlyiQc1mVdErCdL23L2 X-Google-Smtp-Source: AGHT+IGluCNAxWphJY5oLf7BFcHLws0WcrzT30WgUrnw7Jkn1prWk0RP85ZHuA6LYv3BSHTdGTTpJral8jcNKEIrlhU= X-Received: by 2002:a2e:84d7:0:b0:2d4:7373:2a5b with SMTP id q23-20020a2e84d7000000b002d473732a5bmr5882184ljh.47.1710793077757; Mon, 18 Mar 2024 13:17:57 -0700 (PDT) MIME-Version: 1.0 References: <000000000000bbb3d80613f243a6@google.com> In-Reply-To: From: Yosry Ahmed Date: Mon, 18 Mar 2024 13:17:19 -0700 Message-ID: Subject: Re: [syzbot] [mm?] kernel BUG in sg_init_one To: Nhat Pham Cc: syzbot , akpm@linux-foundation.org, chengming.zhou@linux.dev, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, Barry Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: D8690C000A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: tg8dp5jmicpkhdcuyo8cmxd7axdosmak X-HE-Tag: 1710793079-508222 X-HE-Meta: U2FsdGVkX1/JdyT3WkAbo5uRwn+jQoGk9woqBP25QRq9KC04IgoIcWD/uL1zP3KginU7c/WyZG+NOLwv2vNgfFrqnEyqMiUIwQntOk5ooWNc7OjWqynESyN7KkFdzhiXsNyIX5UIQF4mTUzp2SsbOM7CKjs0aYuxFkOQPFreWPB+YIsyiNADNXodWoK7SGrjRadWdmgvhmFOSWXusZPyUzl6bVyMkpammMc0G3wtxWC90s67NWx5+1X6uDwS5jMq9ang096tVzC9pm+ODm4+35zNcvaFmDX3EccQm6jgRoNm5H6VX2agbDKII9NZs9Nv8r/XUZFfMjYandaRVZGqFO31VZhAD/s79VBfBFrpp6yIgqaG/+i0EZW5JzLPIYCkdO3ifFHCCcXW5+/2jam3GAhuQwnA1pE7X/F5npvW7jgNTbEZEr9KQEhMDwbZjhasprSxutAHwWp4j3IcQnwIESXw05XbD3AtX0C/xFZTC+ElnelSC4i1Rv7l8UnknhJifoN567tyP/RhV6Voc4CVgpxS6BnuMlxwVC8HWhsjaNu0pcpFRXeTQw5Jx2oAS5iyASaV1SnMzUSObxUXGQox/PtH84tjrqcOeP8OzdtDM1S9U3eSkpoUk6fE8U7Z+ZGTdqESo8nUQWljPg3dlD9xbrTkeAOQIr56edsYBxdP6bmVToXlvHGjCnc3CW+/hHvxyD3J0UlanjKwGJQyBoXp8ByZ5ErpDDLsp2OJQ4wqL57MlyZ6V8uPrUW4qBi2TAQldeAkhMrpAYCWp6i6JoH/QH1QySPuEbKkoQdwa+w1WKk97rIKO98GULysFFuyK1FsTtPMp65Ceq7kQAKX4tBUzK/AwFyRjiaDE4F+3+vfyrfndaw9ZRWQPFX/KOS4c6kK7TYhiiiTUFvtClr0n6Gnl/qqMaOEaET6N7cKnSQFVbdY5mwG7R/1qyf+Np9BPanWFm14sfIxKWoKQWXIjbT KEMHch6e m+2fI+9QjWXQ8OEk7dsZOjBFOqp1J2YNOq1YH9f8TgDvGf78sA6QsOL1rY8loD7CSByFHcTun8qa4lusf9mAmW1ISWSF+VNzqCV1h6YjjRz0e9KYbvmo3cM6kk9WR47NsixUs3PS5Mcns1y3vh1D0rf+Apj6iMAavVg73XCwE0lei4rzUXI8wkwgxUXBXsJ3Mr03GiHKqZs721bGzBC+sWXandP7S6KXLHnE9sYOs/rGioSaN+NpH8NKyDTOmZ+TqcnxikrHwX29zhsOMlvfdnXBcT4ur9aCr2H3vDR8B43QM664= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 18, 2024 at 11:00=E2=80=AFAM Nhat Pham wrot= e: > > On Mon, Mar 18, 2024 at 9:58=E2=80=AFAM syzbot > wrote: > > > > Hello, > > > > syzbot found the following issue on: > > > > HEAD commit: e5eb28f6d1af Merge tag 'mm-nonmm-stable-2024-03-14-09-3= 6' .. > > git tree: upstream > > console output: https://syzkaller.appspot.com/x/log.txt?x=3D13043abe180= 000 > > kernel config: https://syzkaller.appspot.com/x/.config?x=3D19bb57c23df= fc38e > > dashboard link: https://syzkaller.appspot.com/bug?extid=3Dadbc983a1588b= 7805de3 > > compiler: arm-linux-gnueabi-gcc (Debian 12.2.0-14) 12.2.0, GNU ld= (GNU Binutils for Debian) 2.40 > > userspace arch: arm > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=3D1706d2311= 80000 > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=3D13ba7959180= 000 > > > > Downloadable assets: > > disk image (non-bootable): https://storage.googleapis.com/syzbot-assets= /8ead8862021c/non_bootable_disk-e5eb28f6.raw.xz > > vmlinux: https://storage.googleapis.com/syzbot-assets/0a7371c63ff2/vmli= nux-e5eb28f6.xz > > kernel image: https://storage.googleapis.com/syzbot-assets/7539441b4add= /zImage-e5eb28f6.xz > > > > IMPORTANT: if you fix the issue, please add the following tag to the co= mmit: > > Reported-by: syzbot+adbc983a1588b7805de3@syzkaller.appspotmail.com > > > > ------------[ cut here ]------------ > > kernel BUG at include/linux/scatterlist.h:187! > > Looks like the provided buffer is invalid: > > #ifdef CONFIG_DEBUG_SG > BUG_ON(!virt_addr_valid(buf)); > #endif > > which is "src" from: > > sg_init_one(&input, src, entry->length); > > Looking at the surrounding code and recent history, there's this > commit that stands out: > > mm/zswap: remove the memcpy if acomp is not sleepable > (sha: 270700dd06ca41a4779c19eb46608f076bb7d40e) > > which has the effect of, IIUC, using the zpool mapped memory directly > as src, instead of acomp_ctx->buffer (which was previously the case, > as zsmalloc was not sleepable). > > This might not necessarily be a bug with that commit itself, but might > have revealed another bug elsewhere. > > Anyway, cc-ing the author, Barry Song, to fact check me :) Will take a > closer look later. I am not a highmem expert, but the reproducer has CONFIG_HIGHMEM=3Dy, and it seems like zs_map_object() may return a highmem address if the compressed object is entirely in a single page to avoid copying to a buffer: if (off + class->size <=3D PAGE_SIZE) { /* this object is contained entirely within a page */ area->vm_addr =3D kmap_atomic(page); ret =3D area->vm_addr + off; goto out; } The virt_addr_valid() check seems to indicate that we expect a direct map address in sg_init_one(), right?