From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8A82C46CD2 for ; Wed, 24 Jan 2024 04:53:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 589BE6B0080; Tue, 23 Jan 2024 23:53:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5123C6B0083; Tue, 23 Jan 2024 23:53:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B3646B0085; Tue, 23 Jan 2024 23:53:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 259606B0080 for ; Tue, 23 Jan 2024 23:53:10 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B30A31A0773 for ; Wed, 24 Jan 2024 04:53:09 +0000 (UTC) X-FDA: 81712985298.15.A5FB0BA Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf02.hostedemail.com (Postfix) with ESMTP id E38B38000E for ; Wed, 24 Jan 2024 04:53:07 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tzqddggS; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706071988; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jbbOrSG210rOp8pDrzickj6q2E2LjgjMyvfy8tdCtvI=; b=twvcu1mGRmXbNcxnd9tPdyVv2h7LUBirj5I1hsGMJURHFLXfk01U3y5w2PpJPOQ4U5K7UK VWG1NAiFc6AW1wodavqjZRKSIT7ATng2IVlkIwbUvJ0xfmXM0kN5S+FsirZiJuTy22dVLS 97Lzw1bNckKLp7bTOLsAmwM/yw+81+0= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tzqddggS; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706071988; a=rsa-sha256; cv=none; b=WOb0ZbQUvz1NCJQQLHu84yZ8uq4IYxxYUimPyfQ6Mxndr26JW0kMBjiRu3si7/hagb4LW+ Cde10lvCZcJCb+P8lw6m44kr86IruAvINS1zGZoex5PXT3iLAUnyQSKyCfu6s1PWPXeB4D 6r4sbkay0f9rsAWg0UuEXCy+quDsSic= Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-55c6bc3dd54so3546279a12.1 for ; Tue, 23 Jan 2024 20:53:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706071986; x=1706676786; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jbbOrSG210rOp8pDrzickj6q2E2LjgjMyvfy8tdCtvI=; b=tzqddggS1hyDg63KFarHOO203L23K2YpUOhe7xBruRvSZ6QL6iYXo3kggi+XKyMlMm 2i41yLXYc21wUh9lxodpWk1XJGzN5C3+q3r0812NFOgQxuuVjlcWne0P8+uAFSb2GCxy 1iRElqabZq6VzlOTw+2NEfjm7tar+idOzA1vx8wyJCIQJBN6g4Nsdu5f2gOmGwz2qjlU Yyucjc36/ROo6QD7K4i5AFOvMgmbrBbn72N57oaX3vFNK5dIbOUwcO5MchSOwEXPt8Z3 TL3HJqujS6TZysBh5wo6Av8MdrPXzfy/Km7TV+f7DAebmefFYCTmm4hO78eb64CD5FL5 Vrgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706071986; x=1706676786; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jbbOrSG210rOp8pDrzickj6q2E2LjgjMyvfy8tdCtvI=; b=mRik46UllNuyxMTUilTRvtU8kf+n0MnLeNDCVZwHxpOnFtVzfO+QLN39O6/b514/Om odzuDI1uvDd12jGSrvRJXm80B5huFhBprjO/GVbGFiXKhQGP+Ye0Of6/WHrz9xQJByN8 PK2xIYu6VAWQ+Et+8ohEEkK8Bht7fQAcK48rB4Ky6YP7JzOMTAnND6Wv3H4+WAM96tAT hBjSHGJIPI7hye75eCG12CE5O9y2fyQJdbW4Bkpwp2BC08Uz6W8JsXzKnC1q2kE7G7LR 1Tg96SRzJ/CE2wPGBI1crohLxVJOjTQJjyarhSiGRoIXbwbCpQip3qtLtZ/Oqv8PxE+b OA4Q== X-Gm-Message-State: AOJu0YxEcXqzkrnKqbywWwOJEfanG1r1zCVCtfW+1w5953HuUADjSnaF HdCkUYn3wsxrc+YJ7RvoYh2ChRc+PnXXjOkOtHu8+KvMbjXWffTnyk96epS7l6rMEu6xfeH4IhX biWFIycnufu2oK6cGAXj5Cm/zWL53t5Nz/4LQ X-Google-Smtp-Source: AGHT+IEsQe1YFNd8pR55+rNboWKDDEVrJaaGfXSbJE8aX1qVrBqLFI0F4Pj4taUHbIwaD2FS2o1UjbCmRXziX+zwKIs= X-Received: by 2002:a17:907:77d0:b0:a28:a7cf:b014 with SMTP id kz16-20020a17090777d000b00a28a7cfb014mr673835ejc.2.1706071986187; Tue, 23 Jan 2024 20:53:06 -0800 (PST) MIME-Version: 1.0 References: <20240124045113.415378-1-yosryahmed@google.com> <20240124045113.415378-3-yosryahmed@google.com> In-Reply-To: <20240124045113.415378-3-yosryahmed@google.com> From: Yosry Ahmed Date: Tue, 23 Jan 2024 20:52:30 -0800 Message-ID: Subject: Re: [PATCH v2 2/2] mm: zswap: remove unnecessary trees cleanups in zswap_swapoff() To: Andrew Morton Cc: Johannes Weiner , Nhat Pham , Chris Li , Chengming Zhou , Huang Ying , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E38B38000E X-Stat-Signature: 74w6x5tofbbwcwgayrr3tyiwh85rtao3 X-Rspam-User: X-HE-Tag: 1706071987-294586 X-HE-Meta: U2FsdGVkX19u1iwCpfifqVcdqCe5CNupUobWZ9eyNTPEh6RNrf98IQrL76bbEemwHaMfMwZRJVQR4jWxAEsl0A4pByapB86JMqAO2xAAwkwuoMvfYrOYWwfVudeVSNOWqE5bGqaALNTf74zbB2zL3xYBI1YLXnuOhSr3Sd3X4Uw8qpHw33NjsOKqQi0shpEwihTAYkl8Xi2ScMkea6QAvOZCxN8LojmBrqtP5oAWeCEvoS+o0SGP2cLhRv5yi95UA4JkeXcfVqL0hPmPwFS/ypu0pHtpfG67I7YzQIoxIq10z1HzHFDlbA2p7Ye7uV2Jo4vCa/9rqGfK8E8OuxIhEZ1kEMr5EBlsPi1Wr4NdXqk8LpohSiju03KdChopA2snhVoM8BFMtWNG/n1Gt1JmZqFAmoiyVOje9hY4f20r+0UUr6VVid0tHIIOB/8SIySiteUPquOS/ICq7LIJ3UkRt61KjGub1/th0InLzhcqFZvXbQXmpAzgg7bBkuX/ilz6tenQQvLDjl3dIHIr+jmwYgXcYyvtSd+VL+XQobyswsz+kU3gAr3fVCDObGSr5j+4iAaJHvcWRS04g5c4oYmwMuNvCIpneYvYfKxcxlcUht9INGg7E1Qjl/+0pDekYWeLB7RDkzinOpiRe2tpBIhTv6DsSr7b5EEUyNBpGSDMKWR/Ow2dK6yzMtUxQKImk0J73/e8d9FZwD/DAGWVzigH3O+JYZ7F7NYVuTtw7eTcbJs7qAEtbDQfyNin3U2siqM/BkdFoEQKwIols1tbVK7JL+ITmSP7col1Qt/H2Tqn1A1GSEmPWJ/WwIpn4PNLHqcBii9EQ03H3SIZqk0QrHMxzAkolswT9cDb2SGj0JvtgNiwRjuWT8uK4+zSUN3N9mQ9VJOYGGqSSiPw/gRMp4sHCKmPVdiN+4rHNBzLEb2Av4Avz7VtSYGNMCkTBpVkCNtPi1F4uIOeyRVEao8dozi Choyqdkr Z17Hqkzt5+JXI1pURKaxPQUuuk1nmfU4v4LcS4cfSfcFpNqb0nCohCJUACBaGdRNqU1AVDdZ1KlZ/efvtgDGaOqIHDRHtyj/ATq9Rti9rERz42RnJLw/QvICRGWzGG4oMj7SRZ9y4EgeiCutRZRlFi7DEdGPFfJYrop3ukJDCNcW6FlCuu54aGLrvyYWwn1ip92xoNJKOjC58HgI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 23, 2024 at 8:51=E2=80=AFPM Yosry Ahmed = wrote: > > During swapoff, try_to_unuse() makes sure that zswap_invalidate() is > called for all swap entries before zswap_swapoff() is called. This means > that all zswap entries should already be removed from the tree. Simplify > zswap_swapoff() by removing the trees cleanup code, and leave an > assertion in its place. > > Signed-off-by: Yosry Ahmed Johannes, Nhat, I didn't carry the Acks forward after the rebase as the code changed significantly.