From: Yosry Ahmed <yosryahmed@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Nhat Pham <nphamcs@gmail.com>, Chris Li <chrisl@kernel.org>,
Chengming Zhou <zhouchengming@bytedance.com>,
Huang Ying <ying.huang@intel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] mm: zswap: remove unnecessary trees cleanups in zswap_swapoff()
Date: Tue, 23 Jan 2024 20:52:30 -0800 [thread overview]
Message-ID: <CAJD7tkbCyW7rOHH+32vY962QKDQj89xF4knUuqCx6PkeYHeDoQ@mail.gmail.com> (raw)
In-Reply-To: <20240124045113.415378-3-yosryahmed@google.com>
On Tue, Jan 23, 2024 at 8:51 PM Yosry Ahmed <yosryahmed@google.com> wrote:
>
> During swapoff, try_to_unuse() makes sure that zswap_invalidate() is
> called for all swap entries before zswap_swapoff() is called. This means
> that all zswap entries should already be removed from the tree. Simplify
> zswap_swapoff() by removing the trees cleanup code, and leave an
> assertion in its place.
>
> Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
Johannes, Nhat, I didn't carry the Acks forward after the rebase as
the code changed significantly.
next prev parent reply other threads:[~2024-01-24 4:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 4:51 [PATCH v2 0/2] mm: zswap: simplify zswap_swapoff() Yosry Ahmed
2024-01-24 4:51 ` [PATCH v2 1/2] mm: swap: enforce updating inuse_pages at the end of swap_range_free() Yosry Ahmed
2024-01-24 5:20 ` Huang, Ying
2024-01-24 4:51 ` [PATCH v2 2/2] mm: zswap: remove unnecessary trees cleanups in zswap_swapoff() Yosry Ahmed
2024-01-24 4:52 ` Yosry Ahmed [this message]
2024-01-24 7:34 ` Chengming Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJD7tkbCyW7rOHH+32vY962QKDQj89xF4knUuqCx6PkeYHeDoQ@mail.gmail.com \
--to=yosryahmed@google.com \
--cc=akpm@linux-foundation.org \
--cc=chrisl@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=ying.huang@intel.com \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox