From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51F20C61D92 for ; Wed, 22 Nov 2023 06:45:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D62AD6B056A; Wed, 22 Nov 2023 01:45:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D12AD6B056B; Wed, 22 Nov 2023 01:45:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDB4A6B056C; Wed, 22 Nov 2023 01:45:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AF36F6B056A for ; Wed, 22 Nov 2023 01:45:14 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 82082803B2 for ; Wed, 22 Nov 2023 06:45:14 +0000 (UTC) X-FDA: 81484653348.30.607F676 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by imf07.hostedemail.com (Postfix) with ESMTP id C04BD4001A for ; Wed, 22 Nov 2023 06:45:12 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=HZtv7nP8; spf=pass (imf07.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700635512; a=rsa-sha256; cv=none; b=bNQdy1Yxm91Snaul0u7EyJj20p7MHy4/SBNyAYzffRb9NZld0rcJMFyoxdmVAgNJBxZCbM BeJnpOU3jKT9XGdK5vUkZbSYhXHwgXpwWVrB6bBlU6vYb/hTjbB9O6wXw5g+D9cSePp1IK dhW6kC7RV3U0XXyT9YKyk8+SnyA84d8= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=HZtv7nP8; spf=pass (imf07.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700635512; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5xwyYye+wQlYnjpBJCOKYjPSHv4hsDlpq0YhFNQKNEc=; b=g4JLUjr3pLwjy33vOb9QM7eLhI7kux1SZENdAlFL9SgVwid8MNs6WZXTS/k5rAbUEc2KoI o1pIALigtyUN4FoTAYZlkfonoX8kCLsWLzabtVgBdBlAmz4t21NqcMyFZr79vHOXdkFXZo bguNPBqnEOASw2q0389Z+KSjYz1/r5Q= Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-548d1f8b388so3916298a12.0 for ; Tue, 21 Nov 2023 22:45:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1700635511; x=1701240311; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5xwyYye+wQlYnjpBJCOKYjPSHv4hsDlpq0YhFNQKNEc=; b=HZtv7nP8BFko88vf3R4hcPS8MoEjA0ovpR7iRtKlXowvFdKOFIILzSKFGPtXKxHlKD VphGSCNuN8Ncxou0aK3LcalT5AIAyaPBJMef2P4zOlfJYrqYyrDrGEgyRpCPtUSCqwgr AnvvuNN2VYlob9XXnSdPem6dk1eumrtJA6zmWu002zCTLp2KfHj0ngeqE2bbpmxerP1q XNKTaz4Fh8/KP4ieTNzKKHRxyUHnP24sPo3ZiYpfWx2yHCeK7buME6S5P2xxFgulYk/u k5gmDiPW79SgmrKMBhUJ4zzP1j56AE9YFgBsMnZ+/IbsQknJ4aBRc8HIuGmyTg3d7uZv JCPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700635511; x=1701240311; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5xwyYye+wQlYnjpBJCOKYjPSHv4hsDlpq0YhFNQKNEc=; b=waoc7vF1FdUYjVmdJ3cGDaROHl6WSQcNIwAzatUAcDPv+F49z6DtFbwSTHoSjuhR4L 9kLFV/XYzAa9CKB/J7HfqG7xqmDjCbEJVU/fRgyW6bFuu98pq0ORwdmDfYEseJQWPdDP iGSIRy4/EdVR98uwIh5k/XaCx4wbMHgYc4Mj6OitT6SNjvS302uSMRzlTt0lQQSiW3Zl iEEVNHnu/qrYnNlN/vZ9ocmpimJS/qipD1NsARsrcnnOHzk5MZY3+2g7oP02oUQ0fLX9 IWrMG8jzcreRxn28O9PsC7AECkqciPERQP6lyL+OLtuwjgDuMSPW/A9uJeCAiVkI+WV+ BxYQ== X-Gm-Message-State: AOJu0YwX+zT+dbnWMwV8nMeaZNQm0FShyEGe1nKWYSI49Z9B8rLrMokV mSUuczpx/JJ5/7oqONmWdRlz2RpMlyLQ9wPZRTeXfA== X-Google-Smtp-Source: AGHT+IFeHPawSGxU4UWzIS3J233xNDbTVcl8jRgj9Wuu8H+hsttAxcgpq7Z9KOdt6bDg4cLcSsG1Tc+VOIbGpxwl+Gg= X-Received: by 2002:a17:907:9158:b0:9df:bc50:2513 with SMTP id l24-20020a170907915800b009dfbc502513mr824738ejs.65.1700635510928; Tue, 21 Nov 2023 22:45:10 -0800 (PST) MIME-Version: 1.0 References: <20231121090624.1814733-1-liushixin2@huawei.com> <32fe518a-e962-14ae-badc-719390386db9@huawei.com> In-Reply-To: <32fe518a-e962-14ae-badc-719390386db9@huawei.com> From: Yosry Ahmed Date: Tue, 21 Nov 2023 22:44:32 -0800 Message-ID: Subject: Re: [PATCH v10] mm: vmscan: try to reclaim swapcache pages if no swap space To: Liu Shixin Cc: Michal Hocko , Yu Zhao , Andrew Morton , Huang Ying , Sachin Sant , Johannes Weiner , Kefeng Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: C04BD4001A X-Stat-Signature: jromiynfzxs18ymia383xhbzec9e13cx X-Rspam-User: X-HE-Tag: 1700635512-41809 X-HE-Meta: U2FsdGVkX1+MC9nt3V9kBijtwtNZqw1zeyMkJngx7k7bXLWRkTAK7I9cYtw//CE3oPKwhklzU4dB/cpVzdASe0fp0194yRMF4EqbRJ3Wt9OfTonLfRQD8yFUTgci3BCFfm6LpfeRqi/Il0zRWuo4M4obvAEYx/+a5w6+ZPwcQ9vhrl+BOC5+QpsvuEJskwE4Rc0VKRsosM/BD9+DSkAJBREFryTdq9WHdHX2AKDGxGF3voAXNOqjYYWLt2NFie9iggZelXfNheA+eb0s2waredbRBcJbIRiKNFLyCMSBPhg70E95Hp2DnIndDr98XcDL7VQ4EEon4kpwmLmJ03x+ipSwUpoThvxi9wUQ8YwKCIuCiW1gDL0ZKBIveInt2OZkmooEbmWh/6JpSY1yjU+RoF2jCFHJL33RarUp1YtvCokhlz5Gs/17PGYkronxAkYrYwHXrKiHY7F5mEp4OY+OqiDjhQ9PjP3J/8b8IAbobZJIuw8qfJRRO2QCELMUWvulFU60tpurV3DWa8zmrnZNbwrX7SZ4bpMFFlSjMcMUQdrigOq0I1k97TjghMZKqtsj61yOMP85RJIkpbKxy/Mh/Zvp+ETwv0DSNQiwsMqv1P32s02hIKre+fli5sIDjgK7yt3hv3n17/MNcbmlYyL0uD5hDgADloBcBzd6QqcNWNs1O4K1MshaTNPoJ3oSY+7NITM1CzvofYBImK1dA3mOQAJJpI365Vw4Cdgux4Bm1XGc3eYaf18Pz6YJG3fuPwDwTm62Nk4g6PjnLWR9QAc0/wW37jQ84CI3HMshGa6+yM+VWrdUu7mkL/phpXfcpXoCIW+foYwpHk4ST4YcV+GgDhyRwBZ2jUw2ny5mHZYHgHA3k9Mfjz36uUs53ljVgbDu2123GAG6brobsolo5TrYr/8d3/QaFEQL85JEFhpWtak6PPwGUB3OQ8Wp5Np1o85F487kv4gcF3be+8NW3Ck r9vfU+WK 93t/9ep45jYvpU4XoW1YVkOeamtcDyU4zv4YAAS6D08gh8dH2iZ8TJZdSr25ogvanzeEmSusui3ZYeSIRXt5IHDrpwyC7uWCLYCB5J5rDVZuYxWe3FWw73591lZtt4++azFKrmY0cl0qrvUXaJoaHgvjYkKzEtFPQCMMoFesTdNV+gHamm0psufKNdRD/Ct0D9p++r6+9e0utTTdJZJXZsnRCbSi5v0iDsDs3fxxy5ShwWJk/3J2sx4p0xQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 21, 2023 at 10:41=E2=80=AFPM Liu Shixin = wrote: > > > On 2023/11/21 21:00, Michal Hocko wrote: > > On Tue 21-11-23 17:06:24, Liu Shixin wrote: > > > > However, in swapcache_only mode, the scan count still increased when sc= an > > non-swapcache pages because there are large number of non-swapcache pag= es > > and rare swapcache pages in swapcache_only mode, and if the non-swapcac= he > > is skipped and do not count, the scan of pages in isolate_lru_folios() = can > > eventually lead to hung task, just as Sachin reported [2]. > > I find this paragraph really confusing! I guess what you meant to say i= s > > that a real swapcache_only is problematic because it can end up not > > making any progress, correct? > This paragraph is going to explain why checking swapcache_only after scan= +=3D nr_pages; > > > > AFAIU you have addressed that problem by making swapcache_only anon LRU > > specific, right? That would be certainly more robust as you can still > > reclaim from file LRUs. I cannot say I like that because swapcache_only > > is a bit confusing and I do not think we want to grow more special > > purpose reclaim types. Would it be possible/reasonable to instead put > > swapcache pages on the file LRU instead? > It looks like a good idea, but I'm not sure if it's possible. I can try i= t, is there anything to > pay attention to? I think this might be more intrusive than we think. Every time a page is added to or removed from the swap cache, we will need to move it between LRUs. All pages on the anon LRU will need to go through the file LRU before being reclaimed. I think this might be too big of a change to achieve this patch's goal. > > Thanks, >