From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43A2FCDB474 for ; Fri, 20 Oct 2023 03:46:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC8178D01B6; Thu, 19 Oct 2023 23:46:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C799A8D0003; Thu, 19 Oct 2023 23:46:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B219E8D01B6; Thu, 19 Oct 2023 23:46:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9F8108D0003 for ; Thu, 19 Oct 2023 23:46:33 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6ACCC140461 for ; Fri, 20 Oct 2023 03:46:33 +0000 (UTC) X-FDA: 81364452666.07.5C5930C Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf10.hostedemail.com (Postfix) with ESMTP id 9DEC8C0003 for ; Fri, 20 Oct 2023 03:46:31 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Tm8RBKwT; spf=pass (imf10.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697773591; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VGeRszknI8Vp8HsUL3IX8fsK+U4qmVS9OPc1Q4Z2bP4=; b=VO3ncZdilOMZzUkcOz5AVEqz0HD566Jdxjc+Ej0OqeT8wTdX0TBVFWti0/Vp1hl7Mx3t76 c6soadCJAz3MawQ9uPmoDiXf3f5G/Gmba0YU7iqrKaJHgW8mrACk3G1DVn4SHHePjeYXl+ elppJoBA/pPmc6XKmSdwtC+1H8+pFsM= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Tm8RBKwT; spf=pass (imf10.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697773591; a=rsa-sha256; cv=none; b=5W4wziNJvNggDcbwILvNfNX5O+P73ItZBWS0cWWbw/V+g9ezP6LJ9zbmuGwGHvctvqbrhP RVyf4kdZjmvIn66f68FL3VFjgBryO4a6sHLu+PPUeNEGkkQZPjHgofb3xCNiG/8qTmA5rH PzHzNnT78KYegubs5OFS9jyTABDgARg= Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-53df747cfe5so427348a12.2 for ; Thu, 19 Oct 2023 20:46:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697773590; x=1698378390; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VGeRszknI8Vp8HsUL3IX8fsK+U4qmVS9OPc1Q4Z2bP4=; b=Tm8RBKwTXN1PYPIElMy/yo6BCuo2uPoSfz+7ARM/i6iFhxqt8Pd9TUOtg8gOtomaX9 s+tye8AWztnzMfuLPKGnlAE2zycPrgxfsDxcx6Ef1EhTviO2l0s78BQ+za5L15gR4kqH Kwm/kcbq5gtbbESewB+EMjtN11bpmby88sIKC2cl/POfRyzlAaBrQwRAsrKYmNe7GHUf kdemfg2wb3cKBUfp+XWfXrVneCc4DPPehCXmZD8E2JF1zPGatkkjqVKBfbyWImpXCSTl cSTZ3u0StjhHrWZmD2Aw3d8iF0kF1NTd4iBJfgasYlKxrgbymO+HLgxmCDWcgANnVfWN /aCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697773590; x=1698378390; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VGeRszknI8Vp8HsUL3IX8fsK+U4qmVS9OPc1Q4Z2bP4=; b=fMMeFaUcw0DtWOrMn1FCMxnMU9SAXdyoRnCECicOfjHdMv7AmjvZmvaWhbbkRp/lG3 JGxOfjO0vwl7ijM21Ff1FldPIXpF4APDDEuRUc40s0W1fgc278I2PgJR9kqWe2qI2Fdg yPaGuwlTYFRqHmAnI/S9U1x1nqXYzzxTkvqJ1YLit7EFFausUQrvnXldwAlBXKdwll23 Rl/wVBQQslNaDhgShDE5/UvWdUJc+je7z/3YdoiSvLLM+BVkSkJCKgyj18Er0hRnRJuc 26eFgv0Rqrm4L4dfn7HstB+tuOZ4wmBdc/RcwxbdH0LPxJm2IzfWp193Ltn23P+63dOy /xYQ== X-Gm-Message-State: AOJu0YwEjvMZvTu8K01vOLVCeVa/HhZSmwlSL1bwuc46/EsSjkmr2okD 26rJb4Qy1z6VKrULn4g9wmTQNnFdmo9n8hOdhhrrZA== X-Google-Smtp-Source: AGHT+IG2T7laE3iDmE7uz9HaeoIjLZakva0IZlxp9hy9kmChsrsM4a0HvG38mHosxab3hwmdo2F6W4k3d6d0ZwzjwuE= X-Received: by 2002:a17:906:6a13:b0:9ae:74d1:4b45 with SMTP id qw19-20020a1709066a1300b009ae74d14b45mr411837ejc.65.1697773589697; Thu, 19 Oct 2023 20:46:29 -0700 (PDT) MIME-Version: 1.0 References: <64899ad0bb78cde88b52abed1a5a5abbc9919998.1697632761.git.baolin.wang@linux.alibaba.com> <1F80D8DA-8BB5-4C7E-BC2F-030BF52931F7@nvidia.com> <87il73uos1.fsf@yhuang6-desk2.ccr.corp.intel.com> <2ad721be-b81e-d279-0055-f995a8cfe180@linux.alibaba.com> <27f40fc2-806a-52a9-3697-4ed9cd7081d4@intel.com> <05d596f3-c59c-76c3-495e-09f8573cf438@linux.alibaba.com> <93abbbfb-27fb-4f65-883c-a6aa38c61fa0@intel.com> <0aaf6bf4-a327-9582-569e-2a634ce74af4@linux.alibaba.com> In-Reply-To: <0aaf6bf4-a327-9582-569e-2a634ce74af4@linux.alibaba.com> From: Yosry Ahmed Date: Thu, 19 Oct 2023 20:45:50 -0700 Message-ID: Subject: Re: [PATCH] mm: migrate: record the mlocked page status to remove unnecessary lru drain To: Baolin Wang Cc: "Yin, Fengwei" , "Huang, Ying" , Zi Yan , akpm@linux-foundation.org, mgorman@techsingularity.net, hughd@google.com, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 9DEC8C0003 X-Rspam-User: X-Stat-Signature: bxauj8x578378iytsuz7ffgpok6cdcee X-Rspamd-Server: rspam01 X-HE-Tag: 1697773591-832109 X-HE-Meta: U2FsdGVkX18xiGuOw5g/tQSjFFWDbvHBh/6xZzRbxBcw5RpQ+b+aMdlDAPz/Syu/HnBY/i/o8ywywqUGcy3qeM4zqjmJWc84dI50djWfLEN9vLgtoJT4KaPDDU2wcXyeM7NABohYh8kPZnAiyajluS3rTDKB0sBr9y14OJx5aSdDttOUZaBG8TuoESL+jDCHAGftcqQklGquBbUWmSI1+RgvDV0AJYn1Lq/BVmBx3zX+wSTigW1cDkcVC0AMC/pH0n6kFjzdtr81cyb9sRsreai0/9FLTnNFWosol52QLYcsWSD/IUxnLEaaSUGZhxvxnowHNK1wJ+bms8hLm+u87FgoF6HZauQHV/ElmsIxj7kJZierlytTOkntU693Ewr/K+GVr1Mh/XV8liYnrK8Ko+45S27BYgfP+9AIupqSZUqnCOZWhvRemxNZjPWtybK/MyUXYKh2ze5tTZLv5Pfu8NOJFbzaI5gtL6rWCQZUkGL7r9Yu3g1AVU6pGd+185fA45Oqwn0BqT+khrR9XSjakC4KFIrnejord1TK8zPtEgylPgSUFlpmLwt8f0hhdEuHvIppd+CfYsb55XrC02BWi3dt9vWrFPHLvr8nwMIJH1jxZdlB0lIaUmKbSZJhBb/2JZ5ftnXCtT1OPvhDz+h6lCXlIw1GZCqP1wMx/k9CRD6347BVul7nBu4R4sbBefLS0grgyA2NgACrvX+8/y39fju3VRHM0pSpNKejBwie2YtgEg8TIPlLDeL7yHRVa2gyl5rAdHrKQocsvSX4mMZXhyKtuxxmw8ZcWBR2x8oeIoVaz/tHS6TZON0QKSxh+bnThcGmM3u3dMDcuEfmmhlizHvFVaVfgf/igC/dEZLWQeToN2fOIhDPr7BGzlj24+QMG7nzEmqECK0CW5IalPF5KL8upFIOpL5JqVwh5hUuwg6i+UE5e1q1pu+Yom9nGpqdyj9OSPOu+S2LCO1zuZ6 LoEEWhzd lKPMEJSPW1boQOuXfCM9cSKDaNrDb/EK8vLfn9mtTEr3odrVxS7NBgGpihsjPEOjUOvx+gmUiB48AdUZPn7fr4j9V06JDbcMm5YNFmqoCnUB0h0wA9BIbYWvLX15sQvGs27HJrJTcsuirokfGMQXF1tCog7Z+Jxok1xwxRi59o8oRZIMJV43wrRSYZRyowFpMiPoYTmN053oCcbyhmeNFQ1I05nZFN2Xd874LJlZ9ci47895GEuLwWrAM4nU5yciXfuTBdobUGEkt3aPN4U0ZZaX31D8sloCJgpESItDwiqL8SmP9+3TeY+4WRA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001270, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > >> > >> IMHO, that seems too hacky to me. I still prefer to rely on the migration process of the mlcock pages. > > > > BTW, Yosry tried to address the overlap of field lru and mlock_count: > > https://lore.kernel.org/lkml/20230618065719.1363271-1-yosryahmed@google.com/ > > But the lore doesn't group all the patches. > > Thanks for the information. I'd like to review and test if this work can > continue. The motivation for this work was reviving the unevictable LRU for the memcg recharging RFC series [1]. However, that series was heavily criticized. I was not intending on following up on it. If reworking the mlock_count is beneficial for other reasons, I am happy to respin it if the work needed to make it mergeable is minimal. Otherwise, I don't think I have the time to revisit (but feel free to pick up the patches if you'd like). [1]https://lore.kernel.org/lkml/20230720070825.992023-1-yosryahmed@google.com/