From: Yosry Ahmed <yosryahmed@google.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: "Yin, Fengwei" <fengwei.yin@intel.com>,
"Huang, Ying" <ying.huang@intel.com>, Zi Yan <ziy@nvidia.com>,
akpm@linux-foundation.org, mgorman@techsingularity.net,
hughd@google.com, vbabka@suse.cz, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: migrate: record the mlocked page status to remove unnecessary lru drain
Date: Thu, 19 Oct 2023 20:45:50 -0700 [thread overview]
Message-ID: <CAJD7tkbA0Ofvw8wQM0017DKWC3SXOT71rCnUhGkoPgQ4wOfLOA@mail.gmail.com> (raw)
In-Reply-To: <0aaf6bf4-a327-9582-569e-2a634ce74af4@linux.alibaba.com>
> >>
> >> IMHO, that seems too hacky to me. I still prefer to rely on the migration process of the mlcock pages.
> >
> > BTW, Yosry tried to address the overlap of field lru and mlock_count:
> > https://lore.kernel.org/lkml/20230618065719.1363271-1-yosryahmed@google.com/
> > But the lore doesn't group all the patches.
>
> Thanks for the information. I'd like to review and test if this work can
> continue.
The motivation for this work was reviving the unevictable LRU for the
memcg recharging RFC series [1]. However, that series was heavily
criticized. I was not intending on following up on it.
If reworking the mlock_count is beneficial for other reasons, I am
happy to respin it if the work needed to make it mergeable is minimal.
Otherwise, I don't think I have the time to revisit (but feel free to
pick up the patches if you'd like).
[1]https://lore.kernel.org/lkml/20230720070825.992023-1-yosryahmed@google.com/
next prev parent reply other threads:[~2023-10-20 3:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 13:04 Baolin Wang
2023-10-18 14:00 ` Zi Yan
2023-10-19 6:09 ` Huang, Ying
2023-10-19 7:25 ` Baolin Wang
2023-10-19 8:22 ` Yin Fengwei
2023-10-19 8:51 ` Baolin Wang
2023-10-19 12:07 ` Yin, Fengwei
2023-10-20 2:09 ` Baolin Wang
2023-10-20 2:30 ` Yin, Fengwei
2023-10-20 2:45 ` Baolin Wang
2023-10-20 2:47 ` Yin, Fengwei
2023-10-20 2:54 ` Yin, Fengwei
2023-10-20 3:27 ` Baolin Wang
2023-10-20 3:45 ` Yosry Ahmed [this message]
2023-10-20 3:52 ` Yin, Fengwei
2023-10-20 4:02 ` Yosry Ahmed
2023-10-20 4:04 ` Yin, Fengwei
2023-10-19 13:23 ` Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJD7tkbA0Ofvw8wQM0017DKWC3SXOT71rCnUhGkoPgQ4wOfLOA@mail.gmail.com \
--to=yosryahmed@google.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=fengwei.yin@intel.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=vbabka@suse.cz \
--cc=ying.huang@intel.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox