From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C727C3DA6E for ; Mon, 8 Jan 2024 22:37:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB0EE6B0075; Mon, 8 Jan 2024 17:37:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A61DB6B007B; Mon, 8 Jan 2024 17:37:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 951706B007D; Mon, 8 Jan 2024 17:37:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8188A6B0075 for ; Mon, 8 Jan 2024 17:37:21 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 50B9F80365 for ; Mon, 8 Jan 2024 22:37:21 +0000 (UTC) X-FDA: 81657606282.20.8A7D242 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by imf02.hostedemail.com (Postfix) with ESMTP id 39E0980003 for ; Mon, 8 Jan 2024 22:37:18 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=EsHYV13U; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704753439; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P0Wg2B2xBGG1Cu5qs0eAgovYqyf38el6XsD5yrJOGPM=; b=zXdZ575AjWG9m/xqNddM79cOfFh7PuOoTxBpQ1bnmOqPLr6uDuHEo13bKU+daZ0eqmPpkf 5QAfzohhQnLXpBrFA1ORdFQQhaAx8JQR/etxz27zAvIFqPeDinezuPc00XgSjXdgs2wJq5 ydnONlXwhOAOMLmI8UxPkAYmAPTISHI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=EsHYV13U; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704753439; a=rsa-sha256; cv=none; b=fohpEiEnjZt3X8uZuCbqZbRim44qubgd94tkDvNSnwrImQaqmcq0SFNPjkvvNBFDBwL0Uc PSf+cMb3lrTBd1+aS1mhsfM2Py7D7v8mh7hfeCPzZAFSDPvd1s3+PwQl/xvThg8APbfUE1 8ymdnrj7x+bfHRZw2kg4mTwPx1M/XCk= Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a2a17f3217aso232717666b.2 for ; Mon, 08 Jan 2024 14:37:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1704753438; x=1705358238; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=P0Wg2B2xBGG1Cu5qs0eAgovYqyf38el6XsD5yrJOGPM=; b=EsHYV13U3YwljlwQzPDK20UXKrhOqpGZDvxMbdENHhkrlZQC7a2OprW9Cka3DbSrAY y5Hmd20eae9OZMqqLZoPFkFTWLyH10ZQbLjFYBw7dMYiuBhe60/K1n21ThUB7NFcUfUG K0x+Xf6/YdZ+tEAiztCW9O9sX8mN1XkeHLiC8wYkOt3E9M5SeCMKENCZwDcZE3SrZppn EfBuVxBfojLoZn2u5B11rEp+0CQkaPVgRqzpPGivbGU7l5+b+pcRZbqrZOltKhOQx8T2 W9Migmd2PLLL63H04E+0UzIBZ2BGpX2je+fSubUKhE+WFoV+FfT69CGxh1f47jf5E2hU Q/mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704753438; x=1705358238; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P0Wg2B2xBGG1Cu5qs0eAgovYqyf38el6XsD5yrJOGPM=; b=jU73IMyWEdpxHY+JxNcCHak81bFst4oxe+zt7yZ8EHfuP+laXqO0ssyJCdhkwjtpQi yf/VWDBeVkIARSxgNL6MhrDdjsY44RISjnS7hE+PqjwmpomrGU2yIsu2GWPVjv0UZtzl Meov66iNQ7WfdYeelk9wdHxt+Q4pN13IYMnGzP4T6EQWHp/O60fJMgB/QF1X2Lm++Yey tSTeZeou2I5frthnT73W7UTZmOOyzLcgc3mjlYwV+7xDsc/et7SFwgkhDUyjL8o491zI hR10vq+QARGp7I5OZrAAkkWR1e3QTVk1j0Xol27yU8z0VnR/3xfcKaE+pyOwsl2eYngy yr1w== X-Gm-Message-State: AOJu0Yyo0EnsyI/kTW0xEP2k6KCKCap5QXcVj67a+Beha47jWUKzKOGd NsHK1zQDRi5lfR+he+fNu/hAjh1o1+s1p94D+CpzgBx3/U9r X-Google-Smtp-Source: AGHT+IFN5J1doAci6kryiLc1sO6gh6B0fzumEjG+b7LNFMoojDVQWz4rXQtX+Ihwcq8B+lNiH24SVRS6WZPZs+N9Il8= X-Received: by 2002:a17:906:dac8:b0:a1f:99dd:15a3 with SMTP id xi8-20020a170906dac800b00a1f99dd15a3mr77902ejb.107.1704753438108; Mon, 08 Jan 2024 14:37:18 -0800 (PST) MIME-Version: 1.0 References: <20240103095006.608744-1-21cnbao@gmail.com> <20240103095006.608744-3-21cnbao@gmail.com> In-Reply-To: <20240103095006.608744-3-21cnbao@gmail.com> From: Yosry Ahmed Date: Mon, 8 Jan 2024 14:36:41 -0800 Message-ID: Subject: Re: [PATCH 2/3] mm/zswap: remove the memcpy if acomp is not asynchronous To: Barry Song <21cnbao@gmail.com> Cc: herbert@gondor.apana.org.au, davem@davemloft.net, akpm@linux-foundation.org, ddstreet@ieee.org, sjenning@redhat.com, vitaly.wool@konsulko.com, linux-crypto@vger.kernel.org, chriscli@google.com, chrisl@kernel.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, nphamcs@gmail.com, zhouchengming@bytedance.com, Barry Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 39E0980003 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: o1t8nmxw7bixrrg5admpb89apqenbp13 X-HE-Tag: 1704753438-314182 X-HE-Meta: U2FsdGVkX19Me5l89+yHake3e9qFSHTrA1cYZXtMEt09RRsg+O7ALBea1Oz9C1QT7gYKFvEHpvbAZbJLAnED5MOCwkFCCvOzfuY3tdRJP468m5ml0yhKcdMeULG0zLwPpXIlDXCWuR9d51fnvjVCAHuN1V4lCWWvC7TwY71ZrGF43Px/pgvomjaLMidWV2jLlD+jx38YGnG9KI87BOBJGR0ffElzCIugC69GgQmt4nuTgZFsEAfiUF5xqYb25643fA6k0uVTISCs5YeUGxv09HqWm1BYcO6pB67GwNrvofGj962ys5G98Fc/M76fhA2QhUPA69fQ1yiAFJU9Hji2Ilrb9HeSW1ZYwrAeGolqgUn1sDtaz3jbIf0E4muDHsVQYzKQGuv9t5dNOUA87ZuypLxQgqWz9ZCPetrYZMdWpJIEA+cqYrF8mdAh5O7dTe7z56KVrx+Emz2cDTwLCBzkuzlqP8f5AFzihDLruVNTPQArzv36/+XlraAVgs2argLy+Ncoit1HkjW9mv7DsNYvJT0SnvN5VU9GCjVqXrvi+6EVfINVCRaB8GgREYYCIZZ315gG+eAoaIA4/Gip03+tuhKm0gABYU1skUxcztkJv2NPW7CaTwwSfFMSWKYQoOHvlnlbnvbZMybZ80BsZgTyepmOoqSbMpxBmjzhlFwP22bs5WEYZdSonfNvRp1ZrDzh2P4YsHOZQCsrOLA6OtacUB+N+9fjhadmsFNKKILaq4DxU1+iue/FRxTzcOCkGnAbt03Y0Z6e2g3r1cwlb544cd06YiU/eHi5iLfjNEXIFDJxjTOCIkYz6gcrqcJFvBhEAG/a+u8RWxLnVifO71u41/ZFydOoZpl7PuzKzOJl+cf9JX406DVhozCTVfSzenmN7apxNcegjsIpbt6baDyJTOmjtPaSm7HW+WBaWNhOGxuVGCMR/Ec5cZreJmPLjJAcEMHzj3D+5T8TqUJz2Dk Ae6hEZg1 d8l+kaexmNvCIWDEfwzYZOL8R/spr2EUSvjNNzuhtqLSfnSdQDheUh5BlKeag5YoUKcXdIpm0uY0U3/GWF3aKwHSymeOVIVil8/9DWz9q7W/su0Xf7Tm0T1y2Kro+LHJ699l26dxJ4DVt5BoKoMyR8Q31y9AZS+3qMieiRcD7VHEfVIPY2DknYbLd5aLe6scxumuj/yQcRDKJdLqYtmIxB5R7t3E/GV8PWL0QvYxb2RYfD4+/ia+B3Z2DBmPFqc3ZTnGXD2rDuxqcMdEn87nwiM0i22onIi+mQ+Udztkp0xVhaVTUZig9l6AHqaccZ988JN+x5LT7F5Z0ZfdKtn740dgkDUfk7Lk8marFXBw88ADinD8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 3, 2024 at 1:50=E2=80=AFAM Barry Song <21cnbao@gmail.com> wrote= : > > From: Barry Song > > Most compressors are actually CPU-based and won't sleep during > compression and decompression. We should remove the redundant > memcpy for them. > > Signed-off-by: Barry Song > Tested-by: Chengming Zhou > --- > mm/zswap.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index ca25b676048e..36898614ebcc 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -168,6 +168,7 @@ struct crypto_acomp_ctx { > struct crypto_wait wait; > u8 *buffer; > struct mutex mutex; > + bool is_async; /* if acomp can sleep */ As pointed out in patch 1, I think we should name this explicitly to be about sleep-ability (e.g. sleepable or can_sleep).