From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F008C2BBCA for ; Tue, 25 Jun 2024 10:31:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C6896B0306; Tue, 25 Jun 2024 06:31:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 177216B0307; Tue, 25 Jun 2024 06:31:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03DD86B0308; Tue, 25 Jun 2024 06:31:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DB3DF6B0306 for ; Tue, 25 Jun 2024 06:31:21 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 80B69818AB for ; Tue, 25 Jun 2024 10:31:21 +0000 (UTC) X-FDA: 82269043962.22.FF4C3D0 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf13.hostedemail.com (Postfix) with ESMTP id 92ACF20024 for ; Tue, 25 Jun 2024 10:31:18 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=32IOZLnj; spf=pass (imf13.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719311467; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ws9SOHPPrEiKArb9NtFvj/rc13eSTiFTo+1pisOVwsE=; b=ShDcUpNiaAlHr/+OcjPwW5P7UeWfDQJ1ofo5Klu6wVnr93AKRXfB7f05LEowmqXzR2+nmt nZStMPLpkOYnPD5v/atjO6W4pb2CGu9KbrYPm+C1mpQeZ0sAN6SYfxfAf9ohR9W2FC5F1a WIOM0INWqbEWkxexddPw9LGqjHb31ho= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=32IOZLnj; spf=pass (imf13.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719311467; a=rsa-sha256; cv=none; b=44pQG7h/EUVnl/Iky5Cj86c157Z5Zd+UcJSucYwYGqbVew1UFe40GFqiUp22Ev3PRXXyG2 vP5izeaTjUYBcDWnmBZ0Rj6X8kXJjjgU/nbEclYDHf1uKF6hrJoMxkeXDY9q5PEh5caIYH oU43URXA2QgaGl+2Us9vZlPAh8LPHBI= Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a724cd0e9c2so256785566b.3 for ; Tue, 25 Jun 2024 03:31:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719311477; x=1719916277; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ws9SOHPPrEiKArb9NtFvj/rc13eSTiFTo+1pisOVwsE=; b=32IOZLnjMQ9y+sRKpGv//cn/38QSgwIgR6XKFrDpdGXB3iIzksftEPsV0MxGvhmgVf rMlGXK7B6jDpTwwSiFsxR4Smv6FEp0Ej2bIL23G9vPJ/829GOG0fIhBYAHe/ITjBqV2i h6gaJHGkn01teK5acOeTZvnBHD7YqkuBmj7uSI84az/hsMb5JShGVH32pZaZSbtqloWW 0vmv/XJH5J8vMHVwmmn3E1ZTbeDaI7ZCZv3hCQmKn+fCJgzuClURxpK7vp42zUbFjxeE Y38R1PCcU/WTDIP658OO/lYojblc/+IX+bpo0qrrNVv677go0fVasRA+u2TB/LhRnCEA scVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719311477; x=1719916277; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ws9SOHPPrEiKArb9NtFvj/rc13eSTiFTo+1pisOVwsE=; b=d1IjqsatSdcXTbgxcJWx69mVkvRJQ5Gxc26Z30J62Cds6mWgkGPkTgAw1HD3uEA4Ms y8pHmD+ScbhHQ8C8Ifej9AhIyElFlnVYfL/F1Ii/LVCKMNXPJYhmN1Z7yFJNmUo+sdf9 8KZDLYP8/G/dvNWwBJLcEK6DDuBVTLMMTv7SE5IGhUPIXOE6hnACJI5vmkLS1Xu2AZcI ESMcMCRgN3+Qq/doA6X+x3ajEh6EySKIWtvOS5dGfBHTcaIjzf4hGOcu7PBIsWd9/CWz 6e0lENFcvTj2X6vt1SWQMx3at7pxwh/Fp8XzTkLKBGHW6G/sTdkozJcHX/ZtR763UaZ+ uNrA== X-Forwarded-Encrypted: i=1; AJvYcCVOFWn9bNQlsdTB2Y3A5n1rv9jNqzJ/NAqavwtlUXgpS0aKE2V5ZWcZYhgAXs+xIBGyCt8kFkSiyer7ZZ83ZY8/hXc= X-Gm-Message-State: AOJu0Yz915+6nLaOOtsDP1lZKdtXColGpEpPfPLVFbhFy15ojojFQYKg 6yCWb0RVMhX4eZxlWXI+AByuBgvWsSsWD5NLmyAu4prBRDRJHisxUJFyu121K7PRBHNy8YoNHQr gkWq4XgHbV9k0NTJveX8hfyHlw4Qqra5IIitY X-Google-Smtp-Source: AGHT+IFrs3kbhcd0kVhjLmP7Zh5J4rapkDDSUXNuVHvjKMsSjePNXYsAJNoRclJ5r3nRfCoh/UPikC/QR7N50v+7KAU= X-Received: by 2002:a17:906:4456:b0:a6f:53a7:adaa with SMTP id a640c23a62f3a-a7245b6dc61mr410737266b.11.1719311476503; Tue, 25 Jun 2024 03:31:16 -0700 (PDT) MIME-Version: 1.0 References: <20240621054658.1220796-1-alexs@kernel.org> <2e9ce344-e25f-41e0-8ca4-b6d80e095735@gmail.com> In-Reply-To: <2e9ce344-e25f-41e0-8ca4-b6d80e095735@gmail.com> From: Yosry Ahmed Date: Tue, 25 Jun 2024 03:30:11 -0700 Message-ID: Subject: Re: [PATCH 00/15] add zpdesc memory descriptor for zswap.zpool To: Alex Shi Cc: alexs@kernel.org, Vitaly Wool , Miaohe Lin , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, minchan@kernel.org, willy@infradead.org, senozhatsky@chromium.org, david@redhat.com, 42.hyeyoo@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 7hpu6czfrz8k5yikwuk9f84noix67z3b X-Rspam-User: X-Rspamd-Queue-Id: 92ACF20024 X-Rspamd-Server: rspam02 X-HE-Tag: 1719311478-825999 X-HE-Meta: U2FsdGVkX1/jDkxMpeq609Q04GB3cQAkXeBslE3vTD/vAEbsg1VMpQJvz2eyku2JawN7aSuts9siuHHE06xnr85Rjp6lWTu2kBKp41ZO2NiaCDZp2ICJxpQXSwlE0Bd5CGpRaDJhsSdaL2ztyinr3KpNJ5YYiO1lZ46c59+8rvjaN1CrvJLYAvFwhT5lTyE6OnwXTavaKZovlPSEbsgBKWAHzlS5NPxttigR/0w+4vPV78JQQsLQnSHo13TEcPWXM3RxQ9+BqsEm57/pWBA16qAeNjozXlSSVWlCyqaf/gtCv46FrP+VJKwfS3EwpoREne77PUeJTJvaWA+yAp4N8jpQkUmC3f2gAs9kKAUyr4LsMZa0wskvXESG5oPIDcWtbr9v7rHPA/EZ8sf4RU88kAtP9oZEircPb7BbfFvQq9yULR1Yx7hp78RHqz/R7gAD+HIcFaxXcwlfDetj/qVHaF5TFWi+VYLg52XRg9cldL1yRcKHx1fAxsrzC3CW6LZMx/TMZkakiWQRVUof+7w99X63LwZhyfScwq5P2Vd3Ji0DX3J1kjLZDr7KUTOgSkJ9kZ/ldbxywnmH2AnsbWMM1qVbVMNoTbMIx/53O1OgOeXrutGFZ+rlU4ENA0HzZ2ZmTB4Js3m5onbf9vtHnieEAVVwKbmdVgkPSqve06pz7sM0bDl8xQ7FhKVtH0FvJiu7coBx8Li4dYWOOzwr6ZMzB4EYsLX+28WFGPfyAiv4IK3jMgk12Pjt236rqxFH3hunkg8YAtFqbczWonvA9SK61TpkFgCc5TpBdMeb/lKkXBGEzOD3u62lAn50Q8tcMKj2l1h7U3dvYyZYR1Mv8BrDl0T6ZRf6y0lMMuzSPSoSQfIuvWh0qvFKUpltynoCF4fbKNxdX1UqAioP/1JqgWP88G63qlZ3aIfkLoPKwJEDsz7ilmKEVmIUPP0TrDO7tqf+xww8MZVn33ex1UK2hey NnpfjJGA kNYBvfVo3z6FeDCtQdo+OnglYGV1xgBrtID1Rv2IhKQXB0dJFRlnxlxUpmMephFHrDlPpCUEzzEEZHz6jS4c6zogm6zuYRF0u6dUL0bscZmI5KCKH6l+JbYgtlTPNSh5KkGITBkbNvxUx569uTjxfiMatOzvSkTesrQ8ykOTm/vJFo4rCSNdhoRRackQ59VoN+I+zEvCtyy/rpKq32HSFJuw8w3Euh0+10sxK2Xt5lJpkEkTJQXV8ld5H4bYjXPH5FstslgwYC5LL6j4UnZ/6dFglkpATdicaY3Anl7UBIufO4ZX9W25nKJ3BS6+83dx4tO58pS56L0u802tdKnLMHGNZieG41RSGevHYAy7l8+ALLXRTF8fVux+yTkaVbZXeh5GE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000014, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 25, 2024 at 1:11=E2=80=AFAM Alex Shi wrote: > > > > On 6/25/24 5:46 AM, Yosry Ahmed wrote: > > On Thu, Jun 20, 2024 at 10:42=E2=80=AFPM wrote: > >> > >> From: Alex Shi > >> > >> According to Metthew's plan, the page descriptor will be replace by a = 8 > >> bytes mem_desc on destination purpose. > >> https://lore.kernel.org/lkml/YvV1KTyzZ+Jrtj9x@casper.infradead.org/ > >> > >> Here is a implement on z3fold to replace page descriptor by zpdesc, > >> which is still overlay on struct page now. but it's a step move forwar= d > >> above destination. > >> > >> To name the struct zpdesc instead of z3fold_desc, since there are 3 zp= ool > >> usages under zswap, zbud, z3fold, zsmalloc. It looks like we may exten= d the > >> zpdesc to zbud and zsmalloc, combined their usage into one. > > > > Please do not focus your development efforts on z3fold. We really want > > to deprecate/remove it, as well as zbud eventually. See [1]. > > > > For zsmalloc, there is already an ongoing effort to split zsdesc from > > struct page [2]. > > > > [1]https://lore.kernel.org/lkml/CAJD7tkbRF6od-2x_L8-A1QL3=3D2Ww13sCj4S3= i4bNndqF+3+_Vg@mail.gmail.com/ > > Hi Yosry, > > Thanks a lot for the info and comments! It's my stupid w/o checking the e= mail list before work on it. > Anyway don't know if z3fold would be removed, jut left this tested patchs= et here if someone need it. It's partially our fault for leaving z3fold knowing that it is headed toward deprecation/removal. FWIW, I tried to remove it or mark it as deprecated, but there was some resistance :/