From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28987C61DA4 for ; Fri, 3 Feb 2023 22:31:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C03E6B0071; Fri, 3 Feb 2023 17:31:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9482C6B0072; Fri, 3 Feb 2023 17:31:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E8B86B0073; Fri, 3 Feb 2023 17:31:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6C1E36B0071 for ; Fri, 3 Feb 2023 17:31:21 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4DFCC40870 for ; Fri, 3 Feb 2023 22:31:21 +0000 (UTC) X-FDA: 80427427962.05.FE62BAD Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf27.hostedemail.com (Postfix) with ESMTP id 6ACF440016 for ; Fri, 3 Feb 2023 22:31:19 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=KAaaQyjP; spf=pass (imf27.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675463479; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dWWZZt8Kd4jgexM3P2TiZQc8VKtIMzPQG+XBMGoXd3A=; b=6U7w9VSHk0Ln/Cbx/VjjerdXG+hN5M64jiC0jHIG8CA/0jrjB3BkIjcCgxC5E7VijBDFg+ fFoXlXQ/FpAM2jpXWRsxywgjcMb58oxFUpm2rxydYWzBRIlJlVUCJcuD3gs9mBVdfhggtN iWHzll3hjbnc2JIVtpAnbJ2UyYV50Pc= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=KAaaQyjP; spf=pass (imf27.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675463479; a=rsa-sha256; cv=none; b=z3UDW4dYq/mTrIcf/2EeckDftM2SeZ5yNmDIPOFZ7n3IVI3sQgBUMX0yQ5Vf1re5iBYE50 itgoGMw87qiQEC8DtbsBWgXnBrAa2TKsYfV8/bLwXb4UN0pSocwsiXaUWPZ3HwPAc4HnHH nsm4s13xrA4yoGWrsR4gmVdY0BW3KTQ= Received: by mail-ej1-f46.google.com with SMTP id bk15so19247853ejb.9 for ; Fri, 03 Feb 2023 14:31:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=dWWZZt8Kd4jgexM3P2TiZQc8VKtIMzPQG+XBMGoXd3A=; b=KAaaQyjPGwK5bqIhRr/0vsX0mK/cllOocnrd3InMcbq4UNsMPH1EAzHpj8k0DULfrU LYeN9IuTZZ9KunpCXqpNhekp1fgZqmzx0V/QSjn6LccSZhKmUuVjz9zwJ2g8gLLyGGy3 tcYLvcuNXZZEpSvrQBRUDtmDAGF0958HA1yJotBPrUuJZqSA/tlwjPNwgO5fSfAiPM9P wlfJbx5VPi7Hdgerg+cet3bseBQsyi2WNDLbb5zCzh/xjuGdpAeAWS+IKsqvoEB6WsCK nTaOW9nT3V3BCJekQVJL8dHPe1q4Jo2TTriZYQB+IHe0PdZFa1oQ4p4N3UkM0IV8yHik oXAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dWWZZt8Kd4jgexM3P2TiZQc8VKtIMzPQG+XBMGoXd3A=; b=tJLgILa1efE0ctWCfswYkWU8mHNpw48hgm0IT8s+nSceKEG2i1VD7/F7eVtUFqbjdd gwLgFTrOLoXyArf+rzS+hT4Q43oLOpJ7UHAlSOhMmA9JzQ+rTaodV+gjdg4N4wpX7I6o jgSC1SXFb+0Kaz3fMG7fuWTPu1+vbnSuGolMPHpYncuebvhnElv1gx1wbEz014I7I0Ah 5k9PAmh3ii2JQmzCy/0QW+nena9XHecPg/Ro/8tb89cBX/mydFf4wngBNHKIAMJJSRdX zvaUnXI6r9KEeNSMgQZsI6HlDpF25Mc7Sh4jHkAnAXcc4el8C7lkg4rwY681v5DCT+d8 lSpg== X-Gm-Message-State: AO0yUKU3SjLtoPX6VwZ+aJr75byfmFhn4Fyxz7mPQjAbLaGLF/Swkvou cRJkoMpmzXLYHo/ZTSP+WcNSueCyUqinQb1JijA6DA== X-Google-Smtp-Source: AK7set/ngCUt3CFIMK1ZEA00e8oy4dFzGJAM1H1PmSx4A9FBTa8WDKIPnYAqeI3LGjP/KCfjZut7Hqka4SW9V2e2hvU= X-Received: by 2002:a17:906:c319:b0:878:7bc7:958a with SMTP id s25-20020a170906c31900b008787bc7958amr3493108ejz.220.1675463477828; Fri, 03 Feb 2023 14:31:17 -0800 (PST) MIME-Version: 1.0 References: <20230202233229.3895713-1-yosryahmed@google.com> <20230202233229.3895713-2-yosryahmed@google.com> In-Reply-To: From: Yosry Ahmed Date: Fri, 3 Feb 2023 14:30:41 -0800 Message-ID: Subject: Re: [RFC PATCH v1 1/2] mm: vmscan: refactor updating reclaimed pages in reclaim_state To: Matthew Wilcox Cc: Alexander Viro , "Darrick J. Wong" , Christoph Lameter , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Miaohe Lin , David Hildenbrand , Johannes Weiner , Peter Xu , NeilBrown , Shakeel Butt , Michal Hocko , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 6ACF440016 X-Stat-Signature: 3p49yk56o57qboa9aeeitg7bfrcpees5 X-Rspam-User: X-HE-Tag: 1675463479-963704 X-HE-Meta: U2FsdGVkX19WSIGsRzl+YfBD8vw1C+sdVB1eDHFCIDrV3Cip5N48S90T/0xEqNXLFSQM1CQvOga0JueM3Mvy1T8ERdlm3zyXBsiwWFJ3bm31G+Re6c4rHZtJeLVq9i80FK6X3QOPvmc+FzTouVkEm7aNDSXMlIrDB1tcgkvj1fkidQkZUcdxnhZvBJXVgSa3fgAAEpgICrEx2A70YMm2edK7/8GujelyOzRoQQxOlQYDCpmD91bVGhlONgMtm2EJhAJqPnQluoLQ6SV2h12uOpdIWSjvYv4Qi8CclwYap8vyQ9r+TnmW2ODQnP1YABa43tJ0D+3Z+lDuN3feYpsm/2QHY3w27yzI6IcJPnYmClORl3PQcorkXNtIjBlBWHMBhcr7bUT4npt4KXCI7ejsF6wgID3SG/R/2rG9nMFW5H3eDbyakm1pLwg9x2F/UJ/ehE1BhUXoAwREHP01Dyc4fCunlBBTW3n63OBJm/fHsf4CRP9eOckH20HWVUBgh/YEBlrGNvQk1HGni8w1PknCY+j072qMT1Z7/IweZyRX8oxiQt31r/XdOGVyqIdkLkBq23gyHQ0OnKlKFdMsdR26vrmM+9MFcM7nOiIPrHRLhnJyYySoUbxj6B0FHJPvpNVvXei0MQ6tdHO/t2o64TBqbyuGOEQz8q4L/05WF+8faU1gmMT4H6LmmlAkoaYpSHS2rAyrcA35x+iSBKzH8nQ3u1Mk2+Ca5sR9dLJ33wgCoQy/abvHN+aGgyskyRQ7IoMVX9ev33rq4IseerC85O98pJBNCOIbdYZBhhse9laOx4wiiSegZLK+yTbqAp/dsj33cYLfiEGGiQbfDiR3Aq6AdWVrpr3hJdLYZbN1TYQAfcPlC7dQ673X0W00tcfOXni4DJ585Smi8XEWgiIcLNvQ3wgzTXgFsYr6KuIrhiyTSpnth2vwkfKezaeECz8w4U1EqVPfaubQNgr+Dc6WRQv xoC/Jgg/ 2w9R95qucMjUTTq9w8pC7RihATH3ByKWPExUfyQHPwvAK3wnXuqW+sgB3gCtxJg4kl92ve4wSnpyQUYoTJ/SHCQXIKolDgVx6HMLdlUdBkDZXGCZVFk0MHvlQdDQqlvYP745jHE6QTvMkbGFndEjAguq44eZOx1czTd0qBCJWvwftU/OxfFm4OTTy3vXYOslUgLquUdhQNy2d6gZN1zZ3PEwt7RNn56Fumw1dAX1KFlTWjXn4yaMa0qx+2nXzDbPJp8Ugp4ZdEow1MBt0C6FPkHcQwrhufHA++SdXlIJ+xpEtw6KFrsvnnWNR2LQYQSrWCu5Rhm4UW2OSuflPgMNzzLj4CZNslZ9eyxBh9UjUbQfvZoi17Lrvtsy9pHyW80PsmVzHt9AkXa8ao7dJzYnr9v/RXht7K4/enSuugecWUpfAJnU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 3, 2023 at 8:22 AM Matthew Wilcox wrote: > > On Thu, Feb 02, 2023 at 11:32:28PM +0000, Yosry Ahmed wrote: > > diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c > > index 54c774af6e1c..060079f1e966 100644 > > --- a/fs/xfs/xfs_buf.c > > +++ b/fs/xfs/xfs_buf.c > > @@ -286,8 +286,7 @@ xfs_buf_free_pages( > > if (bp->b_pages[i]) > > __free_page(bp->b_pages[i]); > > } > > - if (current->reclaim_state) > > - current->reclaim_state->reclaimed_slab += bp->b_page_count; > > + report_freed_pages(bp->b_page_count); > > XFS can be built as a module I didn't know that, thanks for pointing it out! > > > +++ b/mm/vmscan.c > > @@ -204,6 +204,19 @@ static void set_task_reclaim_state(struct task_struct *task, > > task->reclaim_state = rs; > > } > > > > +/* > > + * reclaim_report_freed_pages: report pages freed outside of LRU-based reclaim > > + * @pages: number of pages freed > > + * > > + * If the current process is undergoing a reclaim operation, > > + * increment the number of reclaimed pages by @pages. > > + */ > > +void report_freed_pages(unsigned long pages) > > +{ > > + if (current->reclaim_state) > > + current->reclaim_state->reclaimed += pages; > > +} > > + > > report_free_pages is not EXPORT_SYMBOLed Will do that for the next version, thanks!