From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EB7EECE587 for ; Mon, 9 Sep 2024 20:30:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 020886B0201; Mon, 9 Sep 2024 16:30:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F12A36B0202; Mon, 9 Sep 2024 16:30:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E01AF6B0203; Mon, 9 Sep 2024 16:30:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C20276B0201 for ; Mon, 9 Sep 2024 16:30:04 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3557814112B for ; Mon, 9 Sep 2024 20:30:04 +0000 (UTC) X-FDA: 82546341528.20.4706C96 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by imf10.hostedemail.com (Postfix) with ESMTP id 5DD77C0007 for ; Mon, 9 Sep 2024 20:30:02 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=PaklNl9Z; spf=pass (imf10.hostedemail.com: domain of yosryahmed@google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725913700; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XaeSQCeGfBRdIaHorPwBFNBXhIKm2efh/hZk06eZftc=; b=FXk5/VY8b7S2gj+gFjzdhHvHCIwItdrpl6+jBLouhYcdKw9XHXz4STSTC8bPqH0ULMuB3T p8GwUqoQncBMRuiLID4jDkKXxMvgmv7/aDN3PTOxej6COpEB5jngHFH03H7+AyAR0nRHKc OXbWzdniE+LAQJbUzy7qOQkIelYdKKY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725913700; a=rsa-sha256; cv=none; b=N2Ryjt2KwZArDNDn3JAliyaX+2jJkOqm45PIA5g/3O6PrKQXL1wl75OG0pMjsTpR/VE9FK W9x5JH3CHRh4jBHOnrjt1KFNtMavSI/cBqYdfpiHKDIlOk+MZ4xlDHecixoCbWYa9McTL4 v9gtdxCR3QBRaQFQhx19rVA6AwfLMko= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=PaklNl9Z; spf=pass (imf10.hostedemail.com: domain of yosryahmed@google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-42cbface8d6so339615e9.3 for ; Mon, 09 Sep 2024 13:30:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1725913801; x=1726518601; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XaeSQCeGfBRdIaHorPwBFNBXhIKm2efh/hZk06eZftc=; b=PaklNl9Ztr5UA7mZ/SnrEar4hIdGs/atNeSvDyTjUCPwkP8ylc6zZtYHPlqOOFdHlo OLigpF1MMgDO43Jm7DxV/xTgw39s6aI6W7la/LjqSMQKIpnn+4Rja5Jf5F1QMu/RixiJ vFuwHtirA3SLYd2aTrDLR5JTs8u9pO96dRVmpQ9XKQze5c0rRnckZ6S4bFIuxIjC9VUy fHDOVbSyglVYw9YQ9I7Nib1/ZVfVpiMQ2bVHPFMD+CwqM9FCtQ+xz/p5Xl/+pLaMXw+b nUGaJbZrUpgxhNSy0NrHj72+V/SjTRGqEw4uVCgWpEJA9WPrqVVhjrQlsN1rx1gssvSz +1Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725913801; x=1726518601; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XaeSQCeGfBRdIaHorPwBFNBXhIKm2efh/hZk06eZftc=; b=P1fqlTga2dNApoSPtbsaFJbR16+fR04SXXlTJvoUonD1mkNol0uRA5bXm70WWMbswv NGPl9AcQJ8rMXyvNo2207Sb0Tfz6sZQqUhjUhUUS5ZwO/hAWwhQFMqq3zLy5oPfQdXWY k0ej6tXaA3WrTmeOFPMIbO6FxB/nwEZgurVAkF3oD9MvQ9hPWeh2ZUSvBg8Vq2dum/RP /NkbsVL+HgufRRrgW5/HiZ596HMnfqcof6TV9AgYF821tqRCXoEkKYJBmooPbYN8J2qe 4oz/zeg9chW5P3kP8C4ocWNs3o2E6bPE08PdcVfMrj1igA/NCGDBnZVQIPj5c5w4VJtg KIxw== X-Forwarded-Encrypted: i=1; AJvYcCUGNg81ca5gM7t3dE/Ih6HSWgzpWL6glKQsVYxwlaTPM89A7AjdXyQ8Bc9CroLvo/6Y56D31gyBtw==@kvack.org X-Gm-Message-State: AOJu0Yzjary4InloiAbGks+73Yv38ClSrOclMktxbBxUbtmL9+9KOHyL gv7eHbmA8f5IerSKqWUbQR5QX0LqgJJJavBvOPrLKJUTDjwbP2xht3RgbBs0IABjjHyORFhv7MO lRzNdj6c0aRq9JU8wcImQb8tva7Q84M4ppy0v X-Google-Smtp-Source: AGHT+IGGDgVrgTdXrGeSeuVyKgWmJPMNqrnV8Gr/pbVAU/1kji99wC4S9pU3ses1bfxjWm712k8Ob7/H1W5GgkPQXfg= X-Received: by 2002:a5d:4d4c:0:b0:374:c6af:1658 with SMTP id ffacd0b85a97d-3789229bbd1mr7700608f8f.1.1725913800042; Mon, 09 Sep 2024 13:30:00 -0700 (PDT) MIME-Version: 1.0 References: <20240909202625.1054880-1-arnd@kernel.org> In-Reply-To: <20240909202625.1054880-1-arnd@kernel.org> From: Yosry Ahmed Date: Mon, 9 Sep 2024 13:29:24 -0700 Message-ID: Subject: Re: [PATCH] mm: z3fold: deprecated ZSWAP_ZPOOL_DEFAULT_Z3FOLD as well To: Arnd Bergmann Cc: Andrew Morton , Johannes Weiner , Nhat Pham , Chris Down , Arnd Bergmann , David Hildenbrand , "Mike Rapoport (Microsoft)" , Peter Xu , "Matthew Wilcox (Oracle)" , Kees Cook , Vlastimil Babka , Chengming Zhou , Anshuman Khandual , Vitaly Wool , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: phnoijdxnsqft7ef9npuc1kkhkpumk7b X-Rspamd-Queue-Id: 5DD77C0007 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1725913802-25245 X-HE-Meta: U2FsdGVkX1+1sPAFn1Q4qzm/dMVQgLNVA1nv6j+fxsd/fMrxlrBNVZ6maQSdvdu5HCVaDrwPEnEm9N6WwbizwO8E5KvS3JF1W1wjCEoJmwge3uTKnTFEcLT5otfxw/b8Y+sX59kUABAFfuzVOYNUNRa4bhV6rHacDYYTfH25uOzaT7BR39lvUuKHPi7P4fYL0zH2iaFCsYuIZmJvEG/t8OBfNSy3PAtNomS0KwQnATZ19w1PcQfvlRw0Ky0uuz4vFx+a2PjaZJnMIQGEHY5Zdm7bUoD2Zp1iuRoI9MwVrQoN+0isLzYI+6bmsWmHWgc17EIxh7zqrw5x3qmSqBWb8yXcymuT63JVDbKhShOB7ovDSvgcx34rGL8Ak0n7EUZNGhRUt0QUmFvxVi7a3ZgFv0GA5SheOS2Cn+Pkbd7hamwf3E1XrGzTH8cYpGftZcY7HsKJxqEuLBmmar1M5FM879HbZb2VOFTy08ZLt3ALk4C0SAozR1SBagIhWRoCbSoP54JbcfqJLk1SZ/fERa/dFDrAIahvwWhYBeSv6U69OYrgHvQw97GMHSPBn9qu/hv0eW2RYV9d3eRRB6dS0psWnZfJmRj4hnPR9K4y3NMpLifPFrQkzJ2zCo7eFODwJB7hirqF4S8Q9UtZF6oKsr519QWT9bzl8kHj904J4LHacTKvzVrkCcC33QOK2483BCm6q8sG/IL8R/Nhaxm+hnH4iGKuZgYZgns/miZEv3xHdaVxNcebSrURGDNqTEIK70xScu1cbFpMUL8NZxZFSRdqT9U1cLLL9RnkxAzcG/QoYU9SBZu01aaAuTAnEmttWlt/lyP0O750SHtNpGSvd5GJ1fmE+zLUGEtK1zVXxbXbSdYndLtaVkAksNwIvDDHm1aepFNuAio9yHuxJm/bl24bGoiYI3NgfRQpVKoPowpKg+QfqWskeWzb1avMzJ94IIMxmJCKjw3O/kRzb41sQoY gCipP/sP t4yoaj3zqpgfHTXv2mqoFSOwz0hRozo+l5r3bkoDks8btebo85f0FWJDaBUwTxTcL9JDlw8GMXj0aDPMVjmcpQ/JE7z0PG6EK+OTVmpaNmkNXfNMz1mXmBwm1NpRlhSkEvyg4q1NUcfD8xOa0p2Ei4ovExGD7oyAyTpq8IszoHJQWEJCKfW9K3jp77xwPIZCiKavWPr/golyGIcjAYqx5mpNFA4elxY3eEZHqaOb8HmME6L6akgxutiNmu11ypZ447m6foyN2AOCPjWuv54IBihHTSw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 9, 2024 at 1:26=E2=80=AFPM Arnd Bergmann wrot= e: > > From: Arnd Bergmann > > Randconfig builds that use ZSWAP_ZPOOL_DEFAULT_Z3FOLD > now cause a harmless warning: > > WARNING: unmet direct dependencies detected for Z3FOLD > Depends on [n]: Z3FOLD_DEPRECATED [=3Dn] > Selected by [y]: > - ZSWAP_ZPOOL_DEFAULT_Z3FOLD [=3Dy] && ZSWAP [=3Dy] > > Avoid the warning by selecting Z3FOLD_DEPRECATED instead, > but rename this symbol to ZSWAP_ZPOOL_DEFAULT_Z3FOLD_DEPRECATED > in the process so it no longer automatically gets used with > old defconfigs while still allowing users to select it > manually. > > Fixes: c68c1bed014d ("mm: z3fold: deprecate CONFIG_Z3FOLD") > Signed-off-by: Arnd Bergmann > --- > mm/Kconfig | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/mm/Kconfig b/mm/Kconfig > index 7c9930bf8a9d..09aebca1cae3 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -146,12 +146,15 @@ config ZSWAP_ZPOOL_DEFAULT_ZBUD > help > Use the zbud allocator as the default allocator. > > -config ZSWAP_ZPOOL_DEFAULT_Z3FOLD > - bool "z3fold" > - select Z3FOLD > +config ZSWAP_ZPOOL_DEFAULT_Z3FOLD_DEPRECATED > + bool "z3foldi (DEPRECATED)" > + select Z3FOLD_DEPRECATED Thanks for looking into this! I was going to fix this by changing "select Z3FOLD" to "depends on Z3FOLD" instead. It makes the warning go away in my builds. Does this work for you? FYI I will send a new version of "mm: z3fold: deprecate CONFIG_Z3FOLD" as a hotfix after v6.12-rc1 is out as there are currently conflicts, so I plan to squash the fix into the next version if that's okay with you. > help > Use the z3fold allocator as the default allocator. > > + Deprecated and scheduled for removal in a few cycles, > + see CONFIG_Z3FOLD_DEPRECATED. > + > config ZSWAP_ZPOOL_DEFAULT_ZSMALLOC > bool "zsmalloc" > select ZSMALLOC > @@ -163,7 +166,7 @@ config ZSWAP_ZPOOL_DEFAULT > string > depends on ZSWAP > default "zbud" if ZSWAP_ZPOOL_DEFAULT_ZBUD > - default "z3fold" if ZSWAP_ZPOOL_DEFAULT_Z3FOLD > + default "z3fold" if ZSWAP_ZPOOL_DEFAULT_Z3FOLD_DEPRECATED > default "zsmalloc" if ZSWAP_ZPOOL_DEFAULT_ZSMALLOC > default "" > > -- > 2.39.2 >