From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 034F0C001DE for ; Tue, 8 Aug 2023 06:37:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 96D7B6B0074; Tue, 8 Aug 2023 02:37:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91DF76B0075; Tue, 8 Aug 2023 02:37:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E7758D0001; Tue, 8 Aug 2023 02:37:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 70B716B0074 for ; Tue, 8 Aug 2023 02:37:48 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 36D3A120A78 for ; Tue, 8 Aug 2023 06:37:48 +0000 (UTC) X-FDA: 81099981816.03.EB251FB Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf16.hostedemail.com (Postfix) with ESMTP id 6B77A180004 for ; Tue, 8 Aug 2023 06:37:46 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=LT3iE7It; spf=pass (imf16.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691476666; a=rsa-sha256; cv=none; b=aU+h8/RTGccdY5HiLqWZkVNwPlgLDeG+bskYBFj4DZt4EZ3Js49/ahnyLWRDiUESWLoXOk 9lOOGiBFbLyRJCQc5Iligl3yr/IbKEO2lK7ER3rDasdJ2HkKEs1CObOhm/YMd5X9or4IZG Z8NNdmwkcgll5HR6saDV8RxxSQgXQz0= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=LT3iE7It; spf=pass (imf16.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691476666; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+wA5WddqWKyKRnKwDQfXys9tWYpkiEQYiVU+NYcqhh4=; b=G9qYDBXU9Z0SzB06zWnv+206TdRrigIKi1Nqvj+HKcJXKJ+INNbPjXKT+G4nUXFLrXs+sT 4uVu+BqlrQm/pwYQjgyEKrbhgnvAZ7iAaGL/DJ//cP0e4jlrrbdfsEVs64PYULG4AgR4jH 5mfZBud5o9dgtXhpBxjHNcu/GOpQAdM= Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-99bdf08860dso1356856566b.0 for ; Mon, 07 Aug 2023 23:37:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691476665; x=1692081465; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+wA5WddqWKyKRnKwDQfXys9tWYpkiEQYiVU+NYcqhh4=; b=LT3iE7ItBTCa3wJQIn7jIHLH0/MN1to4Yh5FnQ3Kl4oua70qqwb/3rn5/tmdlq5st8 ggkf1/TQv0Q/MIG/DKoa+aripElhJ6i1Uu7o3MsOaBSyeFK0LL2xMYXm4jiQOwyEdIcj fcKt29LLYDwJ1+O1salnM8Ni1Cyd6ZKwVsW/+Wq1U4tziw4daqA9jTSWSGIUCGZCGyYJ 3wqqsQnn2PrQm/E0+BaqwQeF2kimFMfzNj2DdnWqH5/Lgv0gsXh8ajWnkaJoyfUekP2T JTohxvWvUnfT7bxBucOxdt9YSeTpAYgOK9uM0uDfhLgAAN/Td0ILxs7IPFljRtKEdKnM /xrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691476665; x=1692081465; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+wA5WddqWKyKRnKwDQfXys9tWYpkiEQYiVU+NYcqhh4=; b=hs3G2crxRgl3ti/7I4D+Sq7JbBQxA3aZ3bdlJ/FHCStb26Xp0d0Yn/yaF/X+KP7Lom 29JIyei1A/Trvjl/UxxVnmc83yktMp/EpdjgZfw9cILRC81Anpi/6OU6PSbJCQBzh94G tn/6elFUDbW9li++VIpViCQpV96zJmpWNxGf3m3FQolbDKaBWPsMz6dLvREnohPPikHf LMQLkt8KUNl/kfDnC6DcKE63CT0k8asZMzOHVNOxFeTiZzxwpDnT1AS2VZ6YcgYcTSWs iBR6LlHujAtoV1CoOyPPHbi3m18iEJVyyaSqo8VdDNluNf701a5ZNE3VTZy22El4jAp6 1y4Q== X-Gm-Message-State: AOJu0Yzsuh8CsPkIlJsHR8yusW7jj+n8P5FfbcXlv/sQzMllIg1eLXJe SRyMgHtModO77Pu9Pa+5B40Xg/X+oHzg664zcUlekw== X-Google-Smtp-Source: AGHT+IE3U/GqAYNkUo+lUKRJw/7PZijyeSXZXhdHOTQ/nLFoajk3tt1cgp3as7bcVXeoFbLRdQcA3MMVyp51Uf93mjs= X-Received: by 2002:a17:906:3011:b0:993:eee4:e704 with SMTP id 17-20020a170906301100b00993eee4e704mr9969687ejz.38.1691476665091; Mon, 07 Aug 2023 23:37:45 -0700 (PDT) MIME-Version: 1.0 References: <20230808062056.292950-1-xiujianfeng@huaweicloud.com> In-Reply-To: <20230808062056.292950-1-xiujianfeng@huaweicloud.com> From: Yosry Ahmed Date: Mon, 7 Aug 2023 23:37:07 -0700 Message-ID: Subject: Re: [PATCH -next v2] mm: zswap: update comment for struct zswap_entry To: Xiu Jianfeng Cc: sjenning@redhat.com, ddstreet@ieee.org, akpm@linux-foundation.org, vitaly.wool@konsulko.com, linux-mm@kvack.org, xiujianfeng@huawei.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 6B77A180004 X-Stat-Signature: y5hbanxje1k5pmem5fu91sfa6w9ypry9 X-Rspam-User: X-HE-Tag: 1691476666-853922 X-HE-Meta: U2FsdGVkX18Qneo8VsWwTDKJly+0awXbeaxCNBHwzyUnhSlzLNBLrnxeiU04zvC0WZ8/QZ6S1pFo6mBecaHuL/d8k71ihaNAloFJoMfXHjoTJouN94Txm/Nb+sTFfV3BxNbWBr+VeDfLVJ/0sgkqPmrRoXTQKCFvzwKE0jnB8D9ezHBG/5k3FqKA6lM9eGLAoYrVh6QQ1xumLbaryZqhtMEeZrsMrvyoGwa/YRYJFLQUEsHA4RW5V9jn2+nNi7aFDc2eyzpC6AP/F7+DfM1WRNLBwKuRqbDOWxnxNaGiSdFXOSrmrME0wa4JkLArfo40LHKhs2nc85c2jvrsGFSUB1B0L2wnOmcHGiaa2hndZMFwD5kTRlb74Kt/MiTcBXhQNtxUbZWr1EVl9rzyETXi+O68FmWUmbRMEhf+tOgOpiU5sdwQ7jgeTTASVWNOoJmButn3dZXhe0Pc/KEge8TpEobSGrfTw71NXQnQHieZiyJOMemmRRmO+cv0we0F/Y1eP4iQxVWtoIjOJkmD/4L8IAJxTDP4SkzoSQsKspYB3LahAEW+13/38nl/ktqT98Q2ntCo2OomV3hHnjedvBv+lLBxZ+rFI92vXLiHosXsB6/Ih59MJPOoFSDIot0EJMics08YbHTMHjfZBHWL18eY0ZHy3bbaPbm95MM+mN6kRt+tb2Jwr8gSXOjmcNZjgTvdWIFCpIKd2NpThgh/qhQTTmXHgQnJ+QYGqX8DKIlAvtjP8peTR8ry4g5Y80aPcgXFtcC1GqcMfT83vuWi33CZaEAag2pMItkK1OmfK6lPHIP4jNfM/xtWbagVtTV81oujmTE0TFOQ//JPhldnDqhyxr7CcxoHNPn2qmxNpEWUGEuN6W19wSEvZAO4JrVhcAPuX76nOxti41FEpjv+EWqCM9od++qhOcVqoATL860z83Zxh6uh5YQgrLMy8p9IzGw/kLtnr1C3Q48Mgi0gQfV 3Fg5rAL4 gPbd04Xb5gedbedJGWpOJD3Nd8AYXDdvZJtwx34chYwRzBGeSXShM8VI5iPoaPaRiZ9kIAYc63cKefuK9T/oVS3MDBqHtmrxyuTlsGgPEVs4useJJrMiAekSdJrtD13QFBYPvmmWJUjlj0ImPWvQWHitlBu2mazy6ZfHmpOA60/IA7O+wVjUdSMtBV2ASvGYJhckTQHE7yduMxTCtTDEv+1zrKJ5Nfz3SNqTtMEXEVBEgpR1Q5/ubbpTLcw5HV2Sav2AiyYEtkoVPwTE5THUO+QpnPtHSutuRlURSEqH0fZmg+UWKL3rR2Z/FHsFWoR5rC3aPI1TtkZ1CSo203+z67qIGwBIMC+Hg4ny98CaEBF77kC0PfGAbyXv3Hw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 7, 2023 at 11:22=E2=80=AFPM Xiu Jianfeng wrote: > > From: Xiu Jianfeng > > Since commit 0bb488498c98 ("mm: zswap: remove zswap_header"), the > 'offset' has been replaced by swpentry, update the comment for it, > and also add comment for 'objcg'. > > Signed-off-by: Xiu Jianfeng Reviewed-by: Yosry Ahmed Thanks! > > --- > v2: reword the comment > --- > mm/zswap.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 5b56d38e7339..1e17f11a7896 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -182,7 +182,7 @@ struct zswap_pool { > * page within zswap. > * > * rbnode - links the entry into red-black tree for the appropriate swap= type > - * offset - the swap offset for the entry. Index into the red-black tre= e. > + * swpentry - associated swap entry, the offset indexes into the red-bla= ck tree > * refcount - the number of outstanding reference to the entry. This is = needed > * to protect against premature freeing of the entry by code > * concurrent calls to load, invalidate, and writeback. The = lock > @@ -195,6 +195,7 @@ struct zswap_pool { > * pool - the zswap_pool the entry's data is in > * handle - zpool allocation handle that stores the compressed page data > * value - value of the same-value filled pages which have same content > + * objcg - the obj_cgroup that the compressed memory is charged to > * lru - handle to the pool's lru used to evict pages. > */ > struct zswap_entry { > -- > 2.34.1 > >