From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08E26C433EF for ; Wed, 25 May 2022 20:32:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 723148D0003; Wed, 25 May 2022 16:32:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CF448D0001; Wed, 25 May 2022 16:32:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BC278D0003; Wed, 25 May 2022 16:32:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4E02D8D0001 for ; Wed, 25 May 2022 16:32:21 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 249A921630 for ; Wed, 25 May 2022 20:32:21 +0000 (UTC) X-FDA: 79505412882.26.DD07900 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by imf20.hostedemail.com (Postfix) with ESMTP id E4F851C0047 for ; Wed, 25 May 2022 20:32:04 +0000 (UTC) Received: by mail-wr1-f50.google.com with SMTP id i9so1462128wrc.13 for ; Wed, 25 May 2022 13:32:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=A0dEd4NUNMrTRFFSR3+OfkYzmb9W3Zxpow0f09EOgls=; b=s5IkQauZnOLISvCoz7A9uhGFFCaH1f6gh+yufCmj+HN/vMS6luKtssU9qd7rvuHP09 HhINtg7TpvcOmZm1ouHcVkjKk6zEEeNeWY6nO4yudTi3fchpTd2jAQqb7M+Nqsts4Yl7 iU8Hbk1kY75EEpSOU6r93DqrrMnxdh+0P0FaPzPHtty0hvs+DnUoYHaN0FJ8JZvzSoqy 3Q8c8fxts4s9EzUn+2U1k5GK3ykGZ9PNN1dkeb+A9fBG9SRLbEsFSjaOXJdyhkQ5EpFr 5OFDAMcBoiBF7XQQZ+WFPEM44Gcr2BZC20P7JgeRPoHbwD64VcWUoQXv3RdTO+wXTsYy iKYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A0dEd4NUNMrTRFFSR3+OfkYzmb9W3Zxpow0f09EOgls=; b=Q5UOMgfEZyujIcmhpFqMzFYir0wQlVrK+0yVRcA92wwKcrmxArsnZX0vI0cD1ektg0 M3hsebTW594JXozlT+E4L0Tw9wQeEm/aMNG2Fu8cyEb1/cJx6p/90vYWAzodKTZ5BlFV n0wBFcyCRBgmEB5V2q/nkpDXKpM/VBx5HP2kOEaeIQtyAhtbpYQbLof8akiyCPwEk13V J2EjS/rKJmUeoM48cckpaoW98I3r2vK45cV5JWQby2aYFN0najkKinMglpZUQBoI9JtI 7VC9vPjE00vpgIItYYZdmTg2pK8H19Gf8OSwnLnVXk2FeQjYyMEIyWYFomiX/ZmfZgOQ OXsQ== X-Gm-Message-State: AOAM533S5Z1U/Kia0LHDe+jnmbJT29P92HnJeO3eMfDsOstJGNZzE8Yz DISvZwfmX2LSUWtBvfMTclPEW98XALARGEYJ2xrtqA== X-Google-Smtp-Source: ABdhPJwXo576UKmIFQOkfOqX3ZmH0+6z5clVG1g8qmpwjGuMYibxp/UlYvMSX4DWWCcwuUAYtbcV6NZvvy1saRiJ69E= X-Received: by 2002:a05:6000:544:b0:20f:ca41:cc4c with SMTP id b4-20020a056000054400b0020fca41cc4cmr18728082wrf.582.1653510738811; Wed, 25 May 2022 13:32:18 -0700 (PDT) MIME-Version: 1.0 References: <20220518223815.809858-1-vaibhav@linux.ibm.com> <87zgjcg4xs.fsf@vajain21.in.ibm.com> In-Reply-To: From: Yosry Ahmed Date: Wed, 25 May 2022 13:31:42 -0700 Message-ID: Subject: Re: [PATCH] memcg: provide reclaim stats via 'memory.reclaim' To: Michal Hocko Cc: Johannes Weiner , Vaibhav Jain , Cgroups , linux-doc@vger.kernel.org, Linux Kernel Mailing List , Linux-MM , Tejun Heo , Zefan Li , Jonathan Corbet , Vladimir Davydov , Andrew Morton , "Aneesh Kumar K . V" , Shakeel Butt , David Rientjes Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E4F851C0047 X-Rspam-User: Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=s5IkQauZ; spf=pass (imf20.hostedemail.com: domain of yosryahmed@google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: uphqp7c6ry4sz8t58g4tuc97n1rsr597 X-HE-Tag: 1653510724-516934 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 25, 2022 at 1:59 AM Michal Hocko wrote: > > On Tue 24-05-22 12:01:01, Yosry Ahmed wrote: > > On Tue, May 24, 2022 at 4:45 AM Johannes Weiner wrote: > > > > > > On Mon, May 23, 2022 at 03:50:34PM -0700, Yosry Ahmed wrote: > > > > I think it might be useful to have a dedicated entry in memory.stat > > > > for proactively reclaimed memory. A case where this would be useful is > > > > tuning and evaluating userspace proactive reclaimers. For instance, if > > > > a userspace agent is asking the kernel to reclaim 100M, but it could > > > > only reclaim 10M, then most probably the proactive reclaimer is not > > > > using a good methodology to figure out how much memory do we need to > > > > reclaim. > > > > > > > > IMO this is more useful, and a superset of just reading the last > > > > reclaim request status through memory.reclaim (read stat before and > > > > after). > > > > > > +1 > > > > It might also be useful to have a breakdown of this by memory type: > > file, anon, or shrinkers. > > > > It would also fit in nicely with a potential type=file/anon/shrinker > > argument to memory.reclaim. Thoughts on this? > > Can we start simple and see what real usecases actually will need? Agreed. Let's start with a single proactively reclaimed memory stat and then add subcategories if/when needed. > -- > Michal Hocko > SUSE Labs