From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAFA8C48260 for ; Tue, 13 Feb 2024 08:27:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B3E38D0003; Tue, 13 Feb 2024 03:27:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 564F76B0093; Tue, 13 Feb 2024 03:27:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42DB88D0003; Tue, 13 Feb 2024 03:27:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3493F6B0092 for ; Tue, 13 Feb 2024 03:27:44 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 15F73A1FF1 for ; Tue, 13 Feb 2024 08:27:44 +0000 (UTC) X-FDA: 81786102048.09.E480CE1 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf14.hostedemail.com (Postfix) with ESMTP id 364C4100010 for ; Tue, 13 Feb 2024 08:27:41 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=rhRjJXxl; spf=pass (imf14.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707812862; a=rsa-sha256; cv=none; b=ljzbp6R98aIbVWGREuxkAy/Lh5q+MP3lv40SCj6Sei1ZItxVgrXFTvbJo+p2nKoTelrB/1 /ET6WdToj0NmQ2v2giZx6Gm5yo4HE4HU2vznyEpdpUFgedO5LZWe7/9YMUOtCb6TNUtZo2 EXHUX8/mCwRY03evEyrLc/se4Y4Cr/g= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=rhRjJXxl; spf=pass (imf14.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707812862; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y3WjgnS/0uTsTu5AkzuWUBzFFkJ7vB0n4CmWqXcol3k=; b=U94aTaQS2x27jEHopy2jQo6rzFzmVcFojyA0g+MoRar7S9CU0BKHKqESFBkJdG5fzNgncP 2FYGflou+dPVTyzMfkYi3aRCR9GFXj8AWxadwduZ4GCctKJBcLq9PzyfqcY6+XXgeRSK7I R7onRFXlzmIaC1+Zs6xr8xeDvyCuV/Q= Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a3be744df3fso415985766b.0 for ; Tue, 13 Feb 2024 00:27:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707812861; x=1708417661; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Y3WjgnS/0uTsTu5AkzuWUBzFFkJ7vB0n4CmWqXcol3k=; b=rhRjJXxlwglUgvH4KJr8Mq6khCM0JC+MNWdjtijm0giLM4hVLCZPg3nN/qBjBU2G0p 5RWyWn2r4aMviS1bz8PhKW6xDxXU0x1tiwMW6ZTpPaULzTgqjtzTPB0bqlqWKSox/5so s8CeiOAE4r69jMMntFhOTGElQVhLuOnjUDGAIVQTFWWixrchDuXsosnKlEQd5VB+Q01x iVNMGSgfy8ChG5CXb/Ak4gCHSlEtK8Jy7Hn2GbOZ67hdmSLQy/3nACmbfykE1CQ9I9yT 5GLU0M9uXFXIKq06AS+zAXqcGQtrY4Um9jMO4RhFY59LwKW65mgK74CKcMyZu2WvGCgK 8BuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707812861; x=1708417661; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y3WjgnS/0uTsTu5AkzuWUBzFFkJ7vB0n4CmWqXcol3k=; b=qwOvMv0M4drYhBsQdenwC67Uyp/ysyv8MLiXPHpbN4UkY0lmKDOXxeb2rGSde2vWA+ xnTqm4qKVAOnvVsF7vwdRFjFlQ3h0whhiXh4SsyyNe5UBYzrPahsvvxzr3/24sUy9cnj TtzCG5YVo6laVeA8qWRxt0FP5yruQhz0fhvRgl8ESYR8k0C0R5C4LHtiJ3Kg/TFQG8ne UKzxuC3pie/zMNlOe5k44mFRhxkTCUnRs4H10OLY3Hxl12zgWxetsfv+sd13YxXH1MQj s6trnQjY2oF1yQ9Ayi+dIQ1B0oZtvSJf1ucQYGgEdTW2xtvhWNWi6ZfqqZc7S8UkE2ir eHlQ== X-Forwarded-Encrypted: i=1; AJvYcCWrDxwktRD5cwpHEYp2Co/DPtAhhQ/1bSpoYqv4KkD9DHklq8gqWpzt46Ub7/ySq8vRrBpkJEpB+tSMBO4II8bMkxM= X-Gm-Message-State: AOJu0Yx6DOgzCy7IVid8IBVW8d9VzstPR5S7RruEiBKZ4fwG9tBR7s7P mbtkplda3lhcqUAdZg2CT/16QKRJgZy2Fb9HGcNjr6U6cJn/lObVL+4O9RRo/S9vQyacNj5YjAQ 84ft3UM9LSDcI11uT8PWTzQPWYdHmta7mG12IdCOqDwmpLCq0aAiX X-Google-Smtp-Source: AGHT+IEpPKmlPZxof8AsTwn9jt/MFHXveVQGOZhtEGSo4ujKvUnZwH+MVNrxmABkvpz0KA77x5vnpmGULh5jx2srlcM= X-Received: by 2002:a17:906:2290:b0:a3c:b7d3:386f with SMTP id p16-20020a170906229000b00a3cb7d3386fmr2724008eja.41.1707812860609; Tue, 13 Feb 2024 00:27:40 -0800 (PST) MIME-Version: 1.0 References: <20240213082601.GC3448692@cmpxchg.org> In-Reply-To: <20240213082601.GC3448692@cmpxchg.org> From: Yosry Ahmed Date: Tue, 13 Feb 2024 00:27:02 -0800 Message-ID: Subject: Re: swapaccount= commandline option To: Johannes Weiner Cc: Michal Hocko , Narcis Garcia , linux-mm@kvack.org, Roman Gushchin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 364C4100010 X-Stat-Signature: 6je9kb7j8iqmtyj8khg31gt9g759cqe8 X-Rspam-User: X-HE-Tag: 1707812861-873782 X-HE-Meta: U2FsdGVkX1+KT6oyZAK3nS2iu8CpBWekys15jaEI5DpTNSv1kVc6gSTvlal/iEtcyI9feU6g+ht5+AtkYiCFa6j6X+G0G1mF1q1R9mdrNkVmH1uB7SbyTErPDiIMakNO0UTnxtrNqYctvTln3oO4eWz58DylYYM90tpcA7oUHlIS9CZm6UGKkQuAcypsahYWtk9s7N5yT7qeaJH0nW7uuFAcR7viwcutocAch2Ns2r4JXY86yUDDJuglJxgzxXaXa2G14ej/mgilkn0gk/ql/A9ZzgEcaDvJTyl5S7iOjauRdeu8crlZ2eKw4bqDgU8wQFnZZWRCMDjgoCqBeAGZkOlSB7qV8zVTkkk26W3odyWehoIF3UEClacwWT1wyvPbVNjgwnUqag4zqIgMq4ydlaDPB799AiqtKrPf8glWPifAReyzKA132s4jDdfGe9yabsRGfPBezymS8LQZ1LWq0o4z5YeosMxm7fVs7qM5pWD3c26kBdRVPk2fwlA2l5zANRrM8GLzpFhNCdQmuJfqhX5whDVUsejzpTUKxPXvhVy8Mm7ooZ8h4SgK2niKl3+BzfLOTjeLAgek6trhz8wEAhrogRs+e965I0a7/1QpWy8zZxhk2E46FciXC1AZ+mMl27JmdEJcGqNuUL71Kk7YxbKtgk5XKXEgxKQ7tCFXVmwf2fCB10hwn/QYFaywRGV2/PNUUXQPte48xMt5WBZiR60/Z9nMieuuBdcIsW8++bXL4JTlZS9sCMXyMDEwI7FxImkTnpJclqL0gOwmzE2CRgMmLTKoSPr2mTqcCglflgtWK+b2hfvNGsNVLJwj8Yh7ishWFnYvjG9Ui0DlDJSKFqGNWLKx97u+TnqntrENYuwOkwVK10wepv8Yrr4ZXwfLVZvxIO5qOp826Y1KrMG6KxbiEPmZ+td/o/iSzDrA6CQnLojaH4sSlmNgocGVQu9yETJrzGagB5K8Ri9fQSe Qmj5SkMk +wZRBjHhkZ5neQzqBPJbqfehD6ZHel+0qBRyNnCIe/gustpQVlFkHAxI2MGOfUILvq6+kCRhtwSDSPrDgLyuFBT1qegNoLx11uB6TEqQp5wpXSUOuK6Ll7iHe7Y56CWdhzRYwBJmPoJLTsV4dy9ij9NvgpuW1FWBPL4EZVaOVRqLi8YzrzK0jJJvMaQ9U7ZCX2Snn0VJ1YQfKccWIgD5L1CTIBsAk+kKX/nOpBaOKbJmSOg6QZKhaOeaKCI5uePIM7Sd5+2FsRzdfy/Vq3DRwDUJjc5r0dOjwoBZ2LU0cjpLGCT6aowgSEgeNb2gzoTisexSnVs+iAZUi94Myn/jGfvS9cCw22l/4Gld6y1Pr4eWj08scOnk3pKaRemmT1VFQQv6cgAp0hmaaK11KJ1OymhClOqccpBSMxar23maMT8dAGfVpG2IiTAR47nluhebZqWbA6wyZX1PZWpfsRyPoqrU7YMce8PItXC7i1mn1fmw5nvqOl5msVoG5iRv3HFhGdFsMdjILKkpCwV4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 13, 2024 at 12:26=E2=80=AFAM Johannes Weiner wrote: > > On Tue, Feb 13, 2024 at 12:09:26AM -0800, Yosry Ahmed wrote: > > On Tue, Feb 13, 2024 at 12:06=E2=80=AFAM Michal Hocko = wrote: > > > > > > On Tue 13-02-24 08:01:37, Narcis Garcia wrote: > > > > El 12/2/24 a les 23:37, Yosry Ahmed ha escrit: > > > > > On Sun, Feb 11, 2024 at 1:33=E2=80=AFAM Narcis Garcia wrote: > > > > > > > > > > > > Hello, > > > > > > > > > > > > I read this warning on Linux 6.1 boot: > > > > > > The swapaccount=3D commandline option is deprecated. Please rep= ort your > > > > > > usecase to linux-mm@kvack.org if you depend on this functionali= ty. > > > > > > > > > > > > And I want to know if this impacts on LinuX Containers (LXC) sw= ap > > > > > > accounting. > > > > > > > > > > swapaccount=3D was deprecated in the sense that it is always on n= ow > > > > > (i.e. you cannot do swapaccount=3D0 anymore). I believe you are u= sing > > > > > swapaccount=3D1 and want to make sure that swap accounting will s= till > > > > > work with v6.1, right? > > > > > > > > > > This is the second question we have had about this message [1]. I > > > > > think we need to clarify the warning (and perhaps backport to sta= ble > > > > > kernels). > > > > > > > > > > [1]https://lore.kernel.org/linux-mm/2593755.Xrv9ptJ69j@sinistra.l= ocal/ > > > > > > > > > > > > Thank you for answering this question, and sure this clarification = is needed > > > > both in documentation and warning message. > > > > I've found deprecation message was commited on 26 Sep 2022. > > > > From what Linux version release, this deprecation is included? > > > > > > > > I suggest this for setup_swap_account() code: > > > > pr_warn_once("The swapaccount=3D commandline option is deprecated. = " > > > > "Swap accounting is always on. " > > > > "Please report your usecase to linux-mm@kvack.org if you " > > > > "depend on this functionality.\n"); > > > > > > Would it make more sense to warn only if somebody tries to disable th= e > > > swap accounting? > > > --- > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > > index e4c8735e7c85..dec75eedf634 100644 > > > --- a/mm/memcontrol.c > > > +++ b/mm/memcontrol.c > > > @@ -7936,7 +7936,10 @@ bool mem_cgroup_swap_full(struct folio *folio) > > > > > > static int __init setup_swap_account(char *s) > > > { > > > - pr_warn_once("The swapaccount=3D commandline option is deprec= ated. " > > > + bool res; > > > + > > > + if (kstrtobool(s, &res) || !res) > > > + pr_warn_once("The swapaccount=3D commandline option i= s deprecated. " > > > "Please report your usecase to linux-mm@kvack.or= g if you " > > > "depend on this functionality.\n"); > > > return 1; > > > -- > > > > Yes, this makes sense to me, but I still think explicitly specifying > > that swap accounting is always on now would make things even clearer. > > I think it's okay if it only warns when somebody requests disabling, > since the confusion won't happen anymore for folks still explicitly > requesting the enablement. I did add a blurb about what the preferred > method to control swap behavior is, though. You did s/swapaccount=3D/swapaccount=3D0/g, and I think that's good enough.