From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5851C67861 for ; Wed, 10 Apr 2024 00:53:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF27D6B0082; Tue, 9 Apr 2024 20:53:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA24D6B0083; Tue, 9 Apr 2024 20:53:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C69C66B0085; Tue, 9 Apr 2024 20:53:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A98816B0082 for ; Tue, 9 Apr 2024 20:53:41 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0C7381C08A1 for ; Wed, 10 Apr 2024 00:53:41 +0000 (UTC) X-FDA: 81991799442.04.E7C93A7 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf21.hostedemail.com (Postfix) with ESMTP id 364061C0002 for ; Wed, 10 Apr 2024 00:53:38 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Iu9939D6; spf=pass (imf21.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712710419; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4w30RNt2IfMUjklfvgDmalvXrZsyb0372fw4oVHKjSk=; b=CEPPYTfgPDf+Lhszz2C8hUOWm3NQKEQFyLnlYzoWj1JaUd+0/Fzg0TNpsxA5edv1XOfArw RuPHKinKHbZkUNctIRoMrVpjS0nKy7iPFwI/btCRjYoG8w8/Ek2SVXl+YG6F0TW/rqqNrv AG0DcD1byDdnnsqLaE56VA/D0gRh0nk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712710419; a=rsa-sha256; cv=none; b=hI6lSQQUUMaT8ICGjCR13g9usdhBIlDZfClIlKfVj8Q6dVQAFs2hUiiJA59q+9nOQ78nL7 sidUgQhU3sDqcmIV2wkFbOrIVREw+PXwTj3PEsHqY5bTXRaeorsDzqNnxc5TGnjc0AZLLJ +xpJFgE4SGJTpheUZhNqMh0PYw0fuiQ= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Iu9939D6; spf=pass (imf21.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a5199906493so621710766b.1 for ; Tue, 09 Apr 2024 17:53:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712710417; x=1713315217; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4w30RNt2IfMUjklfvgDmalvXrZsyb0372fw4oVHKjSk=; b=Iu9939D6nRFPcN2oazdsoATcw1OIqIc83pRgbvH4v6H6L64fsKOAIAAOnf8qRqz/9c W1Oo/N0NT6dSZfZ0P0iIiyAKOne1j53HZEyEcTsKEWg1u5lwIdNzuhbZp55IJRrC1dYE K8hJHMPl2XHGNTgp2iq8jBXwz9GGWs1/IPwKUYlT48V+/e6mi7xd1G6l9lD00ThDSl4X hwEZ+7rXAkMu9Sx7qz/WGGZeycdyJaKfqMyIfatCPPf0XHN8fux4SVd4h0Grw5QNw8wg nBk8J4HkpjbEn3aQxL7/8Q/cG3zs9ibcrrVOG7XfLn9f6w5e9OZXy/IWJQC4fKf0zipY dmIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712710417; x=1713315217; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4w30RNt2IfMUjklfvgDmalvXrZsyb0372fw4oVHKjSk=; b=bilx6cnmCbHUvdWR9tUE2lLs/AbK3GIeV3sCyUbFvP/zZ1bcwmvGfi1PabZmHDI/Bl 2Kw2v5gv4jqIC0GJp04uxLUp0QDAzqOE2WdqyW0M7i7dt6qH13gUIdNhcTjL4EHzYGoo XR/9+tMObyqoa+oQ7HAeyc5mav0HRsHgMgDrkET2vHnaZI0bfkK8B7PYmiGmJNedPbt9 O1tQSMNUqLMO+waz9Qc3Dn4BtLefC0RfH6RhCJJYgcqHLnB4JnV6qotNJzH4/SOgGkOw y320V4JMVITQSY7WxrxmQ6Hu04Xqm2E4khc99NV53O5d8YukahXHWJQ2UXiKrRxF2AT4 oBCw== X-Forwarded-Encrypted: i=1; AJvYcCUb0T4DpvasBR1MZhpu6y8kJpz8Gmt9VzTgrbjvIbnZeMKx7DZwQdND5LzTjYhUsO7LK6UBv7eajPOrtxBa9wh1ick= X-Gm-Message-State: AOJu0YwAUhWaWwsxfhk4TFkVHyeR3iokh2HCfwFu8Q80wyW0PACqZwca ZVEQUkDdCBUuMoaxowUcCcJRKDrYhPNdzRgC3RK1S3zWWFzzLDVGsci0vKB1gfC8HjWu3JpEl+q H/WwOJn7YwLh4xtmwekOfGBnv5XOcCGOtaeMN X-Google-Smtp-Source: AGHT+IHBqwcvOxXjgiQrSE/ABnznnh1jLedaXxfgvV158OwPm76B04H0EpVDwJZVCI9ikofDJN7iePX8BSDXHJIyAJk= X-Received: by 2002:a17:907:20ec:b0:a51:deec:483c with SMTP id rh12-20020a17090720ec00b00a51deec483cmr557352ejb.6.1712710417418; Tue, 09 Apr 2024 17:53:37 -0700 (PDT) MIME-Version: 1.0 References: <20240405053510.1948982-1-yosryahmed@google.com> <20240405053510.1948982-3-yosryahmed@google.com> <20240405152619.GA866431@cmpxchg.org> <7aec7b98-db81-4238-bdd6-afb69679f852@redhat.com> <69dcd33b-e8de-4927-93dd-d4ea22834a18@redhat.com> In-Reply-To: <69dcd33b-e8de-4927-93dd-d4ea22834a18@redhat.com> From: Yosry Ahmed Date: Tue, 9 Apr 2024 17:52:59 -0700 Message-ID: Subject: Re: [PATCH v2 2/5] mm: zswap: calculate limits only when updated To: David Hildenbrand Cc: Johannes Weiner , Andrew Morton , Nhat Pham , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: f5qk87yhtgcgswqm19z3xmwswsm6pr15 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 364061C0002 X-Rspam-User: X-HE-Tag: 1712710418-320509 X-HE-Meta: U2FsdGVkX18ENOGMABL/izhcoum2BB0+Q1IADgiXSBjLobafB9Zx4HDqVCdpkZGcTCesGOHenN/aESIpx8S+ShaS0hcVl0a/tMAMQYHddEos4rOhITTbBQLWjFYTH26Sw81sEyrwxAmm+jmIzIn21T0BENcjCBdHTj1KmBFGPm3YarCIBYRU+EPQUMkoXc4eOZlGtW2euvb88hrAn0U5MaUrFyZ0E7mowi4GEDbMZs7XvZKwIjsNHJyZ516zcHr/M2Lew7il8E38fcVBhAXJnmS0V8G0D8f+tcnw4FUWu5rrLniELFKaNdW8oqv94sHi2GsxpMHe5dN1ICE0STJfhpg1OhcTGPFfi+bIcJua/yrFTLNPsNPPjJ+2I+rgU/8BgYHZvc964HUBKHxS9sCxMNyqkO9xLHcnL6bHtZqnVm0rN/nNC35ZclGeDIy6ugk62X5cCitaWOfHiaFkbtpfWtXWtE9oPhgb6g6RVU6qqRaYyI+TIDwl7lroCXyiQqBm19P/XwfVhoGZ8gFGILvCz6mEP2IOzEm7Sb17mUJ9rG0yl3s30KgD+3yUU724v7xAh+6XmPLQFM4eharwXsShf1k1MuPg7rNRjrRtaqku6UWj7FJEyWBD6ul+nEEfyh+Bq6Ytr7/ZP86G18692eSqq7C0bzYSzPzKbiDNfQ4vIai/TtgeATOJl940mkvgrRlweuEXXi+thgw9wtJYzgU1XkauK8WoK291uYab7U9obm+wznyKn9AHiZgsn+LYYyH06Tj+h+l9xx2B3JrHAJmlw0Sa14KHkNUjFkYLLxrr0YHaZb/2+CjDlapgEhlOsbedbwz9xs+lSZLIv8nMTzfvjsD19xIbxZ5Rm5Pc1vQyDDLj2843o0b2n36B2/EXAap8QJQl+g3dbiJ3DtcknKqRqIZaaUlIz8dC5BTaKJC8nAG/hPD625pc8x5/o9ZGPr9bCC1xi4q/NPQJNAV6cR0 tUhfcXdS TFrJuXRhYdMvhq1LKYiEVax73rijSTs1PdgBSfW2l0qilb2uJ2kc5IAP7jCs9W2m3laKLaz2WSyjUm5bL2f/Sln/zkKMn8+xZ0Al/cKETCtfbruWR/hsYElYUp+LL2SvIritc/roSOoH1rAitRR7GsbA1kkQW5E7J9VTSwj0ndCHDHqBkK13gEdUqMwC2igeBFzilCAjWG2teiUvrk8/k/WCFy92CBzAuj4dF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: [..] > > Do we need a separate notifier chain for totalram_pages() updates? > > Good question. I actually might have the requirement to notify some arch > code (s390x) from virtio-mem when fake adding/removing memory, and > already wondered how to best wire that up. > > Maybe we can squeeze that into the existing notifier chain, but needs a > bit of thought. Do you mean by adding new actions (e.g. MEM_FAKE_ONLINE, MEM_FAKE_OFFLINE), or by reusing the existing actions (MEM_ONLINE, MEM_OFFLINE, etc). New actions mean minimal impact to existing notifiers, but it may make more sense to reuse MEM_ONLINE and MEM_OFFLINE to have generic actions that mean "memory increased" and "memory decreased". I suppose we can add new actions and then separately (and probably incrementally) audit existing notifiers to check if they want to handle the new actions as well. Another consideration is that apparently some ballooning drivers also register notifiers, so we need to make sure there is no possibility of deadlock/recursion.