From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B846FEB64DD for ; Tue, 25 Jul 2023 19:25:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00AA96B0071; Tue, 25 Jul 2023 15:25:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EFDBB6B0074; Tue, 25 Jul 2023 15:25:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC59E6B0075; Tue, 25 Jul 2023 15:25:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C3D736B0071 for ; Tue, 25 Jul 2023 15:25:43 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6ED76160EEB for ; Tue, 25 Jul 2023 19:25:43 +0000 (UTC) X-FDA: 81051113766.22.60BBF02 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf19.hostedemail.com (Postfix) with ESMTP id 77B1C1A0016 for ; Tue, 25 Jul 2023 19:25:41 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=k0n6UJsh; spf=pass (imf19.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690313141; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gccFtzx/Ez7hMBziN2qyyxk5R7pKLnaq2lGrOQwbiIg=; b=UIsG3W4k7bnL0Of0GugKW6v6xeJrEHIOOJclTlHkm9IFwYXlrhy8PWKQAhgv1BLKHCXWtn 0fFzjWuUGcbA7dNmBc9mKg9micv/LCzshalwiP0Vz5FxR9bf1fWS/i98ijocVfP8XngwQp MdBpx4DWHg3wzR3WSXh3NVEpBz0JaUw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690313141; a=rsa-sha256; cv=none; b=wwSyz0XZr11q5u2KvBb2W/tZnEEJrD17vN4sr/QFgRo5ay5XbJ/GpINzKo4YdDFgpH8H4I CyE5zJlrUn/LuGo0YznvAkdlKfguphmFbyRroh7wyaadjQ4ZFYkxlZkrzia0BEoKVe9raN faFCRGrNaOXyExqYQC16V3Nl7n3ldvQ= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=k0n6UJsh; spf=pass (imf19.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-991ef0b464cso43918466b.0 for ; Tue, 25 Jul 2023 12:25:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690313140; x=1690917940; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gccFtzx/Ez7hMBziN2qyyxk5R7pKLnaq2lGrOQwbiIg=; b=k0n6UJsh+lZ+hTFQLHMj4us4wXltqc2G5v/vYmRmdyhuGwj/r3CqrJQDQxYE7M80HV wCdCAHYMJw9hGgaxndA5Yw5povenCAxQCF3buKcM3DMGQeQ/QkKeRqwsSoWAxirUzBFu UkmK/vSMxzsFGgwBVpCUK57IAtboaemAE7ebrGWETSgDp9xmV0NDxqEsx/W/U8ADDfcD 5HNiz8T5RsSwulHQJVJMRYhWuv5n78tVzHmeurEiseDIKMSTADQIF9p6LCbuFCjM3uuJ O3Lp/YaO+gnCWAMU/TpQ63dzghPVFrKFG0NlQ7eRmy7GbIg85NO/vUpytbZsiSXE3FIh M8/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690313140; x=1690917940; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gccFtzx/Ez7hMBziN2qyyxk5R7pKLnaq2lGrOQwbiIg=; b=MuApq+3gnUmk6dKH6GZL+eNEQZLQAC8VIxCXXszCGUEIbSoMLmLUKlAkuykQ5pfm4y 3caaQNlsovfpjgwQky8R3dhNDyw/cBwedWwrWBW+vE1IwzLuTE+NLVkLJq2dAg/ThIyX 7sXlMPN3AwCQ5+rBYZRSEPIG11+PIMxJHtOKp4Hh25MxoXEsq7TSEbZk+RtLZpU0sMOZ sQJikaCWRDuaDo0TAdtsvNVyboz16uHUW9dnP0pCI27/6QPSaVXClGEkUqyzh5yVCJ5b n4110i3xXWiJdrz4eKx3hyeCiYyquWEwt+TuAUF97zU3w4yBPcNwju7IqwktNxRqu6PF mohA== X-Gm-Message-State: ABy/qLZqAH9QGrUUBXodX8aiZhUb0Ti1fqA+ogtm7D4TlJtZghrkV2Ko sYMcIe7IOoJa77+pRdRaDzQDToWMXbVUexnFOFfktw== X-Google-Smtp-Source: APBJJlE6Jp+9TcsoE2xrGcMb1FH46ep2aSbVKNupu8UWDV9Qk1Z8PkQDoSfBqm9P+BjxfgtQ/hDihq7yHn7I8gjHqik= X-Received: by 2002:a17:907:1624:b0:978:2b56:d76e with SMTP id hb36-20020a170907162400b009782b56d76emr3811521ejc.12.1690313139847; Tue, 25 Jul 2023 12:25:39 -0700 (PDT) MIME-Version: 1.0 References: <20230719174613.3062124-1-yosryahmed@google.com> <20230725140435.GB1146582@cmpxchg.org> <20230725104310.ac652a03ab92357a162b1f92@linux-foundation.org> In-Reply-To: <20230725104310.ac652a03ab92357a162b1f92@linux-foundation.org> From: Yosry Ahmed Date: Tue, 25 Jul 2023 12:25:03 -0700 Message-ID: Subject: Re: [PATCH] mm: memcg: use rstat for non-hierarchical stats To: Andrew Morton Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 77B1C1A0016 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: n7j4sqsiru4ftya4qkst5mb37qqdxzsp X-HE-Tag: 1690313141-249572 X-HE-Meta: U2FsdGVkX1//8vMcVRmCpOdkmkJ5QSKoKWLEW6acFbcQIlgt8rQHfdteK7lt767c1p78vp6NTBk4iPm/43dKjC2g6Xaggde8OachuTV5gpeMeAwwysjxHsnXAu55+OluDmV+0lXB78XiaHjR5zDMPbm7EUTEg7igHIE+b+2hI2cJEcQrRszgJtHe0r0CkGu0DuU8RnvfWvJxth5fuSnwvBnTZ4Wy1yjsNWjr95YU7VGx2Z0kb4AGgamoot5yrA5OPveX6da1kEucBvB6SLdMDb2ZkujQGv7t/PN5RArexNea1iY4I8wuhTGc97yceh9GHwJn26EDLXeoy/hGHgKPiXu8iYzsHJ31XIPgFjSiQWNp0L9S/Y+Ts60xSDEQvPvefSwrAgI9woQtM2E54MBsyfkSIOcYWdGvyV8QecFP29itxwwUbGjWpmU31mUsNyaFuUKEzZtNV7tTje9n7iSPlpbQrckqbqEgfPuh+Z/1LoY/EGsgFTTFGywGaS4NI7DMlxv6Vjcu98Ykuf+Bp3mQZq1B1ySJ08r6yCXSgqCdK2ACHARjpw0oaOFfY7b1Tzg6BHnvk7Q60uf5ZHWSIu/xqt+4uvS1rzBOrfWxL8L4qpLz39V9sV2F3F/hmT441GMmYxCoKjRQgB8XfnDj83ikiaFyEWZIl08rIKhwMevCWt609ml1kEJoh/EBeSXiPBB3MAYJI6K7z7In+FiDm66d6oTskRSKZGFLw1slKchV37arJho3bY6MxsSt3udFvkgDQSY1aaCu2LynTimfn6yLO0ytjUSqpC4DMmluIAXiumuutUQIadm4xcCQX3E30nFMqYY73980+lL7uF0Ubp+VS6H8woYTsEcH5QHVHgjaFz7g1wQJRJ3RyjRjWiNs6r4299CvxVoVa/WGRXe4hdwIxIa2n8JfLZ65+k1iZ7h2MLBbQOWvn3cf3ZRm6kHKaNl5Sr26nzW/Nc2bYuwaowu Vnc5PEnt Ag1g3CRMcYwyGBs82fsQ5FDP5EHCemddFsf/OwBBrjzqWydwwr9h5If1CbYpKU6fbLRMHLefMdXR0qLQFd0RiguUdEbMEWdWwVTQxtojBA6q6Dh4+G52hutKwiq07SxXOibXNpBvzaLcdydjUY/hWxSjsNP/4XH8+UjOxlYlW/V4oYUt8uE02jywAkoOhu2pJXKf8Q013u9ROgRtXy2srpkES18hapze/pMPRGww+b4hu9Q3fm1HmyTFjs3xlUbLgAQid4KuhYcDM2DoW59HQUjJw8PJ4YFxmhmPeq4rKDH/Dp2Ro4Sc6dZyBtsyTb5hbbVvcMebrbTU0XtDqM1tVpwT4XL/5Sp0cyscGeDIb5x5JOQ8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 25, 2023 at 10:43=E2=80=AFAM Andrew Morton wrote: > > On Tue, 25 Jul 2023 10:04:35 -0400 Johannes Weiner w= rote: > > > > Signed-off-by: Yosry Ahmed > > > > Acked-by: Johannes Weiner > > > > But I want to be clear: this isn't a regression fix. It's a new > > performance optimization for the deprecated cgroup1 code. And it comes > > at the cost of higher memory footprint for both cgroup1 AND cgroup2. > > Thanks. > > Yosry, could you please send along a suitably modified changelog? I will send a v2 once we agree on the history story and whether or not this fixes a regression. Thanks!