From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B31A0C4345F for ; Tue, 30 Apr 2024 08:34:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47DB36B0088; Tue, 30 Apr 2024 04:34:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 42C926B0089; Tue, 30 Apr 2024 04:34:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CD5D6B008A; Tue, 30 Apr 2024 04:34:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0E5D06B0088 for ; Tue, 30 Apr 2024 04:34:50 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 74A561602A7 for ; Tue, 30 Apr 2024 08:34:49 +0000 (UTC) X-FDA: 82065537498.28.2FE090B Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf15.hostedemail.com (Postfix) with ESMTP id A4206A0017 for ; Tue, 30 Apr 2024 08:34:47 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=o1zTZkBp; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714466087; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aBu8BqMTHMfO28FxxomfhI3ilqxqETOIjPW5gQNZKVM=; b=Nfw3S0vueo8ibmmFEdtIWc3zr6HbP3jcfHR32uQkbfZ2Ae5CLCTWEv2jA1h+DWSfkwYh7V D22JMRP036REcYdHa8VL4nf4l3f8P3TBENTmwatgGVdTvywj1IE0ssnRYJfTJ9KRTcZ+8n eWxEiYYJe83pxfBwuv+coodRgpsIEFw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714466087; a=rsa-sha256; cv=none; b=6qFPgz0a9dc2S9QMQtXDYHUiRZWZU6m3k361vsHf1kQ3T2o9O2I6jWqkyV127yuUKMsgq8 YxbxYflLmaBZoa4jqRw1mtENs9/TIwc4NTVSfSFUXJykbTvX6cQfqa/zad4gDlbyY3G+iR 4WM7Z979nTwUtMm9tGqeFSdJsXdwWrQ= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=o1zTZkBp; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=yosryahmed@google.com Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a587831809eso641503566b.1 for ; Tue, 30 Apr 2024 01:34:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1714466086; x=1715070886; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=aBu8BqMTHMfO28FxxomfhI3ilqxqETOIjPW5gQNZKVM=; b=o1zTZkBp0p6uU/M6EWw2i6NPwVyDBDbyCXB+6yAJsZsihMgB+v8KZ6UAW1etjEDcZE S9eFJcBme6pd/wPZzA2c32XtZOObl6UoWZhp/zo8vffnH5CFwZC5Cw5OHRGj77B4PhB6 cDf2a9+9fbi9OKj2MLGGgMrh65zXOPB3yWdbGXQlAF5j+tEE0vgnsquVo53mBmcTC4Yg SoyLP1lShvlpzVx4v0tvEPafTMwiJkj/3tUvHLu3JF7xSHPyMnJM4s/y8OFy0lGkl6kq ICFxZkofkueS7d/38o/aZXx22JdtCqfcfrhtqrqcrZUp8F2gOhhZ0jm4EcAXP2CiV42h oEDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714466086; x=1715070886; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aBu8BqMTHMfO28FxxomfhI3ilqxqETOIjPW5gQNZKVM=; b=p9jKYnj9cQ3Leh2hzSQqzlF9X7L1mzFtB4bx+C0MrxqnQWMcyXhb1cPq9T2n6VbJK9 mDV8h7cL+yRVGhLejNdwgBaF/ig2gWWdcfZilKklxJAwyGZrA7tY5EXgrWWQ2uZBdArf YeGI0UG4CFP5Xe0ZEL4YWZgwpfF004NPux3asjiy+iVXV1BY11fI19F53ir3glaca4hM 2rIOf6L0eCJI8RlgLsGSnnUFd4o+h3JdPLOS5El7SXHP8T3IHOF46Cbi08T/iKKV9ufx rbSTBOSoX0iTflVnb2P7V+z0T4GCetTqjBvRg5S8cKkQFxPZBdV32NCV7Q2Z3YMgkxqJ s0Xg== X-Forwarded-Encrypted: i=1; AJvYcCXJwfFrkcG3Boh+sXqK4FXBy3RW0HWhuLhAYXk+uYoTxEl4eDUxCdRJdwlVmSRTzOGbK8iHcAEXZVMBdc6kPwoUjVI= X-Gm-Message-State: AOJu0YxkPl4rzoouHzKi7iE35iGQwOfsnPeimidERmwGP2qKZI5YWhAr LiTTa6DaIi/cAbP0/foKkchOnPeb61qUtcFkDcA965j00HNwQLqXR9wX3tH5dCFW00dKeqglYLd FfPNb7cY21FqoF6OVwOmd/DdGCs4ILcYWwDZi X-Google-Smtp-Source: AGHT+IG9FviPkvXS5CMDFsIMeJxQdptXNvUHM9jcQby2d5RwfDkT3fUJ6oWeWv1yGvKqNb+hyZ/tP8fW9+HefgCbVAU= X-Received: by 2002:a17:906:e2c5:b0:a55:2e77:c718 with SMTP id gr5-20020a170906e2c500b00a552e77c718mr8516330ejb.54.1714466086036; Tue, 30 Apr 2024 01:34:46 -0700 (PDT) MIME-Version: 1.0 References: <20240430060612.2171650-1-shakeel.butt@linux.dev> <20240430060612.2171650-4-shakeel.butt@linux.dev> In-Reply-To: <20240430060612.2171650-4-shakeel.butt@linux.dev> From: Yosry Ahmed Date: Tue, 30 Apr 2024 01:34:10 -0700 Message-ID: Subject: Re: [PATCH v3 3/8] mm: memcg: account memory used for memcg vmstats and lruvec stats To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , "T . J . Mercier" , kernel-team@meta.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: A4206A0017 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: quk4whgtjrgcn7ddujeanyxdyb6m9fuk X-HE-Tag: 1714466087-874696 X-HE-Meta: U2FsdGVkX18T9m/4rC8A2vyWCDsNtP3BhP5MbiU52PBIX255pBdoj6mi10xjQyIBXTDDHZiw0hVg2INeQz0diJ2BWMB/My4ERPpUCnk1pyxPN/NF1tMd+7mdXOGN5AsNShEtf3cQS3C6zsoPx1MW9ns3Ag2JhIVv1a8ZCOS6O2vhbvXkyvysch4wHRFIuXM2MvjHlEhjozf1h1vcEQBvMTLUW4mt3MXhaPhVtawkPoGirnH7SNmWZw8gweVykezDqc1s+sc9/LaELdFx6ow3zGUVLfmHwhWFHBUIRiRs8GyTb019xeE4TCA+YEb9aI/wdCqgaYGPUYKV5NW/jSv4tKMzLwMtkRrZUZcjDKpoY0ZFyg3pjF+Z1jv/7mAoukIDn46sWsl1BGec43amnMToP2Lc88hvDfQoOT7cn59IZThupzGNQWoWCv6+OlIjd1ACz5Yy8hmsG+O/Z6mZQGMu00DvudV5T1p5SRjQ4Zcy41DuN3jgyYg2BY4O6mLmmNlYSQMaW/YeuCFtK0FDw3ATpyynePcJHBQPSz0+JWl1+CQsi7ZTzGwd60FDSNUFc1GOaRGIb5uVvmWth6tgx/N5SVIx5gOpBp+xfGAx2CgQ/bgFufAMP+KYFFfosB6Q0ag5grjge61+dk/nv/kLQHZ+tyiTmfIsqwE4RnUVjhvF7SxKmccFttm9VIs8vNwy32MvW4dYEf85L5qTTvKBJNX3Yhwg3QSBRJ80EfEA463GjywPRoeiBdkl04jAPMrcvt9KQtjf7Vr9XBNR9wEmQUkBv8ZvCoXS8Kep3/gLu2VefD0ADkolOSs+k6/Zd6JBZoXl3gSgGn71wRQjk17UQWwzszndN5alO1D9wPt3WKoAFyzd/3PZtM6zns2kmf6Opu6htaWng16Rpzre+atT793TsSvNP0xsrnKRSjUseBcbH6YbVdU/PQwPxRJbAFJcATcdXB/IA90tBLhHFp+SqT/ OcDJNbG4 cKLqDNRFby99Nw3W2p/gylqw5e66xsUpaJnrY7IMRHG7zVPNxSjVNXL6JiXa9ahGsM+58Flj8UGnQN4gidKm17GzfuVyAjbwn8Dg4wdlr3AATgS/8jYP13v8e7rWZewR4HaQPUIEQ7StkPyjrjI1v62dEvH5CHj6WfnKdhd2SCuXT+Pr2T2O7bmVNHXGJ3ZtXQ1p7tkliJdsIKq9YWem+HleQoeIOv655B+Ngl3ifrCuQt3NKIRqVhWUI3E5A/9uNk+j89YC135VizrwiTDyYyt9N8fjuEer3bTdO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000017, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 29, 2024 at 11:06=E2=80=AFPM Shakeel Butt wrote: > > From: Roman Gushchin > > The percpu memory used by memcg's memory statistics is already accounted. > For consistency, let's enable accounting for vmstats and lruvec stats > as well. > > Signed-off-by: Roman Gushchin > Signed-off-by: Shakeel Butt Reviewed-by: Yosry Ahmed > --- > mm/memcontrol.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 7126459ec56a..434cff91b65e 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -5545,8 +5545,8 @@ static int alloc_mem_cgroup_per_node_info(struct me= m_cgroup *memcg, int node) > if (!pn) > return 1; > > - pn->lruvec_stats =3D kzalloc_node(sizeof(struct lruvec_stats), GF= P_KERNEL, > - node); > + pn->lruvec_stats =3D kzalloc_node(sizeof(struct lruvec_stats), > + GFP_KERNEL_ACCOUNT, node); > if (!pn->lruvec_stats) > goto fail; > > @@ -5617,7 +5617,8 @@ static struct mem_cgroup *mem_cgroup_alloc(struct m= em_cgroup *parent) > goto fail; > } > > - memcg->vmstats =3D kzalloc(sizeof(struct memcg_vmstats), GFP_KERN= EL); > + memcg->vmstats =3D kzalloc(sizeof(struct memcg_vmstats), > + GFP_KERNEL_ACCOUNT); > if (!memcg->vmstats) > goto fail; > > -- > 2.43.0 >