From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BAFDC54798 for ; Fri, 23 Feb 2024 04:47:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7E7B6B007E; Thu, 22 Feb 2024 23:47:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D2EE76B0080; Thu, 22 Feb 2024 23:47:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF6D16B0081; Thu, 22 Feb 2024 23:47:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id ACAEA6B007E for ; Thu, 22 Feb 2024 23:47:00 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7BB1C1C1220 for ; Fri, 23 Feb 2024 04:47:00 +0000 (UTC) X-FDA: 81821833800.02.9F4F997 Received: from mail-ua1-f41.google.com (mail-ua1-f41.google.com [209.85.222.41]) by imf14.hostedemail.com (Postfix) with ESMTP id A7D5D100005 for ; Fri, 23 Feb 2024 04:46:58 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Vj9R1aew; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of yosryahmed@google.com designates 209.85.222.41 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708663618; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=98SsXJdzO2/QYlzrGwJU+VOpHGdjqBT3Ywfctx81eYA=; b=mdmDmXVagSrAY8v7tvWQq223OlnV52hLnBE4yVPjjEH2NX7Z0/2AyqHAdx3eBpc1sRrN7M 3tW4MtDDNv8NK7wFici0z8dK6MUlMke5FwTNvfBL7/L4BebcrKZrHotathnEIHd2lcMWii qs53ohwKi7MLqiBTekuch2J6ZiKyALU= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Vj9R1aew; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of yosryahmed@google.com designates 209.85.222.41 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708663618; a=rsa-sha256; cv=none; b=X3F7kM2SR0RjEPWEuqFcccmnLNHzP9jQffVCUgjZSNCc24fnXhRLgYFCvQXCJT5dkbwvf8 DD494kpsTY1dgynloOtrKnz5mBVzJk+I5AdwNH95nEY1Zwq5i/7HHDw0m9gG1bIpoGAB2n f/O0Qfw2hHsq+QsoJiG/nUeUfIxfTvo= Received: by mail-ua1-f41.google.com with SMTP id a1e0cc1a2514c-7d5bbbe57b9so226116241.3 for ; Thu, 22 Feb 2024 20:46:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708663617; x=1709268417; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=98SsXJdzO2/QYlzrGwJU+VOpHGdjqBT3Ywfctx81eYA=; b=Vj9R1aew+TbbfxKJ8H1o6+X9eAC5dNlG0vrrBKQ+u8VdT7+NegG3bLmw38L01h93Yl ulEDVjnH3z8vbHsDUOcIbRPIVQSSzp1BVlprtVum+9GST9aa5CbIc3HX7QhZkEhRuFr0 2LR9XK9egmJBbHAzPB/LG8b5EegDJI4lFK74TMCTGGXdBQJusU/Ol+WVCDhEZtTrhF6j NUnLZnPCS8ZOhRsP3XBpP4ubVYHQp+IqVwoHAlI4N63C5aonCBwoNEGlcMGvg7KJxh4j riPDL4LYN/sYOztTgrkgXcXzE1ZJVKw3/6A5QjfSFFoGi3l8Y0186GKv6hBqdxKRbtgJ 9gXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708663617; x=1709268417; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=98SsXJdzO2/QYlzrGwJU+VOpHGdjqBT3Ywfctx81eYA=; b=iudBXfcbPxgxKcwtqCaV3HObp1d6FRGqlQqfsoke743vFuS4YRn4/hqvK7sc9ZMaNn WKqgooa66uTQNqjNJd5kF7SindUedqKBbC24tZj1thK/sbmX+3DSOA6PJubXwLWLtKF2 6nosXpVhU06GfsGGQxcLR1VpKpPceei8ueW/H+YXyLwxoltDf/Jr0jSgWdkQuVaY1S9G c0qADb1kheOCNL+6YY/f8eyeqlqeXFJV2FZYaa2YmSa56+EOwl9V/xxqLawltst9D3fF b61aQ0B5SEsrsWAlvDCzU+GuCWO0sAkG7m4n3sHjwQ66AEC5y7YhLTgl9FKXPRpENrOO bStw== X-Forwarded-Encrypted: i=1; AJvYcCVGKhl0e6IHJZ4l/h8FG5MlGwkRgJTAF2XpvUa9Dv6dgYiPXDrRUkBchUB+FpsK6+uUD2Itn+vAQELcWqoViiUHhAI= X-Gm-Message-State: AOJu0Yz7wyXt5LhluZfFlQ2arQkMwVfVTKc9WJxm8iUkQhPuWqskCZR8 U1O31ZmlfK20sZzbl3s8xGi6lza4KW25rBTcf6rHnBrsJXw48CDroqNyGz5Bq7yjYyvQkyLcSaE vXnKdPPt1/2PUXYH0W+hISVuvnOy5+Nam7If1 X-Google-Smtp-Source: AGHT+IHLJauUiF0rqTT18jvHpgRY2X3ODeLmlM72AlgOShsf7F205kobxGmKmoCjvK4GHvyNgXSi4VcYiSKE0B5axFQ= X-Received: by 2002:a05:6102:1621:b0:471:c019:c9e6 with SMTP id cu33-20020a056102162100b00471c019c9e6mr798026vsb.23.1708663617395; Thu, 22 Feb 2024 20:46:57 -0800 (PST) MIME-Version: 1.0 References: <20240223035548.2591882-1-wangkefeng.wang@huawei.com> In-Reply-To: <20240223035548.2591882-1-wangkefeng.wang@huawei.com> From: Yosry Ahmed Date: Thu, 22 Feb 2024 20:46:18 -0800 Message-ID: Subject: Re: [PATCH 0/5] mm: unify default compressor algorithm for zram/zswap To: Kefeng Wang Cc: Johannes Weiner , Nhat Pham , Andrew Morton , Chengming Zhou , Huacai Chen , Minchan Kim , Sergey Senozhatsky , linux-mm@kvack.org, linux-block@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A7D5D100005 X-Stat-Signature: 1f41ujyftusjc9ky1owg9uecbrd4j53a X-Rspam-User: X-HE-Tag: 1708663618-211250 X-HE-Meta: U2FsdGVkX19rFR7EAQJynQaw1EfHKdGe49t/6pnXy/GG9gISlLiOkQ8Te7rDuFBHdWCs2qJGcxzr3t6EEwZ3gJ8442aY4AQdnA9HMoTDETSy11MUzbI7dQIAdgTPKZTRT8g4BxreQ+J+r/4c516nZNI7VZsHhPQd7peVycLju6yqvRhd/2mhCoEVGy4M7yRqg16DRlEjvpAKqXlSOOvog5EtNkbQrZ2r3Rg/CpkCXEfip2vstp0XXOwSSJ8HiLfsIRbXiM8bMvDluj5VQ//GIeUI1clxgwl4IFgAYzP17EgtmGKaWOS73d9InCKgwukqoqBs2hkCtyUhXq7+2Lc8Xqqy+cDdNC9vuNFZX6+ZPXlrA2Kond85YUFT2w4BxO69uUGsAxF20ZQyKKRS3CJSrOvTe58rS1vnyPOOPIC38p/mxg4UcnLvpTgmxXxeMsAz+ki22UjwMSN8bpSht3lvgWLZQZ6DBOxFvDOyV1moTXuLjotwrEt1wudBXFsNFpFOfQGwQV1TtgJkT4f+wAil5PlLiC3PDZh37T+GOAgLG+mqSvjdfuemFz2htd25Jz3C5skWTIWerg3pSSF7b4wMllKTON+vRAV+GHuYU++jmdzIeHTWlb3AHPeE4SH9e9RZR6TKhH43LFlh8gyYEdnmKAVG1SRy+PBSIT7Y/T88ex1mVQgxYkodSHBg87LSxpOBwBvSmkMlRZPPkH66bfDbYQq2FvQkIkiWLdNBx+uSOgtVznq+SxwzOxzZfTk0R/EkTkQnFaJ0fyqLzBXoC05IJ7U5YGw07giWP5GyTJav4t1XLQAZ6mDO8hlN+NLQmjH7/f2YaK6xPwDoS2XX3Q6Irho70A08jDkoExJgtcSuHs4aTToNgEhZPXNdy3mye2zZSU8bVuy2hK8RZ217+Uk6fJ1puS4mdSzWMOtsp8qpXHPlgfbgZEPCZeJPSX54HDZBX6dZZOSiaVldttebgFr VmxQ+aNz 7AAh5AILsWQi6IbMVaTuNqmIQ9YQP+VaYtKx+OciciekkSUQWEEHyeJPEWHKg1gCbiCQCKok+rupE0IS3jfojCwQZUGVH7abn+qjyz4NTEWjcCi5UG/5X8Iv5uCiYiF7yhmw6e5sVvidlOUSKAJHskCl3UaOTj93E+v/3wv8YajKmTfrRCrM2owo14P4ULDYtAOjo9y8Ed+c9KSAMvNi/JcZsTu7mNgSlRWYT0Yc6VXQgHIrYwl+9EKVgC83EZvd77GGsl1/dwlCdefi1y5ppdEBJAFzLudL2Oget3X5uFNt10iqrGP2fc38CIdR4kW6L8UpTWOeCOi+SU1c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000359, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 22, 2024 at 7:56=E2=80=AFPM Kefeng Wang wrote: > > Both zram and zswap are used to reduce memory usage by compressing cold > page, a default compressor algorithm is selected from kinds of compressor > algorithm as the default one from very similar Kconfig, also both of > them could change the algorithm by sysfs interfaces, so unify the > default compressor algorithm to cleanup the default algorithm chosen. Both zswap and zram *can* be used for compressed swap, but zram is a generic block device that has other use cases, see https://docs.kernel.org/admin-guide/blockdev/zram.html. For starters, making zram depend on SWAP may break some of those use cases. Otherwise, I don't immediately see the benefit of unifying the config options for two independent subsystems just because they both use "compression". The reduction of the config options is nice, but in this case I am not sure it's doing more good than harm. Also, most people use either zswap or zram in my experience, so they don't really have to configure both anyway. > > Kefeng Wang (5): > zram: zcomp: remove zcomp_set_max_streams() declaration > zram: make zram depends on SWAP > zram: support deflate compressor > mm: zswap: default to lzo-rle instead of lzo > mm: unify default compressor algorithm for zswap and zram > > Documentation/admin-guide/mm/zswap.rst | 2 +- > arch/loongarch/configs/loongson3_defconfig | 2 +- > drivers/block/zram/Kconfig | 44 +------ > drivers/block/zram/zcomp.c | 3 + > drivers/block/zram/zcomp.h | 1 - > drivers/block/zram/zram_drv.c | 2 +- > mm/Kconfig | 134 +++++++++++---------- > mm/zswap.c | 8 +- > 8 files changed, 83 insertions(+), 113 deletions(-) > > -- > 2.27.0 >