From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60E1AC3DA4A for ; Thu, 8 Aug 2024 17:18:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C1A7A6B007B; Thu, 8 Aug 2024 13:18:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC9856B0082; Thu, 8 Aug 2024 13:18:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A91336B0083; Thu, 8 Aug 2024 13:18:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8B6246B007B for ; Thu, 8 Aug 2024 13:18:17 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0D9191A159A for ; Thu, 8 Aug 2024 17:18:17 +0000 (UTC) X-FDA: 82429736634.10.18C1D89 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by imf29.hostedemail.com (Postfix) with ESMTP id 28E3A12002F for ; Thu, 8 Aug 2024 17:18:14 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="Si4dU/1Q"; spf=pass (imf29.hostedemail.com: domain of yosryahmed@google.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723137462; a=rsa-sha256; cv=none; b=LpwWTI7lJIbOrTcR+Ob9d+5acZAnNc8FCGXu1C9y5xpyS4bxCQtt5sHdE0Y6GUy9FeNC7r zYeCv82mPARs6q5MN/m7iGNKF+Hmo+zinSN8wor+k4MO2GnYuSWFn8ikX4ZV1iAV0VwYC7 V4+W/AkL4FA1UUpMgOOpYWwjoLFyiGo= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="Si4dU/1Q"; spf=pass (imf29.hostedemail.com: domain of yosryahmed@google.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723137462; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bm+7EpRnlnQ2hj516+ZMFRLx/ir/OPRTVmLMCWHFcSM=; b=wWfCaBjpuAmRqCZr96VY8+PlGIb+WUEpQnjWbqBvIPubJ2UB2oMi2zNIyn8ExDNqN+EYj5 1XCBRHbnBhU1BEGWnCb6si4mrgaZE8BFpUymsl45WqnO8xRainRzlyy87Zx7JXI85NwLkb W3dCO5QDNzCQ1DDy4qv4PedVAYK2HJ0= Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-530ae4ef29dso2123720e87.3 for ; Thu, 08 Aug 2024 10:18:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723137493; x=1723742293; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bm+7EpRnlnQ2hj516+ZMFRLx/ir/OPRTVmLMCWHFcSM=; b=Si4dU/1Qpl1dTirXbVfg3CiZx+ERDkvUA1YXjzh80mqYWVcajXpwWLDTe8ggxV1zau 4/is3xio1pp15dwCjj5hUWyJ8f0hnTv4bGgFYo8UqWifFBgAnOJ7/Th9pGmd/Mmz8LkS Iqyuj2b4wi8Rd1e9S+9gDEw/R6rnIwUveL+xiyRS0j7ypExSA2srb/Bgh+jCKATvE5Px AYfcO7iMAFFOukjGzoQT9JCEeCmtsq2reKazeYQCbBDhzZLyH4OJPd6EP6VH1if/XCUB nrHLZfSTQ7L/dUovqTC77k547r4QuxRWuwA4aPRfX3ajhw8nqnaZb6ZWOmTqb870HJ9x 5aqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723137493; x=1723742293; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bm+7EpRnlnQ2hj516+ZMFRLx/ir/OPRTVmLMCWHFcSM=; b=YETzn3h70/KkyI2Mg+W0BCNH8t9zYEBee2PcXyCQnUVg02TPl1RbzCueJkguE/v7Ty xes1NsNnxKQWPwFWQYQTgTl60ILM9jbZqveUwda7vNNhWClx45lXF1x0atFFVAoqM7jC JCG+8NwpWlKMY/Cn9wnQcUmHj5JAaXhzxGiFDr9jU71C6Ghz84nHohLTeQHsjTk9B+09 WJRKb2VCJp+CMp06IS7OuaUCusHX8R7Pjj3nWB3ZOt8OTeE77O7jF42OsLJm2aoAIVKi fv+1EgbdtEE/DoBMZSFLTI/59x8UC+wyeZeNS8/JAF7lu0WmFH/iYh2559dP/Iq1BCH/ nNEg== X-Forwarded-Encrypted: i=1; AJvYcCWVMOaqIpIydaPDshiTDfS5aLW/GcCIFtHFCvgaLyN3VZv40XcEgZlEoe5eSU62B5XjrBlyRDc6ZODsoDKgzz3VZrQ= X-Gm-Message-State: AOJu0Yzv+XJd31WFRX6orxxvL169T2vjj4EDf9wmVPvkNDXowuYcDrnI lPCIoqfg925uTcDImYyMwvx5Y8dzGr4DrH0zQV7vR9Nn9ocjcTfX0FvatwS2Sv7nKhfYgv7184t SBFNPHTRUzQd9OFPvRhhwNbau7Y7lplfyYBz/ X-Google-Smtp-Source: AGHT+IFX49a2OF/Tc9efpcO9wHBlC2TllxQpsOJeLgpePzN2WzsXhYz7AipyJBG+1Flp5wutlQjnl3zlIsiZq3pi7Mc= X-Received: by 2002:a05:6512:1113:b0:52f:cd03:a84a with SMTP id 2adb3069b0e04-530e58768c7mr2426138e87.39.1723137492346; Thu, 08 Aug 2024 10:18:12 -0700 (PDT) MIME-Version: 1.0 References: <20240808154237.220029-1-pasha.tatashin@soleen.com> <20240808154237.220029-2-pasha.tatashin@soleen.com> In-Reply-To: <20240808154237.220029-2-pasha.tatashin@soleen.com> From: Yosry Ahmed Date: Thu, 8 Aug 2024 10:17:34 -0700 Message-ID: Subject: Re: [PATCH v3 1/4] mm: update the memmap stat before page is freed To: Pasha Tatashin Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-cxl@vger.kernel.org, cerasuolodomenico@gmail.com, hannes@cmpxchg.org, j.granados@samsung.com, lizhijian@fujitsu.com, muchun.song@linux.dev, nphamcs@gmail.com, rientjes@google.com, rppt@kernel.org, souravpanda@google.com, vbabka@suse.cz, willy@infradead.org, dan.j.williams@intel.com, yi.zhang@redhat.com, alison.schofield@intel.com, david@redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: ani658tusnagdhrcggekz5zh3hj8ue7s X-Rspamd-Queue-Id: 28E3A12002F X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1723137494-467419 X-HE-Meta: U2FsdGVkX184nYgQurHK9OR6Rt45j30xqLkwiERrG6zBT42proB4+dZ1/+X47y0Iu5gzYg7/gIANEAke93ryn3a+rM8pEMce0Xnyd8u6f/TymEpkMAfMAAuGsi1J9w6e0vuk7taKazT/aukaMyAZ04egClkB3ShiBFcFo7vzUU1iDSVPJ1ZLgoYm2ES1Tk/nAtfcHZfrviHu4loiOjs0/EaO5wF4/1FSZrE6yyCjaCFz/gS5BKYH8BpaWv5k/fKy6OiDxkQ71wWu60fMcf8YBX90IJdQpQ+30XK8Pp2kHVN1N4Bs60Arrr06IDIw0pnxqPqe5hSQhEyXvhejJCqdzZ7BvMTGNfx6gDqSic88fWFiGvmL15tmF9xlZJaIVHRFhJ4o417uZb8Hfqwwbr3ucMobj2eM6Q7bXuoAnCjfIGUa/Vdn87UyoQYkCbdhQ3Jl5ibj4wDktbpe+1lZwAEW+9uV4Ubm6zDEj4g2ZP4j2VEYnQb9eWmFMSDcMaDA32WOGkd9pWvG1AmcoALwGzYTNIy7nC8+bhKccBKqomcUIXL0/2H6nrRZQGQiMQLZ18s0bdGW2pCw+OANpfGj6ZUoEfK/2CV0eYHBan9np+UnxtEg3ej0C6gmAwOEnX66gUFtM+R4htqJBHYkRjXO2YN1u1lLO8yM+QfIuOBZR4MUgOnUNSs0Idur9qMBT50uK7BmfN7IQgPZntugqQGROoGT4jCd5DZ2CMx6pIMT1nFf2jN187fzcUCyE5Jqcir2x9wS74MCH4eXtRHHm8yXY1ZaqYJDL979eGju4ZYJC3ZPksXnTx2F+BEAeoA3Iax5cArv+M2rfARDr+VyMAkp9FZqxQfJYcDWZEaNlwxOisb8/T0XBTIGzsMS1WTJbTWHC5d7BGM4LYzcIFtDiernbsrYvmG4ZkAQZwzVb/RZy183j6hyLl87aENzBllV+nCR3f1bR6n4P1rnfOLCbmigKp2 0jWEZ4uj KHkfrX5NP00dweUTmqj+cjiwe29kohX/C5Yf8iyf383nvyaZef4aJvuQGfJWDKu1+OVDsBX4mFpIO0+y4xIcgncSyUWR8Z7uWcd/QI1PC6us8y9z2r2uBvHeLHlc1fnusrMVB7FL2Yq3N0411JeqWzHE6NhSb3oJhB26zFAfYdQua4jNRmY82Jl2MvWjKuPCQ5EeTGSwvp5jrad/NgLUpMRM3hwG5v+wEPFjyVwzfH4ZFia09iW9DGqw2RjrEh2G/InHZ2eA0n+9PbHDtwueEyYGn0Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 8, 2024 at 8:42=E2=80=AFAM Pasha Tatashin wrote: > > It is more logical to update the stat before the page is freed, to avoid > use after free scenarios. > > Fixes: 15995a352474 ("mm: report per-page metadata information") > Signed-off-by: Pasha Tatashin > Reviewed-by: David Hildenbrand Reviewed-by: Yosry Ahmed > --- > mm/hugetlb_vmemmap.c | 4 ++-- > mm/page_ext.c | 8 ++++---- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c > index 829112b0a914..fa83a7b38199 100644 > --- a/mm/hugetlb_vmemmap.c > +++ b/mm/hugetlb_vmemmap.c > @@ -185,11 +185,11 @@ static int vmemmap_remap_range(unsigned long start,= unsigned long end, > static inline void free_vmemmap_page(struct page *page) > { > if (PageReserved(page)) { > - free_bootmem_page(page); > mod_node_page_state(page_pgdat(page), NR_MEMMAP_BOOT, -1)= ; > + free_bootmem_page(page); > } else { > - __free_page(page); > mod_node_page_state(page_pgdat(page), NR_MEMMAP, -1); > + __free_page(page); > } > } > > diff --git a/mm/page_ext.c b/mm/page_ext.c > index c191e490c401..962d45eee1f8 100644 > --- a/mm/page_ext.c > +++ b/mm/page_ext.c > @@ -330,18 +330,18 @@ static void free_page_ext(void *addr) > if (is_vmalloc_addr(addr)) { > page =3D vmalloc_to_page(addr); > pgdat =3D page_pgdat(page); > + mod_node_page_state(pgdat, NR_MEMMAP, > + -1L * (DIV_ROUND_UP(table_size, PAGE_= SIZE))); > vfree(addr); > } else { > page =3D virt_to_page(addr); > pgdat =3D page_pgdat(page); > + mod_node_page_state(pgdat, NR_MEMMAP, > + -1L * (DIV_ROUND_UP(table_size, PAGE_= SIZE))); > BUG_ON(PageReserved(page)); > kmemleak_free(addr); > free_pages_exact(addr, table_size); > } > - > - mod_node_page_state(pgdat, NR_MEMMAP, > - -1L * (DIV_ROUND_UP(table_size, PAGE_SIZE))); > - > } > > static void __free_page_ext(unsigned long pfn) > -- > 2.46.0.76.ge559c4bf1a-goog >