From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED2A8C4332F for ; Wed, 13 Dec 2023 23:38:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DBC08D007D; Wed, 13 Dec 2023 18:38:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 78C9C8D007C; Wed, 13 Dec 2023 18:38:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DEC88D007D; Wed, 13 Dec 2023 18:38:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 48C1B8D007C for ; Wed, 13 Dec 2023 18:38:34 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 27A44120B35 for ; Wed, 13 Dec 2023 23:38:34 +0000 (UTC) X-FDA: 81563411748.21.F4293A6 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf25.hostedemail.com (Postfix) with ESMTP id 4D12BA0020 for ; Wed, 13 Dec 2023 23:38:32 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=pvs50pIq; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702510712; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=khBmMizas9gxTRli+QPr2dO7hNeCzSMKNFFwhsbIguQ=; b=eXGG7xBoWVeIOWeuXpgLoGoEvyD4/FnkbXkPohmVBO9lcot1P4itZ0j8lYaRLT2Iychn+c 7cInxiaGVT8Tt41ve/bFGwQzRyG6WML3S13RJpEolLgUc7cM6G5yRR2Cr4QggMukyMYOLJ 9jsYHW1bdpoPAXyhLhU9pTbbEF6GGpI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=pvs50pIq; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702510712; a=rsa-sha256; cv=none; b=FCSNd+mZwE0O0va6wsYP5joC5QJcActGTv1YX6bgNnkAGUlL3znr3Gqd3ZxT1rVF4oN+PA /b9uIs56Wmw5f44mYyoMgPz+TnQc7pKvCV9TbyOkFVj6lzYE1KfagfP9aXHgDnykU6RkOC KcWO4I5FfmdPB+IOCa4ltKOa65ybQPA= Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a22fb5f71d9so13959466b.0 for ; Wed, 13 Dec 2023 15:38:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1702510711; x=1703115511; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=khBmMizas9gxTRli+QPr2dO7hNeCzSMKNFFwhsbIguQ=; b=pvs50pIqEwMqrjBfwfHR27qHIr1pupAB9u297KZgV9WwCGmbtXerXCWeGSrHRpcs3w of/tALmHEFJabzaKzVoVstMiFvJuUmdWt0qeVii61+la838GBXI2iRRa3ZF/c08pzjvZ 0GuBBYsvEjxvIr+UeFmgW0vlgn8yipcSk57eRPq8u0U3Jg/LrC6CtIXvT8AWgX16t/Vl Ix0L4sro28uk/a/IkKdRf8m0xANX5F52fkAAblYPgKYL4fQz49RVpnEC8kz8OHaNklqY tmvY34Q1PaQ8UjrcEYUtPNkgp98siMFZ5vnSbb+su3cUgjQziE+EBzlqUjYWKC3zbuFO OACg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702510711; x=1703115511; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=khBmMizas9gxTRli+QPr2dO7hNeCzSMKNFFwhsbIguQ=; b=RzWWTHJjaENvR4L+uUs+cnJB9EkdSm/ptb39jrX5xFR0Sx6S+4mc4bJNgHgW3c2IA4 nw7h4MOYH5x3eOUGTdO0is3Nizk5OjfNamfoG1uXc0IkkSb7KH8eo8gsfoZr9FY/jAn5 8e/P9Uz2BK0/lNkF2y9PPOCU3erfuraFSB2DZ232MDsIOy6p2AmkT980c4Im08cXnoUu g83ve7m/pyfNhT9fBqFhEGEzEZxzqLaBRu4498rpPZdoOF5Q0h592aC3yi7zOvjXXfAL x+I3zpoJY/a4tiH0NcymumwyvBVGTmRIMxoDJgDtl0sf7dTvR5r4xqkF/+I/ASspAlWB Nk2A== X-Gm-Message-State: AOJu0YyQxIVNGa9a6oBVk6NapsBAlUOodLSYLYo2dvg+7Ys1Y9LVxFvQ AYEpg3mo/9sJrX3XhY6CeCdy7OZuCOijqPmKUgxvKg== X-Google-Smtp-Source: AGHT+IHyfcctpaOGCbgl20TU191uLxWgu6dKSBEraZPkN8kPrLIJZsuGFaf9QjriDYu1iEALgMD30ywF0wx6UgxW+Dw= X-Received: by 2002:a17:907:831d:b0:a1e:11ea:ee15 with SMTP id mq29-20020a170907831d00b00a1e11eaee15mr5701389ejc.77.1702510710830; Wed, 13 Dec 2023 15:38:30 -0800 (PST) MIME-Version: 1.0 References: <20231213-zswap-dstmem-v1-0-896763369d04@bytedance.com> <20231213-zswap-dstmem-v1-3-896763369d04@bytedance.com> In-Reply-To: <20231213-zswap-dstmem-v1-3-896763369d04@bytedance.com> From: Yosry Ahmed Date: Wed, 13 Dec 2023 15:37:54 -0800 Message-ID: Subject: Re: [PATCH 3/5] mm/zswap: refactor out __zswap_load() To: Chengming Zhou Cc: Andrew Morton , Nhat Pham , Chris Li , Johannes Weiner , Seth Jennings , Dan Streetman , Vitaly Wool , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4D12BA0020 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: wh4533ego9u6tub9cmi8tzne365xr4cy X-HE-Tag: 1702510712-259998 X-HE-Meta: U2FsdGVkX19w0r4p+bjkDL7+WvOgfuWvCuhg8WoYuJ6RIBjDQaWCVrH31pZqOZrMRaJsLg9WgkkDJ1XvwX2i0W9mE0lXEt819syQ6iBwOeQiQOMH4nDs1y+sVypiHHFAD0A0E900S/MmQjD1wFIrjh466oYT6sBmZxbuq6UET8LUEyF3bm4ZmA24r2xjDnoWEAWvfW79QCzsf+xgL38L0vSHU2fLOqjXczwpIvjyqyqWXClOjCckBJWB99yDJvc5sPUeT7XgT8p4Munonvqt11V53EaMcdl7Y6CnpMoW0VvpGPEKZaFsYBjoqFLhll8oJ52TK3PrijZydrfhO0WDAsr39Tr2XJFwIqyV/OommS/bdsUo5wPBs9bpEIGgDlsTrHBRcFmnAAGjmJoXwqE9M3+h9b3LLQnZgelyCG23gzoaXL2azruYQvfGU7lRwtvj/ibonsdlGkUNooXKjP029nqFUAxv2mKNdFdKPnqB7PGZYHLs1Jc9ORCzeV8y8FsOoFCn6XoPeJdQ4QPRZIm899RDYRev3HnCG+WR4sKVN5UFK1R6LOqxHqAmEnEnoy6TCswj48SncNWhREbBg7OqOtUg+qlOCWF66N38kd3kQX/PhoSIy2zFgVjFhSZ6COp9dcdglKlpzq1fI9NdU+GlH/A64FBgopJymoPXDOCHdPkq8wJVKge4YY7TaPVdyTXUVmm4A8HcKjbJ5aSxiqRZexEl+OSpEP+fzlLje0L8dNhELhOgWnCCjjsZIHmwNhjbB6v6I/zawvwYiqbrLAMLSv4wRzPL+Jdg2Y40yml6VLYXEHsIVBh+RrarVxz5T01ESU/B5t0JE49HLdNJbxSQBWFDB8jyqngPuxC24yx/v9OS6+OSgzueG1W/2ZKyfU6BZB1e1hJ0ZP59gxdrOjmc+vwowCs6fd9TH8iQtGmTALgtDh8oRPAOPe+Tm/mUa4sBJiS8jctck8DMdcranwQ 3LdqGJ7b /BH0TlYSPTXwT3WweL4FPeMUECy6AA9REVoSMMpKuRQcZZEA1cMzDy0XqwbHvugUJwB8Il+PS92InPL6C4kkNNn9hmByX76jcQyXhFSbdvT4d7P/WxZYZO7gsreZBHcpELDVJuFSMlcx/US1eUkMx6YJzh4GM5Rse7ckbnYdbpY014u+DRn8vsDU8fLzFosZD5ucCH4ROw6yhHHMXRxAJ+znaGnQRYEOjs/w6+2cJUagdV1qoilFxSO2lBUvhDxl3O6ywwD+mWciB00I/eR4rpBxaaP4wDemng7/kNQztv2XkFBn6UYJtSQc9zTamiQ6VLWlrJtYik1rjXTWOtRh4ynPlm7sqX5Ek+Sb0pCRqg7x+5QcopCOaEhMC7Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000220, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 12, 2023 at 8:18=E2=80=AFPM Chengming Zhou wrote: > > The zswap_load() and zswap_writeback_entry() have the same part that > decompress the data from zswap_entry to page, so refactor out the > common part as __zswap_load(entry, page). > > Signed-off-by: Chengming Zhou > Reviewed-by: Nhat Pham Great cleanup, Reviewed-by: Yosry Ahmed