From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C49BE743D3 for ; Fri, 29 Sep 2023 00:38:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E6E408D009A; Thu, 28 Sep 2023 20:38:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E1DE98D0002; Thu, 28 Sep 2023 20:38:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0CA68D009A; Thu, 28 Sep 2023 20:38:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C33E38D0002 for ; Thu, 28 Sep 2023 20:38:44 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8CC9A16105B for ; Fri, 29 Sep 2023 00:38:44 +0000 (UTC) X-FDA: 81287774568.30.EFFD73C Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf29.hostedemail.com (Postfix) with ESMTP id C4239120013 for ; Fri, 29 Sep 2023 00:38:42 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Zm2hFGHP; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695947922; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=45d+IBpPQ99/+1Gj6Jf9YvBwKOBDNkQcunQHUXPJFp8=; b=ejmXHEyR1Ijadj1Hz2jLMq+LOUTUklxl3xu2U9dL9u/C/Q5kzUJucfIPe8B83/xo22TP9O ZgaKzW7Ly6nPHk6GQ8dagD01vC7n8xE3m8gVq12YVc6YlNvHKhZrjCkJfW+SjN3y54crpY qCpuS9aqk6ZfFdkzSvxLmiv6veT0ojY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Zm2hFGHP; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695947922; a=rsa-sha256; cv=none; b=cwkwsyjiwki7LSU7bLk8MCZv2eGnjQugkR49CKBJPqg/LISrlPU05MoIGJ2tPKfHz3s26G Z/tD84kiz6+qR0/f31JmMDVA/IP+jPr9leIfSO6mfChMPHt66cc2HoKAvBHStc3m1flbDY hdCTW6972sQhiBzPxGnPHYhKRsq/8GQ= Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-9b281a2aa94so1187453866b.2 for ; Thu, 28 Sep 2023 17:38:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1695947921; x=1696552721; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=45d+IBpPQ99/+1Gj6Jf9YvBwKOBDNkQcunQHUXPJFp8=; b=Zm2hFGHPQbWzDSXs9cGOWRy3KBhurRefZtFNQ54xZQtN1Qv6qiyYk2K7HMz7QXV9bd 5pQdN6jcgiJIKUhui1mimI5AzFu+sBOVZ6LfDnUzK0KR1cA3H07prEydrboWRPwf9b4F tkmGb70xALSi4sztfpk3DJvnnqBheR/sw1E2WQud6778R65AvJUZiUYsBl87KogTMXWG Jo83lvlJhlUC+/uJ2iDXMuvIn+gyAj1xFhKRrR6iGbQfJ2tzfY84KVjGsH1VsnZiMkc9 t4I/2zn3SaKIVKQ39ObOQ/lgcWnUz8qpyzJ2+8M2I10Jc/p+ovk7kNQ9gVv6dkJgR9xr 2Z6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695947921; x=1696552721; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=45d+IBpPQ99/+1Gj6Jf9YvBwKOBDNkQcunQHUXPJFp8=; b=WPdqgC6bUOKvAwktd6S2Tsi7a4zNdlTJF6dtD1M79Er+8iloG4RATZ1kaQPxZsn1FS PC9BBXzdWGd9otBOdYhs6bzsdnbzZZdymNhvH0X3WqZM4GsaWy/hQPr1BywKpun7AdgS 8xVA6B3423aOSIqVcLB+QfjL14TbZxYzt4OMPDy93mSgT7z+nO88LMHkjua9DdWIgHu8 mj7yJUv8W/zq8hCuiJ1aw/GB2vWk7ACjV7qqm0+t8+6+UOaLkNshfT9kNjGUCIzodVq7 GdJchmufBxWVlGd3bX3CRv7c2ZtNVSqprYJPXl41NzVeytR8w5pt2VVpoKF0cYAFt2ov Hu4g== X-Gm-Message-State: AOJu0YxhNr+86w0Pvo0TdjzTYfeW4ipGXwOWSGYWsaLtjxWG0jh97LGP U0tcBK5MwNBXO2I8d9bt0sDs7y3XNUSUNMcy4761VQ== X-Google-Smtp-Source: AGHT+IEpi/1or+NKN/RfJkcGWCFTZxjbKVATnUt74MN/BxUwEMwAr8ylk7EU3yfD119SsDCYLFHYCtHNfM5R6qnD9EY= X-Received: by 2002:a17:907:7801:b0:9ae:72b8:4a84 with SMTP id la1-20020a170907780100b009ae72b84a84mr2276590ejc.41.1695947921024; Thu, 28 Sep 2023 17:38:41 -0700 (PDT) MIME-Version: 1.0 References: <20230928005723.1709119-1-nphamcs@gmail.com> <20230928005723.1709119-2-nphamcs@gmail.com> In-Reply-To: <20230928005723.1709119-2-nphamcs@gmail.com> From: Yosry Ahmed Date: Thu, 28 Sep 2023 17:38:01 -0700 Message-ID: Subject: Re: [PATCH v2 1/2] hugetlb: memcg: account hugetlb-backed memory in memory controller To: Nhat Pham Cc: akpm@linux-foundation.org, riel@surriel.com, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, tj@kernel.org, lizefan.x@bytedance.com, shuah@kernel.org, mike.kravetz@oracle.com, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: C4239120013 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: hgihtw83qxzpt3suu1i11mubyxuf9fg3 X-HE-Tag: 1695947922-303599 X-HE-Meta: U2FsdGVkX194gryPtgMV+M8r0FAQpXvJaeg8uJ430PsGTirVL3UVi4WyfA7OqOL4jdeVSyU0bfxUc+GlPlcJp4a2jqOLWB028tlVNB6+KALpkyp5xBkS7kWtxjNpWTd1ky602TG13yDHpDbd39ltp9Kw1bVBDJwceENRtLuvRJIVD80xmlEgckcYb6K27vzkMZkwoeaiaXc3MibYv/X8l1Y7Oaobq3yvfWSh1U53OuTWjzzHRn/nRZmvk1vGG8wN7U+YRgZBzKLrIcybnKGxTvMQnMaFSXiX9ZEGtrElFftDVPIjA0qjehqxK/JsYGYlaHt4CyUQue0Kd/ray9iADg43MGaBHgCqUhL+N+JOL0lk8G0i7pHdweWHVngSiyY7SQohsARYcHpW/4ZDcRb9AEbMwZMAz9o5M55ITol/IjQEbGU92APRXzNWwZ2AU2tDCKqxDX31gvcuhIqv/ARdcneWRxOIbOxsVKMenBX4NIiIH/cxo5o1KC+XY3uWPmwgSfS9bCR37KyoOzt4SynUhkClvxPaDS3VAW7XFHDIUaLModlUxcXE/OR/p8DQt4V3TsoW7FE+Pi1KbDzFabPyVMdUDk46OaVCCysrvBUQqnoRij9xukVIIkmEbKH2O3UZK0XEZQl0rEXnupuZfWKdLOY4wRVx6zOoROT0fj5mVqP57E0OOIldBXrDN3bBb+DRhv5K3GbBLscEhodp4e9dW21RDVWHznqPKMdlkf0D4jg+TkbuGskzFzA6Ld3SMS51dxHh9BrOiYpNJMseJjiho8qZzI9+BRFrTl8tudRSDgo9ZJPZTvo4tG11w3LQESfiVCG1JVaP26UDOzYWjGw96kupIoUdDa7+ypuhkR8a6viU/q9Ztp9Bfk0EXC+N8lNHVOtJYbzfUwnU0F2/++tmnfysTFz2vjgAUut+kJ7l0IVJNEIRjBGq7Lku8BtZs88Wq6zbauhQSHGCak+P5lF CjnJ5zEB OMKRycKqYtNfD7SZfKIhDXEtFrksf7VKRHNqueirzdGwDNevFd4xEcKlXx/xTas4CGYRUY472uS8u0uQhwJ+8Pg+sf9LqNWwNxpdwW2S7q573TafAHNSE0W3dqT7/KohiLxcD1vQRNI0jgcQIlFlhm/iStVg0Gz8JyT1V1nS6Qyep2veNmkjc3wgL21RHsO+EWO8lUbKAeCHM1GSKM713pFq205F+EqkGHEuZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > + > +/** > + * mem_cgroup_hugetlb_charge_folio - Charge a newly allocated hugetlb folio. > + * @folio: folio to charge. > + * @gfp: reclaim mode > + * > + * This function charges an allocated hugetlbf folio to the memcg of the > + * current task. > + * > + * Returns 0 on success. Otherwise, an error code is returned. > + */ > +int mem_cgroup_hugetlb_charge_folio(struct folio *folio, gfp_t gfp) > +{ > + struct mem_cgroup *memcg; > + int ret; > + > + if (mem_cgroup_disabled() || > + !(cgrp_dfl_root.flags & CGRP_ROOT_MEMORY_HUGETLB_ACCOUNTING)) What happens if the memory controller is mounted in a cgroup v1 hierarchy? It appears to me that we *will* go through with hugetlb charging in this case? > > + return 0; > + > + memcg = get_mem_cgroup_from_current(); > + ret = charge_memcg(folio, memcg, gfp); > + mem_cgroup_put(memcg); > + > + return ret; > +} > + > /** > * mem_cgroup_swapin_charge_folio - Charge a newly allocated folio for swapin. > * @folio: folio to charge. > -- > 2.34.1