From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6777CD8CB4 for ; Tue, 10 Oct 2023 19:02:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A46A8D0006; Tue, 10 Oct 2023 15:02:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 154A98D0002; Tue, 10 Oct 2023 15:02:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 044458D0006; Tue, 10 Oct 2023 15:02:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E7BFA8D0002 for ; Tue, 10 Oct 2023 15:02:28 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B18691403FF for ; Tue, 10 Oct 2023 19:02:28 +0000 (UTC) X-FDA: 81330472776.15.E89E1FF Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf01.hostedemail.com (Postfix) with ESMTP id BF2FD40022 for ; Tue, 10 Oct 2023 19:02:25 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="e9zoY/IG"; spf=pass (imf01.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696964545; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5woyaOlfb5FRD/2ky2o7l2Lh0ZKAp5sQQeLB5eexnx0=; b=zC99dqZsonsIlvgT+AS6sCN9dzjtvv1lwfax6LCfpcB3GF8de92k0tQCAedAO8o6VSScXQ U2OjI5NSjk5hvqAUCZxgNnu+nDFCAwwrj7rCgQxBr35A5HpLnYnCclzELIhohW55Vet1uO Yw2xJcHqmKszz0L9uVSGU6SLQeBCzFg= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="e9zoY/IG"; spf=pass (imf01.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696964545; a=rsa-sha256; cv=none; b=TJect2d4aDanqo6fYjpwyarCgNUPNf41xhSLH8ALlCU9i8NgxswQzjhtG5KJPRbl6nN2nE 7PooETY90QFYdnidL9I20vC+TkLZfw80Ss/tYPaf6YwHQJhKBFZ4ZWyopXX6zZaLqSPGov +tFXMU4EiH56zmOZW6OPJKOSl6+n+SU= Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-9b96c3b4be4so1019488466b.1 for ; Tue, 10 Oct 2023 12:02:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696964544; x=1697569344; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5woyaOlfb5FRD/2ky2o7l2Lh0ZKAp5sQQeLB5eexnx0=; b=e9zoY/IGCvKdWBRbd8Ob8vqqrH7zIFk9NyFDI9QqSUWqM3L7qs2QQW1q1UVftAa3ii jXUEi8+tXDB1sMvIzlDrD8ONqKZxn1wr7U7laQtECulhPvQL65v2B7rP+QAsXzQNn6Ot e9g5bIOavtp7o+/HQshCieMQK9yzPw16ke0/93RQKMOTpleLrCRjwlTlvJHehkpBvoec XTuG95Fw7RIOcqFl2Lzqhn37aWUQp8FoNULM6Z4mv+TXuvaKHMP3tG+iCSlfYJ3l1jVy tdlTDmxgSko6qVTRZIyHCEiQxebLHTQRrMEV3f6P4Ubo6FxjGmF1nUjeVoHwdvbAltcb worw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696964544; x=1697569344; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5woyaOlfb5FRD/2ky2o7l2Lh0ZKAp5sQQeLB5eexnx0=; b=G55FPYVPBhYSVraWsXHE3MM3XM7j97YXhNNP3FKv7DNBJIHCNaimrbG8urD/wADW0R wW//+IzG4xSeXDp/yMWIsxqLmoTljwwY1G2zVjK4nXmVMmaiH98CX5JeuwNFdz3AYsiK MUvfvbb1IiGHg99Qq/E2froX1kvmynp9HGQ4lQgJ2MR03mG6+8G90sJFX+ie81Nxryqo 8RoRD62o/3g5IXIDF6KCsutiKVVezlKoEdd7utkXJ3Kyfl85XCOWCBaJjxpNSyKw0teR 3aQx2IC6iH1qo1bIPdDhNTaYEyG9pSzfeofdfToJDNG1jT6X+bNwAPDTNMPHmkr+MPku d6vA== X-Gm-Message-State: AOJu0YyWJOLkyriooz9jTO9W9LrNNnYjjvamhFBmqStvpGHTdCPFYJAS iwddHU+Y1zZKklTz7XEhE6gmJiM/3S0WxodHVBwSpYj0WPFbEZ79SOA= X-Google-Smtp-Source: AGHT+IH9bKUffChQjllZKWXnZLqMPjRf0Bp9CGpOP4CvCWQxNB07IIGTrxdZrDu0oiPVMWwbVLPWJ/cU73YSpZmjB7o= X-Received: by 2002:a17:907:2cef:b0:9ae:6355:5ef4 with SMTP id hz15-20020a1709072cef00b009ae63555ef4mr16422145ejc.3.1696964543989; Tue, 10 Oct 2023 12:02:23 -0700 (PDT) MIME-Version: 1.0 References: <20231010032117.1577496-1-yosryahmed@google.com> In-Reply-To: From: Yosry Ahmed Date: Tue, 10 Oct 2023 12:01:44 -0700 Message-ID: Subject: Re: [PATCH v2 0/5] mm: memcg: subtree stats flushing and thresholds To: domenico cerasuolo Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Ivan Babrou , Tejun Heo , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Waiman Long , kernel-team@cloudflare.com, Wei Xu , Greg Thelen , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: BF2FD40022 X-Rspam-User: X-Stat-Signature: da3aoms9pqp5smeo9dzikuzyhn6xgtt8 X-Rspamd-Server: rspam01 X-HE-Tag: 1696964545-164123 X-HE-Meta: U2FsdGVkX1+ZRowzrBOKfi3VgSpxPM31WN/U2eX/3FYRNT/9lpwHT3I3BOjKSpAFulAoVcDAGN7VFjVMa4h0FHYvtiy54mVGSPf4QaE3+sZtHtLBuA8+VVjPCpPsi6NzhXydSrSDsk5URAEVBQXw0syLNuOCVEfINYkEbTT/rsJp/yQOC5phkG85XsRRB/PiPeZCVh2W0cBE1+f5XyTle58YnzmOI0A3u1rvSLjlROlkzUEYLDONiJpu8YWGKC/u6sqhzgxbELuxMfMGeCyO1kNqoByHJfQ5fgPUGsu4BG+kMs0AVdwDLBTtA9LmJ3sofZ3FISGGQqoD8SC74Fjb2pKgtqvowA7IKhsFUlgKyfUCCpGh0PykPCi2AD6qeMAWGBmyEyeAHKiToRXsVXFOmGkrrcX+vghMBR3ZNPIwtQftr/s8FLH0CjkgCZprBSlR7F3tfkcV+8gOKdGYLbtK+ehhU9kcRbFIueEEsieTfJH1jyqTb2f2UkF63t7pzKhxmlXq+5EmB05FZXu1ssc3bGf+iGJq07yZvn5jGI46388NzTjKLfVQEJabwx/CEVT7EHzJPYG3Dyf+a6pyB7lSyhzWLNOOfu5qr1CDWbSXxzUvcc6Xj4F5Zvz7auFGvikH/l89poF7Wy6sxyyrjs9mVasnHMBmH3rScItdxOBI/4Ry9uVQLDdAx5M7mGExPl03U+EbgCJ5Bw9UkiPiwl1u5lr9Kvo/1OBXigoGH6AfBw7b46VsgGcsbGRUEOXFUyv3QDs6d/hWwlmZzAUYwOkfpVQKwO0IWtsJXhmstwwTGiPr8S0O6tNqVTJ1EUpidajKNnblCpnRcVZzxsg01hqrUPczqDS5OSoWAcc2NsRjrP4ceDu+Q6xaCPr6aN2nCT402/4KGME+GY9cTNIiAIBDRb0eEJAXruAOZ9kuJCzsD7D4hvPv8ip3OH8zHfnM2dRvQwP8HhZe2bmlZyuXSG5 ONqFyX5q 9IvpSWN59fCSaG+RC1JfGiYdHD+UxgccUaUV7pScNV/0MvYTBlqLA5Jc6VA0p+adlN7XrlmRWB7B8bXm1Cn7/dLoUyROf5tdPYpD3/NvlYvjtEl0Hu6ow7HeXZPqVjvJ232SU1tFGG6kq5E+xV1p7AmUA9Ky+vNJY3JSmfDDBEvwzwtrYVjpI/Sq2K9A2tCnj4KgcF9Oou6tSQ7PHlBtx17xgMJV5q3DE1IMneQjajRvTDl0gk+Iive9G5YchiCmXNl3usZmObo+JB6izZu62Ezx0OzD6wz25EGQloEQhqP/r1T8WlUltgaYRsY49jXkFLYBmm6qLw/ii0W4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 10, 2023 at 9:48=E2=80=AFAM domenico cerasuolo wrote: > > Il giorno mar 10 ott 2023 alle ore 05:21 Yosry Ahmed > ha scritto: > > > > This series attempts to address shortages in today's approach for memcg > > stats flushing, namely occasionally stale or expensive stat reads. The > > series does so by changing the threshold that we use to decide whether > > to trigger a flush to be per memcg instead of global (patch 3), and the= n > > changing flushing to be per memcg (i.e. subtree flushes) instead of > > global (patch 5). > > > > Patch 3 & 5 are the core of the series, and they include more details > > and testing results. The rest are either cleanups or prep work. > > > > This series replaces the "memcg: more sophisticated stats flushing" > > series [1], which also replaces another series, in a long list of > > attempts to improve memcg stats flushing. It is not a new version of > > the same patchset as it is a completely different approach. This is > > based on collected feedback from discussions on lkml in all previous > > attempts. Hopefully, this is the final attempt. > > > > [1]https://lore.kernel.org/lkml/20230913073846.1528938-1-yosryahmed@goo= gle.com/ > > > > v1 -> v2: > > - Fixed compilation error reported by the kernel robot in patch 4, also > > added a missing rcu_read_unlock(). > > - More testing results in the commit message of patch 3. > > > > Yosry Ahmed (5): > > mm: memcg: change flush_next_time to flush_last_time > > mm: memcg: move vmstats structs definition above flushing code > > mm: memcg: make stats flushing threshold per-memcg > > mm: workingset: move the stats flush into workingset_test_recent() > > mm: memcg: restore subtree stats flushing > > > > include/linux/memcontrol.h | 8 +- > > mm/memcontrol.c | 269 +++++++++++++++++++++---------------- > > mm/vmscan.c | 2 +- > > mm/workingset.c | 42 ++++-- > > 4 files changed, 185 insertions(+), 136 deletions(-) > > > > -- > > 2.42.0.609.gbb76f46606-goog > > > > > > Hi Yosry, > > thanks for this series! We backported it on a 5.19-based kernel and ran i= t on a > machine for almost a week now. The goal was to fix a CPU utilization regr= ession > caused by memory stats readings, it seems that this series was the last b= it > needed to completely fix it and bring CPU utilization to 5.12 levels. > > FWIW, > > Tested-by: Domenico Cerasuolo That's awesome. Thanks for the testing!