From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA4CBCD1284 for ; Thu, 4 Apr 2024 23:36:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AB1B6B00A1; Thu, 4 Apr 2024 19:36:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 45BFA6B00A3; Thu, 4 Apr 2024 19:36:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2FC7F6B00A4; Thu, 4 Apr 2024 19:36:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0FEF36B00A1 for ; Thu, 4 Apr 2024 19:36:46 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 994FC40C29 for ; Thu, 4 Apr 2024 23:36:45 +0000 (UTC) X-FDA: 81973461570.16.CFCA1E3 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by imf10.hostedemail.com (Postfix) with ESMTP id E5FE8C0002 for ; Thu, 4 Apr 2024 23:36:42 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=eahlkYVu; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712273803; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oPaPLo4tvZFunx9Zm5TfZKvrRMiMo0LvEV2TyEtrGw8=; b=2fNqqlMA7XyP/Yx/xR8v8ySr4ILi4xCSqVm7HNOFv2yi4uSFx+z32s3RwfV8tHoXoAd9IY aH7ssqxI/GMWEsOwkMPg4avyEElPzJgoppRw9ihCms9D1AKcU1ZrIwNDcOFhVHZurL7SGO XRKqRsstKmOpXRbO7qB6thwXBct4yaM= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=eahlkYVu; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712273803; a=rsa-sha256; cv=none; b=EuKzPw8g2ljoD5Do5r0y8WMhRsAd3DmwVxqGZTM61wJ6rcquOGHoogbx5yfXvqnEBTiWWG /OHz0VTX3rJR78IQSCHvlhv3/1o096Wo8uR3miO3yPOOR3+WdAuCjALerNeeReAKRhN4ot bvddFHl1duSwarS7yy7NSvWyqqfVU38= Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a4e62f3e63dso203973766b.0 for ; Thu, 04 Apr 2024 16:36:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712273801; x=1712878601; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oPaPLo4tvZFunx9Zm5TfZKvrRMiMo0LvEV2TyEtrGw8=; b=eahlkYVubEVjjMvZK2FgzSsl7MyaS88hEeKrhHC2fGUMAmSgkl+ajJmtMLKQvJ64Zb sYWmzzPAUAfNceAS60jS20M0rusOhkmGhNubTngbzQJtxAz7O3cBzm1w5gnEH5TXmpzO YPMHZpY8RvNktkueqi+A0xPvYZ2uS1dq/LKWS975ojgTZL3DyZn7WJER9hjYK8g2b8++ H5nnn/uTgZBJy5u6X9D9mVCXJJndab6qAl0lHPVTFKztHSkcK+8o836Ru5RzXdbAnB6w imEWqBxqOH+iflpYmeS7YFod1TRDmfCe3lvhhgUyUELVNRcB3F4GZHMuXABu02aUD5M3 abgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712273801; x=1712878601; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oPaPLo4tvZFunx9Zm5TfZKvrRMiMo0LvEV2TyEtrGw8=; b=RyBo5yFIDIDWj9QNERb5HYMlhsmOMNRgFi5zXGfN7WXbq0L+xLA0owK4Fko9XJMSB9 K2To4NfDXYpnmc4N5OUfDQSpACNKqAnOR6/GjX+QJzrSviQ/yRl39uu1yYTqhIHF5Afk JR0TnOvyZDoYX2hF5ejDq2eCSE5ulwD6LqVNEsK6IHEC4sp1cYZ7PD3IqALneq1K5QhC yCB1mrq2oVKSKF+U+gcCgbXK0Lr2Q/U+8pfaLVpcgfARheEEBUH2cGXhCe7p+FORC8hL eXIxs8pYMekDxTAfbjno71LAVX/V464g8xKOTD3flaMTUE5IOZDq0e6sXw0WTRnqr3I9 jqiA== X-Forwarded-Encrypted: i=1; AJvYcCVat+0RgN4xrv0Wl0u/2qfc7E2ZTFPy1xcBeCWIb3uW98iHmBx5Gq/bXeBb457cNFVY295OviNTOFBmo+DHZQtx5d0= X-Gm-Message-State: AOJu0YwjmYGg4n97PKQU/8djFQAOWYv+bUwffYaavouyiLYpKoP6l0re 1xJADvtX0kKUUeY89ojqwoD7JFJhhL8qb/ORJcaedRL5VoZ79wvATbIbI+YYx5m73NxT5OTndnX V+7r8QseiKnWWHtalaZ4VdyOWLQcOO0vL6Cfv X-Google-Smtp-Source: AGHT+IHgW8H5JiF83eWk2CFNYwC1L+/Z6Sy81eE18wk8rH7kEwSDoBNRg3oIUIv1wE0Hit+Kk3O2AQVQPQrOwuBDwCA= X-Received: by 2002:a17:906:5290:b0:a45:ad29:725c with SMTP id c16-20020a170906529000b00a45ad29725cmr683187ejm.62.1712273801359; Thu, 04 Apr 2024 16:36:41 -0700 (PDT) MIME-Version: 1.0 References: <0000000000007545d00615188a03@google.com> <20240403180752.f95e1b77e033b5e03164c160@linux-foundation.org> In-Reply-To: <20240403180752.f95e1b77e033b5e03164c160@linux-foundation.org> From: Yosry Ahmed Date: Thu, 4 Apr 2024 16:36:03 -0700 Message-ID: Subject: Re: [syzbot] [cgroups?] [mm?] WARNING in __mod_memcg_lruvec_state To: Andrew Morton Cc: syzbot , cgroups@vger.kernel.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org, muchun.song@linux.dev, roman.gushchin@linux.dev, shakeel.butt@linux.dev, syzkaller-bugs@googlegroups.com, Yu Zhao Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: E5FE8C0002 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: enrqaayo1q5wmqr4k9hcw4nuidk4wgid X-HE-Tag: 1712273802-2276 X-HE-Meta: U2FsdGVkX19/MXcpBDIrlcLI6tv3lIJ6HQ51XOqOpwCJLqyjZrKL1k0YHYr8UF4L8wrPGNBdodAHyuOMgMYJTsG56gguB2i073oOBF9V/V77LhOZuL50HE95LAfkHOw3lC0WEY3XVYpoKA42tVY6n27uWe//YuEovXtl9KZMyWgVxjo9dh+sbpexc8TwSzfgHOTCkuksUFTr0rWGcAvFa2pXHUhksH7Ayj1tU1krigLb1z1eFWMkaqEHxt7ihPYDKqWZeUr6vc4HKeFkRPMnUTM+zvp/xx6qnfZRhP5e/XfFegbH54xzkqvZG0zmDVHAAHDP89i8n6iUNL910y012xxW31EYM6soGmue3XWPE1/b+kYlZri10jKpiBr9V81TEg+alPSm+9y98M3UFRiNSklauVcmuaVNZWh63OTpArH0tBTelgKvO5OtdaFEEZgQvpskO3ev+3T41NUiMs6n+mJVlWrLW91W9ASfEuH78xV287QnBDcDHB6r0j9YsZjomePgT3kLtCy79Oz7QDEPXahxIGmJGyWMlcLjHd394dtNfyP3zr5sAkmGUcpkI0JAJ6JZGL4qcepBaPfldAqWbQmsMYBhPEw6yKKWaJXJKiI8xUWhjJdu4BcgRYgu7k7rJpolx0wQYL8jD/NGDVnUUPAxPTjuuB1zhRZhW9NXb7BZcrF1OJ1/ZtGAMjyCzuZZ1QFrNDtKW/ysKPSRSUHUR5cSJol/liBaKGPoWyWTMCUw+yuroCFENhSpPHQdp/m1KDLJ2ZH9dWLiRP8f0koHSs7MLB3FqToyhXXw4uiLVedTEfDsuTZ+9GmhBMEjqeBaLuQNmZ5016dyxeAoYi5gwWFe0bHf+8SCQRVgUN8qA1RQEtRyINmJlQu3VjU2I3tNX5YHOShh6LeIjfTU7VVzDVPlIQYdXTN0XyOIJdFPAB3PLNnRrVqfMLr1EkUGev61Ya37wUEIrVcf5CRVoKS ptPSJYyE /mIZ1J1CPHPOzxiIE0CdQhXHMJA9wu6CmcMiyTttsFm+W8u+VCkvqxDrih6SlLwMc598TwmtkwwMXnbACXkKLtWP9ai2+nyCWVTYTeEuR1s+oQEiwPvSJOxaZjsfLHoPcWBAsuSVHboNgmPY/VmMtcQbjEO1Rh8HDJxuLRZpexKl/j9vVFvF6PGF43yXZlJz+ROA5eFqgTvWWoJzUJBwxZ6n4ykYRHFKOAE6tfE1lOKwzBOqSuJDwsQVUHvwrWH7iBUuWl2ZK2Ts88gLGjzzHGeL45Y4RvqmSf2UilIZtH9sP4cA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 3, 2024 at 6:08=E2=80=AFPM Andrew Morton wrote: > > On Tue, 02 Apr 2024 01:03:26 -0700 syzbot wrote: > > > Hello, > > > > syzbot found the following issue on: > > > > HEAD commit: 317c7bc0ef03 Merge tag 'mmc-v6.9-rc1' of git://git.kern= el... > > git tree: upstream > > console output: https://syzkaller.appspot.com/x/log.txt?x=3D15fd40c5180= 000 > > kernel config: https://syzkaller.appspot.com/x/.config?x=3Df64ec427e98= bccd7 > > dashboard link: https://syzkaller.appspot.com/bug?extid=3D9319a4268a640= e26b72b > > compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for= Debian) 2.40 > > > > Unfortunately, I don't have any reproducer for this issue yet. > > > > Downloadable assets: > > disk image (non-bootable): https://storage.googleapis.com/syzbot-assets= /7bc7510fe41f/non_bootable_disk-317c7bc0.raw.xz > > vmlinux: https://storage.googleapis.com/syzbot-assets/efab473d72c0/vmli= nux-317c7bc0.xz > > kernel image: https://storage.googleapis.com/syzbot-assets/5ba3f56d362d= /bzImage-317c7bc0.xz > > > > IMPORTANT: if you fix the issue, please add the following tag to the co= mmit: > > Reported-by: syzbot+9319a4268a640e26b72b@syzkaller.appspotmail.com > > > > ------------[ cut here ]------------ > > WARNING: CPU: 0 PID: 30105 at mm/memcontrol.c:865 __mod_memcg_lruvec_st= ate+0x3fa/0x550 mm/memcontrol.c:865 > > Modules linked in: > > CPU: 0 PID: 30105 Comm: syz-executor.2 Not tainted 6.9.0-rc1-syzkaller-= 00178-g317c7bc0ef03 #0 > > Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-= 1.16.2-1 04/01/2014 > > RIP: 0010:__mod_memcg_lruvec_state+0x3fa/0x550 mm/memcontrol.c:865 > > Code: 45 85 e4 75 1d 48 83 c4 18 5b 5d 41 5c 41 5d 41 5e 41 5f c3 cc cc= cc cc b8 00 04 00 00 e9 80 fd ff ff 89 c6 e9 a0 fd ff ff 90 <0f> 0b 90 e9 = a7 fc ff ff 48 c7 c7 18 43 e1 8f e8 32 51 f8 ff e9 5e > > RSP: 0018:ffffc900034beef8 EFLAGS: 00010202 > > RAX: 0000000000000292 RBX: 0000000000000001 RCX: 1ffffffff1fc2863 > > RDX: 0000000000000000 RSI: 0000000000000001 RDI: ffff888024b92bc8 > > RBP: ffff888024b92000 R08: 0000000000000005 R09: 0000000000000000 > > R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000001 > > R13: ffff88801c326000 R14: 0000000000000001 R15: ffff888024b92000 > > FS: 00007f0811bf96c0(0000) GS:ffff88806b000000(0000) knlGS:00000000000= 00000 > > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > CR2: 000000000cfff1dd CR3: 000000003e4e2000 CR4: 0000000000350ef0 > > DR0: 0000000000000031 DR1: 0000000000000000 DR2: 0000000000000000 > > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > Call Trace: > > > > __update_lru_size include/linux/mm_inline.h:47 [inline] > > lru_gen_update_size include/linux/mm_inline.h:199 [inline] > > lru_gen_add_folio+0x62d/0xe80 include/linux/mm_inline.h:262 > > lruvec_add_folio include/linux/mm_inline.h:323 [inline] > > lru_add_fn+0x3fc/0xd80 mm/swap.c:215 > > folio_batch_move_lru+0x243/0x400 mm/swap.c:233 > > Well it beats me. I assume we failed to update for a new case. I'll > toss this into -next to perhaps shed a bit of light. > > --- a/mm/memcontrol.c~__mod_memcg_lruvec_state-enhance-diagnostics > +++ a/mm/memcontrol.c > @@ -860,10 +860,12 @@ void __mod_memcg_lruvec_state(struct lru > case NR_ANON_THPS: > case NR_SHMEM_PMDMAPPED: > case NR_FILE_PMDMAPPED: > - WARN_ON_ONCE(!in_task()); > + if (WARN_ON_ONCE(!in_task())) > + pr_warn("stat item index: %d\n", idx); > break; > default: > - VM_WARN_ON_IRQS_ENABLED(); > + if (VM_WARN_ON_IRQS_ENABLED()) > + pr_warn("stat item index: %d\n", idx); Line 865 from this commit should be this warning (i.e. warning because IRQs are enabled). This also makes sense because __update_lru_size() should not be updating any of the above stats. folio_batch_move_lru() in the above call stack should be acquiring the lock with IRQs disabled though, so I am not sure what's going on from a quick look. Adding Yu Zhao here.