From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE20FCD5BB8 for ; Thu, 5 Sep 2024 19:28:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5543E6B0085; Thu, 5 Sep 2024 15:28:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 502B36B0088; Thu, 5 Sep 2024 15:28:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C9F56B0089; Thu, 5 Sep 2024 15:28:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 17C6B6B0085 for ; Thu, 5 Sep 2024 15:28:51 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C08A9A5C05 for ; Thu, 5 Sep 2024 19:28:50 +0000 (UTC) X-FDA: 82531672020.24.8F401AA Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf08.hostedemail.com (Postfix) with ESMTP id 02E8C160016 for ; Thu, 5 Sep 2024 19:28:48 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=lT52V0Uz; spf=pass (imf08.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725564431; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5KLmKjwBlcsqYy7uwv8s+snyzzCreAuqR4mvIYss8N4=; b=tTFIuZyA15cdTBhCeVH87hmorofgAwf5HDP9Zdn0qrLax1gD68IPds9JWQDwt1L40adMVF r4Oz94cyaH61yTJOMZLAc5FYM/vS6XEdNDZq6veEtwW4FNbqvAa7DN7q4s0S2AKY46zyk+ U8hmdXHkVW90aOElUzogx95PoTxfEFE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725564431; a=rsa-sha256; cv=none; b=T6mR4fGhKzKtexCf879OZYcxLKegw+m6N5jWj1Th2lSOMs1ayu0zNMjWT4v8+ef9g+uIdL PhRxB8RW309x7hac8PMbjwmil7iOYWweqZo877HY2GYlcueBMRL0gvluk+/joAMrLEFTxK P0y6u8MO/KcDPtKVyPZCyBvBWJ98FmY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=lT52V0Uz; spf=pass (imf08.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a8a7596b7dfso162679066b.0 for ; Thu, 05 Sep 2024 12:28:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1725564527; x=1726169327; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5KLmKjwBlcsqYy7uwv8s+snyzzCreAuqR4mvIYss8N4=; b=lT52V0UzOGl+OWbsU11TCWsv+SsnYMj31RtoTspp5N4CQusR+JL/YMwXGnnXRijf8u M/kclhDuwWDvRECD38D4ikjyDVZCO7nCW8TATw2sjQPCFY+csykgrVTi8bWA3gAyjVi6 j+bH1IPOJetG41eR/UdkAH53DSDaaRsSi3BlOQvxwhs1gYVpqaVgjPGnSY/LRAHDheMQ U1iXdcCvNrM3PJk6sYdij2HP8Y5EsZmdkz4gFGazxROMSC/OKCXS1C1fa4DjwoZzZtBH tfs7GYGfcsV8YNmx7VwmBxwv9pYdPlSO7YPIqef2xqd3BbONR+JfZQvkcwZNA+YIegaT 4/7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725564527; x=1726169327; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5KLmKjwBlcsqYy7uwv8s+snyzzCreAuqR4mvIYss8N4=; b=mkv4hGIxdG4rE7BWMIaCU73kaxkwCBbMHsAs/h43WuDJ2yfabFVJNWZLUVHDzsEmi3 W3/6THv9Z1DBKTe/JBqgxJ+/CllQkRORYPd0Mv8J+lwmpCL1bbJitPUpYel/yb2ZjM0L w9Vw2mjvg1d6tSS0BRKAGc6UERZmMcbevrJsIGaF9R5sHXSFINUdYVE5uuh6nf58LXxA 8exxCh9qAAm5w6OiQrl92hZKrPFUf64vLni+j4dom7pbjizi9b/yCrZO6M1ImshyZEou YGGY9K7/zciu50kkclN8ZbrV7MXwBLhz2bk+CzRkR0tCpp2QoIbcRXpaYsNvZ9nFktR0 hNMA== X-Forwarded-Encrypted: i=1; AJvYcCUtwdwLtmFFV5XSxyCI2phDOosMA7Fuw5Z3J7D6E6QNipcve0saoC76KKT95rF+9cCbcpKq7U+wMQ==@kvack.org X-Gm-Message-State: AOJu0Yxu2SSU/Y19kowou5HCslNn3LaFx4r/trsvxBrzfmY22VFHFYGe tisP9R+aoVIQzE/MwWO2aARH9UEYommfXw+ayOiy/oT08fQ7Z4g7W9GwoyR7fnnrEksg4o53XZE og0W5yMI7Z9XVZtXKBfKsUHstrOjXoAoSpmzz X-Google-Smtp-Source: AGHT+IExMzKdlKYyXmWF9bvws6Z4vbYhzd+WTREiDX1gnbcal6mcDklJpHfUw3bCSBISZNBsnBsi+GgPB3T7pvpvST4= X-Received: by 2002:a17:906:4fce:b0:a7d:895b:fd with SMTP id a640c23a62f3a-a8a42f8ae77mr631412166b.6.1725564526354; Thu, 05 Sep 2024 12:28:46 -0700 (PDT) MIME-Version: 1.0 References: <20240612124750.2220726-2-usamaarif642@gmail.com> <20240904055522.2376-1-21cnbao@gmail.com> In-Reply-To: From: Yosry Ahmed Date: Thu, 5 Sep 2024 12:28:10 -0700 Message-ID: Subject: Re: [PATCH v4 1/2] mm: store zero pages to be swapped out in a bitmap To: Barry Song <21cnbao@gmail.com> Cc: usamaarif642@gmail.com, akpm@linux-foundation.org, chengming.zhou@linux.dev, david@redhat.com, hannes@cmpxchg.org, hughd@google.com, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, nphamcs@gmail.com, shakeel.butt@linux.dev, willy@infradead.org, ying.huang@intel.com, hanchuanhua@oppo.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 02E8C160016 X-Stat-Signature: ecoe4jixnrwop3eidrr86f753n1hir8n X-HE-Tag: 1725564528-270635 X-HE-Meta: U2FsdGVkX18GHMMfsqUyK57qhhJylPoR0zkQOOpANx2g5SDOC4FZRnYKpB0ID+7enZELUZGVXBAjHOKkIxxM7pkBuiwADaW3qn3qVH1urQVeR1lMSMAUxL7RKfhbEK8pUkjmdRalwnwbDRzHTvvxorG4x3Ndj9ypbfbpxJSTOh1TbcrH+qp1kLEP+vYdYy7IBMWUFpr4YiR+JJgIjwBVpWV1wE1ymIAhidvMZGT6R4UClNL/UD5bvARI1r3NWKMY8qId5uqpPY+FK+7hVelLIMoHXqoC8pTy6tL83ND9ZchzAQMaQi2zNIhdnbxEqodTVbBqcddO8c8ZeUw/513MAgGh3WM1fRjlJZu2pGexXOKIOXhqK5b9B+cguK1Hpcje3dVWVWI2SxfIKaDgKfPbdEXjOPnP0tEwBW7KSsyWTFpEb7ak9Y1/0sOVFTUhCfzJYnKpJdpSSf1cfToAZ26rd24ZGzKA8B0EdvzGpREv8QgNLLmQ4UvNuVqpbV4Q6kx+tysJEnpUK+IgQs29clLgdcQ0afUiJHVAfcwK6Sc/VhtlOtZ9+QxZ6bJMX+WUzxRM0jtn2g0rjmfJPaFcFS45FCcspIF9fsznj0GpaPIFa66FQR4PhtlsiB64hZufuw711lZL3WJyCkkGrKUP/cTkl9dhTPNmdNlBvF+yCYGXbC30ZzH+IYirrwDjT5LyyzJSNEm3AsHI/ph1Vbfh4Yc0qk7uJwko/haEb/C5CKttZEI7e8/FEuf4+73EqZ/ArVpkl/6196xYQ9UicEOu4PN3yHB8F686C+mSxGaVwnFcE31vp/+PHUnL+DO9R+fPPcrUKnKBcEJ68t5HpNDKBXSwbOACxbg7xQlTjudy0eNZXAzzWJ5SVu1yo4DAVM7conO6NOWz9kLmSPEryv7nIRtr0AtJC8zebBSGFhEPPbI1jOp0EisEC7yNZnuaNam0yqxJYm+avzkw1ZmPuMH5tO3 LNyMrSHn joyYfIXaSpSRfVR1ZOFv1kgjfyodDpOs+FpdJTB8esRoI/r5D3rzcLKu6N/++Dbz2ol+iEOBwYoDK+M2tG1O/wA250TjYcI0SatZW0yluj+vJwyMmOSHzZnM1Se5IY8IZs/gHkz7/g41KRZ4JfKN8nJh64LHNsR5oMD5p0gUOB/+kFAQZZd1EEngoZBVNYwol2ghz X-Bogosity: Ham, tests=bogofilter, spamicity=0.001380, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: [..] > /* > * Check if all entries have consistent zeromap status, return true if > * all entries are zeromap or non-zeromap, else return false; > */ > static inline bool swap_zeromap_entries_check(swp_entry_t entry, int nr) Let's also rename this now to swap_zeromap_entries_same(), "check" is a little vague. > { > struct swap_info_struct *sis = swp_swap_info(entry); > unsigned long start = swp_offset(entry); > unsigned long end = start + *nr; > > if (find_next_bit(sis->zeromap, end, start) == end) > return true; > if (find_next_zero_bit(sis->zeromap, end, start) == end) > return true; > > return false; > } >