From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CCF9C77B6C for ; Thu, 13 Apr 2023 11:30:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 248136B0072; Thu, 13 Apr 2023 07:30:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D12B6B0074; Thu, 13 Apr 2023 07:30:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04A40900002; Thu, 13 Apr 2023 07:30:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E64A86B0072 for ; Thu, 13 Apr 2023 07:30:22 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A63FA801C2 for ; Thu, 13 Apr 2023 11:30:22 +0000 (UTC) X-FDA: 80676149484.28.17A1392 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf26.hostedemail.com (Postfix) with ESMTP id D6ADA140003 for ; Thu, 13 Apr 2023 11:30:20 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=FawizVY7; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681385420; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r9VZRy+ALIrbnuoSe0PNBBfvqUV9FWtMpLqMl4pVQlE=; b=wUmDfwp4jN7RiPsMUGZZ8tHvpbBwqF6gbxx8/pWPyaBVmgPQJ0YYboRC7sdiYSH+XukN8A fvGRBfJSsNYaBRqi1sZ83gbnDbMIoL60qM55iEpR5Lrp7chleEO3Pt/lQIGYFkTli6vc4i rFzkoiwP39YDtnnpVPMaG57uxDrsEW8= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=FawizVY7; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681385420; a=rsa-sha256; cv=none; b=dPa7ZvTVK+o3TeOmgUXDP+B+cRIbBN6XDIJ1rNnZbgnJeRe7Ry2mT6Ehrt553NQNFhpHdZ q7/b3mW/93JCxTYRwCXKvQGG6xLiWxugo9SBeB0FEUOCUf03Y7RdSRAe+TXCqoeu6Jn/GK lMLyOPIbRrAw3vhb9MnWPYwVsYFreHc= Received: by mail-ej1-f53.google.com with SMTP id z9so9555849ejx.11 for ; Thu, 13 Apr 2023 04:30:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1681385419; x=1683977419; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=r9VZRy+ALIrbnuoSe0PNBBfvqUV9FWtMpLqMl4pVQlE=; b=FawizVY7HhksSlM/EXpzcpXldi+yCz4HZxgMXFrA0D7TY4SooKByYRyl/PrpnGtURT U6ZKsSzk7dtuHBeRnU6ubUixkbtyvQKJMGIGlbSWvMmR+qYeXlDB7bsjXKsp0vUodqxS m++tC1HwAEMoJw2Z8Byx/zXZc0awaueEJ+rjFerBgu6BSFlkLZ5kDARUp5jMzmZuP+2R YavPMLdiDbZj4QeI9567bpyOc7Su1ZUmVqDBnoD3ih8M3yTN3z81SNKoOCn9/EFVOzkE xLRdq6Jac5+YtYp0Wtfjk1nyUNJJIKHH7MXAgKQriYtIcNy2davJ3g7H0KNWCGx5h1ZK SLZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681385419; x=1683977419; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r9VZRy+ALIrbnuoSe0PNBBfvqUV9FWtMpLqMl4pVQlE=; b=elPQZHK+jWnZKrlJNym3qy6mZgQm3jeN7dCxtcM52RIbGSVt5QvVHXf0QKZpTBpxBx 6OdY7zpum7t91gNfN/ygArd4O2Lclt7jFUY8Mz1tLgVTBOFmsT6OF6GxLD9Z39NEYDlQ VsTllg4mBFhH0suEy1fxKL1+jnJCsaxRZJeiUAvZTTEgQxbYeQnLNpdBGfyPNKfYBxvt TYBcYsCOB++1218imIQnEFkb7SpXzyO8Z79S8I4v05x9/cIhqhTxpieWZtr8DwojE8l0 7MPZbTG11KDBCbIBGs9KfGnjrZFGsVm3UAwaX6UUw9I4De6WEyYXflm5PxMtLWKRwpfK XrrQ== X-Gm-Message-State: AAQBX9fTUh1tBvmaThyJwrGx6QFEX6rciHGarxULsX7uvJwnQcxMddvi venbYWx1NtTIccFoamaXb8Ra+SaEd9G3dqFSUuj9Kg== X-Google-Smtp-Source: AKy350YGfS9e19HP05Oiznjy9Mfa8a36DWz+4bhJqVxRh8Sp9QjK9ffjx1ux2/OVFijfQ9Nymg9OabFJJrpzaJeAblM= X-Received: by 2002:a17:906:f753:b0:933:1967:a984 with SMTP id jp19-20020a170906f75300b009331967a984mr1014820ejb.15.1681385419329; Thu, 13 Apr 2023 04:30:19 -0700 (PDT) MIME-Version: 1.0 References: <20230413104034.1086717-1-yosryahmed@google.com> <20230413104034.1086717-4-yosryahmed@google.com> In-Reply-To: From: Yosry Ahmed Date: Thu, 13 Apr 2023 04:29:43 -0700 Message-ID: Subject: Re: [PATCH v6 3/3] mm: vmscan: refactor updating current->reclaim_state To: David Hildenbrand Cc: Andrew Morton , Alexander Viro , "Darrick J. Wong" , Christoph Lameter , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Matthew Wilcox (Oracle)" , Miaohe Lin , Johannes Weiner , Peter Xu , NeilBrown , Shakeel Butt , Michal Hocko , Yu Zhao , Dave Chinner , Tim Chen , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D6ADA140003 X-Stat-Signature: utpb9ihrine3ionxg9zzcm9mauawtpn5 X-HE-Tag: 1681385420-875223 X-HE-Meta: U2FsdGVkX1/khkVJpxOOA9LnngR9FvgCjTu7mE1v2ZMX5gflxMo8ztgrpzYaPk2zFY8XRHypLkPadzyDsHm7OVFzqV0Q1NDnIo9OD34QiEifcCsIzwB6khTLcO+BrZz5KuYHdgv6kIWeeNdplkRcTOhNuNgZmLPOkVd3G/VngrjkenVgen1h/9+1RssYt3nHKdhPPppKys7NRVnFceWnuR5JwOIoSh0ZMJC4ogWWlIUOjfDysChm7/RK88UC0f6e15APFw9Ubjy7EFYZE68nFi+e17FzqQAGyld4/6URPzNRIYCXz71o0q/vmPjBL8jQ+nmDIrPfcOtEX6gmU49WLn5sQZTo/X6Y3osp5POhexhPVu44tk2iZalbs8MZlTF8H2kH37UZyKPZWnwMZDYuvz3f4vuaCqs4LmzRIAU5KmGFTvFNXoYsSdGwhJucnTt9Fg8waDcDF5E70MYVy9BVDCUQSLzJ9w49vONGYWhIzf1Gn7Es/cf7wFffQX9H9X8+xgT9594DBv/zof3QTcPFj+VXNfByACPxsOJ/hAkHuz27Ie+mVSp3eTjb1D5u6qtb/soGXMRv7/jCCY+qmp9uFxh0b5zoDeZXLCSqgb6o00NcOewneujG+gjDXfFtHzKswQolhXim2xJWTR7A9GWNsamv5jwrGWEdY7hL+tRYY69/15iOz1jnJZGVw2SBkSYpF1QJCir1Ph9QcWwPka4mMsJNDqNAqaK9mI/Vxd3GfC11PqUpCvpJhaKqHfwMi563t2snYNIr+n/w/ttU/yCVsaBNrL0ZnTpRmwAZB81bXsuOSqilcsha8gfQc1PQQrunFotM8QPH16cDrtGmrlQsjJs5TDdCCqd2NS+mBstUR2iBgSVXwYKF4VBE/P0IYcT33/L0LgaAvz+up+HkePLaCBsNiEfrW+CKmosM0DOVSXJj2fqrqihDutPJrxHB/mbl3h1S5QguepL7Uv8zFeY VpLNUDpe bzHxIG4HpwLMk1r7fiqIpKw8pOKZWbdbhOL5RsavZZ3hmbr6GVeEHdhSmCZ/fa5JzpNO0o2y9W1UFvQVSa93eUrHf6BTEh1ibY0A3xfGgGjCwqZm1xNgHuhhNlIn21K9iM8iLqS5vijACcVQ+gHtYBV7sy0I+KpjLYisoHVlED1W4Xv5rT43JEbNmVS1110bv0U57J8v8i2bVv2VQ1uhoaa+FTJ5j8UYFkIx5lyfQwIeGpeANUvGorZCkIGdkXVm4BlFHfX1GTyduN5vWJw7EUtYFyNfom0QXjWps0o368f1zWT1PIQ8GXOxu/CznI1WSSGYsi0zO5V9kifpwIgb203JVAObq4Jwo006RgUaRa15Joys98EzewT0+aXSCtR2At4ZY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 13, 2023 at 4:21=E2=80=AFAM David Hildenbrand wrote: > > On 13.04.23 12:40, Yosry Ahmed wrote: > > During reclaim, we keep track of pages reclaimed from other means than > > LRU-based reclaim through scan_control->reclaim_state->reclaimed_slab, > > which we stash a pointer to in current task_struct. > > > > However, we keep track of more than just reclaimed slab pages through > > this. We also use it for clean file pages dropped through pruned inodes= , > > and xfs buffer pages freed. Rename reclaimed_slab to reclaimed, and add > > Would "reclaimed_non_lru" be more expressive? Then, > > mm_account_reclaimed_pages() -> mm_account_non_lru_reclaimed_pages() > > > Apart from that LGTM. Thanks! I suck at naming things. If you think "reclaimed_non_lru" is better, then we can do that. FWIW mm_account_reclaimed_pages() was taken from a suggestion from Dave Chinner. My initial version had a terrible name: report_freed_pages(), so I am happy with whatever you see fit. Should I re-spin for this or can we change it in place? > > -- > Thanks, > > David / dhildenb >