From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3C99CD98E0 for ; Wed, 11 Oct 2023 01:48:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 200C08D00C1; Tue, 10 Oct 2023 21:48:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B0938D0002; Tue, 10 Oct 2023 21:48:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C7638D00C1; Tue, 10 Oct 2023 21:48:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F21228D0002 for ; Tue, 10 Oct 2023 21:48:53 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BE9211CA927 for ; Wed, 11 Oct 2023 01:48:53 +0000 (UTC) X-FDA: 81331496946.30.E5065AC Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by imf23.hostedemail.com (Postfix) with ESMTP id EEBE7140007 for ; Wed, 11 Oct 2023 01:48:51 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Mp6ytsHg; spf=pass (imf23.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696988932; a=rsa-sha256; cv=none; b=pDqnl9RPbHTFTsG68DKH/anfFEyuKG12yKVIC2hA064BXdTRXhnUiqCnu83S1hyoA1XrtK oryW3FGZFetsq2tyzFST+50OgXm68S2sQyRRfU/+7xMepQdOgt6r6A/j08EEzHS+K1DYgF iW0qc4NPZjvg0AaKRjuXEnt2aWJ6yBg= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Mp6ytsHg; spf=pass (imf23.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696988932; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LgmTMfuU3cCeLGy5YhBbbvizhGvmrwNUjrSNHCgxSVM=; b=0GBfb2tnWC8RjrT9YJfMwB6TUjL5PPazNNG6BXSo3c/UTASAFZMjSABFqQKvP7VH6omTsP uhMonMzUpYlwybhEQ99hbQvSMg6VlGm65l4dRD6HUXGaGgqyr9HGgDVNgtb539keSbHTih HXyU/Ei1tbBUetXgigWWgKH9ZMF5u9s= Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-9ba1eb73c27so489373966b.3 for ; Tue, 10 Oct 2023 18:48:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696988930; x=1697593730; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LgmTMfuU3cCeLGy5YhBbbvizhGvmrwNUjrSNHCgxSVM=; b=Mp6ytsHgrUilTR6C4oexdREZ9TIynKJiWswcziluik57VTdH62u3XZV4VmxTxrCJVc Z7DLE2FlTIwaiFzQpDxoA5XgZeFdZy5v4d/uqWQJT5BU8WC/CAr3x3fOGPLTd2a8NZ50 JsCPb6Kh7vMFNGWYV5pJ8YZ7sIQgquCP/NoMF+qseSWplr0zVWNjxYKp+30V5ep/qNno 5M5EbUKvS99IbBNhKYcXSfrD0cPyUyZbtU0C6N4wuAvAb+RMf4wMfTOGhAvExdrqx6uk Hvz9Id3/RwEDdJRJHPChbmJML5M4nFHx5xmrqSA5BXitBmUlt1UiyXuhaPcJ9u/W8JGK y42w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696988930; x=1697593730; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LgmTMfuU3cCeLGy5YhBbbvizhGvmrwNUjrSNHCgxSVM=; b=bIrsIO9om2fnRZ/Y82P/TpGocfW4JkAeZe41rLOjhm2N9Cjg/1VVeYEqVKxdILKgCM yi/QcH9tDby7mSJOHC6MSxQneHu3upCT0xjWlxY5oVxTKxhCtsPWML+Wsb7VDuhpVJue JgbDKwDNECTqnJ9tKo9hJuAn89kYl0TTxps7k69G7dVz2DpkVkpjz2hbdSQehhMjAvj3 SlCxoTmwdpVqD+kIfGOsU9PAInA46GWYNwIPpKlNhFpSnda7wgK6TFtvECCPKalpliXG RnxLzGiFcsm7Ix99wHUQqd5gld4qsXQMPSdWr0Ub8TKNfEQuJi6a9LVh9E9r0wTBQGym wP5g== X-Gm-Message-State: AOJu0Yy7vH6fedxh9EatNESQnryRZDj1zxHNbCxGLLvw5/GWvSz4f/sz i8NL4/dnBGW7nAHVNIOS9JJi11NDG3Rpb4hpwF1x7A== X-Google-Smtp-Source: AGHT+IFG8zP5Syqi5MZ6+G6K9VUFI90ompaJz3mzhBWqc14rM6pucl7DnlfREAkMgADEGF+ZpGnbG1KidG8/lnu9PFw= X-Received: by 2002:a17:906:32cb:b0:9ae:7622:eed9 with SMTP id k11-20020a17090632cb00b009ae7622eed9mr17959783ejk.50.1696988930108; Tue, 10 Oct 2023 18:48:50 -0700 (PDT) MIME-Version: 1.0 References: <20231010032117.1577496-1-yosryahmed@google.com> <20231010032117.1577496-4-yosryahmed@google.com> <20231011003646.dt5rlqmnq6ybrlnd@google.com> In-Reply-To: <20231011003646.dt5rlqmnq6ybrlnd@google.com> From: Yosry Ahmed Date: Tue, 10 Oct 2023 18:48:11 -0700 Message-ID: Subject: Re: [PATCH v2 3/5] mm: memcg: make stats flushing threshold per-memcg To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Ivan Babrou , Tejun Heo , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Waiman Long , kernel-team@cloudflare.com, Wei Xu , Greg Thelen , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: EEBE7140007 X-Stat-Signature: kxbxsfppqjb5b6o5gc8o348rk7d8oo4w X-Rspam-User: X-HE-Tag: 1696988931-204721 X-HE-Meta: U2FsdGVkX1/AdaLiu2gKPT47ptocJR7FNsP0SX+G+7VTAFG0xA40SLr5nAydijBWgcK1GZTi8wa9djrFpGYpZOYw00qNIa+/KcKCJjm3p39KFNHP+c4l1Jut+wknX6AhHPz7UVgu2x2HAqQwmNqvrQJGgsRMQ00y1XEitEX+TXwpA3ry8wg0hqNP7PYpAU+ABzuOKT4DCXPU1AE+O0qeoJTeKQGmF5s81MdGXt/F1ZRqXWxmC+MK7X1tyR+l97NGwAJI7DdDlUR5LX/YRz3Mz3Ie5mzbinf5eI4AyNw6RDpHMN41v3H3iwE/YaFI/GaJBgfsR+KWl/9e5yYd6bm67xORcyUeV++vYXEnGvouzsYmjcOFYs/IhIdXmXlTTLFEVg0KhBV9TmSdluZAmLsQEO9L9scY2YYbGtAXnFBBgXBn4//MfqSq2MFcB1TrFyLBIOeR+KNlgxMIEQNW3Vx7B4yXIGfRLSOofKutOjQ2GthDoNREZqNOXn0B1XpRKPLu4EVw+1L2KFD/tU8uIpi4chEDh30jK7ucrFMJ2Tc8+57pFXd4/Ylyvp6dNlz8x0sB/xdYc9H5mmAuChAfmq6BtIeyN37xMBot69TIMjfjdIniLGGI8ppEkAFLYncFfGI2/JOmOjb/YVfF2xBQUYD+eRZNPOm2fStzqwI/zysGGn2BzsWc088OALay4e7tLQKNNpX5LD9U55KWLbDH8GL40zJwaYcF0KiYwSAu4wRf4IunsIJDeFNjwcGdPCliOwxOGCAu7rHdfOwP/jCfe8yu1egerI6Lj5Ap7vkiOcSg2VJlTt/QLLhtAlF1SnizxI9V+dCM7FF4acpj17iDJSFMcbrXipIbg+ZqyueJuwIo7aScY2rHyNhjkTIVBD/vozq+qZaBqTAiWeSTPz7XdqfeUT2VkUAaDt7Hly7IqK75KrxoRr/oWczJ1sSUaOL4qL8qLhLiK5JMtLTnoz/5SK4 Tspt8eA+ x+K/mULnNyyMYzcww4cpXcorD5q8oOY7S2C73dYUeQ0DWaoVWtbs0uemMOz2dP4zB6ArPX+oCzGfcCFkRL/ODNf60teX9vIlAZ4rbHMihdgOp3OKgCPLFgJDLfo/hbwcDTSiIrg1aQUXnlEPxkEoOtLYMRgVpqMWWR9HPMopthmaJpTSfj9HQaISUFPnLkBiYHbAzHY5p3K+UghWrh42NK+IcAVFMMUKkOicGKnM8rv/nMKcdAnjd+TiYiQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.003687, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 10, 2023 at 5:36=E2=80=AFPM Shakeel Butt = wrote: > > On Tue, Oct 10, 2023 at 03:21:47PM -0700, Yosry Ahmed wrote: > [...] > > > > I tried this on a machine with 72 cpus (also ixion), running both > > netserver and netperf in /sys/fs/cgroup/a/b/c/d as follows: > > # echo "+memory" > /sys/fs/cgroup/cgroup.subtree_control > > # mkdir /sys/fs/cgroup/a > > # echo "+memory" > /sys/fs/cgroup/a/cgroup.subtree_control > > # mkdir /sys/fs/cgroup/a/b > > # echo "+memory" > /sys/fs/cgroup/a/b/cgroup.subtree_control > > # mkdir /sys/fs/cgroup/a/b/c > > # echo "+memory" > /sys/fs/cgroup/a/b/c/cgroup.subtree_control > > # mkdir /sys/fs/cgroup/a/b/c/d > > # echo 0 > /sys/fs/cgroup/a/b/c/d/cgroup.procs > > # ./netserver -6 > > > > # echo 0 > /sys/fs/cgroup/a/b/c/d/cgroup.procs > > # for i in $(seq 10); do ./netperf -6 -H ::1 -l 60 -t TCP_SENDFILE -- > > -m 10K; done > > You are missing '&' at the end. Use something like below: > > #!/bin/bash > for i in {1..22} > do > /data/tmp/netperf -6 -H ::1 -l 60 -t TCP_SENDFILE -- -m 10K & > done > wait > Oh sorry I missed the fact that you are running instances in parallel, my b= ad. So I ran 36 instances on a machine with 72 cpus. I did this 10 times and got an average from all instances for all runs to reduce noise: #!/bin/bash ITER=3D10 NR_INSTANCES=3D36 for i in $(seq $ITER); do echo "iteration $i" for j in $(seq $NR_INSTANCES); do echo "iteration $i" >> "out$j" ./netperf -6 -H ::1 -l 60 -t TCP_SENDFILE -- -m 10K >> "out$j" & done wait done cat out* | grep 540000 | awk '{sum +=3D $5} END {print sum/NR}' Base: 22169 mbps Patched: 21331.9 mbps The difference is ~3.7% in my runs. I am not sure what's different. Perhaps it's the number of runs?