From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69941C76188 for ; Tue, 4 Apr 2023 22:30:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F1C686B0074; Tue, 4 Apr 2023 18:30:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ECC9B6B0075; Tue, 4 Apr 2023 18:30:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D6D1B900002; Tue, 4 Apr 2023 18:30:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C02366B0074 for ; Tue, 4 Apr 2023 18:30:18 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8514E1A0C41 for ; Tue, 4 Apr 2023 22:30:18 +0000 (UTC) X-FDA: 80645153316.09.7CB3D55 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf27.hostedemail.com (Postfix) with ESMTP id B697E40002 for ; Tue, 4 Apr 2023 22:30:16 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=b4IyRp88; spf=pass (imf27.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680647416; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0F0lzmh//kU6Hr/bZenUmvphqVbemCLYMPNErPk8x3E=; b=A+KIm5ju7i8/iWOsMAIkxPR9j7/4C+uSmosIJxofGkHiPUUvjkZaAPMnVBwcNOOpKWr3uS hK5riXabEIUXg0LmjEQoydUnOqmOzDTD+IWwK3h+5PB1YKAeMajbL2cqc0/VlAM/1F9ZrQ 4ulK3VEFQq6gEfWlGlBRqmMukzClLL0= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=b4IyRp88; spf=pass (imf27.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680647416; a=rsa-sha256; cv=none; b=mu70FRDWodI/KROFIGoXw7EHblYZVqQXf0WNhsihiE2p9OZLkNCo1KjHCfkCDa0PTRZDyO hNagY82l3lDt9KvGXZspj18e5Xo41mV6RLznB7Td1k/BX7NEC77Lz3OU2Fp0vsVse7pecp QYwLjGo9cOMbM1zz6fFpvvVNynpKDEI= Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-930e691e34eso2780166b.0 for ; Tue, 04 Apr 2023 15:30:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1680647415; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0F0lzmh//kU6Hr/bZenUmvphqVbemCLYMPNErPk8x3E=; b=b4IyRp88zYH+fSFm72zWDlXUERnaECOs2dNWSY8wvYHXDyhc21CfrXSGD8tG1+7iWV JIYkSb8KN8o/Z8Jg17DO42eSqwA9EotMbW3A06tEphcu+BLWgU72V58EGpFowf3Sm95b riBr/R64Rq279OKgW/si8ih9UFtHY3jD93TnEisidu6wh2cBn/vhqlZ6RMa1x3h6bl4A vjzQX8ldn3Lw+BbnrI1goKHLmSBodj5+PhlhjN7KgFUezDex6VntUbXfnVOdg3JRqUKj rtqHB8xSBOdD5dcCeDn788WIg2O52eQzg3/iWLPFJmD7Ndpn/Tf5gRYGMWV3FilcwAXP JI4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680647415; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0F0lzmh//kU6Hr/bZenUmvphqVbemCLYMPNErPk8x3E=; b=tewCUpjBWmmVqKy4HT7JS3us19vYTW7pliXfmlHdBaiHeuhOkYLNDMk3B4RtF4PFXZ Rn1igXx47ih+fdvjAswHEk804Ol4qfVWCl/HfgPGBa3cS1KcXvkD9PzB4WDGvvJJ7SnL xSJpyWe1zqOtVHAik9xDABa4SVkimi3BlfHVmw98JvbpJ0LBhBEEaxYbT6G/5WWtuRhT l/LTTbfp3DBGSoq/GSwOKXa2hyTubX9GsdftFLBwvX6/zd3j2+IHI+JYQ4HkYpSEtLfo euC+IhIVpIht60LW09CLqnljPKmv4phJLvNcyTU43Q+RPgqqqFkXMkQwZVflLjjoIzn6 imoQ== X-Gm-Message-State: AAQBX9dq6S2iAjbN6mEeTyyQiQyl30vILPCTCvmzEHkeC2LMIt0IRg82 WMuk0tbqC9FyAsJR8BzOFMDgX/HIk3PJQQRNgs2R3g== X-Google-Smtp-Source: AKy350amz6Eprvuqf895o089d4zwFDhOBBWUQKxXDQJwLwqZDE1FtvEW8TxkiPLj+DQ9E7WNymwJ2e+yHOxIgrYhhxw= X-Received: by 2002:a50:9508:0:b0:4fb:9735:f913 with SMTP id u8-20020a509508000000b004fb9735f913mr65063eda.8.1680647415217; Tue, 04 Apr 2023 15:30:15 -0700 (PDT) MIME-Version: 1.0 References: <20230404001353.468224-1-yosryahmed@google.com> <20230404143824.a8c57452f04929da225a17d0@linux-foundation.org> <20230404145830.b34afedb427921de2f0e2426@linux-foundation.org> <20230404152816.cec6d41bfb9de4680ae8c787@linux-foundation.org> In-Reply-To: <20230404152816.cec6d41bfb9de4680ae8c787@linux-foundation.org> From: Yosry Ahmed Date: Tue, 4 Apr 2023 15:29:38 -0700 Message-ID: Subject: Re: [PATCH v4 0/3] Ignore non-LRU-based reclaim in memcg reclaim To: Andrew Morton Cc: Alexander Viro , "Darrick J. Wong" , Christoph Lameter , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Matthew Wilcox (Oracle)" , Miaohe Lin , David Hildenbrand , Johannes Weiner , Peter Xu , NeilBrown , Shakeel Butt , Michal Hocko , Yu Zhao , Dave Chinner , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: B697E40002 X-Stat-Signature: jsd3bj9e3ciydn8mts93iwnsz67wbumw X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1680647416-78261 X-HE-Meta: U2FsdGVkX1+4taW6YKXh4+4oXO/5VGFKhkXrmyEfcFzdEKk8qmWVTeJ2rieFh+oItM0AwIR5uqUKqzbnRKITeoxcCVfaMjmUTGeotvYeGvHw9cXYTjgvq/+vvro5xRyYIKUNoT4dKtB329fAVtijUzpqEkSFuBVV7/sZCkIANz1sLLVjbAIRm0ZihV5jrBO1+Sc6h3+8+Uhhj4TPBGP6L1hSl4ZncFN8BQDBeX46hX0a3SJAvat6tnQ6qk27SWen6shjUm6caCbbaDZtr2L90aSKnwsegvqKiPNspO9tRV2lYk994siKGHWeiZm2vDacaPK7g3zu2jy6K2OYFMp8A/xBYoKBh2JdroC/SCSE3yQtWHB97h1Z8PZF3u/x8GlIpDqhMCoFyxRmJc46Vb0bWdpshw+bsCR9zf/KHaq4NdAh0M+osuQ01KLbUHLOwxAPB6aJjsGXdwugjQi4Chxyr1LEQiWNQCIzVq/KPpmHRXX7vM5dNaldcUW/ghRJT2CRhrgeTYgIK2CgOOy8AuKjwkhKf38SStT6qYvph3JZX+SOaDxXVrbgewQsnmxo5KodsHSvhHVTllF5HcUaiVWs/DslgHDKb1tDZKdoVnewxb7yE6hVL7kvu7EkJ5Y8sKXbEaQaKo2Ky5ENCaPrKhE18oPGjbeF9g/JF+uy8PEY/m9sZQ0ttgfmWvbUa4l/Q6rnRVlw2o75aIbRO5eMbBPyEdAqHK/gmd0F0Sx3nVDdVNY6DslutNmrCJu4I0dWE6MaqY3R7+4OOjGw5RvoYpZnL7gwTdrATOJnHzfKQVagv8CP2iKMrGBxwvbTmnl+XrSj7iFkKib8xY2K9sAAIUs8vd7wIzV8mAG9zYf5wFA7uwJyiPTe7tL0lkHMveSl/jJsIFJnUF3qijWXb7wmXrkQ7An74Pegw0n8OmrvM2QMFDsv0uQngJ1983vXGxFPkbsX6A9zQ4CWYcyLZHqql9Z Z1jMSab7 TD7Iz0bHiWgHo42x0Q8beKJThClq9OwH4AmscH0so8ic/m5yR5rXQ4uMV1kWvESN60nQ9cSM3tzQFFLEzRyptgJujb0RUT1YXK5Ct4gS9kZ+I4JpN7+gN+jVrJSxkV7pKsHAKC4udXgatd9RkIoHkH8Y6Xe1/iM0HUZOAFRnaRcLrH2igmAJS7ID2jyX6gVrh/FeRonUz0x+iKJuaa9xIdeEC7/YtVEwfbveeobI1KJviaLpyd0eKxTbGNuOpM0f2dOgvB0noatueJe+dhtPvEJm3Qq1OWgKhzPagCpfJNnYD5HZE3TU9qr5RCa+4HtcI1EQpN3aDILGKMYLuVl033Tm1zb2p9XwvDMj0yYF19i/5St6JUPGA92xL/zjIpEUgyQ7t7/FHg3/dirU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 4, 2023 at 3:28=E2=80=AFPM Andrew Morton wrote: > > On Tue, 4 Apr 2023 15:00:57 -0700 Yosry Ahmed wro= te: > > > ... > > > > > > > > > > Without refactoring the code that adds reclaim_state->reclaimed to > > > > scan_control->nr_reclaimed into a helper (flush_reclaim_state()), t= he > > > > change would need to be done in two places instead of one, and I > > > > wouldn't know where to put the huge comment. > > > > > > Well, all depends on how desirable it it that we backport. If "not > > > desirable" then leave things as-is. If at least "possibly desirable" > > > then a simple patch with the two changes and no elaborate comment wil= l > > > suit. > > > > > > > I would rather leave the current series as-is with an elaborate > > comment. I can send a separate single patch as a backport to stable if > > this is something that we usually do (though I am not sure how to > > format such patch). > > -stable maintainers prefer to take something which has already been > accepted by Linus. > > The series could be as simple as > > simple-two-liner.patch > revert-simple-two-liner.patch > this-series-as-is.patch > > simple-two-liner.patch goes into 6.3-rcX and -stable. The other > patches into 6.4-rc1. Understood, will send a v5 including a simple two-liner for backports.