From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B59EC47077 for ; Tue, 16 Jan 2024 20:20:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E79146B0081; Tue, 16 Jan 2024 15:20:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E29636B0082; Tue, 16 Jan 2024 15:20:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF1696B0083; Tue, 16 Jan 2024 15:20:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BDAF86B0081 for ; Tue, 16 Jan 2024 15:20:20 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8DF12140AFF for ; Tue, 16 Jan 2024 20:20:20 +0000 (UTC) X-FDA: 81686291400.11.F443C2E Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf16.hostedemail.com (Postfix) with ESMTP id AD7CD180007 for ; Tue, 16 Jan 2024 20:20:18 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=RueQLZbK; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705436418; a=rsa-sha256; cv=none; b=vOZBv21IlyjpKlGMaObN760g/d/w/8Ad3cszflAT5yh7L4x0cLkefhuWOmkyd1qEUUg4Cq UPGag1mQSG7rVlzs8mxhRztyxTJVKZtSfAnUARJeyuj7NveYJItK0qh0UvQqnUmLYbKr+g 58q6Z4Y0wJ785RiYw4ggm5rk1ED5JOY= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=RueQLZbK; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705436418; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P3E2Y2gGlsfMwMpgThK3AbQt/GlaabuQMTiIlyvqmJY=; b=z97VwTf4phenVoRPMuodKfwlPv3vy0lmKGMoGxf6WG16UKBufPq4i6taDxropzOoERKocU bSyvIYMnaRgD/1i6bcTO3L+W+P4EiOzasltNRzdIKbq/68FQK2Gl8juJ8K/HB7QzlXG2zx 0DVItE98UB6z8N7htEkm1+Y4vy26T4g= Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a26fa294e56so1079173666b.0 for ; Tue, 16 Jan 2024 12:20:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1705436417; x=1706041217; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=P3E2Y2gGlsfMwMpgThK3AbQt/GlaabuQMTiIlyvqmJY=; b=RueQLZbK6hdmE1Dm9EpJscNjeLpywcyM8RVoZF5P3GPT1fawUhCMzfPBPof39ebhhN eClDOAUYffI2jCaoIcTPfeUukHxCZDigZloVD8hN8lelVbo1vUy/fK7kVVHEBAd7nHog /KvJ0Z+EXOvBwUlOQnW3wAVY7w7vEIOtDMooKZ2z8wp9U4YnvcDgjLZ+BYdsNLreFZxp bz/pDruxho92zDfvZiwXqBcgfN22/F2l8kS4cc+qUQ8s0RcAs242VcdNhECwpVusdVpN clDr6MAh5/nhXiUHSwd6SpV9VmaGyB+yzU4F6Hb3Nu7GadSEPzJtVM/4uda7wlKHDOnt Qi+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705436417; x=1706041217; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P3E2Y2gGlsfMwMpgThK3AbQt/GlaabuQMTiIlyvqmJY=; b=PpJR16N8GFK9indQuSeajZF3Hw80qyMKg39Co+JOP92VB4F/06Ts/p3WcprSwCFWjF XqMwUSFxzz0m0UxsL6MM/bUrhhzIH5o6FkQjg4IjV6qLN4BGtxQUMkHCi0BGx7dV7Kyn 8Ey7CBf2GDgIx40oXzm5WeaHSfqUv5tMN79ImjkHjKHkOfKqRD7dq/ZdeLxHkLEcdYLd YlUP3Cg+x+n432Bw7z/hEf/PEB6U6Kl3HtPQ8t8U14pa8HAlHVoGJcBW45biHZlDRxKF MeFyiYp++GOlxItd+lTcXUTfW6D56nTAjaR56urUaHmL41uavIa1Ge9x/wIZ0eRXOpl1 ULLw== X-Gm-Message-State: AOJu0Yy7FKJI0jWP6fEcL+tIORN1gD/9liNCfwtrrFDQ9ped2LfZQ46q giKOhJbNNkxmJKyBgEfHgX+ynPQ9BxjHP+3ebRYok/o4iyP1 X-Google-Smtp-Source: AGHT+IEPFQwqltvYgFxlysBjGHd+0u+L4kfWHJuGtRT3TShDlHV6JS9iDCNOLsEInB40YpGF+P8XDD4PBoRyi2p/qPg= X-Received: by 2002:a17:906:1457:b0:a27:915e:a306 with SMTP id q23-20020a170906145700b00a27915ea306mr3648666ejc.136.1705436417121; Tue, 16 Jan 2024 12:20:17 -0800 (PST) MIME-Version: 1.0 References: <20240112193103.3798287-1-yosryahmed@google.com> In-Reply-To: From: Yosry Ahmed Date: Tue, 16 Jan 2024 12:19:39 -0800 Message-ID: Subject: Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED To: Christoph Hellwig Cc: Nhat Pham , Miaohe Lin , Sergey Senozhatsky , Huacai Chen , Nicholas Piggin , "Aneesh Kumar K.V" , linux-mm@kvack.org, loongarch@lists.linux.dev, Johannes Weiner , "Naveen N. Rao" , Minchan Kim , Andrew Morton , linuxppc-dev@lists.ozlabs.org, WANG Xuerui , Vitaly Wool , Chris Li Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: AD7CD180007 X-Stat-Signature: foam7wq3hhqujz4re3kagggd6gya9pk7 X-HE-Tag: 1705436418-938871 X-HE-Meta: U2FsdGVkX19MHslk2TD10i34tuxRDx9ZDnd/wspHdFreswupDSQmM7lERH5rN5CbbgI3QjxI06aqm+vc0okSQog8oN9QNgwIF4hl6cUSCkVMJH7rvAKjD6B8MQYAQT8CRrVJPoB6gwrzHuYpP/9/TUvtB5TkVYf8cGa84NxvJcgLfIcxP5+Yo18YEfQ6esE/nI9gegyP4D1D3qa/i4TlKu2yq+93Kp6evZY9Uv+kQidJ81jbm01LfQMkX9nGsdb1rwDb4sZ5P4nBCRxgl8rbGfAPx6Cuv3J2PsrFBfe2n/I7CNaDCYwCxTFGg7rpS9asin3xya0P1+N2kTXCB3ADEtr/RhiS37nDrlJrapMfGXpy8S9qJgmtSXtfWutj6D5QLMpalYF49Zqiolo/seK9+M1f7ct3JgiTBdJW7Qm9FYIiN4ThqhJsoGV9jIG6NhkHmZKF/wzjtg/D8+B21pBKpz6AjDG7bWK5WzrWPm8km9NauQj+dIUmRP5WL0T+l0jCkqKdOKIOF88t3xCaYZjzqbmk/Lh2Y5IOJf27ZWDFCskvxrCcgRN2kfV7nGIi8Xd7hPXk2W6u3LsKn2g3qQC/tgaCVoRLuOUqbHp0LGR7of6eTOu7qaIux64JWzKB9m14YCOvVNDbOdhPne61sTOyKCMJQQrwbotao5dPhA0UwHCxvyWVqcJd03hB1X8h+7rOyvrV7x7xr9XoMqSmM3lGRPsaKv6j/R107mC0HaVPux3m4V2gJc1lXgHSJyDSJfNWaW6OC8agy3JjH9rp3c3pVqFFvxUeuj6M3vy1AVEmUDQazYMr9Ee6rz9v/3DFuf2LzqX4zjXH5k0ffVeiHnzkmZXMfjtrzXiCuJLjDRjk8OH0v4NxDiHyNmYI3w1MPKwhQtqDAvb/4f9TFYNSis8GYvanUi1WN0KBHRWlYzJx4zyfiPPyE+I66prO8j/mbR9hwGCP1jRZ7MsD/uhfQZq kRQGIlFj 3CfAZm9V1uiQufYNRYPcpZVZ43V3OoAoElxNVWxepNiiEQ2Phyf8rOBZ3KKgueDYGCwYadzgDeAAiXro6tQrVoqfNfkrcpsNyoMPQhRfKPSMx9JFdiEHKvW64ldHJVgFMXwXrdeWMKKlt+CQxOX9KtmUqQ4FDVPIDIRs2vrZ/maRUPFqGXRlce6DYaRq4PLxGCDPLppUYArgjlg40INnPzwlRBEbPq9olFIhkB0F7f2I1U+y8C+3QLvpNMa9aY0rWAVMoek9sPXvpYwo2b07iBqLu8JpIr2iv190yrL0U1KXg3R/v71KnjOcDeOmj7+O/qFkmA3apzIpRa3c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 16, 2024 at 7:39=E2=80=AFAM Christoph Hellwig wrote: > > On Fri, Jan 12, 2024 at 04:38:30PM -0800, Nhat Pham wrote: > > > > > > I thought deprecating z3fold is the low hanging fruit. Then, once we > > > can sort out the MMU dependency in zsmalloc, we can go after zbud as > > > well. > > > > Makes sense to me. Should we do the same thing to zbud? We probably > > have even less of a case for it, no? > > Is there any user visible effect of switching the allocator? If not it > seems a bit pointless to deprecate them vs just removing them (or maybe > making z3fold depend on !MMU for now). Well, better compression ratios for one :) I think a long time ago there were complaints that zsmalloc had higher latency than zbud/z3fold, but since then a lot of things have changed (including nice compaction optimization from Sergey, and compaction was one of the main factors AFAICT). Also, recent experiments that Chris Li conducted showed that (at least in our setup), the decompression is only a small part of the fault latency with zswap (i.e. not the main factor) -- so I am not sure if it actually matters in practice. That said, I have not conducted any experiments personally with z3fold or zbud, which is why I proposed the conservative approach of marking as deprecated first. However, if others believe this is unnecessary I am fine with removal as well. Whatever we agree on is fine by me.