From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33F93C2BD05 for ; Mon, 24 Jun 2024 11:39:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B850C6B03DF; Mon, 24 Jun 2024 07:39:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B34DB6B03E0; Mon, 24 Jun 2024 07:39:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D6D06B03E1; Mon, 24 Jun 2024 07:39:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7E5D66B03DF for ; Mon, 24 Jun 2024 07:39:47 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 00633C0E54 for ; Mon, 24 Jun 2024 11:39:46 +0000 (UTC) X-FDA: 82265587572.28.40561B8 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf16.hostedemail.com (Postfix) with ESMTP id 28D5F180012 for ; Mon, 24 Jun 2024 11:39:44 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tJVVhYPV; spf=pass (imf16.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719229171; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M6E+Z4q0t6fWuppwjmqdhl1cVxuMUHJxywE5tNzb6uU=; b=luj2oTlssVMj8X8hY0lHDoAvcLR0+xROvJSHcJAUafs2xfrUqffJuz7zW8/hFgRinJ58M0 tTpvx3G6WR7f0GGK/aCzxh7FwVpKzOVEQ93QNJslr3+QONi/iC+V1dkLIaFnxHMosDbMN3 1EAAeqoKYlzVCgWuU3bNfAMz8HYguu0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719229171; a=rsa-sha256; cv=none; b=nxN68fHWlMmhMjuotFgFGgj+O/qYZZMIs9uRk3Uba1XDRMJWdkJRr/rvwhChwWjDqxtu3Y Xhm+f6FKkwo1+Bd/igQIZXMZqfhlnudlgomU9L/eYXCn/NjZBPr82GACC+Zx8CjLuCLZuW /NkG/oJJEaVAjlP5JYwTzo/SkZbYbyc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tJVVhYPV; spf=pass (imf16.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a724b3a32d2so128244366b.2 for ; Mon, 24 Jun 2024 04:39:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719229183; x=1719833983; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=M6E+Z4q0t6fWuppwjmqdhl1cVxuMUHJxywE5tNzb6uU=; b=tJVVhYPV+kCqn7YISOT/0wWO14pdX0clKtZOV0G/amc7mKTaJ1RPTxY8wy+gpSZqe0 K28kakl4ZoTO8x9PqtRFVSBgDZhYnA/+mysEX7vimyWvzUedLsj2ZaNzpA1eNMtKcZ4s jt7f4fAJGT33ghehsbR2V7ZQZqnWkCE2a07TsUeFbVG9hi4CAegpo/iNDV5GiVTSJ+Ls VerNFuM1vUbQjp2q70bUKAJJdFutW/Q8HLrHaSMBkl9kCbQ18nj8kQRbVLEcvDv0y3xS uUJiDmRMnIh5EeliXH5mzE1Ad/GcmNwiCtmTvpIvQn0O+P3kCqLnBzUKeCSUQy9Jf4Ub 4y0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719229183; x=1719833983; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M6E+Z4q0t6fWuppwjmqdhl1cVxuMUHJxywE5tNzb6uU=; b=haiUNtp1L5uhKe/NSI2VBDE/oObJqmxvaZu/ZQo8pjCiDzHQIJygisjcpLewMWdvqm MChxWCYYLwvbwyH4fI/5y+C1JkcG8S9Tea+vLtD53x0wiMpM6czdbRhF0kWQ1yLg0lb9 6oo5bFXoXmZE+SCWNUdLz/cazKQtS2YEyQD89uIBuy+yDGoSvhzsB7RmRo/77pxY2dPR WsOq2KQyDAy31LfLBYg5L3bYmSwlZpAO8JNHdf86a1K2QM9RVX9KA5+TGmsC2YRji65E nlELrkaKjwWupl7hKcMj6QT3HfHVL5ns0ef4079krXtlDJbNFNS4iMzhXzPq+olhtFH2 P6Bw== X-Forwarded-Encrypted: i=1; AJvYcCUU7RisW9HbDxGqyXn2bg4eX6KlBxXII0OYRU7yYCmE9+TmxF3KovueQ7DCKW4TwlXuAdRey+Y8AEGkNyA1EdcDTT8= X-Gm-Message-State: AOJu0YyK3BSgx5XgyfbxEYKL5dmK4jxXER3/9OzbSu1M2067kKHSgPaf Qq6rJU2b7dWOpJib5vHQaf/ZkLqqokRE63cGgI5bqu7ek7ZCZBxZ8KiuTDIOh34YzcKjY/TAtJh GH63pQRfQ6/B/N3HFQgK5vnD5WXnUuZXNYEY2 X-Google-Smtp-Source: AGHT+IFVDjJiW5tRgKr7Rv6jfLtNj4pMnHxoB1S6WgpkGHM8UIogHPVME1RMJr/Emfw2Q+GzhXHVWc9V7sBVpGwkqRo= X-Received: by 2002:a17:906:a8d:b0:a6f:e552:aae4 with SMTP id a640c23a62f3a-a7245b648aamr247139366b.25.1719229183074; Mon, 24 Jun 2024 04:39:43 -0700 (PDT) MIME-Version: 1.0 References: <20240617-zsmalloc-lock-mm-everything-v1-0-5e5081ea11b3@linux.dev> <20240617-zsmalloc-lock-mm-everything-v1-2-5e5081ea11b3@linux.dev> In-Reply-To: From: Yosry Ahmed Date: Mon, 24 Jun 2024 04:39:07 -0700 Message-ID: Subject: Re: [PATCH 2/2] mm/zswap: use only one pool in zswap To: Yu Zhao Cc: Chengming Zhou , Minchan Kim , Sergey Senozhatsky , Andrew Morton , Johannes Weiner , Nhat Pham , Takero Funaki , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 28D5F180012 X-Stat-Signature: 8rn13ii1rixtjjowd378hxrh5h18m1eq X-HE-Tag: 1719229184-553491 X-HE-Meta: U2FsdGVkX184hjMjqsy+Gg5HG9iQ1xw+GhItz2hiJPxN1H/wFgqBxHHFOpRh2aUuotn411+virwTx01F9+rUZWMUwMm29UQGmactL/3AYlPUMF6cJVsvi/dDS3RqKUteaBCdnZWhh68fMsN7MfpoxwpTzyWbwel8cbd39d9qtlfIvtgpJWfgzg938B3HbDK8BaYOaa7Ci0ZCWsRpzGYmhNxpcT38SY190UgxPiAKj9Bba7Mhx9j8RTImAlm/4QR5SX6vge06hX5KIu5yVAM8ScX/yv38idVNZWuVb1ey0RN7ukrtsgvOK9RB3MfFQ9oqlgOmgyQnSGpdrsmARo6dlDKL3IBOKaLHyvPiubqd89NdB1Sfqkqih3yU5eJpL3oDyKdiMGILn0OBEQSv3YSbJkf/P6TSVRMa+iO+kTH0A1To/7mqEX5pYp8bF2E21A1gP/7B6zyvxPkpcLPpBXGkhB800R82jAKG4OjVINJZsG2RI3hvDuxwYcV3fmeffmmx6u8SkGUvNJwjzhWaMhDnVbzLEL0jywCEJ+6N2LRqAvBN+zJkSosbCoZPuyv1PV1m9wzsVrU+WGw/C6vBLmgo/kk4XBbef/HWNul4tkTTH1kUnMn/Dkg0kfk73O2trYjsUQkxRqBbAQq2fIFABHXGe1B1EFjR5uSBR7TkmESk+dAMZ7TWC32fmvd2Lug0EH2QA/O+TcA1MHyvVL9UTX2lqkPMvSsVv8M0aOlscrJHyNKzJsmjCapuV2hpTDRqMzm5JYoQ8z8idrk0uU2ICA5fVVEJ51Na9EhKOV8DIKxepjf0qmfDzbE7+15vS8Um6++2PoC5vEy4Xmfcgtdjqgj5bMn0HDGD/D0ggIpBcr/Ai9FJryQkNx+rXvwYFxca+CLEkxbK3HK21ZpNffQVDsJSfyZ3ite53UZpJBewjtuBi7BRHvA7GRR3jt5eoVZXQH9BLwvizz1C/hdQRTEo1a7 4KXihDR6 A48z2DQtBaACei5k0oN//Damnb6ne7DmxhGHFZ7xmsKW/W3Bo7KoipAl35M0j/aQcnfjPSjuEE0XXREAgjN1Pl6wTvo3hp6ryXPtlc9v98YOeuchOwLGTXJUKz4OPXxfX/UMrRprUMPrRGihjDuoh+dfi1dtyijMRQDBLV10GftimffC/nlYFrT5Vz+9J+ArnC5xGZSDCXpbdPfeqgesHafsNynJfrr1e64p8PHk6Wdoz1Lt4dfPXe4tiIqggRC7iJXpx3WYZLhp0PRGRCSWraPJ8JA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000010, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 17, 2024 at 1:20=E2=80=AFPM Yu Zhao wrote: > > On Mon, Jun 17, 2024 at 2:16=E2=80=AFPM Yu Zhao wrote= : > > > > On Mon, Jun 17, 2024 at 6:58=E2=80=AFAM Chengming Zhou wrote: > > > > > > Zswap uses 32 pools to workaround the locking scalability problem in > > > zsmalloc, > > > > Note that zpool can have other backends (zbud, z3fold), and the > > original patch was developed (even before zswap could use zsmalloc) to > > make sure it works for all the backend. > > > > This patch only makes sense now only because zsmalloc became a lot > > more popular than other backends (even though some distros still > > default to zbud). > > And this might also have answered Yosry's question about the > "historical context" here [1]. > > [1] https://lore.kernel.org/CAJD7tkbO+ZLdhs-9BpthztZX32i8C4=3DQEnoiXGS7bM= 399nqwzg@mail.gmail.com/ It does, thanks.