From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3E11C4707B for ; Sun, 14 Jan 2024 18:49:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB70B6B006E; Sun, 14 Jan 2024 13:49:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B67616B0071; Sun, 14 Jan 2024 13:49:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2E4A6B0072; Sun, 14 Jan 2024 13:49:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 940576B006E for ; Sun, 14 Jan 2024 13:49:56 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 648901A031A for ; Sun, 14 Jan 2024 18:49:56 +0000 (UTC) X-FDA: 81678805992.20.53397BB Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by imf15.hostedemail.com (Postfix) with ESMTP id 89C73A0006 for ; Sun, 14 Jan 2024 18:49:54 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=38LpGv3p; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705258194; a=rsa-sha256; cv=none; b=cmf/E8+s28A74FYkp8RYGQFTrPiJkWnwbqpHT+S9B/PfyaGfczMeo73vfC8aMaNPpMcFoN vUgTKiRtScjJ05rVaHY/QXyGozhbwGmDQUs+6chGKzs2d4oHg6QEgvQJdU1CEXUykaFeTd w7uTyzqGLCI4ptE2gGARz1tv37t2lC4= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=38LpGv3p; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705258194; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AhMTxPmt0/flYm2bklU2LyKEn+DRcXTdo6lmYP/96pY=; b=4aop7b/970yuRflyuihKQyvDtfWbXdDXvGO9mFOGQtOXTglqub7IRPSQGyI2eEPTuACzy/ /em9rYpv/cHIlx1j3BDsTvtuHeZtYikBR66i7XTv6PVeyada6yEwH1PWuc51Nm8sjAeFgU FJd1RLKBRqr25HY44joNo5gQqDgTVr4= Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2cc9fa5e8e1so93999621fa.3 for ; Sun, 14 Jan 2024 10:49:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1705258192; x=1705862992; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=AhMTxPmt0/flYm2bklU2LyKEn+DRcXTdo6lmYP/96pY=; b=38LpGv3pIKi2dIK4FaH8ahl8Mz6eA1YRs0uVh17j4+aedAFk+QVnPckxUr7EEZLZHU 5iknMHpfPL5UJ7VrOVZzZRBcFfHzUEj9Y5NiUAXXW/me508lRkWfOVTiSRJGQ3BoRtRW AB/urqNtOjRA3MO68J2D2CyeeGjPB2cpg/GpQj3k9LSfA2FtDvVW+jgBRPkwWdyv8AC/ xWfUsa+zd5lhmjCYU23qdzGBRjiXq89FFgnifySR4ifwk0bABtgIfjGsmwhId2pylcq0 i0QKyE7LCipoE83q7sLmJzuOC0QshtbdOJ9ZVSPEkvl/1+XU+SlruEY6Oeyhd86JYweg 1gdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705258192; x=1705862992; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AhMTxPmt0/flYm2bklU2LyKEn+DRcXTdo6lmYP/96pY=; b=pAK5q6zRdtYTkH67uKwGRXjtVZK7y95v3nqe2BikxcjS9pyETwY2Zo48YSYWjXpfID 6e3F8TSSCuDDf5sr8Jyt18limurSsLryx1biCA6myWhOLd9DtrpXMGnHxth4uzydzf4x nceJu1NPNridRBp/gGJ1tXLfyfdC/4qdnpVa8sswFC3+S+TeTBfqRZe0xJkGhaaRWw9n hGwEmEr9U7s1jqcC18U65AlauQPw035lyQf6S564d7EDtIfyKanTa2HyfeaHEyf7DY9V 91P+kdKnuwnW4DF/HYoCGUJYLvYjWnGNx+RMS2u904U3u7458LmEXZtXBIPEJGMQMD9t b9iw== X-Gm-Message-State: AOJu0YwOEZriX/AElum7xns2T3dtx5AhwV+tSJCRPfRixFqnPGrxJB8B lRkXv7Gl3a6d2+h51oTFJICSSC8azmVpAmJdosRI17+aZYi8 X-Google-Smtp-Source: AGHT+IE/ZJhQ+UJe7SuwAe0k40YNaGinhlOrjQPNpsEA5fIP8FVoDZruH+nhmxgiR0kdZREz4OcNJrLV9g6Q4YXwnlg= X-Received: by 2002:a05:6512:1186:b0:50e:cc3e:2f30 with SMTP id g6-20020a056512118600b0050ecc3e2f30mr1496009lfr.109.1705258192392; Sun, 14 Jan 2024 10:49:52 -0800 (PST) MIME-Version: 1.0 References: <20240112193103.3798287-1-yosryahmed@google.com> In-Reply-To: From: Yosry Ahmed Date: Sun, 14 Jan 2024 10:49:15 -0800 Message-ID: Subject: Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED To: Nhat Pham Cc: Andrew Morton , Vitaly Wool , Miaohe Lin , Johannes Weiner , Huacai Chen , WANG Xuerui , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , linux-mm@kvack.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, Sergey Senozhatsky , Minchan Kim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 89C73A0006 X-Stat-Signature: 3ztripb6ci1ijydirpoufcjqpirxmq18 X-HE-Tag: 1705258194-170295 X-HE-Meta: U2FsdGVkX19fzi+FGZflhhC9gQJbG/5UswX7OENPN+mVtRUygaL5eIc/Df+2L5Og0dAbXxNq3aOyKFFRj2+koH1qIm4amrjPDsMP2la5zucC3/OmfDUI3T5kjNw0fCZjeQVkItGZ2cv79waFwO7s7qvuiy8MKRXKjsz0zt9Kb+ZAcO9GV6kyoRrgxvyzk3le4C5sYWK7IpbC6UBQEZWzH0N+18inlJf7FEfTm52LhCV8dDxEURK3WuGJXNm0rBhEmWuaTDgczkrx1c+QUurYjpuRC3fI0JdPCbBJG2u4kbHMrQ04OZtPZKDOXRw8LP+9iPw9Iwo6y54rTUbtrQ9nU2gYXPcrqlPKpe7axTTic1l/M3ifrPaO+caabP8HHcUfoT8CfNXpPpOrAdtyp/gS94ZPL3o5n60SZNDK3aOUe4MuEBD0TQvchQ4iBcbZa+rjLpg0EV+nsxHmyq22d97m2Om4Xk0koJMTWN440zN/wvmJXQv8tIMlhP5ozVf+z1xProln1A6JqdVRiq/NbBQ67NUNQJCqRJQDX5UvD1zs9CY749DsoXhUaufX3PLWVNl1iDzsCKXWz6WwFK/xp3imY++W3Tols46p0FsE21bTEWEO/8mwJLeSkDP0CnFB4l2QwE13i/jq6SOkB7e7ZGARzGjfq0qLX9YMJKqk7yn2y9Cv1hpFY50W2gystddVCW0LrinJNtxS/yvEdzdHARWwwzk6ovzIxDKKwjlweCC3eoHy6L7ecBgo3FowcJ4WIiiOB/M3ZkXWEa+KMIRtqtH26mVmFx9bdajG34zzve2BytNFIar7ztjJVPWfFhg51mUKWaKpYFelQhLFsJWsdPE5yVICvLlM5BSSDEDnY+uWOgdmei9oEKYJX2DjratzJuUjkC7FAFPdzD1pt5PeEZ2oYsShJ7yCY/7n9/0iY+pK1N/wPvVI6DM++91+S92ecXhnCZPKJg6qv5urC+xc6S4 fV9mfZ4Q dGyMVVxUDbRS6bX0Y0tTPi9NLQcrVBVCRRP1saCjNVVFgUFwx1m9i1OB/T3FCibkveYS5pbQkQiDATN87A8zrdH0ZOc7KBjKNdrPS9hk/ebj471zjW+TiKkNiUS0E7BDj89FC7v3Wpy24fjinzk6bwqlMBvoUlVTzV8gaQuoo66zP0W8h8YYr9rVOsU8ERcvu7ga2U47V7ezixn5xViQ1t/JARzA43hygVxGExdYg9VcHVZYCd2ozmx7QuzxXoR+IMcd9fNGbGpv7gdNivm2mnxj6k7/9u5xKXgr2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 12, 2024 at 4:38=E2=80=AFPM Nhat Pham wrote= : > > On Fri, Jan 12, 2024 at 3:37=E2=80=AFPM Yosry Ahmed wrote: > > > > On Fri, Jan 12, 2024 at 11:42=E2=80=AFAM Nhat Pham = wrote: > > > > > > On Fri, Jan 12, 2024 at 11:31=E2=80=AFAM Yosry Ahmed wrote: > > > > > > > > The z3fold compressed pages allocator is not widely used, most user= s use > > > > zsmalloc. The only disadvantage of zsmalloc in comparison is the > > > > dependency on MMU, and zbud is a more common option for !MMU as it = was > > > > the default zswap allocator for a long time. > > > > > > Johannes and I were chatting about this the other day. We might be > > > able to disable certain zsmalloc behavior in the case of !MMU, making > > > it available there too. Once that's happened, we can outright remove > > > z3fold and zbud, and have one allocator to rule them all? :) > > > > (Adding Sergey and Minchan for visibility) > > > > I didn't want to bring up the zsmalloc MMU dependency in this thread > > to reduce noise, but that's also what I had in mind. Sergey and I were > > also chatting about this the other day :) > > > > I thought deprecating z3fold is the low hanging fruit. Then, once we > > can sort out the MMU dependency in zsmalloc, we can go after zbud as > > well. > > Makes sense to me. Should we do the same thing to zbud? We probably > have even less of a case for it, no? Do you mean declare it as deprecated now? I initially thought that would only be appropriate to do after zsmalloc has no dependency on MMU, so that we can confidently say zbud has no practical use case.