From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCBC3C4828E for ; Fri, 2 Feb 2024 22:35:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51EAA6B00A6; Fri, 2 Feb 2024 17:35:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CEBF6B00A9; Fri, 2 Feb 2024 17:35:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3968A6B00AD; Fri, 2 Feb 2024 17:35:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2A3F96B00A6 for ; Fri, 2 Feb 2024 17:35:51 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F079C140793 for ; Fri, 2 Feb 2024 22:35:50 +0000 (UTC) X-FDA: 81748322460.25.DFEDA0B Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf14.hostedemail.com (Postfix) with ESMTP id 3D974100009 for ; Fri, 2 Feb 2024 22:35:49 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=3+34UTaA; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706913349; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0+qQwjL7b78T10XqvIbUCoEdwqpS1GzNQCRv1zXvcjA=; b=8UCaWOkW6lQD87FApx1S4rqjqIn/5N0h6ipj0fy0MHKpNjPptJM/5dJeRKH6DspspJRXIq rrLMa3LfJ0gf6dJNa2ceVzGwkQvbvPrhulCx87JyKU/OuESq+bjIN01mOClJA1NqXrMseM /BGmabWiPneoM3vLaSgOPWMjy6UfzEQ= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=3+34UTaA; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706913349; a=rsa-sha256; cv=none; b=nP20vCdWy2tBnxEKacmemcL7jz2QxHkevvgGiLUv0hwT1N0bK1raaGmurDim33zfkaL0wZ fplz6poV9DW/I0vYN1QzIZVNNzu4jdS1Nf2ivhbRuDInkn2WePwDtSWFobz5sf2G04s4aR 2Rj11psDw+O7DELqvBOIYPJeUcw3wpQ= Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a3604697d63so409457366b.3 for ; Fri, 02 Feb 2024 14:35:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706913348; x=1707518148; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0+qQwjL7b78T10XqvIbUCoEdwqpS1GzNQCRv1zXvcjA=; b=3+34UTaAW2HsplIx8Byc7vRUKAZsAhuRq5cChJgQW9BkELQZDX7I6COX/xxNvTMQUA AP0ZkuKgyATudiSb7G+P11p/yP0aZBFlmq7ko+yijVeFLffABJnm/MWDZSG4K1MmE0nf 6BOB1acVuDJt4O7xeFe3xAhvd4q9l+zoueiV1yyvCO6V7dGwuLUSR9tNmgGf7yTlOjIU 2BAiRjbv6IBldFql9Mu6e4zXFVjN/0KXX+FE/luH5WRWvZa3uankXoOQeTg6ZKV9arAu nmVeo7MmIOFBL0B9gSGs1pQQSVJmlSltkcvh1JDkBMVvUfdj3mmwmV/7iMwIPmwEJ0so f29w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706913348; x=1707518148; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0+qQwjL7b78T10XqvIbUCoEdwqpS1GzNQCRv1zXvcjA=; b=KIVBK5MXId02XRVm/2xFd6UYKhAiDzXkryRqWdd1Kd38lY8ley3+ZCsvN2usAxHj8U 6HNiREBR5lJ+WaHmAgQEF1J2ysphTUw4I6LklnLx3TAt0d2XslfmHHh/TnCO1ObTYqjU VyrkiXgj2Hh3cG4jnLRwYlqVU81ou2LeUl5kjKOFKBIzMa1zu73FYf5rTgB9hJikfuT4 7QOk6YzUbPcoV4eExwq6A1SWlU8CRN216F8uda9jdw5hjz8hkbcgw6YEcVAxYk5sgJi3 QMqvRCa2iJD7u+qYppJ4cuiHW/k8xRCUrfEYwWpynZntnKxtZxPGWvMubJK5ZyYy7AgE eGQA== X-Gm-Message-State: AOJu0Yw4viXZLnhe6F+FQQGRs+bg69xoU6SFbeJJdk6sp8rpD/m1hQ9k +aO5c5VV6eP2/9+YjVbx/ibEstFEIkotbQ3e/Uv8MSrI/bj9M8UsxYM/tizQzvebnpOJTxBanJr uJa8ypCCZFOMYoEhXxLXIdbSvCEeXok0nGy6+ X-Google-Smtp-Source: AGHT+IGvB459/BXAdardPQcfjxRtp4LvVuLJxT3vVQFzFdSPsDtLjHnCQ98ZXWaIPxQz5tA8GbHQnHBkHHBxQI1eHnw= X-Received: by 2002:a17:906:250c:b0:a33:b64f:48c1 with SMTP id i12-20020a170906250c00b00a33b64f48c1mr6152350ejb.21.1706913347656; Fri, 02 Feb 2024 14:35:47 -0800 (PST) MIME-Version: 1.0 References: <20240202221026.1055122-1-tjmercier@google.com> In-Reply-To: From: Yosry Ahmed Date: Fri, 2 Feb 2024 14:35:10 -0800 Message-ID: Subject: Re: [PATCH v2] mm: memcg: Use larger batches for proactive reclaim To: "T.J. Mercier" Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Efly Young , android-mm@google.com, yuzhao@google.com, mkoutny@suse.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 3D974100009 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: wcg5ksur9emarpx1i5wnzo87obtdr4wa X-HE-Tag: 1706913349-194168 X-HE-Meta: U2FsdGVkX19ConQdqmKlp/jsLEAJi3lJzfXQTKoj1Z2IzvmaqZQ/r8xUXKG2vzm6Gb3fyMJ7ose33WjJqv3X5JFnkn2vHQRXVD6mHDOk0iQiylPuA4iIJItuYmHzGcV2EpmgEARGRVp4sudZVRo3JWrI8Ufq2O+cVx30iVPG5FP+LFAl9/wKE5JYivwBPY5xRg1bweriq6x9+6rZVvgwoEuvzAXsQr0XIvsu12H3qNHnGX84VNZpVEJF5RH8TTgjTK5N/g/PYmYncWpPMI9Z/qFrqUM5wmym3Ba9qKsj0eh4krC+O5VWTOqcWYngcd5cQWak8B9Ka+3YoqL8CVqa3/snC7U4ZaMe6+aYRq8WAyKX9LIntt4NUOhUqEQpYvkm3UHX5RknP66nW5avsUQ1JBUFnVf+v65u+jNY4cYX1DKe2m/Yeb2qDETtC2QzibhoJGTI+bq87IFVoJ8tNp34k6261VqpKCzisVzha/V/bmOfu3VKzoQVxTOkuuHJUBAMFm2lQxu9L9dodZDkPwbZRifPJZGzMuOJ82b19fz5N7VAywXHCOtNcVaTTYMgAgA0dz/CavJp/ghrGZvX5DrxAqHufxeQmgExgfimWUM0aTdFt3DTVjYpEJwGmAKP4xBtw8ZjFR5dHVFEuPJ1yRBshkkjq0ARH7iSjiVgune91Cwe4Zd1uG2FIGHfVW0MRoWBZmSZPEYtZxfRHSVKH/MOCSlujlBV0Ib0sWoRelF/0gFwANsNaj79s3cV2Lm/9omG/GKAPjE7F93KgtPYGbNGRMl4vIhMPXhCjh1FBexgVdXi9GO/yCDuD3mS0w7DD9ZJrHSIC/YH4zGPyB7FmgkzUu+B7apl5ymbu5Z95RFzykud5g0LoFFpDvjp1+Jmnpaz4JXHPGYGCAlF9VNQIxyidIMJ145AhvDZ8ILk2MkzgqkhuxjywY4O7GvNHDH51K6mKmyJFDhpEINW52mXooI hWXEmVnI ml0YXggGVPqAL6pZOnqQCx3BMfLvMOvCyXIQ6l9J5xz3Z9jQwQ00MmU+lBxCuQAiOv+DZmjvNYqXf1AWWVp7ZoMahv+QiUJ88aDgMEpb3utl9kXk1FcLxDYqilmLTAttMThL69hXzA3QV1D8dqgudnV70VDdEEtMIGVBAPlX9LXuJOtMstBbrcZVbUXaGuQqyl4h93Uh1pUbE7tYGKSZaCdjwnaJv6nxwU2J0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > > index 46d8d02114cf..e6f921555e07 100644 > > > --- a/mm/memcontrol.c > > > +++ b/mm/memcontrol.c > > > @@ -6965,6 +6965,9 @@ static ssize_t memory_reclaim(struct kernfs_open_file *of, char *buf, > > > while (nr_reclaimed < nr_to_reclaim) { > > > unsigned long reclaimed; > > > > > > + /* Will converge on zero, but reclaim enforces a minimum */ > > > + unsigned long batch_size = (nr_to_reclaim - nr_reclaimed) / 4; > > > + I think it's clearer with no blank lines between declarations. Perhaps add these two lines right above the declaration of "reclaimed"? > > > if (signal_pending(current)) > > > return -EINTR; > > > > > > @@ -6977,7 +6980,7 @@ static ssize_t memory_reclaim(struct kernfs_open_file *of, char *buf, > > > lru_add_drain_all(); > > > > > > reclaimed = try_to_free_mem_cgroup_pages(memcg, > > > - min(nr_to_reclaim - nr_reclaimed, SWAP_CLUSTER_MAX), > > > + batch_size, > > > GFP_KERNEL, reclaim_options); > > > > I think the above two lines should now fit into one. > > It goes out to 81 characters. I wasn't brave enough, even though the > 80 char limit is no more. :) Oh okay, I would leave it as-is or rename batch_size to something slightly shorter. Not a big deal either way. Going to 81 chars is probably fine too.