From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3667BC433EF for ; Mon, 27 Jun 2022 16:24:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C37B88E0002; Mon, 27 Jun 2022 12:24:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE6E48E0001; Mon, 27 Jun 2022 12:24:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AAEA98E0002; Mon, 27 Jun 2022 12:24:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 983848E0001 for ; Mon, 27 Jun 2022 12:24:34 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6E0E733225 for ; Mon, 27 Jun 2022 16:24:34 +0000 (UTC) X-FDA: 79624538868.21.88DE6E4 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by imf07.hostedemail.com (Postfix) with ESMTP id D3BFC40039 for ; Mon, 27 Jun 2022 16:24:32 +0000 (UTC) Received: by mail-wr1-f42.google.com with SMTP id w17so13811116wrg.7 for ; Mon, 27 Jun 2022 09:24:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3xCqZKogDypv6eypnWAIX07mm+p6TcVFKXGmBz5uwGo=; b=EFJ93YBppveZN8tb8RoZSuAH5W5SG1LiH1nd2yGt5BUolxb7x2ATW1Kz7biQm14+S1 UM+Fp8eufEM8rSzaN98Vxy+yjs/rNMirq3kcwGggDlKitVyql4aB21ps9KcBglapj9Ua 1W4ZjfHFR1OX+l2hu2sbJa8kLFx8xcw+LngOMpTPoS5at+/yURveHnzp5IGPSJMu7ZvB x275CN6l1938KDghGgk+NqN925rKkvVMXE8N/H2EY4ZUpwt+isaWFqtc66lQKg5sW1P0 qe563ZBGvDzi6k6E6WBMqiK4kFc+qfzpLTjoypM7LjJTmsiLm26bxb/pjD6ij7bCgcHB 9Yqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3xCqZKogDypv6eypnWAIX07mm+p6TcVFKXGmBz5uwGo=; b=w+/6fB/BBfMm60kQHC6uqaHYOl0/LZ1lfx/K7m8thJngl+REeUVbwQeM5irRQQkiJq E+4W7Q95Q27MsxynmLkgw1f+LVa+F95roZL5Zhzx9rfB/TYUhz1hiWgnSrayaDFWqISK /N3sgOBYwwV+/s4lgw806AC+TxQC4t3tKN48ZpGhmWSrnpTqrFLQpmiATqhxNfj3wsOB 6aL1goIPqogvgVfUEMl1O8RVtFgv7OO5b3ktQOOBwruj4GKGbEL9/qhGoLyYF+cegeLg M77qN+gs4s/jtwlSOvTKhYf9ls+DDEvF+s+NRPuvEHTSXzngY2VcZtsD8cs0zs40B6Ax DSFg== X-Gm-Message-State: AJIora9taC4zHjAK/WKh5bzxZE19cibb2jrTRNNW1eUxKcME9YtBHwyZ 3yECJHZY7tHtILmxp6wUGmLmm4GDG5Eq1OTbTq5mEw== X-Google-Smtp-Source: AGRyM1tEYhoQe960g1sn2OovJNLpmUQIbQxWnmCUUyO6DqjFG9AG5gJFJE0O7TF8AscROp1Q2QZs7ydLv2dJU1UWp8U= X-Received: by 2002:a05:6000:a1e:b0:21b:8c8d:3cb5 with SMTP id co30-20020a0560000a1e00b0021b8c8d3cb5mr13353164wrb.372.1656347071360; Mon, 27 Jun 2022 09:24:31 -0700 (PDT) MIME-Version: 1.0 References: <20220606222058.86688-1-yosryahmed@google.com> <20220606222058.86688-2-yosryahmed@google.com> In-Reply-To: From: Yosry Ahmed Date: Mon, 27 Jun 2022 09:23:55 -0700 Message-ID: Subject: Re: [PATCH v5 1/4] mm: add NR_SECONDARY_PAGETABLE to count secondary page table uses. To: Sean Christopherson Cc: Tejun Heo , Johannes Weiner , Zefan Li , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Andrew Morton , Michal Hocko , Roman Gushchin , Shakeel Butt , Oliver Upton , Cgroups , Linux Kernel Mailing List , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Linux-MM Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656347072; a=rsa-sha256; cv=none; b=sKFQyGrKOGc3X06lv01+BpcsHzJTB775iJ3OfYXF5MwchJwdlj5qJWAcBa178pLN74vb0/ SVj8/ItthCavyd5SGBmPVFXtnN7MTYkru0f/RzPFr04WHthUfWOtMTohbHXbTg2CCCf2g9 ApT/iD64hwhqsW64H4OG0YQcjnmAMKg= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=EFJ93YBp; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of yosryahmed@google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656347072; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3xCqZKogDypv6eypnWAIX07mm+p6TcVFKXGmBz5uwGo=; b=z0lhUIcrWnBYuxj/+7lxhavrMYC25w72XEFrmt2W2KOKNE0Ceuabn6wihzZi6PkNBtTnlj g/8v7x1Su8DVO0TXf8AWKE27UhQfy03+LyqmnPHzq61lWhxUWUSZvgIQ/yssXnjK1ayELH evZv11VMD+Ds7XXLEXabNN5+4rBrmn8= X-Rspam-User: X-Stat-Signature: i7pjshrgwdcxn1fm7qywi4rw3ow9wmia X-Rspamd-Queue-Id: D3BFC40039 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=EFJ93YBp; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of yosryahmed@google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=yosryahmed@google.com X-Rspamd-Server: rspam03 X-HE-Tag: 1656347072-801450 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 27, 2022 at 9:07 AM Sean Christopherson wrote: > > On Mon, Jun 06, 2022, Yosry Ahmed wrote: > > Add NR_SECONDARY_PAGETABLE stat to count secondary page table uses, e.g. > > KVM mmu. This provides more insights on the kernel memory used > > by a workload. > > Please provide more justification for NR_SECONDARY_PAGETABLE in the changelog. > Specially, answer the questions that were asked in the previous version: > > 1. Why not piggyback NR_PAGETABLE? > 2. Why a "generic" NR_SECONDARY_PAGETABLE instead of NR_VIRT_PAGETABLE? > > It doesn't have to be super long, but provide enough info so that reviewers and > future readers don't need to go spelunking to understand the motivation for the > new counter type. I added such justification in the cover letter, is it better to include it here alternatively? or do you think the description in the cover letter is lacking? > > And it's probably worth an explicit Link to Marc's question that prompted the long > discussion in the previous version, that way if someone does want the gory details > they have a link readily available. > > Link: https://lore.kernel.org/all/87ilqoi77b.wl-maz@kernel.org I will include the link in the next version. Thanks!