From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AF7BE7716F for ; Wed, 4 Dec 2024 22:36:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F34846B007B; Wed, 4 Dec 2024 17:36:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EE4856B0083; Wed, 4 Dec 2024 17:36:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DABFC6B0085; Wed, 4 Dec 2024 17:36:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BCC4E6B007B for ; Wed, 4 Dec 2024 17:36:20 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3BEAE12123F for ; Wed, 4 Dec 2024 22:36:20 +0000 (UTC) X-FDA: 82858736058.30.C4A0884 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) by imf14.hostedemail.com (Postfix) with ESMTP id E7029100004 for ; Wed, 4 Dec 2024 22:36:01 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=t7m76g7e; spf=pass (imf14.hostedemail.com: domain of yosryahmed@google.com designates 209.85.219.53 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733351763; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eS0FEsruGhh39Bjn4FTH2Nl4cCIzKoK/vUzX8vsG6WE=; b=lsuck1PgRuM2bT4n84mgeDvVEkXYQfJw+Iiv823kjCxAP12A+sslfWSuIKbWBie8M3IsKd ASBzENZG0HzyAh0O4NBO3ND4R+GximYaunE5fqjHAuPvc62m6b2Ij6S6t83/YXZpbMMGVq D6uw0EGgosPbXZbEpro0KyvOHEJAwNA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733351763; a=rsa-sha256; cv=none; b=j4Z8yG+2FUdy2uLVpD/VNb8nNXndKI89Aa0r/ZcPvtkUEKJg4OGuXPtTzyGQt4TMeWvI7D l2KdSePSOpIWQu7K0oWL2qqpCSSONkYFSqG5aQcdNqRcbpvdtgWob+6myVqEb3h3XUnDJ5 3XnGQE/1NIQfu9MQhlunRMY07JQy2Oo= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=t7m76g7e; spf=pass (imf14.hostedemail.com: domain of yosryahmed@google.com designates 209.85.219.53 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-6d8cb085d1bso3041546d6.1 for ; Wed, 04 Dec 2024 14:36:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1733351777; x=1733956577; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eS0FEsruGhh39Bjn4FTH2Nl4cCIzKoK/vUzX8vsG6WE=; b=t7m76g7eFPZr6uRNHuOzzkWAN7FF65nr/LbkkVwNw2KmqGz8N2QNAvERfeA32+UDEK rgsrVwHyF/eNXItd64p76bM+xtWgiC03+C6S7V3Axq2qH7mcA8ms8vgm0xC9pFmKAD5M Iu0EqrwJ89J0zQvJEmg7t5Nx1vjtjrk5Yhsm17a+/BcxToS0D5B0v/D09smNJCmO87Gt m8q/ZQijqhV5PdI+zY5Uc2twFnpwu1C2gyLOgay1ACaaCdP3AXd/8Q33H9cSGF8pKU/9 MQ+3lm091YLbN7P2PubJ/Jclpo7hQqMCRlLmn7P7BhjRZb3VrxxyVAVFpWxJC3IcXqEC aRLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733351777; x=1733956577; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eS0FEsruGhh39Bjn4FTH2Nl4cCIzKoK/vUzX8vsG6WE=; b=uJOXD1hI9/9aFWOVk/YArnKTjv4nu7OS0YHxs3RtQouuG09lq3k5K/v0eDUmdRH7Po F4kqLTmr1yncaGoDj762c/WEZDiIClNdrMdKwcmgRtS4/ObiJmbMYSAn335+hIfc7lia wF3Hk+RJFKtpBmCgXGUzjSNinxU/DeBe3weDoPv+G4Hl/lhKP1FNjQ3vYyt2tW1cIbhR TdQ7rbvX7BuzsyTx7ym2xhG9baNlCBq7hHYqwOBVTBItWcAxTX9f2DvQPkCigBXP4E0L 2pWMsEjzNA6Gx89W7MJIpnM41NUYlXQrfEZDb5fuD+oDDbLXrhp/wsqaQ0ofmfaLSh8T IaaQ== X-Forwarded-Encrypted: i=1; AJvYcCWBR21lVjP7daaez5gTCVFES0T7rBNWSQlYhu/SR+r+zl3zlJp8IOC0gz3j3IJfWHgrVcpJmIqdCw==@kvack.org X-Gm-Message-State: AOJu0Ywe6rMm3J/3SwaxzfrJAR1Q6QclfNqocdF6dNwSq9dGdWG8FlKD tbh6wC7IHvSYDD7o50sR0k9surkKgVNGpJ/Eq6EATXab5imqXvV1MhbfShwZmhV3uCNZJfNcDDm cOHkOUCsf0MBDz8OxR89dQBXuxaBflOxU8OZm X-Gm-Gg: ASbGnctz8YGhS68Dlph6+5BdIB0tXPJkQeMZQaHoQ4DhuEWqhqwReVcFj/AZiQ3OxbH ZymHpXS/0DOUp5ya3MS3ReoorBGKL X-Google-Smtp-Source: AGHT+IEDQzyAy1CVJBsw8OwP0dkCUTIHEYHMvraP8G80iJxS11sgJQkYnJWtKFeWBlFBtQFtcyr8YTxgY3yg7BNQkkE= X-Received: by 2002:a05:6214:c4e:b0:6d4:16e0:739a with SMTP id 6a1803df08f44-6d8c45905f7mr106003306d6.17.1733351777220; Wed, 04 Dec 2024 14:36:17 -0800 (PST) MIME-Version: 1.0 References: <20241123070127.332773-1-kanchana.p.sridhar@intel.com> <20241123070127.332773-10-kanchana.p.sridhar@intel.com> In-Reply-To: From: Yosry Ahmed Date: Wed, 4 Dec 2024 14:35:40 -0800 Message-ID: Subject: Re: [PATCH v4 09/10] mm: zswap: Allocate pool batching resources if the crypto_alg supports batching. To: Herbert Xu Cc: "Sridhar, Kanchana P" , Nhat Pham , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "hannes@cmpxchg.org" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "ryan.roberts@arm.com" , "ying.huang@intel.com" , "21cnbao@gmail.com" <21cnbao@gmail.com>, "akpm@linux-foundation.org" , "linux-crypto@vger.kernel.org" , "davem@davemloft.net" , "clabbe@baylibre.com" , "ardb@kernel.org" , "ebiggers@google.com" , "surenb@google.com" , "Accardi, Kristen C" , "Feghali, Wajdi K" , "Gopal, Vinodh" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: E7029100004 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: sfznhrhiqp3fpcq16fi3bfx57sptrxj3 X-HE-Tag: 1733351761-836650 X-HE-Meta: U2FsdGVkX18rymA8NqEYjKYmf6qsk1cpy5XBdl+aIF2dHIxfyc7tLcNLfm7HSb/sAfC/ab4KOg8Ft/T5WGhFdP5y/WnLDILbiV20x9a2W06VrH7ZzPzp1uKt83Kufr9/TX2EecuK7QdP6RxkggPtK0lfXIHOEzFfFJpmusVaoRuNOXc6ASG/9JhicgO0nN3m/9+rD4NgFEbtuFKyaM00p82dVQfDUx0wd/25BaA1p3Yy+qmOsTV9Q5wlRvz/TdsrYlOEE583oE3X4lIZXAjza+A4YzP5KMA2JTH2P1nMwwLT7pFBqc4uQXvvF6w3yllrMNjK7tP+paLwvSk37E6zli5yZxQepKvxWz9oMijcfqSvzItqk4MzMd6oBQbbabBg37j2+N5ZuNeGkKp98g2SOLUlxN/4Z/1ufhXrj3WhidHL73+YEGeEHOoc6nvwiR9Cq09lXXSXxsqyHVq//Dp8GeV9tiUAx06XS2VwtaVwIMNUO0rWZxU1U2SYlXt4LZKAHrwCdcgWKJF3fVo8wigIFIxjiuvatF+x54MDs0a/vQrF18QXBF6fc0OYL5z+D+sghYwCAaM3zW0VOLy8LII3AF9jxwh+GC91i8pip9L2uzLzLKAQWoH12ccJB133eIToKlkkPE6pPHaJLO7uzoyMTlPqd0Kz1bwES/9aYCNXqEbpKgaBvaF9OXw5i2iuX2d3EMm0ULK2q7HSvbvV/F2SpNNwbpmjpcqotsScN0wQTXzHLdK+Yrdt08cVhhqbsGjEtTVeLw0sBXV+BLbOt0zpcZLfbZuOtVBnsJxAbqhtwMP/mQK35NAHedldQbqsNEED1oiIVs/h1bh3tVF9AfrZoc3Onsn31dSHFHpPfXB0PzgqEb3/cvgs+iGZumrh00VMARptsDS9zBEgqIRL+PyaNp2zdmD+C0DQ4ZKYTt0c200adTsh3gPgO51NaQPX7155mixfhVcNzF57MXDfpOC ilDL4+pG 98DdoE0zOc1c9Gs2gJlUqoETyzlHg8142HwRWKaGPhEvOaSILX+SaaD+cBYGQ4BG7Qp5cCTCVOk6//awXEB4o3b3NwS3ILnsCnSVThY7y1NVmBljrqWLZYgFoNSLrdWrlQImqh1JejkTqd3pj+vyni4TfhobjNzMLR0W/gOemxKILlFsZiq8gxwStKjalgGZI7FdJtMgrJMZqUgQ1i+hxgkuGjuAhHo5ZzQLniCdWT4zR6xOF3WzB8TvhnA8ItaZY62n2WRzSgfSkgs0dBoXUyai5ivaql3MABS4gr/x9zBuQpd0xK9DRBHJjxgG+hf1ljd5IUkwRvNic0J552CF+wfrpVA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000367, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 3, 2024 at 5:42=E2=80=AFPM Herbert Xu wrote: > > On Tue, Dec 03, 2024 at 01:44:00PM -0800, Yosry Ahmed wrote: > > > > Does this mean that instead of zswap breaking down the folio into > > SWAP_CRYPTO_BATCH_SIZE -sized batches, we pass all the pages to the > > crypto layer and let it do the batching as it pleases? > > You provide as much (or little) as you're comfortable with. Just > treat the acomp API as one that can take as much as you want to > give it. In this case, it seems like the batch size is completely up to zswap, and not necessarily dependent on the compressor. That being said, Intel IAA will naturally prefer a batch size that maximizes the parallelization. How about this, we can define a fixed max batch size in zswap, to provide a hard limit on the number of buffers we preallocate (e.g. MAX_BATCH_SIZE). The compressors can provide zswap a hint with their desired batch size (e.g. 8 for Intel IAA). Then zswap can allocate min(MAX_BATCH_SIZE, compressor_batch_size). Assuming software compressors provide 1 for the batch size, if MAX_BATCH_SIZE is >=3D 8, Intel IAA gets the batching rate it wants, and software compressors get the same behavior as today. This abstracts the batch size needed by the compressor while making sure zswap does not preallocate a ridiculous amount of memory. Does this make sense to everyone or am I missing something?