From: Yosry Ahmed <yosryahmed@google.com>
To: x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/mm: remove unused CR3_HW_ASID_BITS
Date: Fri, 9 Aug 2024 18:10:12 -0700 [thread overview]
Message-ID: <CAJD7tkaJKhoq6djbYBAiGiyjoSa+Jwcj1iNcLocgVfxwo3V43w@mail.gmail.com> (raw)
In-Reply-To: <20240425215951.2310105-1-yosryahmed@google.com>
On Thu, Apr 25, 2024 at 2:59 PM Yosry Ahmed <yosryahmed@google.com> wrote:
>
> Commit 6fd166aae78c ("x86/mm: Use/Fix PCID to optimize user/kernel
> switches") removed the last usage of CR3_HW_ASID_BITS and opted to use
> X86_CR3_PCID_BITS instead. Remove CR3_HW_ASID_BITS.
>
> Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
I think this may have gotten lost in the noise, friendly ping :)
> ---
> arch/x86/mm/tlb.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
> index 44ac64f3a047c..a2ba5bb201705 100644
> --- a/arch/x86/mm/tlb.c
> +++ b/arch/x86/mm/tlb.c
> @@ -85,9 +85,6 @@
> *
> */
>
> -/* There are 12 bits of space for ASIDS in CR3 */
> -#define CR3_HW_ASID_BITS 12
> -
> /*
> * When enabled, MITIGATION_PAGE_TABLE_ISOLATION consumes a single bit for
> * user/kernel switches
> --
> 2.44.0.769.g3c40516874-goog
>
next prev parent reply other threads:[~2024-08-10 1:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 21:59 Yosry Ahmed
2024-08-10 1:10 ` Yosry Ahmed [this message]
2024-08-12 6:39 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJD7tkaJKhoq6djbYBAiGiyjoSa+Jwcj1iNcLocgVfxwo3V43w@mail.gmail.com \
--to=yosryahmed@google.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox