From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E1DBCEB2C2 for ; Mon, 30 Sep 2024 22:17:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D3013280038; Mon, 30 Sep 2024 18:17:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB884280036; Mon, 30 Sep 2024 18:17:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B32B8280038; Mon, 30 Sep 2024 18:17:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 924F3280036 for ; Mon, 30 Sep 2024 18:17:29 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 38F8380BB0 for ; Mon, 30 Sep 2024 22:17:29 +0000 (UTC) X-FDA: 82622817018.26.D713A4B Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by imf07.hostedemail.com (Postfix) with ESMTP id 5265040002 for ; Mon, 30 Sep 2024 22:17:27 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ak3akNPO; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of yosryahmed@google.com designates 209.85.167.44 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727734627; a=rsa-sha256; cv=none; b=6u+rGKVsMQ5wAFkP1qTHdm1GqfUOPK70KGukDMbmaeRpF6x2RKa3ULpW70pXWit+k/vsX2 6zhykGpxXRlZJ9D/6wLc07tmeLAKgCrPY0wz+Q7v+YdsnMMwg9vq54EkDFf8Ic4LamZRc8 qf/s1pXKCPZY9VKjsHl9wbEfZLmRzms= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ak3akNPO; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of yosryahmed@google.com designates 209.85.167.44 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727734627; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GJGdws3Y+9tFEbg9OaIrhdneoAXQ+o0Ro9Aou8mtgpQ=; b=qJg0kif4KGlbTHEGthRiPixnj9p+FA7V3FVW1X3Uml7pecEdMv6b0jnNQgJuwlcjaXn4YN iQ9KZ3X+vDrdHjJtgwoE71W2uMqwYKX7ypx6fggOda8ZssXCD7TI/Bi3FE8Q+0Cy559vHl FBX7qnvGNqck4TD09hRITh7WlxBcdxY= Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-53991d05416so2225302e87.2 for ; Mon, 30 Sep 2024 15:17:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1727734645; x=1728339445; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GJGdws3Y+9tFEbg9OaIrhdneoAXQ+o0Ro9Aou8mtgpQ=; b=ak3akNPO4Vl5zfQwko7XD70jZyqZ0tw7R8Jaam7BBiXW6RkBfaCFI7eudi9q+ElG3Q 3YF/lCNSy1EDurT5ejtfjFp1nOSwWCC+eGoZFtNieKSYY4JrntOr04ykevPcSdjYDDgl gdIZp/KEpyDJlQjLmPeLmxpIPghbA07EWZ7a1QgdmnS+A3AdZVXaZ19/2yJB4xcW+3XJ vjZWtZsPGtOVRZH4M7y5ingkrDn3dipQzfUAFXZuwf9Dj/JP/qMYJC0xUKIXuYKE/top lr24fsrIHQ/MsX/a8IA+Jm4TVurxldZ0T2Y25wH1DlrFssoAgDbm2GXXY+swt+OsCuII kVlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727734645; x=1728339445; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GJGdws3Y+9tFEbg9OaIrhdneoAXQ+o0Ro9Aou8mtgpQ=; b=bIPva/YSOpZAiGCKTktxXr+t9ZBcyv5X14U8q7P3bpMOUDmDSLn3d8GtsNbp2hqTzW i1oC4HpZdy9UCEE9ND1kGhP+1tmXEFA4xleWHITo1gj/jw8eOdr9I2+LbtRDjSMwrNIF axIVugs/9rw12z25pQkwEIMy+M2QkUgxqeA+HhIS8+Ca3SqBsZuEPnU6OfULnUQ/S1M1 Qv+Iocyc1hQZXQ6/BmborjfiWpW2U6h5ispH1XSU76n2OGijh8nZIdoM/M/x12Z9pBIk fnGzxs+A7xX2xovRp7s4sovHqeMBaJAo+vAcV2QPcL1LMnuaoRq9WSPLXde7bJB4ZfQ7 cY4g== X-Forwarded-Encrypted: i=1; AJvYcCVWYUfnr7jiRuzs/kpu3pZJlJtj++2Zh1TIVUbO4HYM89I9kVHoLhJmC4k/fXKk52HO0rcPM04vSw==@kvack.org X-Gm-Message-State: AOJu0Yxp7EIHzThBnd9CYTJ1CkU+q9ps34MYSLjUGpSzmXfz0CMkO6V8 DZt7YJSjVNA5UQF+d7oGwE7nmg4GAbpNAy2DwtzC9rV0FpHhMnWuCJ0sAvjnC5s108EDi8LeLAj VAlT9vnckuLqbUuFaV9FWUJsczBXjrDh1utr0 X-Google-Smtp-Source: AGHT+IEtqu/1t7+Hz8N8Rv2Nyxm5B7PZu26wi5aZv6kRMZuDbf3TAyoJC2dBD6Z6O5RquJR/2sG4qk6iSBELnMY+VtM= X-Received: by 2002:a05:6512:220a:b0:539:9155:e8c1 with SMTP id 2adb3069b0e04-5399155ebcbmr4361786e87.8.1727734645164; Mon, 30 Sep 2024 15:17:25 -0700 (PDT) MIME-Version: 1.0 References: <20240930221221.6981-1-kanchana.p.sridhar@intel.com> <20240930221221.6981-3-kanchana.p.sridhar@intel.com> In-Reply-To: <20240930221221.6981-3-kanchana.p.sridhar@intel.com> From: Yosry Ahmed Date: Mon, 30 Sep 2024 15:16:48 -0700 Message-ID: Subject: Re: [PATCH v9 2/7] mm: zswap: Modify zswap_compress() to accept a page instead of a folio. To: Kanchana P Sridhar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, shakeel.butt@linux.dev, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, akpm@linux-foundation.org, willy@infradead.org, nanhai.zou@intel.com, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: yoz3coz4snmqdud3nfzg68c36oo4kcjp X-Rspamd-Queue-Id: 5265040002 X-Rspamd-Server: rspam02 X-HE-Tag: 1727734647-231957 X-HE-Meta: U2FsdGVkX18lKEvlwwr2dI7ixxYBiwxpb98SJ5DY+cHUIia28GAGscp5fyBXFvkjH/uyVZNTGzrHbwTdz/+41HSy5qgABEurR3BWwOvXmejJGUViUr+p82+s/VnJSZpQ/udW7giini0glCao6t1qThGD6PZSg3yOruNpHOeCVcbDsH6KzQF+vWvefNukpDpdG+z9Z2asog7X1jttc/74dYr3asdbOlxce762ZCjhayjXCqNzb9w2m+6/8FWAqnjWAmIRLTE4rtyaxC2fb4KqEUJ3158+AJgcISqt8f0VmwYu+tZyYBIb1jlogghdDciQAddrPTv4z4jkKp8xcYPa/BsCRaQk3XXGBNK8MT/hWh9F3NqYhO33V6vKbNSfgWT70hYx5SCIrLxCsLzpo/0Hl1YADwFZtlsRZp8qOo6sHLLq7DGf5MkDiffj0MyJU4Iy8j5LH/44EbyIq9cX8Ct0baIY31P1UfFK5P4z/LzrSJC4I2PLXopkxTO2unZ/upoypz5cCBSwqe96hDdZBVPCuTTxPB/cHnSKUtxwz3his383kBm5ycAMTvaOjaWOYp/cKE/oNSomgjLhW5lqDfb5yyBp8Hme/AOanVWzHAYcg/BKuaCDX3a8oCbUbYO9HsxvZaGSs6KcreJLpe4Jk6tvOf6VHTg/2YbxObHFjR+HmWaiADcFH434DoHsG1RdSXkywXTpNUIrenC4MjAInmvC8RhFiyrYesZMN28fqxKZzaxpJdifdHvlznDV/jJ+LaGzHxUyFBIDbg0ytItGjts4cdVh/zH8Xax5ppKbNPaIVAzRSMhIHzCbFLBnevCEjbs5gnegXwWoVX75W+DU+rCxS9z1OBIvUc4sGN+Yynd6TF7sKmhmvK8X6BV8c4i2a/cSkEAQ5c106S5ntLa2cWzMwK27euAyoiU9so/tamm8PtLQ7dxG2H23oScN9cgW8WUm4U4QmYu9h/30avYZuKi 4EF2VZVZ xbuZgR4sMu23QVbU0c24nu9PtMtMyezd4+mtqjqUvGQCIUYd2Hqe41sDOx/44K67v8NaTDtFJP7p9CpRm4KEyi7S+T/jGdla5DcaD6v7tp8Z9xcvkcZ8jAK0r4F/Xh0G4WfLNPAJnQXN3NUD3pq2d6qqsdbSq2cUntPyr+99xa66ddVCbsUPzXFInU67nBXX7NC6VdxT1FkLJIqEAO8xbRg4Mr6Q76KxDSwBGAz7DMgAFx9419PDHtB/fYVc5uFTTN7oVAbuBQekk8v1c+hyBdBLjesZy7Al4PL/1EJtqZvFU+/KtbRlH/yGYo6hLz0oM8HyivX75mjD0DHLO98Vt4OIV1KIScUmb1EJCYfBBM9kOcUPuKvTNQzvPFqmZ2q5rLqYEDsz/ys6wQ6IWhY6MKJ0PEw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 30, 2024 at 3:12=E2=80=AFPM Kanchana P Sridhar wrote: > > For zswap_store() to be able to store a large folio by compressing it > one page at a time, zswap_compress() needs to accept a page as input. > This will allow us to iterate through each page in the folio in > zswap_store(), compress it and store it in the zpool. > > Signed-off-by: Kanchana P Sridhar > Reviewed-by: Nhat Pham > Reviewed-by: Chengming Zhou > Acked-by: Johannes Weiner Acked-by: Yosry Ahmed > --- > mm/zswap.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index efad4e941e44..fd7a8c14457a 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -875,7 +875,7 @@ static int zswap_cpu_comp_dead(unsigned int cpu, stru= ct hlist_node *node) > return 0; > } > > -static bool zswap_compress(struct folio *folio, struct zswap_entry *entr= y) > +static bool zswap_compress(struct page *page, struct zswap_entry *entry) > { > struct crypto_acomp_ctx *acomp_ctx; > struct scatterlist input, output; > @@ -893,7 +893,7 @@ static bool zswap_compress(struct folio *folio, struc= t zswap_entry *entry) > > dst =3D acomp_ctx->buffer; > sg_init_table(&input, 1); > - sg_set_folio(&input, folio, PAGE_SIZE, 0); > + sg_set_page(&input, page, PAGE_SIZE, 0); > > /* > * We need PAGE_SIZE * 2 here since there maybe over-compression = case, > @@ -1456,7 +1456,7 @@ bool zswap_store(struct folio *folio) > mem_cgroup_put(memcg); > } > > - if (!zswap_compress(folio, entry)) > + if (!zswap_compress(&folio->page, entry)) > goto put_pool; > > entry->swpentry =3D swp; > -- > 2.27.0 >