From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98EBDC433F5 for ; Sat, 23 Apr 2022 21:44:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1ADD46B0074; Sat, 23 Apr 2022 17:44:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 15CA36B0075; Sat, 23 Apr 2022 17:44:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04B5E6B0078; Sat, 23 Apr 2022 17:44:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id EAA3E6B0074 for ; Sat, 23 Apr 2022 17:44:57 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id F24DF60500 for ; Sat, 23 Apr 2022 21:44:57 +0000 (UTC) X-FDA: 79389474234.08.8D8488B Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by imf04.hostedemail.com (Postfix) with ESMTP id 877DB40033 for ; Sat, 23 Apr 2022 21:44:54 +0000 (UTC) Received: by mail-pg1-f171.google.com with SMTP id t13so10212047pgn.8 for ; Sat, 23 Apr 2022 14:44:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Yx8y7goVHBTlGvdtFFuNwwMCsekJcpP9yvzgyjH/bp8=; b=qUkkGk/bpw8J14YdHOTb4OZuCmi63QvteZvtb9Aamaxo0h8F/x9cxEHz27DzgjZcfU lO2ufp6jXpfprhMFOAKOY0UomKf+5C5Xba3QJ9Lf4mg0l10Kw819Itq5Awrey6+53cOg vVA2sH9g5lqyk8SDJcuqUYgRvr+O2I7vjscVtPkcSJ79na68KphWwZX4Zw31RRzsMgD7 y6Ij35PmRo1cbbPNwwgB/xc3XBmk7Tqx6kzpyXUyoRCj61jI4z4UfkEhCCrywL3K5adi c6eVmKQZxrrOxtFX4Rt9FfNl5dyK0cMSNPoPJHPpsL/X1CTkqgnoWbDbiWbbx0VP5xpa NR0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Yx8y7goVHBTlGvdtFFuNwwMCsekJcpP9yvzgyjH/bp8=; b=bUA/v7XSHvIqQt2ZN0MOnP93DPyJ3g0FjMi6lUysSOJd3CFC6YFm5n6eD/lt42T1LC dn9vQRc/ca/1eTaTY52XEvSgptqMmiNigdmjUB2p8T5gcCwaLoQxHk6dCAD5KCuagTqO wsRCHPo5Sk2aNv5sL3GQhGf/BOlEfF+2H4FO/ysLV5CTMBd+Y4mW0eJgTJ9KvTcOmbUE ErKx/8XT+r2ogpD6HtKw8k3LgCaszWBGFJYzwdIrqBUtTHogxzQS0WqE6of+jfzxKjFr GQKLbOJlGZAjjKeZD3/zXbtTrZ4LMdV22EtbjRMxr3ZSrekaEjk8S1xwZuJaFxSfwazo PyZg== X-Gm-Message-State: AOAM532eZ58XMM5vc38X/qeBFOZQAt08mPmTbGcw2Dk+Mjo44Kw80QEz CRdEtM5yTkkaMQ4FwLsHJ3uJ+SLmBjtx7WGKX0Ia4w== X-Google-Smtp-Source: ABdhPJzaJKGRsqP2YIPaQzlAHHJckJcXVF1PrkoWTCqe4FPh8eOX9DRoOw850DV2KiuelxmOzUr1GvKvl2LEvWTIfHI= X-Received: by 2002:a05:6a00:1695:b0:4f7:decc:506b with SMTP id k21-20020a056a00169500b004f7decc506bmr11503134pfc.7.1650750296183; Sat, 23 Apr 2022 14:44:56 -0700 (PDT) MIME-Version: 1.0 References: <20220421234426.3494842-1-yosryahmed@google.com> <20220421234426.3494842-2-yosryahmed@google.com> <20220423133035.b6iz6vzhzlym3m4w@google.com> In-Reply-To: <20220423133035.b6iz6vzhzlym3m4w@google.com> From: Yosry Ahmed Date: Sat, 23 Apr 2022 14:44:20 -0700 Message-ID: Subject: Re: [PATCH v4 1/4] memcg: introduce per-memcg reclaim interface To: Shakeel Butt Cc: Johannes Weiner , Michal Hocko , Andrew Morton , Roman Gushchin , David Rientjes , Tejun Heo , Zefan Li , Jonathan Corbet , Shuah Khan , Yu Zhao , Dave Hansen , Wei Xu , Greg Thelen , Chen Wandun , Vaibhav Jain , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Tim Chen , Dan Schatzberg , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, Linux Kernel Mailing List , Linux-MM , linux-kselftest@vger.kernel.org, Michal Hocko Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="qUkkGk/b"; spf=pass (imf04.hostedemail.com: domain of yosryahmed@google.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 877DB40033 X-Stat-Signature: b35dsy1fiojqw41hmscrfqzbzsm4w89b X-HE-Tag: 1650750294-26199 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 23, 2022 at 6:30 AM Shakeel Butt wrote: > > On Thu, Apr 21, 2022 at 11:44:23PM +0000, Yosry Ahmed wrote: > > From: Shakeel Butt > [...] > > > > [yosryahmed@google.com: refreshed to current master, updated commit > > message based on recent discussions and use cases] > > Signed-off-by: Shakeel Butt > > Signed-off-by: Yosry Ahmed > > You should add "Co-developed-by" tag for yourself here. > > > Acked-by: Johannes Weiner > > Acked-by: Michal Hocko > > Acked-by: Wei Xu > > Acked-by: Roman Gushchin > > --- > > > [...] > > +static ssize_t memory_reclaim(struct kernfs_open_file *of, char *buf, > > + size_t nbytes, loff_t off) > > +{ > > + struct mem_cgroup *memcg = mem_cgroup_from_css(of_css(of)); > > + unsigned int nr_retries = MAX_RECLAIM_RETRIES; > > + unsigned long nr_to_reclaim, nr_reclaimed = 0; > > + int err; > > + > > + buf = strstrip(buf); > > + err = page_counter_memparse(buf, "", &nr_to_reclaim); > > + if (err) > > + return err; > > + > > + while (nr_reclaimed < nr_to_reclaim) { > > + unsigned long reclaimed; > > + > > + if (signal_pending(current)) > > + return -EINTR; > > + > > + /* This is the final attempt, drain percpu lru caches in the > > Fix the comment format. "/*" should be on its own line. > > > + * hope of introducing more evictable pages for > > + * try_to_free_mem_cgroup_pages(). > > + */ > > No need to send a new version if Andrew can fix these in the mm tree. I will be sending v5 anyway to address your review comments on the last patch. I will fix these as well. Thanks!