From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DE12C05027 for ; Fri, 10 Feb 2023 06:05:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D033E6B0103; Fri, 10 Feb 2023 01:05:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CB4D76B0105; Fri, 10 Feb 2023 01:05:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA2786B0106; Fri, 10 Feb 2023 01:05:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A72286B0103 for ; Fri, 10 Feb 2023 01:05:03 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 66C401A12C2 for ; Fri, 10 Feb 2023 06:05:03 +0000 (UTC) X-FDA: 80450344086.02.7D6F196 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf14.hostedemail.com (Postfix) with ESMTP id AC2D5100015 for ; Fri, 10 Feb 2023 06:05:01 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=TppZacDm; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676009101; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cyCw7uGS0lODDxQUej9sN3LcUc0Kv+YA1s/fVgdFQf8=; b=8JZPGoauqeKFosP1ZL+oYixT+YLR87sv9dB9lBB4LzuSwbj9+hlvd2ORYu5q9Ea5y19jSy BnR3T60RyYFBjPiv1IE74Yl1EVP3jbaNBELhO4DmCeH4qL48LQscRy8SEnS212TrTDtp3G CWPM+4S7UjTF8Kj9E+kPSSt61nmctYI= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=TppZacDm; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676009101; a=rsa-sha256; cv=none; b=T2ZDkfOOxuIo9dBO8w6PYcGUO1G7klOGiHH69tNJFomd+JmCaWVXSFSNkuClkVQ/JUAm7Y /fHonfNJuSBo8xB1LGBHqsFd6oyTmBHRaEZNs+OtLu0ITn5axlnknh5l4Dck2gBvjpH+XP eI3Z2VJuHx6RigPQpPAlJ6Bf9MET8Ao= Received: by mail-ej1-f49.google.com with SMTP id jg8so13050128ejc.6 for ; Thu, 09 Feb 2023 22:05:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=cyCw7uGS0lODDxQUej9sN3LcUc0Kv+YA1s/fVgdFQf8=; b=TppZacDmVjKVMWV/vD8YkcVqNiaV7HzEMkP7UDXDdvUhGWQlLkys0mCqHqresMC2CT qxFvG7R5LNjmQllm7R91eT2P5WMNBLrUpfwsdL/Zk5U0T5zrGPYEkRPZ2JqF41dMZb+E 7GWGDZNgdJDhfYD41mHZpKwqpOvRSDcbzvUTqMH+Ru30tCrcDXcfn+Cm4UmT4Gh1Y8uz H4QJlFk2gZenlW4gyMtW5tgnp2UkPC/7+LtZodjrSnj5Nxzp9N5eWPZOryhXP+fN0oAM mMuRLCfhwuYHy3g1awRfBb1+3kWZ/t6BEZl64eCQis2niB+ha6JuTsrbsfP4Ahk/jM0V Xovw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cyCw7uGS0lODDxQUej9sN3LcUc0Kv+YA1s/fVgdFQf8=; b=MFa+bwmp45f1CX6v9BLcbizEsH4asM5gFenMoKjj4rVYgiFHwxfKzQjiGRps/kCVSX tENStwGiHnJrLqTihftNAkPBTc+RztUTxP5GmCfAszeMpk3FLdrqkx1BGWKqf6NEDwaH PYqEwPhdJGRb8dVKIJ+kT29VoTkTBrYwVAHr6abUSUzefUdRsm48zsoiSm9kaqFCLX+S VWrPUVOi5fSX7oWbkn/SQpFvSIkFfJ356GxfNvO1L39Y09ta3iQI/sNTHT6n1CDvq9Yu xdDFutWL9cjCvb4ASYp5ooFO/od725eOufh+sTD2GQRACkJor3Fl1gtqvH6uvmU+h1Sr AjLQ== X-Gm-Message-State: AO0yUKUYl4kORaSg/UW0vOvWxY6ZSO+N3er5Dq/YWJSd8zLXk3PwP/2a KPxl3I8Ze+0ghxRZNE89o8xEvAT2Z2VgBN26gkqX9g== X-Google-Smtp-Source: AK7set/KLIAuxzZ+iPqGSHKHgnZWT2zlp8hBwI1EZmGk82kj4+nvJtI58SDulBnhhn5DVxhopTqXWx5I1CP0H9rR1to= X-Received: by 2002:a17:906:2a4c:b0:87a:3b3f:b9da with SMTP id k12-20020a1709062a4c00b0087a3b3fb9damr1057585eje.10.1676009100038; Thu, 09 Feb 2023 22:05:00 -0800 (PST) MIME-Version: 1.0 References: <20230206092559.2722946-1-senozhatsky@chromium.org> <20230206092559.2722946-3-senozhatsky@chromium.org> In-Reply-To: From: Yosry Ahmed Date: Thu, 9 Feb 2023 22:04:23 -0800 Message-ID: Subject: Re: [PATCH 2/2] zsmalloc: fine-grained inuse ratio based fullness grouping To: Sergey Senozhatsky Cc: Minchan Kim , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: AC2D5100015 X-Stat-Signature: 33qrk3dyq46qpniaqypewqb5wof7k6fy X-HE-Tag: 1676009101-82269 X-HE-Meta: U2FsdGVkX1/E9x9ZI2n9tRMvzmFcL9bJiZEA+241oXAi/GcfqS2LEJ+RRGxvFAzXbm+snU+ge5fkV+P2sI+6DzIOlp8EjupNBD2i7KLOuU9fbnqLuFutptPiudkYkNjawmHeXWezqgM02Y3dETDdthEWSI/BnSUjQFdpKjR8EfxxGmwhdVpKyDu9v30jZOHvd6RGc3/ZypqRmV+Fq5QYOo9uaUOC4wUQF+PyEEMx0yKd1kzAOvot1tKe0D4Lb28RUHstWGmOQB2Mkrl0E68zacNqVrdOrn9NgWRvAgIyjIJEq3UIM20QhZgB1qV79vnNhmwx6YLaSu9lckFtxFh7FdVjx45JWDLcIi9a4vSZV4lV9KHPSsZoRyPF3Bk0GJjQ8INdB6jGLSr+bW6tDyVdko0QjQurtE2kiNXgLKBz61lGFFmMEYefMybUVcBOf/uUlRwHqSySe7++OrSmmGkg29s2iYLBI/QRI2lQHTyVSD/bFYEAMsuyHJMLWs6aFueIaMQVDOS0lQoAm1OSKqIfE7J3twfXe8IRVjlA8Ss0vfuj2Za+eXyMDlJ5FHNiZkev/4uMBTzgex5+uW4o0xvoDtuc7f2F5UnRgirtcknkid1x3W/UjpoHLv7aHyW7GkvITEyz6LrYNjXvc8UvkQ+e7+zR7xNxgRf1Low6+g97QZQ3bxyv9mFS78OOz3+TiYAz84gCxH3b9/eIAJ2Jypi2IJ4MkdkCPqRGYBJ4/O+u3YWZCwW2RSH8VRjwlouaEJhsQ2p+xtUmapPpWc75iLIstWBG6ZWM8zd5CAAY12UqlbkqfTzvddVFmhuiIxUxNXU2wyFJfluU4/f3f9YRq24Oak5uiu9mxEKdQwX5cUNWuW1xL34rzuANBVGqSnn/IEQYId6C1RnrJ7scDigAp0MbJQqfVzGmUmiNM5thJbeNe+0i74hKCcwpotBCafaN3sbZa3QY0FboaJSkDDaPvAZ zxPav5+m TYfi3qajEBZKNDdVdCgF1ycCilmA2r414Ae45K5kiSn5BjZERXLo8i8SayB2PZTkQRt4axSuVi7rmCAT9etb3nYg8mK+WIKIxijMj1PziZG7Xa7icScL3srSQv5YnKLiEihUwQTttu7HnAlDlLsUOfYiZoshtKTDtYJ8IUu6g8v8rwYuSldaTUup6TgTbcbwIqP5Q+a2tXHdVeG8GN/RJwL7BBj4EwtFc7bJq1j7S/7Lre8z1Cc1hbr35glmVPlv/wBmvUEjhUtEDe149+Uyc/APHcLkdfgZ3z1Hbh+1rjzzMhrg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000692, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 9, 2023 at 9:53 PM Sergey Senozhatsky wrote: > > On (23/02/09 21:15), Yosry Ahmed wrote: > > > We need to be able to do zs_stat_get(class, CLASS_USAGE_70) or > > > zs_stat_get(class, CLASS_USAGE_10) in zs_stats_size_show() to > > > show class's fullness stats. > > > > If we use #define FULLNESS_GROUPS 10 for example, we can break down > > struct zs_size_stat from a single array to two arrays, one of the for > > fullness groups and the other one for the rest of the stats (e.g. > > OBJ_USED). We can have different helpers to update each, the former > > taking in a fullness value (0 to FULLNESS_GROUPS-1), and the latter an > > enum. WDYT? > > Wouldn't this be more code to review, maintain though? I mean, > what do we gain with this - fewer values in enum? I don't feel very strongly, but the patch above has a lot of hardcoded values, multiple enums & static arrays. If we want to change the number of fullness groups to 5 or 20, we modify all of them. Just trying to make the code cleaner. If you think it will add a lot more code to review/maintain, then maybe it's not worth it. I didn't really give it a lot of thought.