From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A25FEC2BD09 for ; Mon, 1 Jul 2024 13:33:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F268C6B007B; Mon, 1 Jul 2024 09:33:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EAF7B6B0082; Mon, 1 Jul 2024 09:33:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D50426B0083; Mon, 1 Jul 2024 09:33:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B5BFD6B007B for ; Mon, 1 Jul 2024 09:33:19 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5DB25C0F26 for ; Mon, 1 Jul 2024 13:33:19 +0000 (UTC) X-FDA: 82291275318.26.06483F2 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf30.hostedemail.com (Postfix) with ESMTP id 78B1380016 for ; Mon, 1 Jul 2024 13:33:17 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VHg3heYq; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719840779; a=rsa-sha256; cv=none; b=DUXRbBBksSd5uGPwe4YX/vRgk8TtDDXiPE3IUcwC0V7fwCx3tNiDdhYb90Y8JbImN/yrzC ekeHtSCO1ZDymiYEN9RvrS1Bsopa1AzgnY2pn22jcyWyIKwFiZ3IxxXxI6Zbpb2joXHJQS I55OvvQKcrQJ0rJpoP7RlfGbxie6HB0= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VHg3heYq; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719840779; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fMFaj2j2QpZkox/Cr3aghbQNsBUWRUsAkpeVtopELzA=; b=N7WDtsmMu7lmVefPwHa0dmYjeO2y1jsJEnItyLnHENJKDIwB/qFXLazXoGMZghodtHBc4B WYkIlOQcoeFx0O/4KerLYd2R0z9O2F9U8+Muj91A9S/7+B9sGJRMuCnG5VK5aksF6EaECA ctNGzQhENwbVdaMzM3WS9NsBCAfQRZg= Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a7527afa23cso117573466b.2 for ; Mon, 01 Jul 2024 06:33:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719840796; x=1720445596; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fMFaj2j2QpZkox/Cr3aghbQNsBUWRUsAkpeVtopELzA=; b=VHg3heYq3ZSk7B5lZIx345gh39OYxBsZGVG/lTT9InPJUiC4E6Z2PGY8zNuYbzhDgf 6evVLRwXPeg12qHhGIrCvOUVXGJkns+mmOo5pbAa8tEEJpF248i4GUUpQXX7igiifZRF CxvzS3RzD1s0T2RmN+1HXkzfcrQXN+AKz0Mhvat3lxloQ5LVHeliZylvANn9xDGLK50+ lp3Eff129LY21c04UWhyUCJJAjBJmZdPYAa1NI+hL/+dvBC+M8Et1Nchtb4Taw551VQ2 e7YkbE2tLvUicmtV7aRK2vYDHeAnl8kQah3i4YM50P8w5WxBU516IEL8xczSL6x4U3S4 QmAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719840796; x=1720445596; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fMFaj2j2QpZkox/Cr3aghbQNsBUWRUsAkpeVtopELzA=; b=VadK8YIU9ZrIZ46iyaJijcVqlKlfSYaEIuewmmyIxLcRTvqgQWcSecHUO1b8lqNh7l Ar4ePOZ7f/U4ZL2riRQGplup7uI/nHT2yqxGH1F3PEd2f5ndZB7ubZfV/RUq6tnipFIw wWDblhEfu20hC3lWZ76phkkJV8herfUfnN4Q10DH7WSi3JnL2hVUYJCACQKIwNWd2qRr T+HTcdeiPb4GvMIliW1Xqj2og9LNLm3a7P0HuzzMEMUXgZMSJK/sv223ewiWyIrTLSAD 2DDhIUevRFO+LAR/mPVWerBsmhLP/DGzGu/6fySqc+ijGOh+e5+g66BmkBcVx3lhh1Zc ERLw== X-Forwarded-Encrypted: i=1; AJvYcCUv2K4IYzv+3zcWDJ27mORiOoKG1JmcayIEPVKVHnfu2CDWv8STc48bJ7JHFCaO2Vr9nWAe287baREuxFPMeI9Agmo= X-Gm-Message-State: AOJu0YzqUDEGRn/YrHYU7NJTQ+fvrrvWnoimTp7QZ4whLt2JYPmL9cta ZjK+J+0DwAbnXiyCh64FieqkmJLpOdOKAKU9BcQaic/nXc30ujYpEJ0Ns35u5MTSli71TW4zwhv AfXvMgfvIOBOjbXNx+NN+th9k7h1XMRSM3wgf X-Google-Smtp-Source: AGHT+IHu1BLuiHzE892CLZKL1woYinWVTBOp50vCOaQbetL/O/zfKJmmbJvsfBiayZX/B22FZ93jhNxsYwnpALrRjFE= X-Received: by 2002:a17:907:86a0:b0:a5c:eafb:5288 with SMTP id a640c23a62f3a-a751448a596mr525273166b.31.1719840795419; Mon, 01 Jul 2024 06:33:15 -0700 (PDT) MIME-Version: 1.0 References: <20240629232231.42394-1-21cnbao@gmail.com> In-Reply-To: <20240629232231.42394-1-21cnbao@gmail.com> From: Yosry Ahmed Date: Mon, 1 Jul 2024 06:32:36 -0700 Message-ID: Subject: Re: [PATCH] mm: zswap: fix zswap_never_enabled() for CONFIG_ZSWAP==N To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , Nhat Pham , Chengming Zhou , Chris Li , David Hildenbrand , Johannes Weiner , Matthew Wilcox Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 78B1380016 X-Stat-Signature: omidkmtu6yd6n13zzmn518yf87syisnk X-Rspam-User: X-HE-Tag: 1719840797-103571 X-HE-Meta: U2FsdGVkX19dOQ/32rk/HzsQMrXW2SlL2r2Yye+RwOusONwx3HquArNq+BYHmOXjeCgs9eRgHds2GGbn86qvyfpZ8jW8oDEOFboVzOd5n3UGd5W1RsriyKIoAsVEJazmpBwi3iUPvzeaijYtjzogJSXxaYBYgscY4OmAxTMssQruo5qqoZVPsw39nYRp+Vbvpqddm8tEEYAdIw8OgYlEOu+gHddpzouSi92HvUFA3heC8YT6TNklIHacCW45sqKzqMmvXCuZz5loMK47Q2RtW4IHT5CNYIrumBU+wDAp76KQLCraIvJSsq4K+o0wwT8ekMXRhwUvF7WVWxd+16OZOwnHYtBRVN8X0G15kWRpTm2jq0koz0F7wE0Vybdti5nCAW6UrPH0hX/lWRtYgZHciMaezrGrDDfNCJfdamm2Wk9BpCz92ULv5muGQS6nrOL2PRNRBB7dXOXR+eUdQYFz61NAX5vs4/6mQ123xrx9xu+4RDYzpd7un3lrjCiRxMknAUmDUZ17b7wLQtlakNd9ngBvvqC+1ntImqPhlddJhdpRVa9VxiMRA+nLSJfG8hROw3HyJaYbUy7sXZxeOU4q93ytsQj2/TUGwZ3mBZeauKLkNTRJKnjdR6icXG0+FcFkJsphuA3Cdtqnzya3VYKEpErN1XrMq3ob1kQd8Ub929HIKYaCujQD+mKAEHtannZ54+JClDxarooGBKuk2bE9RdCMMkd+dBwoqIMZzqwZyogJgYe9UK1BOAgBpLazPdgnKFAU5mPEcs1XWunWBAIblQJArDVGcvoeWKWwZp2/A7k+7310UQh2AbW6BkrKPFq67lbyfU5/WQL7CLLnI776E9wSZouHs4GuwQoV7jrMhATPh4L9lr+OXMm4ua+XreQNldIwRLcqG8LmDyGPe4obUmUOLqvp21GJTEc24Csy1ffM81SoBCI+VZszUZdscT3bnyX4PF8dLg6ZjI5E7Re 1fEjhwd8 NStQfN392a9CxOJAMZezYBorGytGrV+iwj+7yqClFyaJ8XpWJfZuznS8JzjIMRsXFAqk17nEbZdLxyMfP5mG6qHDtnU8lLtErIPvxuIjjdAZxEVuTP42kEOoIiDiVqDDa1djCrU8woD35nfttVTO9Jf6i91WjSanBh1p0e7Q+LEyAB/WqTUaSFl7OkPeyNP72TZvAHzftSW8cNuZPmp8lNHuTzUSxq1eKzJWuT1hTNGC8Pq2dH5NN1Oh3mOTf3B5ANEpxJPRXjmqi1OOr7o57u75dTniY5g1VaT2kvZdnmIemJuWjQ2NKTysR43+UGRLwjof1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jun 29, 2024 at 4:22=E2=80=AFPM Barry Song <21cnbao@gmail.com> wrot= e: > > From: Barry Song > > If CONFIG_ZSWAP is set to N, it means zswap cannot be enabled. > zswap_never_enabled() should return true. > > Fixes: 0300e17d67c3 ("mm: zswap: add zswap_never_enabled()") > Signed-off-by: Barry Song Acked-by: Yosry Ahmed