From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31268CD11DD for ; Thu, 28 Mar 2024 20:06:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A65936B008C; Thu, 28 Mar 2024 16:06:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A156F6B0092; Thu, 28 Mar 2024 16:06:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B5FA6B0093; Thu, 28 Mar 2024 16:06:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6D8246B008C for ; Thu, 28 Mar 2024 16:06:54 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 30B21402AE for ; Thu, 28 Mar 2024 20:06:54 +0000 (UTC) X-FDA: 81947531148.21.CD33387 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf14.hostedemail.com (Postfix) with ESMTP id 4D8F9100002 for ; Thu, 28 Mar 2024 20:06:52 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=L6hHmJIq; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711656412; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ij7Ouf/ymUoifh8mgCvqV2Oc2Vgv7bDzjKVaIK67K1A=; b=NRnWa6RTl2kvaOIBrwKmXqptZ/p7xXKmji3Z6dYVx8Ns4eKDR8uua12MU6rEhI3O+54oen IQBiqsmSupFE/hcYRe2cxnWnnuuURrVWjcBBSgZ1X+4qJ2GMy8hHsfsCcQqlYLI/XgPiQa /rnKgV80TPWD9grd4y63WjToYCNoa+U= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=L6hHmJIq; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711656412; a=rsa-sha256; cv=none; b=CHjuzu0qksc484tl5/G1m+1/bz+q6uVHGlB7WGCAWvmdZBULFX6sDPfm9NxRex2JOzW7NB t4tpJwZGqMrqYfFOwYQEe3klb2tokMyx/L5sXv8dTp/I6VZ1AFIcX7aozMQc14bThxaaFE DBuHyyIN7spq+NXIReU3HGsSMRCrcvY= Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a4715d4c2cbso182729166b.1 for ; Thu, 28 Mar 2024 13:06:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711656410; x=1712261210; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Ij7Ouf/ymUoifh8mgCvqV2Oc2Vgv7bDzjKVaIK67K1A=; b=L6hHmJIq+X/EaqGT/MN+FD6J2c0PLQBH0/eG7F1liMsapZhDed0E7zjTTVRS1Sb+ip rhzr+sU4Z9p33ou5UrViop1DqeskyN3NwIJ7Ex5lmGNna0xaClNpr5M+9Z71OkuDddoH WvBekppVQjuo4XRD/o7w0yQM434SHYHEw7gPKdFM0bHC+eRDkvsl1/HdUuisQ+CuqXW2 dM72FTfMFWNfXY9TKZL2WEc6JeKVfL8tZq5UCt5nch8Z2/d+qQC7C+fh4TwRDdqwmjAo 5XnCyV3EBVvO1IBXvR6s63ZyJmCC0xMs/OlfwaP35kWzHdMqtR252zph08+mwO/S8pJB tqPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711656410; x=1712261210; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ij7Ouf/ymUoifh8mgCvqV2Oc2Vgv7bDzjKVaIK67K1A=; b=vpv0enwt4BufBQmrs0fcJ6GVnaRSZabN1GWg3DExM+ESgtVsGmfBNs6lyK/a2JFSde 2+HwxXDQ0rwsMo9tNS4WOqKUnlyb3IvlAKaue3hsPV/TDNC580p/YqnoaFV3IWmmSflG 0vGdcWFKJ1TSBUkvtkCxPzibqDpXtvfIzeLR/C9iaLYQJMvSv8BX8CjjvJVwMaflHsVT h57dywIxh/ajrZS/c1rPn0rsuTQYRLr4lkvdCWbtPdcl0FmbUfDDva9LZ5CZbGxkb9q9 8IOrNCGJIAio3Hnqk79SLxVZdlQ1EPX6o3cshrhThd+9wRQrBbePbQKx9VbH2sjN6wtx kxbQ== X-Forwarded-Encrypted: i=1; AJvYcCXFurE279ZAA4fY/mquhPpA5FxCYZNeYZWSpDOy3hDLgH+IS+6J58SzVrViMHDppH7pMCrs643DwBDTSoVzuOgaQVs= X-Gm-Message-State: AOJu0YzpgzRF4x+fSUqubWcpULoQjClw0V0eUvuXVnfwIEiMmskLslDO AQlubIcnrEMluVHcW8H7Ttq+G8egjp4kknivP2MG7rm4oD3WnwGFN27HDHibEVgKZYe2O2wgsxf VABG3e1HDZj2JNUQsG+I1ScM23okaR4sSwzzA X-Google-Smtp-Source: AGHT+IE1Ht3Yt9FVoWdIKtNsYI1USNu5UTJHLFwpfZwvzxs6llb+5nQ8s9MPRC8pMqtwnbk0dEnMHrne2iPHPkzCCxQ= X-Received: by 2002:a17:906:c309:b0:a4e:f82:375e with SMTP id s9-20020a170906c30900b00a4e0f82375emr192488ejz.73.1711656410453; Thu, 28 Mar 2024 13:06:50 -0700 (PDT) MIME-Version: 1.0 References: <20240325235018.2028408-1-yosryahmed@google.com> <20240325235018.2028408-6-yosryahmed@google.com> <20240328191109.GE7597@cmpxchg.org> In-Reply-To: <20240328191109.GE7597@cmpxchg.org> From: Yosry Ahmed Date: Thu, 28 Mar 2024 13:06:13 -0700 Message-ID: Subject: Re: [RFC PATCH 5/9] mm: zswap: remove zswap_same_filled_pages_enabled To: Johannes Weiner Cc: Andrew Morton , Nhat Pham , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: fgm9k3yjipxfz4hjwbeos9sz7sidenzt X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4D8F9100002 X-HE-Tag: 1711656412-360140 X-HE-Meta: U2FsdGVkX19P4QamRkWuyS0jo9JzOoEeCqUlngYkOURabFe5Be3yrCKVFL8UetJHAy3uSTVrdKB4RsQa+iH4Dx7lUHdZQi3qXomVdJjP+SXTZ/WMyCkvg5ZMF5UEjaajiFhSAtWsWdw+uSqA+bM0MAWC3jIER6LYDGgQiTJX/7OP9NZGXIBdKKUfULgBvhiSKLgZnQWCZEq9pJQWp4BTUSe+1P/SSo+m2F2jF7nXptIoNYChrCSrmw1ouF0uabBkssacDy5fPfNuCHEV5RiJZ0++6HN4tXb+qpDnjrN8h0VvARyBOfaq1DyoMhrQr7CvVq/wPTpeettYucwTIDA01Nw4Kg4no4ijgYE1eX/VbtWF5etnNiV7jcHHNb25gUWaEfUmyH26qb9PxSa1cxUjNfn84ZlmUKx993gt+bBQSnFiG5BoYyL67IaZP65rI1HLdv2GzG0J3Ln1OpwfYxUbaiTyaJumvfST6GSSUTG7qI9C/sAV4cdtlbzX44O1tWGIObvmwUdgWhIaEEQ5mx45/6NdfhJ+zuPaJwYsAhWw+dnNQ8Gl9jJzF1ySqFyT8v82hvNM2C/EG86708NQPpWi4rQ5vRaTi5NFyHXsyoIPwSY8SD0iP0qPU68Wv3H3eqOC84ULiN75+VUxtq7LaDN/V5xDcsZSix/3re+IaDLfZSVX4dz7KycAt7n1mTXKT9osQeLh84M6/Zs5ISszvC4tqBXxpgB75yFyV8O4CVO+1GmI8Nh92T9xa9xcsZ0quoBPrJcpyEoShVPSylAjn5RyyaMLdiT8c5JJFqU1Jn0KR6oEIKFXWm5ZcxBKdBd3rv28dB4nNJenCH9i1vEyav6PSsRZYFG9YXXB3hZbJu1Z91HL7q6wbDO94DTbQkg4me2HJSwU4v3Fc/519MhLAQ0ZXRmR22NppXAKcazi7Rbm8H1R242sa9KeOahB0fK+Uk5g8HRuOxMiZskPoOU0+TF NF55EL08 wUaYOFvM+ByRYlZ7RgWDDPsVJeDRWpt9Sjaj5zFiMFTqREzRvDobFVSjqCEjgaEdgHRpAQk/vmCKXAZ3b7OKuNnolShUCAliVKh4e7rdBiBVuLkjNZea0hypH59D2A1sSDA7e+S0Yz8c+B+ijBj6Frp4O5X0auzVduT1EJtXg+SbhmW1AxgMvse6tu2cZpVOG5j5VIivmNk3AFP6xXJfKp/tZUI3ePQRqAX9WbbNjm+/bNC064/jsGg6HLgGhDzGbBPpV9i0qmCSHIjGXtbb+KiJQS8pKCpZ+8PSe6IgEBTLwQeHVRiyKWYY2VMgBdX+4prc+EkOiNl1eP5p2SA2Q/aUIY3Qu6Dn0xbls X-Bogosity: Ham, tests=bogofilter, spamicity=0.018044, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 28, 2024 at 12:11=E2=80=AFPM Johannes Weiner wrote: > > On Mon, Mar 25, 2024 at 11:50:13PM +0000, Yosry Ahmed wrote: > > There is no logical reason to refuse storing same-filled pages more > > efficiently and opt for compression. Remove the userspace knob. > > > > Signed-off-by: Yosry Ahmed > > Acked-by: Johannes Weiner > > I also think the non_same_filled_pages_enabled option should go > away. Both of these tunables are pretty bizarre. Happy to remove both in the next version :) Thanks!